Re: [PATCH 1/2] selftests: fix the broken individual test for x86
Hi, Michael On 28 March 2017 at 08:22, Michael Ellermanwrote: > Bamvor Jian Zhang writes: > >> Andy Lutomirski report that build individual testcase in x86 is broken: >> >> $ make -C tools/testing/selftests/x86 ldt_gdt_32 >> make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86' >> Makefile:44: warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> make: *** No rule to make target 'ldt_gdt_32'. Stop. >> make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86' >> >> This patch fix this issue by adding default OUTPUT and convert >> target in Makefile of x86. >> >> And also mention this use case in Documentation/kselftests.txt >> >> Reported-by: Andy Lutomirski >> Signed-off-by: Bamvor Jian Zhang >> --- >> Documentation/kselftest.txt | 6 ++ >> tools/testing/selftests/x86/Makefile | 23 ++- >> 2 files changed, 20 insertions(+), 9 deletions(-) > > I don't think this is a good fix, it only fixes this one Makefile, and > it's quite verbose. But if it really bothers Andy then it would be OK as > a stop-gap for 4.11. Thanks for review. Do you mean check this issue in other directory? I plan to do it. Currently, the x86/Makefile do not use the TEST_GEN_XXX, so if we found a better fix, we could convert x86/Makefile later. Regards Bamvor > > cheers > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] selftests: fix the broken individual test for x86
Hi, Michael On 28 March 2017 at 08:22, Michael Ellerman wrote: > Bamvor Jian Zhang writes: > >> Andy Lutomirski report that build individual testcase in x86 is broken: >> >> $ make -C tools/testing/selftests/x86 ldt_gdt_32 >> make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86' >> Makefile:44: warning: overriding recipe for target 'clean' >> ../lib.mk:55: warning: ignoring old recipe for target 'clean' >> make: *** No rule to make target 'ldt_gdt_32'. Stop. >> make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86' >> >> This patch fix this issue by adding default OUTPUT and convert >> target in Makefile of x86. >> >> And also mention this use case in Documentation/kselftests.txt >> >> Reported-by: Andy Lutomirski >> Signed-off-by: Bamvor Jian Zhang >> --- >> Documentation/kselftest.txt | 6 ++ >> tools/testing/selftests/x86/Makefile | 23 ++- >> 2 files changed, 20 insertions(+), 9 deletions(-) > > I don't think this is a good fix, it only fixes this one Makefile, and > it's quite verbose. But if it really bothers Andy then it would be OK as > a stop-gap for 4.11. Thanks for review. Do you mean check this issue in other directory? I plan to do it. Currently, the x86/Makefile do not use the TEST_GEN_XXX, so if we found a better fix, we could convert x86/Makefile later. Regards Bamvor > > cheers > -- > To unsubscribe from this list: send the line "unsubscribe linux-api" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] selftests: fix the broken individual test for x86
Bamvor Jian Zhangwrites: > Andy Lutomirski report that build individual testcase in x86 is broken: > > $ make -C tools/testing/selftests/x86 ldt_gdt_32 > make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86' > Makefile:44: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > make: *** No rule to make target 'ldt_gdt_32'. Stop. > make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86' > > This patch fix this issue by adding default OUTPUT and convert > target in Makefile of x86. > > And also mention this use case in Documentation/kselftests.txt > > Reported-by: Andy Lutomirski > Signed-off-by: Bamvor Jian Zhang > --- > Documentation/kselftest.txt | 6 ++ > tools/testing/selftests/x86/Makefile | 23 ++- > 2 files changed, 20 insertions(+), 9 deletions(-) I don't think this is a good fix, it only fixes this one Makefile, and it's quite verbose. But if it really bothers Andy then it would be OK as a stop-gap for 4.11. cheers
Re: [PATCH 1/2] selftests: fix the broken individual test for x86
Bamvor Jian Zhang writes: > Andy Lutomirski report that build individual testcase in x86 is broken: > > $ make -C tools/testing/selftests/x86 ldt_gdt_32 > make: Entering directory '/home/luto/apps/linux/tools/testing/selftests/x86' > Makefile:44: warning: overriding recipe for target 'clean' > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > make: *** No rule to make target 'ldt_gdt_32'. Stop. > make: Leaving directory '/home/luto/apps/linux/tools/testing/selftests/x86' > > This patch fix this issue by adding default OUTPUT and convert > target in Makefile of x86. > > And also mention this use case in Documentation/kselftests.txt > > Reported-by: Andy Lutomirski > Signed-off-by: Bamvor Jian Zhang > --- > Documentation/kselftest.txt | 6 ++ > tools/testing/selftests/x86/Makefile | 23 ++- > 2 files changed, 20 insertions(+), 9 deletions(-) I don't think this is a good fix, it only fixes this one Makefile, and it's quite verbose. But if it really bothers Andy then it would be OK as a stop-gap for 4.11. cheers