Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port
Hi Arnd,
On Fri, Jun 14, 2013 at 12:06:51AM +0200, Arnd Bergmann wrote:
> On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote:
> > +
> > + ahb@8008 {
> > + usb0: usb@8008 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&usb0_otg_cfa10036>;
> > + status = "okay";
> > };
> > };
> >
>
> The patches all look good, just one trivial comment about the fragment above:
>
> There is already a "usb0" label in the imx28.dtsi file for the same
> node. When you refer to the node from a board.dts file, either leave
> out the redundant label, or use it to simplify the statements above
> to the brief version:
>
> &usb0 {
> pinctrl-names = "default";
> pinctrl-0 = <&usb0_otg_cfa10036>;
> status = "okay";
> };
>
Good to know, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port
On Fri, Jun 14, 2013 at 02:30:53PM +0800, Shawn Guo wrote:
> On Fri, Jun 14, 2013 at 12:06:51AM +0200, Arnd Bergmann wrote:
> > On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote:
> > > +
> > > + ahb@8008 {
> > > + usb0: usb@8008 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&usb0_otg_cfa10036>;
> > > + status = "okay";
> > > };
> > > };
> > >
> >
> > The patches all look good, just one trivial comment about the fragment
> > above:
> >
> > There is already a "usb0" label in the imx28.dtsi file for the same
> > node. When you refer to the node from a board.dts file, either leave
> > out the redundant label, or use it to simplify the statements above
> > to the brief version:
> >
> > &usb0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&usb0_otg_cfa10036>;
> > status = "okay";
> > };
>
> Yeah, I moved all imx board level dts files to use this. But I was told
> by Olof that the change does not gain too much and looks like a churn.
> That's why I haven't made the same move for mxs. So I will remove the
> redundant label when applying this patch.
I would have the label stay there, because I found it's there like a
comment telling the controller instance.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port
On Fri, Jun 14, 2013 at 12:06:51AM +0200, Arnd Bergmann wrote:
> On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote:
> > +
> > + ahb@8008 {
> > + usb0: usb@8008 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&usb0_otg_cfa10036>;
> > + status = "okay";
> > };
> > };
> >
>
> The patches all look good, just one trivial comment about the fragment above:
>
> There is already a "usb0" label in the imx28.dtsi file for the same
> node. When you refer to the node from a board.dts file, either leave
> out the redundant label, or use it to simplify the statements above
> to the brief version:
>
> &usb0 {
> pinctrl-names = "default";
> pinctrl-0 = <&usb0_otg_cfa10036>;
> status = "okay";
> };
Yeah, I moved all imx board level dts files to use this. But I was told
by Olof that the change does not gain too much and looks like a churn.
That's why I haven't made the same move for mxs. So I will remove the
redundant label when applying this patch.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/4] ARM: cfa10036: Add USB0 OTG port
On Thursday 13 June 2013 15:43:42 Maxime Ripard wrote:
> +
> + ahb@8008 {
> + usb0: usb@8008 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&usb0_otg_cfa10036>;
> + status = "okay";
> };
> };
>
The patches all look good, just one trivial comment about the fragment above:
There is already a "usb0" label in the imx28.dtsi file for the same
node. When you refer to the node from a board.dts file, either leave
out the redundant label, or use it to simplify the statements above
to the brief version:
&usb0 {
pinctrl-names = "default";
pinctrl-0 = <&usb0_otg_cfa10036>;
status = "okay";
};
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
