Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tue, Feb 05, 2013 at 05:55:11PM -0800, Greg Kroah-Hartman wrote: > On Tue, Feb 05, 2013 at 10:54:00PM +, Arnd Bergmann wrote: > > On Tuesday 05 February 2013, Felipe Balbi wrote: > > > [linus/master] Merge branch 'fix-max-write' of > > > git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm > > > > > > It's building find for me: > > > > > > $ crossmake drivers/usb/gadget/fsl_udc_core.o \ > > > drivers/usb/gadget/fsl_mxc_udc.o > /dev/null > > > > > > (crossmake is an alias to make ARCH=arm) > > > > > > Arnd, are you maybe missing a merge of v3.8-rc6 ? > > > > > > I can see that imx_udc.c is broken still, but there are no maintainers > > > for that driver. I'm adding Sascha to Cc list, maybe he knows someone > > > who can help, but if this driver isn't fixed in 2 merge windows, I will > > > schedule for removal from tree and someone else will have to > > > re-introduce it later without all the bogus includes. > > > > Ah, I see what happened now: I submitted a patch that lumped together > > two patches, disabling both fsl_mxc_udc and imx_udc. You already had > > a fix for the first one, so I dropped my patch, but now I see the > > build error for the second one that my patch was avoiding. > > > > The last patch to imx_udc that seems to have seen more than just > > build testing was probably "USB: gadget: imx_udc: don't queue more > > data when zlp is to be sent", while fsl_mxc_udc looks actively > > maintained. It's not completely clear to me whether these > > are actually two drivers for the same hardware, of whether > > imx_udc is the i.mx1 variant and fsl_mxc_udc is the i.mx2 variant. > > > > What I can say is that no platform in the kernel currently defines > > an "imx_udc" platform_device, so it is certainly unused, and has > > been since at least e08300043e in 2010. > > > > I would suggest that we mark the imx_udc driver as 'depends on > > BROKEN' right away, since no in-tree user needs it, and any > > out of tree user is already broken in 3.8. I also wouldn't > > mind removing the driver unless the imx maintainers have > > a plan for it. > > Sure, someone just send me a patch for that and I'll be glad to mark it > BROKEN. coming in a minute -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tue, Feb 05, 2013 at 10:54:00PM +, Arnd Bergmann wrote: > On Tuesday 05 February 2013, Felipe Balbi wrote: > > [linus/master] Merge branch 'fix-max-write' of > > git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm > > > > It's building find for me: > > > > $ crossmake drivers/usb/gadget/fsl_udc_core.o \ > > drivers/usb/gadget/fsl_mxc_udc.o > /dev/null > > > > (crossmake is an alias to make ARCH=arm) > > > > Arnd, are you maybe missing a merge of v3.8-rc6 ? > > > > I can see that imx_udc.c is broken still, but there are no maintainers > > for that driver. I'm adding Sascha to Cc list, maybe he knows someone > > who can help, but if this driver isn't fixed in 2 merge windows, I will > > schedule for removal from tree and someone else will have to > > re-introduce it later without all the bogus includes. > > Ah, I see what happened now: I submitted a patch that lumped together > two patches, disabling both fsl_mxc_udc and imx_udc. You already had > a fix for the first one, so I dropped my patch, but now I see the > build error for the second one that my patch was avoiding. > > The last patch to imx_udc that seems to have seen more than just > build testing was probably "USB: gadget: imx_udc: don't queue more > data when zlp is to be sent", while fsl_mxc_udc looks actively > maintained. It's not completely clear to me whether these > are actually two drivers for the same hardware, of whether > imx_udc is the i.mx1 variant and fsl_mxc_udc is the i.mx2 variant. > > What I can say is that no platform in the kernel currently defines > an "imx_udc" platform_device, so it is certainly unused, and has > been since at least e08300043e in 2010. > > I would suggest that we mark the imx_udc driver as 'depends on > BROKEN' right away, since no in-tree user needs it, and any > out of tree user is already broken in 3.8. I also wouldn't > mind removing the driver unless the imx maintainers have > a plan for it. Sure, someone just send me a patch for that and I'll be glad to mark it BROKEN. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tuesday 05 February 2013, Felipe Balbi wrote: > [linus/master] Merge branch 'fix-max-write' of > git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm > > It's building find for me: > > $ crossmake drivers/usb/gadget/fsl_udc_core.o \ > drivers/usb/gadget/fsl_mxc_udc.o > /dev/null > > (crossmake is an alias to make ARCH=arm) > > Arnd, are you maybe missing a merge of v3.8-rc6 ? > > I can see that imx_udc.c is broken still, but there are no maintainers > for that driver. I'm adding Sascha to Cc list, maybe he knows someone > who can help, but if this driver isn't fixed in 2 merge windows, I will > schedule for removal from tree and someone else will have to > re-introduce it later without all the bogus includes. Ah, I see what happened now: I submitted a patch that lumped together two patches, disabling both fsl_mxc_udc and imx_udc. You already had a fix for the first one, so I dropped my patch, but now I see the build error for the second one that my patch was avoiding. The last patch to imx_udc that seems to have seen more than just build testing was probably "USB: gadget: imx_udc: don't queue more data when zlp is to be sent", while fsl_mxc_udc looks actively maintained. It's not completely clear to me whether these are actually two drivers for the same hardware, of whether imx_udc is the i.mx1 variant and fsl_mxc_udc is the i.mx2 variant. What I can say is that no platform in the kernel currently defines an "imx_udc" platform_device, so it is certainly unused, and has been since at least e08300043e in 2010. I would suggest that we mark the imx_udc driver as 'depends on BROKEN' right away, since no in-tree user needs it, and any out of tree user is already broken in 3.8. I also wouldn't mind removing the driver unless the imx maintainers have a plan for it. > build breaks --- > > sound/soc/fsl/imx-pcm.c: In function 'snd_imx_pcm_mmap': > sound/soc/fsl/imx-pcm.c:28:2: error: 'KBUILD_MODNAME' undeclared (first use > in this function) > sound/soc/fsl/imx-pcm.c:28:2: note: each undeclared identifier is > reported only once for each function it appears in > make[3]: *** [sound/soc/fsl/imx-pcm.o] Error 1 > > drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div': > drivers/video/omap2/dss/dss.c:572:20: error: > 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) > drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier > is reported only once for each function it appears in > make[4]: *** [drivers/video/omap2/dss/dss.o] Error 1 Yes, I submitted patches for these, too, and like this case, we decided to drop my patch in favor of a better fix, which has not yet gone in. Today I sent emails about these as well, in the hope that we can find a solution. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
Hi, On Tue, Feb 05, 2013 at 09:00:27AM -0800, Greg Kroah-Hartman wrote: > On Tue, Feb 05, 2013 at 04:27:18PM +, Arnd Bergmann wrote: > > On Monday 21 January 2013, Greg Kroah-Hartman wrote: > > > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > > > > Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build > > > > > without the mach/hardware.h file that is not available when building > > > > > for multiplatform. Let's disable these drivers for v3.8 in combination > > > > > with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless > > > > > someone has an better solution. > > > > > > > > > > Without this patch, building allyesconfig results in: > > > > > > > > > > drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: > > > > > No such file or directory > > > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > Cc: Felipe Balbi > > > > > Cc: Shawn Guo > > > > > Cc: Greg Kroah-Hartman > > > > > Cc: linux-...@vger.kernel.org > > > > > > > > NAK, I prefer to see a real fix for the problem (which in fact is > > > > already in my fixes branch). > > > > > > I'll pull that branch now, sorry for the delay. > > > > Apparently it hasn't made it into the upstream kernel yet, and it also > > doesn't > > seem to be in linux-next. Maybe this got lost while you were travelling? > > Hm, no, I thought I got Felipe's fixes branch up into Linus's tree > already. Felipe, did I miss something from you? If so, please resend > or let me know, as I don't have anything pending on my side. I don't have anything pending in my fixes branch: $ git log fixes ^linus/master $ git show-branch linus/master [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm It's building find for me: $ crossmake drivers/usb/gadget/fsl_udc_core.o \ drivers/usb/gadget/fsl_mxc_udc.o > /dev/null (crossmake is an alias to make ARCH=arm) Arnd, are you maybe missing a merge of v3.8-rc6 ? I can see that imx_udc.c is broken still, but there are no maintainers for that driver. I'm adding Sascha to Cc list, maybe he knows someone who can help, but if this driver isn't fixed in 2 merge windows, I will schedule for removal from tree and someone else will have to re-introduce it later without all the bogus includes. build breaks --- sound/soc/fsl/imx-pcm.c: In function 'snd_imx_pcm_mmap': sound/soc/fsl/imx-pcm.c:28:2: error: 'KBUILD_MODNAME' undeclared (first use in this function) sound/soc/fsl/imx-pcm.c:28:2: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [sound/soc/fsl/imx-pcm.o] Error 1 drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div': drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [drivers/video/omap2/dss/dss.o] Error 1 -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tue, Feb 05, 2013 at 04:27:18PM +, Arnd Bergmann wrote: > On Monday 21 January 2013, Greg Kroah-Hartman wrote: > > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > > > Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build > > > > without the mach/hardware.h file that is not available when building > > > > for multiplatform. Let's disable these drivers for v3.8 in combination > > > > with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless > > > > someone has an better solution. > > > > > > > > Without this patch, building allyesconfig results in: > > > > > > > > drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: > > > > No such file or directory > > > > > > > > Signed-off-by: Arnd Bergmann > > > > Cc: Felipe Balbi > > > > Cc: Shawn Guo > > > > Cc: Greg Kroah-Hartman > > > > Cc: linux-...@vger.kernel.org > > > > > > NAK, I prefer to see a real fix for the problem (which in fact is > > > already in my fixes branch). > > > > I'll pull that branch now, sorry for the delay. > > Apparently it hasn't made it into the upstream kernel yet, and it also doesn't > seem to be in linux-next. Maybe this got lost while you were travelling? Hm, no, I thought I got Felipe's fixes branch up into Linus's tree already. Felipe, did I miss something from you? If so, please resend or let me know, as I don't have anything pending on my side. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Monday 21 January 2013, Greg Kroah-Hartman wrote: > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > > Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build > > > without the mach/hardware.h file that is not available when building > > > for multiplatform. Let's disable these drivers for v3.8 in combination > > > with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless > > > someone has an better solution. > > > > > > Without this patch, building allyesconfig results in: > > > > > > drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No > > > such file or directory > > > > > > Signed-off-by: Arnd Bergmann > > > Cc: Felipe Balbi > > > Cc: Shawn Guo > > > Cc: Greg Kroah-Hartman > > > Cc: linux-...@vger.kernel.org > > > > NAK, I prefer to see a real fix for the problem (which in fact is > > already in my fixes branch). > > I'll pull that branch now, sorry for the delay. Apparently it hasn't made it into the upstream kernel yet, and it also doesn't seem to be in linux-next. Maybe this got lost while you were travelling? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Monday 21 January 2013, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file that is not available when building for multiplatform. Let's disable these drivers for v3.8 in combination with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless someone has an better solution. Without this patch, building allyesconfig results in: drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such file or directory Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Cc: Shawn Guo shawn@linaro.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). I'll pull that branch now, sorry for the delay. Apparently it hasn't made it into the upstream kernel yet, and it also doesn't seem to be in linux-next. Maybe this got lost while you were travelling? Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tue, Feb 05, 2013 at 04:27:18PM +, Arnd Bergmann wrote: On Monday 21 January 2013, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file that is not available when building for multiplatform. Let's disable these drivers for v3.8 in combination with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless someone has an better solution. Without this patch, building allyesconfig results in: drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such file or directory Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Cc: Shawn Guo shawn@linaro.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). I'll pull that branch now, sorry for the delay. Apparently it hasn't made it into the upstream kernel yet, and it also doesn't seem to be in linux-next. Maybe this got lost while you were travelling? Hm, no, I thought I got Felipe's fixes branch up into Linus's tree already. Felipe, did I miss something from you? If so, please resend or let me know, as I don't have anything pending on my side. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
Hi, On Tue, Feb 05, 2013 at 09:00:27AM -0800, Greg Kroah-Hartman wrote: On Tue, Feb 05, 2013 at 04:27:18PM +, Arnd Bergmann wrote: On Monday 21 January 2013, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file that is not available when building for multiplatform. Let's disable these drivers for v3.8 in combination with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless someone has an better solution. Without this patch, building allyesconfig results in: drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such file or directory Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Cc: Shawn Guo shawn@linaro.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). I'll pull that branch now, sorry for the delay. Apparently it hasn't made it into the upstream kernel yet, and it also doesn't seem to be in linux-next. Maybe this got lost while you were travelling? Hm, no, I thought I got Felipe's fixes branch up into Linus's tree already. Felipe, did I miss something from you? If so, please resend or let me know, as I don't have anything pending on my side. I don't have anything pending in my fixes branch: $ git log fixes ^linus/master $ git show-branch linus/master [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm It's building find for me: $ crossmake drivers/usb/gadget/fsl_udc_core.o \ drivers/usb/gadget/fsl_mxc_udc.o /dev/null (crossmake is an alias to make ARCH=arm) Arnd, are you maybe missing a merge of v3.8-rc6 ? I can see that imx_udc.c is broken still, but there are no maintainers for that driver. I'm adding Sascha to Cc list, maybe he knows someone who can help, but if this driver isn't fixed in 2 merge windows, I will schedule for removal from tree and someone else will have to re-introduce it later without all the bogus includes. build breaks --- sound/soc/fsl/imx-pcm.c: In function 'snd_imx_pcm_mmap': sound/soc/fsl/imx-pcm.c:28:2: error: 'KBUILD_MODNAME' undeclared (first use in this function) sound/soc/fsl/imx-pcm.c:28:2: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [sound/soc/fsl/imx-pcm.o] Error 1 drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div': drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [drivers/video/omap2/dss/dss.o] Error 1 -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tuesday 05 February 2013, Felipe Balbi wrote: [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm It's building find for me: $ crossmake drivers/usb/gadget/fsl_udc_core.o \ drivers/usb/gadget/fsl_mxc_udc.o /dev/null (crossmake is an alias to make ARCH=arm) Arnd, are you maybe missing a merge of v3.8-rc6 ? I can see that imx_udc.c is broken still, but there are no maintainers for that driver. I'm adding Sascha to Cc list, maybe he knows someone who can help, but if this driver isn't fixed in 2 merge windows, I will schedule for removal from tree and someone else will have to re-introduce it later without all the bogus includes. Ah, I see what happened now: I submitted a patch that lumped together two patches, disabling both fsl_mxc_udc and imx_udc. You already had a fix for the first one, so I dropped my patch, but now I see the build error for the second one that my patch was avoiding. The last patch to imx_udc that seems to have seen more than just build testing was probably USB: gadget: imx_udc: don't queue more data when zlp is to be sent, while fsl_mxc_udc looks actively maintained. It's not completely clear to me whether these are actually two drivers for the same hardware, of whether imx_udc is the i.mx1 variant and fsl_mxc_udc is the i.mx2 variant. What I can say is that no platform in the kernel currently defines an imx_udc platform_device, so it is certainly unused, and has been since at least e08300043e in 2010. I would suggest that we mark the imx_udc driver as 'depends on BROKEN' right away, since no in-tree user needs it, and any out of tree user is already broken in 3.8. I also wouldn't mind removing the driver unless the imx maintainers have a plan for it. build breaks --- sound/soc/fsl/imx-pcm.c: In function 'snd_imx_pcm_mmap': sound/soc/fsl/imx-pcm.c:28:2: error: 'KBUILD_MODNAME' undeclared (first use in this function) sound/soc/fsl/imx-pcm.c:28:2: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [sound/soc/fsl/imx-pcm.o] Error 1 drivers/video/omap2/dss/dss.c: In function 'dss_calc_clock_div': drivers/video/omap2/dss/dss.c:572:20: error: 'CONFIG_OMAP2_DSS_MIN_FCK_PER_PCK' undeclared (first use in this function) drivers/video/omap2/dss/dss.c:572:20: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [drivers/video/omap2/dss/dss.o] Error 1 Yes, I submitted patches for these, too, and like this case, we decided to drop my patch in favor of a better fix, which has not yet gone in. Today I sent emails about these as well, in the hope that we can find a solution. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tue, Feb 05, 2013 at 10:54:00PM +, Arnd Bergmann wrote: On Tuesday 05 February 2013, Felipe Balbi wrote: [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm It's building find for me: $ crossmake drivers/usb/gadget/fsl_udc_core.o \ drivers/usb/gadget/fsl_mxc_udc.o /dev/null (crossmake is an alias to make ARCH=arm) Arnd, are you maybe missing a merge of v3.8-rc6 ? I can see that imx_udc.c is broken still, but there are no maintainers for that driver. I'm adding Sascha to Cc list, maybe he knows someone who can help, but if this driver isn't fixed in 2 merge windows, I will schedule for removal from tree and someone else will have to re-introduce it later without all the bogus includes. Ah, I see what happened now: I submitted a patch that lumped together two patches, disabling both fsl_mxc_udc and imx_udc. You already had a fix for the first one, so I dropped my patch, but now I see the build error for the second one that my patch was avoiding. The last patch to imx_udc that seems to have seen more than just build testing was probably USB: gadget: imx_udc: don't queue more data when zlp is to be sent, while fsl_mxc_udc looks actively maintained. It's not completely clear to me whether these are actually two drivers for the same hardware, of whether imx_udc is the i.mx1 variant and fsl_mxc_udc is the i.mx2 variant. What I can say is that no platform in the kernel currently defines an imx_udc platform_device, so it is certainly unused, and has been since at least e08300043e in 2010. I would suggest that we mark the imx_udc driver as 'depends on BROKEN' right away, since no in-tree user needs it, and any out of tree user is already broken in 3.8. I also wouldn't mind removing the driver unless the imx maintainers have a plan for it. Sure, someone just send me a patch for that and I'll be glad to mark it BROKEN. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Tue, Feb 05, 2013 at 05:55:11PM -0800, Greg Kroah-Hartman wrote: On Tue, Feb 05, 2013 at 10:54:00PM +, Arnd Bergmann wrote: On Tuesday 05 February 2013, Felipe Balbi wrote: [linus/master] Merge branch 'fix-max-write' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm It's building find for me: $ crossmake drivers/usb/gadget/fsl_udc_core.o \ drivers/usb/gadget/fsl_mxc_udc.o /dev/null (crossmake is an alias to make ARCH=arm) Arnd, are you maybe missing a merge of v3.8-rc6 ? I can see that imx_udc.c is broken still, but there are no maintainers for that driver. I'm adding Sascha to Cc list, maybe he knows someone who can help, but if this driver isn't fixed in 2 merge windows, I will schedule for removal from tree and someone else will have to re-introduce it later without all the bogus includes. Ah, I see what happened now: I submitted a patch that lumped together two patches, disabling both fsl_mxc_udc and imx_udc. You already had a fix for the first one, so I dropped my patch, but now I see the build error for the second one that my patch was avoiding. The last patch to imx_udc that seems to have seen more than just build testing was probably USB: gadget: imx_udc: don't queue more data when zlp is to be sent, while fsl_mxc_udc looks actively maintained. It's not completely clear to me whether these are actually two drivers for the same hardware, of whether imx_udc is the i.mx1 variant and fsl_mxc_udc is the i.mx2 variant. What I can say is that no platform in the kernel currently defines an imx_udc platform_device, so it is certainly unused, and has been since at least e08300043e in 2010. I would suggest that we mark the imx_udc driver as 'depends on BROKEN' right away, since no in-tree user needs it, and any out of tree user is already broken in 3.8. I also wouldn't mind removing the driver unless the imx maintainers have a plan for it. Sure, someone just send me a patch for that and I'll be glad to mark it BROKEN. coming in a minute -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Monday 21 January 2013, Greg Kroah-Hartman wrote: > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > > NAK, I prefer to see a real fix for the problem (which in fact is > > already in my fixes branch). > > I'll pull that branch now, sorry for the delay. > Ok, great! Thanks a lot, both of you, Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Mon, Jan 21, 2013 at 10:57:16AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > > Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build > > > without the mach/hardware.h file that is not available when building > > > for multiplatform. Let's disable these drivers for v3.8 in combination > > > with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless > > > someone has an better solution. > > > > > > Without this patch, building allyesconfig results in: > > > > > > drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No > > > such file or directory > > > > > > Signed-off-by: Arnd Bergmann > > > Cc: Felipe Balbi > > > Cc: Shawn Guo > > > Cc: Greg Kroah-Hartman > > > Cc: linux-...@vger.kernel.org > > > > NAK, I prefer to see a real fix for the problem (which in fact is > > already in my fixes branch). > > I'll pull that branch now, sorry for the delay. no problem ;-) -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build > > without the mach/hardware.h file that is not available when building > > for multiplatform. Let's disable these drivers for v3.8 in combination > > with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless > > someone has an better solution. > > > > Without this patch, building allyesconfig results in: > > > > drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No > > such file or directory > > > > Signed-off-by: Arnd Bergmann > > Cc: Felipe Balbi > > Cc: Shawn Guo > > Cc: Greg Kroah-Hartman > > Cc: linux-...@vger.kernel.org > > NAK, I prefer to see a real fix for the problem (which in fact is > already in my fixes branch). I'll pull that branch now, sorry for the delay. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build > without the mach/hardware.h file that is not available when building > for multiplatform. Let's disable these drivers for v3.8 in combination > with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless > someone has an better solution. > > Without this patch, building allyesconfig results in: > > drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such > file or directory > > Signed-off-by: Arnd Bergmann > Cc: Felipe Balbi > Cc: Shawn Guo > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). Next time, before enabling something by default, check that allyesconfig, allmodconfig and allnoconfig builds fine, please. -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file that is not available when building for multiplatform. Let's disable these drivers for v3.8 in combination with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless someone has an better solution. Without this patch, building allyesconfig results in: drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such file or directory Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Cc: Shawn Guo shawn@linaro.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). Next time, before enabling something by default, check that allyesconfig, allmodconfig and allnoconfig builds fine, please. -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file that is not available when building for multiplatform. Let's disable these drivers for v3.8 in combination with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless someone has an better solution. Without this patch, building allyesconfig results in: drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such file or directory Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Cc: Shawn Guo shawn@linaro.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). I'll pull that branch now, sorry for the delay. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Mon, Jan 21, 2013 at 10:57:16AM -0800, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: Hi, On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build without the mach/hardware.h file that is not available when building for multiplatform. Let's disable these drivers for v3.8 in combination with CONFIG_ARCH_MULTIPLATFORM, and fix them properly in v3.9 unless someone has an better solution. Without this patch, building allyesconfig results in: drivers/usb/gadget/fsl_mxc_udc.c:21:27: fatal error: mach/hardware.h: No such file or directory Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Felipe Balbi ba...@ti.com Cc: Shawn Guo shawn@linaro.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). I'll pull that branch now, sorry for the delay. no problem ;-) -- balbi signature.asc Description: Digital signature
Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers
On Monday 21 January 2013, Greg Kroah-Hartman wrote: On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: NAK, I prefer to see a real fix for the problem (which in fact is already in my fixes branch). I'll pull that branch now, sorry for the delay. Ok, great! Thanks a lot, both of you, Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
