RE: [PATCH 15/23] dt-bindings: pci: mobiveil: change gpio_slave and apb_csr to optional
Hi Subrahmanya, Thanks a lot for your ACK! Regards, Zhiqiang > -Original Message- > From: Subrahmanya Lingappa > Sent: 2018年11月14日 17:33 > To: Z.q. Hou > Cc: linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Bjorn Helgaas > ; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; Leo Li ; Lorenzo Pieralisi > ; Mingkai Hu ; M.h. Lian > ; Xiaowei Bao > Subject: Re: [PATCH 15/23] dt-bindings: pci: mobiveil: change gpio_slave and > apb_csr to optional > > Acked-by: Subrahmanya Lingappa > > On Tue, Nov 6, 2018 at 6:50 PM Z.q. Hou wrote: > > > > From: Hou Zhiqiang > > > > Change the "gpio_slave" and "apb_csr" to optional, the "gpio_slave" > > is not used in current code, and "apb_csr" is not used by some > > platorms. > > > > Signed-off-by: Hou Zhiqiang > > --- > > Documentation/devicetree/bindings/pci/mobiveil-pcie.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > > b/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > > index a618d4787dd7..64156993e052 100644 > > --- a/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > > +++ b/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > > @@ -10,8 +10,10 @@ Required properties: > > interrupt source. The value must be 1. > > - compatible: Should contain "mbvl,gpex40-pcie" > > - reg: Should contain PCIe registers location and length > > + Mandatory: > > "config_axi_slave": PCIe controller registers > > "csr_axi_slave" : Bridge config registers > > + Optional: > > "gpio_slave" : GPIO registers to control slot power > > "apb_csr" : MSI registers > > > > -- > > 2.17.1 > >
Re: [PATCH 15/23] dt-bindings: pci: mobiveil: change gpio_slave and apb_csr to optional
Acked-by: Subrahmanya Lingappa On Tue, Nov 6, 2018 at 6:50 PM Z.q. Hou wrote: > > From: Hou Zhiqiang > > Change the "gpio_slave" and "apb_csr" to optional, the "gpio_slave" > is not used in current code, and "apb_csr" is not used by some > platorms. > > Signed-off-by: Hou Zhiqiang > --- > Documentation/devicetree/bindings/pci/mobiveil-pcie.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > b/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > index a618d4787dd7..64156993e052 100644 > --- a/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/mobiveil-pcie.txt > @@ -10,8 +10,10 @@ Required properties: > interrupt source. The value must be 1. > - compatible: Should contain "mbvl,gpex40-pcie" > - reg: Should contain PCIe registers location and length > + Mandatory: > "config_axi_slave": PCIe controller registers > "csr_axi_slave" : Bridge config registers > + Optional: > "gpio_slave" : GPIO registers to control slot power > "apb_csr" : MSI registers > > -- > 2.17.1 >
RE: [PATCH 15/23] dt-bindings: pci: mobiveil: change gpio_slave and apb_csr to optional
Hi Rob, Thanks a lot for your ACK! > -Original Message- > From: Rob Herring > Sent: 2018年11月13日 2:13 > To: Z.q. Hou > Cc: linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > bhelg...@google.com; mark.rutl...@arm.com; > l.subrahma...@mobiveil.co.in; shawn...@kernel.org; Leo Li > ; lorenzo.pieral...@arm.com; Mingkai Hu > ; M.h. Lian ; Xiaowei Bao > > Subject: Re: [PATCH 15/23] dt-bindings: pci: mobiveil: change gpio_slave and > apb_csr to optional > > On Tue, Nov 06, 2018 at 01:20:41PM +, Z.q. Hou wrote: > > From: Hou Zhiqiang > > > > Change the "gpio_slave" and "apb_csr" to optional, the "gpio_slave" > > is not used in current code, and "apb_csr" is not used by some > > platorms. > > > > Signed-off-by: Hou Zhiqiang > > --- > > Documentation/devicetree/bindings/pci/mobiveil-pcie.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > Acked-by: Rob Herring Regards, Zhiqiang
