Re: [PATCH 16/18] perf tools: Add debug prints for ordered events queue

2014-06-29 Thread David Ahern

On 6/29/14, 10:46 AM, Jiri Olsa wrote:

On Fri, Jun 27, 2014 at 08:52:26PM -0600, David Ahern wrote:

On 6/18/14, 8:58 AM, Jiri Olsa wrote:

Adding some prints for ordered events queue, to help
debug issues.


went to enable this and it is really odd to have to edit a config file to
enable debugging. How about hooking it into verbose option? Maybe like
multiple levels of -v or -v  or -v queue.


seems like verbose option factoring.. in future ;-) I can live
without this patch though.. it was mainly for testing my changes


It was quite useful to see how various data sets were stressing the 
ordered samples queue. For example 'perf record -g' and a kernel build 
stressed it more than the record on the 'perf bench'.


David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 16/18] perf tools: Add debug prints for ordered events queue

2014-06-29 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 08:52:26PM -0600, David Ahern wrote:
> On 6/18/14, 8:58 AM, Jiri Olsa wrote:
> >Adding some prints for ordered events queue, to help
> >debug issues.
> 
> went to enable this and it is really odd to have to edit a config file to
> enable debugging. How about hooking it into verbose option? Maybe like
> multiple levels of -v or -v  or -v queue.

seems like verbose option factoring.. in future ;-) I can live
without this patch though.. it was mainly for testing my changes

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 16/18] perf tools: Add debug prints for ordered events queue

2014-06-29 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 08:52:26PM -0600, David Ahern wrote:
 On 6/18/14, 8:58 AM, Jiri Olsa wrote:
 Adding some prints for ordered events queue, to help
 debug issues.
 
 went to enable this and it is really odd to have to edit a config file to
 enable debugging. How about hooking it into verbose option? Maybe like
 multiple levels of -v or -v val or -v queue.

seems like verbose option factoring.. in future ;-) I can live
without this patch though.. it was mainly for testing my changes

thanks,
jirka
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 16/18] perf tools: Add debug prints for ordered events queue

2014-06-29 Thread David Ahern

On 6/29/14, 10:46 AM, Jiri Olsa wrote:

On Fri, Jun 27, 2014 at 08:52:26PM -0600, David Ahern wrote:

On 6/18/14, 8:58 AM, Jiri Olsa wrote:

Adding some prints for ordered events queue, to help
debug issues.


went to enable this and it is really odd to have to edit a config file to
enable debugging. How about hooking it into verbose option? Maybe like
multiple levels of -v or -v val or -v queue.


seems like verbose option factoring.. in future ;-) I can live
without this patch though.. it was mainly for testing my changes


It was quite useful to see how various data sets were stressing the 
ordered samples queue. For example 'perf record -g' and a kernel build 
stressed it more than the record on the 'perf bench'.


David

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 16/18] perf tools: Add debug prints for ordered events queue

2014-06-27 Thread David Ahern

On 6/18/14, 8:58 AM, Jiri Olsa wrote:

Adding some prints for ordered events queue, to help
debug issues.


went to enable this and it is really odd to have to edit a config file 
to enable debugging. How about hooking it into verbose option? Maybe 
like multiple levels of -v or -v  or -v queue.


David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 16/18] perf tools: Add debug prints for ordered events queue

2014-06-27 Thread David Ahern

On 6/18/14, 8:58 AM, Jiri Olsa wrote:

Adding some prints for ordered events queue, to help
debug issues.


went to enable this and it is really odd to have to edit a config file 
to enable debugging. How about hooking it into verbose option? Maybe 
like multiple levels of -v or -v val or -v queue.


David
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/