Re: [PATCH 2/2] ARM: nomadik: configure Nomadik for pin control

2012-08-10 Thread Stephen Warren 
On 08/09/2012 04:43 PM, Linus Walleij wrote:
> This converts the Nomadik to using pin control using the
> driver for the STN8815 ASIC.

> diff --git a/arch/arm/mach-nomadik/cpu-8815.c 
> b/arch/arm/mach-nomadik/cpu-8815.c

> +static inline void
> +cpu8815_add_pinctrl(struct device *parent, const char *name)
> +{
> + struct platform_device_info pdevinfo = {
> + .parent = parent,
> + .name = name,
> + .id = -1,
> + };
> +
> + platform_device_register_full();
> +}

Out of curiosity, why platform_device_register_full() not
platform_device_register() here?

Otherwise,
Acked-by: Stephen Warren 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] ARM: nomadik: configure Nomadik for pin control

2012-08-10 Thread Stephen Warren 
On 08/09/2012 04:43 PM, Linus Walleij wrote:
 This converts the Nomadik to using pin control using the
 driver for the STN8815 ASIC.

 diff --git a/arch/arm/mach-nomadik/cpu-8815.c 
 b/arch/arm/mach-nomadik/cpu-8815.c

 +static inline void
 +cpu8815_add_pinctrl(struct device *parent, const char *name)
 +{
 + struct platform_device_info pdevinfo = {
 + .parent = parent,
 + .name = name,
 + .id = -1,
 + };
 +
 + platform_device_register_full(pdevinfo);
 +}

Out of curiosity, why platform_device_register_full() not
platform_device_register() here?

Otherwise,
Acked-by: Stephen Warren swar...@wwwdotorg.org

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/