Re: [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings
> >At the moment we're relying on inheriting them from DTSI files which > >we're including Ideally we should be specifying these for ourselves. > > > >Signed-off-by: Lee Jones > >--- > > arch/arm/boot/dts/stih416-b2020-revE.dts | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts > >b/arch/arm/boot/dts/stih416-b2020-revE.dts > >index bcb9d00..4168b019 100644 > >--- a/arch/arm/boot/dts/stih416-b2020-revE.dts > >+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts > >@@ -8,6 +8,7 @@ > > */ > > /dts-v1/; > > #include "stih416.dtsi" > >+#include "stih416-pinctrl.dtsi" > Isn't this file already included in stih416.dtsi? It is, but it's being inherited. I'm unsure if the DT rules are different, but in *.c files #includes should be added explicitly in the file they are used. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings
> > #include "stih41x-b2020.dtsi"
> > / {
> > model = "STih416 B2020 REV. E";
> >
>
> For the next revision, could you please add ker...@stlinux.com in cc?
Ah yes, of course. My mistake. I used the wrong flag when sending the
patches '--arm' instaed of '--st-arm'.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings
On 03/11/2014 11:22 AM, Lee Jones wrote:
At the moment we're relying on inheriting them from DTSI files which
we're including Ideally we should be specifying these for ourselves.
Signed-off-by: Lee Jones
---
arch/arm/boot/dts/stih416-b2020-revE.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index bcb9d00..4168b019 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -8,6 +8,7 @@
*/
/dts-v1/;
#include "stih416.dtsi"
+#include "stih416-pinctrl.dtsi"
Isn't this file already included in stih416.dtsi?
#include "stih41x-b2020.dtsi"
/ {
model = "STih416 B2020 REV. E";
For the next revision, could you please add ker...@stlinux.com in cc?
Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings
On 03/11/2014 11:22 AM, Lee Jones wrote:
At the moment we're relying on inheriting them from DTSI files which
we're including Ideally we should be specifying these for ourselves.
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
arch/arm/boot/dts/stih416-b2020-revE.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts
b/arch/arm/boot/dts/stih416-b2020-revE.dts
index bcb9d00..4168b019 100644
--- a/arch/arm/boot/dts/stih416-b2020-revE.dts
+++ b/arch/arm/boot/dts/stih416-b2020-revE.dts
@@ -8,6 +8,7 @@
*/
/dts-v1/;
#include stih416.dtsi
+#include stih416-pinctrl.dtsi
Isn't this file already included in stih416.dtsi?
#include stih41x-b2020.dtsi
/ {
model = STih416 B2020 REV. E;
For the next revision, could you please add ker...@stlinux.com in cc?
Regards,
Maxime
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings
#include stih41x-b2020.dtsi
/ {
model = STih416 B2020 REV. E;
For the next revision, could you please add ker...@stlinux.com in cc?
Ah yes, of course. My mistake. I used the wrong flag when sending the
patches '--arm' instaed of '--st-arm'.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings
At the moment we're relying on inheriting them from DTSI files which we're including Ideally we should be specifying these for ourselves. Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/stih416-b2020-revE.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/stih416-b2020-revE.dts b/arch/arm/boot/dts/stih416-b2020-revE.dts index bcb9d00..4168b019 100644 --- a/arch/arm/boot/dts/stih416-b2020-revE.dts +++ b/arch/arm/boot/dts/stih416-b2020-revE.dts @@ -8,6 +8,7 @@ */ /dts-v1/; #include stih416.dtsi +#include stih416-pinctrl.dtsi Isn't this file already included in stih416.dtsi? It is, but it's being inherited. I'm unsure if the DT rules are different, but in *.c files #includes should be added explicitly in the file they are used. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
