Re: [PATCH 2/6] CRIS: remove SMP code
On Sat, 2015-02-21 at 01:40 +0100, Rabin Vincent wrote: > On Fri, Feb 20, 2015 at 01:06:03AM +0100, Paul Bolle wrote: > > On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: > > > The CRIS SMP code cannot be built since there is no (and appears to > > > never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. > > > > Yes, it appears there never was a Kconfig symbol SMP for cris so this > > probably was dead code ever since it was added in, I think, v2.6.13. (I > > should mention I didn't review this patch, or cris' apparently > > non-functional SMP code, in detail.) > > > > Mind if I ask how you spotted this? > > If you're asking if I used some kind of script, no, I didn't. I just > noticed it while working on other CRIS patches. Yes. See, I run a script locally. It is rather simple and only catches the more obvious kconfig related mistakes. I'm pretty sure I won't bother teaching it to spot mistakes like this one. But other people are working on a sophisticated bot that might be able to catch those. But, anyhow, just paying attention when fiddling with a piece of code and spotting possible oddities is of course greatly appreciated! Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
On Sat, 2015-02-21 at 01:40 +0100, Rabin Vincent wrote: On Fri, Feb 20, 2015 at 01:06:03AM +0100, Paul Bolle wrote: On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: The CRIS SMP code cannot be built since there is no (and appears to never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. Yes, it appears there never was a Kconfig symbol SMP for cris so this probably was dead code ever since it was added in, I think, v2.6.13. (I should mention I didn't review this patch, or cris' apparently non-functional SMP code, in detail.) Mind if I ask how you spotted this? If you're asking if I used some kind of script, no, I didn't. I just noticed it while working on other CRIS patches. Yes. See, I run a script locally. It is rather simple and only catches the more obvious kconfig related mistakes. I'm pretty sure I won't bother teaching it to spot mistakes like this one. But other people are working on a sophisticated bot that might be able to catch those. But, anyhow, just paying attention when fiddling with a piece of code and spotting possible oddities is of course greatly appreciated! Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
On Fri, Feb 20, 2015 at 01:06:03AM +0100, Paul Bolle wrote: > On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: > > The CRIS SMP code cannot be built since there is no (and appears to > > never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. > > Yes, it appears there never was a Kconfig symbol SMP for cris so this > probably was dead code ever since it was added in, I think, v2.6.13. (I > should mention I didn't review this patch, or cris' apparently > non-functional SMP code, in detail.) > > Mind if I ask how you spotted this? If you're asking if I used some kind of script, no, I didn't. I just noticed it while working on other CRIS patches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
On Fri, Feb 20, 2015 at 01:06:03AM +0100, Paul Bolle wrote: On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: The CRIS SMP code cannot be built since there is no (and appears to never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. Yes, it appears there never was a Kconfig symbol SMP for cris so this probably was dead code ever since it was added in, I think, v2.6.13. (I should mention I didn't review this patch, or cris' apparently non-functional SMP code, in detail.) Mind if I ask how you spotted this? If you're asking if I used some kind of script, no, I didn't. I just noticed it while working on other CRIS patches. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
There was a discussions about making a SMP CRIS once and the code actually ran on emulator. But I guess something went wrong during uppstreamimg. Anyway there is no real silicone so removing it is correct. > 20 feb 2015 kl. 01:06 skrev "Paul Bolle" : > >> On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: >> The CRIS SMP code cannot be built since there is no (and appears to >> never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. > > Yes, it appears there never was a Kconfig symbol SMP for cris so this > probably was dead code ever since it was added in, I think, v2.6.13. (I > should mention I didn't review this patch, or cris' apparently > non-functional SMP code, in detail.) > > Mind if I ask how you spotted this? > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
On Thu, Feb 19, 2015 at 08:29:52PM +0100, Rabin Vincent wrote: > The CRIS SMP code cannot be built since there is no (and appears to > never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. > > Signed-off-by: Rabin Vincent Nice, added to the queue for the CRIS-tree. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: > The CRIS SMP code cannot be built since there is no (and appears to > never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. Yes, it appears there never was a Kconfig symbol SMP for cris so this probably was dead code ever since it was added in, I think, v2.6.13. (I should mention I didn't review this patch, or cris' apparently non-functional SMP code, in detail.) Mind if I ask how you spotted this? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
There was a discussions about making a SMP CRIS once and the code actually ran on emulator. But I guess something went wrong during uppstreamimg. Anyway there is no real silicone so removing it is correct. 20 feb 2015 kl. 01:06 skrev Paul Bolle pebo...@tiscali.nl: On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: The CRIS SMP code cannot be built since there is no (and appears to never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. Yes, it appears there never was a Kconfig symbol SMP for cris so this probably was dead code ever since it was added in, I think, v2.6.13. (I should mention I didn't review this patch, or cris' apparently non-functional SMP code, in detail.) Mind if I ask how you spotted this? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
On Thu, 2015-02-19 at 20:29 +0100, Rabin Vincent wrote: The CRIS SMP code cannot be built since there is no (and appears to never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. Yes, it appears there never was a Kconfig symbol SMP for cris so this probably was dead code ever since it was added in, I think, v2.6.13. (I should mention I didn't review this patch, or cris' apparently non-functional SMP code, in detail.) Mind if I ask how you spotted this? Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/6] CRIS: remove SMP code
On Thu, Feb 19, 2015 at 08:29:52PM +0100, Rabin Vincent wrote: The CRIS SMP code cannot be built since there is no (and appears to never have been) a CONFIG_SMP Kconfig option in arch/cris/. Remove it. Signed-off-by: Rabin Vincent ra...@rab.in Nice, added to the queue for the CRIS-tree. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nils...@axis.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
