Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On 03/19/2013 01:53 PM, Stephen Warren wrote: > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: >> This patch updates all Tegra board files so that they contain all the >> properties required by the updated USB DT binding. Note that this patch >> only adds the new properties and does not yet remove the old properties, >> in order to maintain bisectability. The old properties will be removed >> once the driver has been updated to assume the new bindings. >> >> Signed-off-by: Venu Byravarasu >> --- >> arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++ >> arch/arm/boot/dts/tegra20-harmony.dts |8 +++--- >> arch/arm/boot/dts/tegra20-iris-512.dts |4 +++ >> arch/arm/boot/dts/tegra20-paz00.dts|8 +++--- >> arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++--- >> arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++--- >> arch/arm/boot/dts/tegra20-ventana.dts |7 +++-- >> arch/arm/boot/dts/tegra20.dtsi | 32 >> +-- >> 8 files changed, 57 insertions(+), 31 deletions(-) > > I think you forgot to update arch/arm/boot/dts/tegra20-whistler.dts in > this patch. This was not fixed in V2. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On 03/19/2013 01:53 PM, Stephen Warren wrote: On 03/18/2013 06:29 AM, Venu Byravarasu wrote: This patch updates all Tegra board files so that they contain all the properties required by the updated USB DT binding. Note that this patch only adds the new properties and does not yet remove the old properties, in order to maintain bisectability. The old properties will be removed once the driver has been updated to assume the new bindings. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++ arch/arm/boot/dts/tegra20-harmony.dts |8 +++--- arch/arm/boot/dts/tegra20-iris-512.dts |4 +++ arch/arm/boot/dts/tegra20-paz00.dts|8 +++--- arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++--- arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++--- arch/arm/boot/dts/tegra20-ventana.dts |7 +++-- arch/arm/boot/dts/tegra20.dtsi | 32 +-- 8 files changed, 57 insertions(+), 31 deletions(-) I think you forgot to update arch/arm/boot/dts/tegra20-whistler.dts in this patch. This was not fixed in V2. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On 03/20/2013 05:23 AM, kishon wrote:
> Hi,
>
> On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
>> This patch updates all Tegra board files so that they contain all the
>> properties required by the updated USB DT binding. Note that this patch
>> only adds the new properties and does not yet remove the old properties,
>> in order to maintain bisectability. The old properties will be removed
>> once the driver has been updated to assume the new bindings.
>>
>> Signed-off-by: Venu Byravarasu
>> ---
>> arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
>> arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
>> arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
>> arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
>> arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
>> arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
>> arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
>> arch/arm/boot/dts/tegra20.dtsi | 32
>> +--
>> 8 files changed, 57 insertions(+), 31 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> index cb73e62..af5a7ae 100644
>> --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> @@ -443,6 +443,10 @@
>> nvidia,phy-reset-gpio = < 169 0>; /* gpio PV1 */
>> };
>>
>> +usb-phy@c5004000 {
>
> This node doesn't have a *reg* property. So "@c5004000" is not needed.
> This comment applies to all the nodes which doesn't have *reg* property.
Yes it does have a reg property.
The node itself is first defined in tegra20.dtsi, and does contain a reg
property there.
tegra20-colibri-512.dtsi (and many other files in this patch) include
tegra20.dtsi, and simply add additional board-specific properties to the
existing node, and should not re-iterate properties that already exist.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Wednesday, March 20, 2013 5:55 PM
> To: Venu Byravarasu
> Cc: kishon; gre...@linuxfoundation.org; st...@rowland.harvard.edu;
> ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
> disc...@lists.ozlabs.org
> Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
> rework
>
> * PGP Signed by an unknown key
>
> On Wed, Mar 20, 2013 at 05:47:46PM +0530, Venu Byravarasu wrote:
> > > -Original Message-
> > > From: kishon [mailto:kis...@ti.com]
> > > Sent: Wednesday, March 20, 2013 4:53 PM
> > > To: Venu Byravarasu
> > > Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
> > > ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
> > > disc...@lists.ozlabs.org
> > > Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
> > > rework
> > >
> > > Hi,
> > > >
> > > > + usb-phy@c5004000 {
> > > This node doesn't have a *reg* property. So "@c5004000" is not needed.
> > > This comment applies to all the nodes which doesn't have *reg* property.
> >
> > Thanks Kishon for the comments.
> > As I've 3 usb-phy DT nodes, how to differentiate between them if I remove
> this @Address ?
>
> then add reg property :-)
Thanks Felipe, for confirming.
>
> --
> balbi
>
> * Unknown Key
> * 0x35CAA444
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On Wed, Mar 20, 2013 at 05:47:46PM +0530, Venu Byravarasu wrote:
> > -Original Message-
> > From: kishon [mailto:kis...@ti.com]
> > Sent: Wednesday, March 20, 2013 4:53 PM
> > To: Venu Byravarasu
> > Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
> > ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> > swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
> > disc...@lists.ozlabs.org
> > Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
> > rework
> >
> > Hi,
> >
> > On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
> > > This patch updates all Tegra board files so that they contain all the
> > > properties required by the updated USB DT binding. Note that this patch
> > > only adds the new properties and does not yet remove the old properties,
> > > in order to maintain bisectability. The old properties will be removed
> > > once the driver has been updated to assume the new bindings.
> > >
> > > Signed-off-by: Venu Byravarasu
> > > ---
> > > arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
> > > arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
> > > arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
> > > arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
> > > arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
> > > arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
> > > arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
> > > arch/arm/boot/dts/tegra20.dtsi | 32
> > > +--
> > > 8 files changed, 57 insertions(+), 31 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> > b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> > > index cb73e62..af5a7ae 100644
> > > --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> > > +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> > > @@ -443,6 +443,10 @@
> > > nvidia,phy-reset-gpio = < 169 0>; /* gpio PV1 */
> > > };
> > >
> > > + usb-phy@c5004000 {
> > This node doesn't have a *reg* property. So "@c5004000" is not needed.
> > This comment applies to all the nodes which doesn't have *reg* property.
>
> Thanks Kishon for the comments.
> As I've 3 usb-phy DT nodes, how to differentiate between them if I remove
> this @Address ?
then add reg property :-)
--
balbi
signature.asc
Description: Digital signature
RE: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
> -Original Message- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Wednesday, March 20, 2013 1:24 AM > To: Venu Byravarasu > Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; > ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-te...@vger.kernel.org; devicetree-disc...@lists.ozlabs.org > Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding > rework > > On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > > This patch updates all Tegra board files so that they contain all the > > properties required by the updated USB DT binding. Note that this patch > > only adds the new properties and does not yet remove the old properties, > > in order to maintain bisectability. The old properties will be removed > > once the driver has been updated to assume the new bindings. > > > > Signed-off-by: Venu Byravarasu > > --- > > arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++ > > arch/arm/boot/dts/tegra20-harmony.dts |8 +++--- > > arch/arm/boot/dts/tegra20-iris-512.dts |4 +++ > > arch/arm/boot/dts/tegra20-paz00.dts|8 +++--- > > arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++--- > > arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++--- > > arch/arm/boot/dts/tegra20-ventana.dts |7 +++-- > > arch/arm/boot/dts/tegra20.dtsi | 32 > > +-- > > 8 files changed, 57 insertions(+), 31 deletions(-) > > I think you forgot to update arch/arm/boot/dts/tegra20-whistler.dts in > this patch. Thanks Stephen, will add that & send updated patch for review. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
> -Original Message-
> From: kishon [mailto:kis...@ti.com]
> Sent: Wednesday, March 20, 2013 4:53 PM
> To: Venu Byravarasu
> Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
> ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
> swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
> disc...@lists.ozlabs.org
> Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
> rework
>
> Hi,
>
> On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
> > This patch updates all Tegra board files so that they contain all the
> > properties required by the updated USB DT binding. Note that this patch
> > only adds the new properties and does not yet remove the old properties,
> > in order to maintain bisectability. The old properties will be removed
> > once the driver has been updated to assume the new bindings.
> >
> > Signed-off-by: Venu Byravarasu
> > ---
> > arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
> > arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
> > arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
> > arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
> > arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
> > arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
> > arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
> > arch/arm/boot/dts/tegra20.dtsi | 32
> > +--
> > 8 files changed, 57 insertions(+), 31 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> > index cb73e62..af5a7ae 100644
> > --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> > +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
> > @@ -443,6 +443,10 @@
> > nvidia,phy-reset-gpio = < 169 0>; /* gpio PV1 */
> > };
> >
> > + usb-phy@c5004000 {
> This node doesn't have a *reg* property. So "@c5004000" is not needed.
> This comment applies to all the nodes which doesn't have *reg* property.
Thanks Kishon for the comments.
As I've 3 usb-phy DT nodes, how to differentiate between them if I remove this
@Address ?
>
> Thanks
> Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
Hi,
On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
This patch updates all Tegra board files so that they contain all the
properties required by the updated USB DT binding. Note that this patch
only adds the new properties and does not yet remove the old properties,
in order to maintain bisectability. The old properties will be removed
once the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu
---
arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
arch/arm/boot/dts/tegra20.dtsi | 32 +--
8 files changed, 57 insertions(+), 31 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
index cb73e62..af5a7ae 100644
--- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
@@ -443,6 +443,10 @@
nvidia,phy-reset-gpio = < 169 0>; /* gpio PV1 */
};
+ usb-phy@c5004000 {
This node doesn't have a *reg* property. So "@c5004000" is not needed.
This comment applies to all the nodes which doesn't have *reg* property.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
Hi,
On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
This patch updates all Tegra board files so that they contain all the
properties required by the updated USB DT binding. Note that this patch
only adds the new properties and does not yet remove the old properties,
in order to maintain bisectability. The old properties will be removed
once the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
arch/arm/boot/dts/tegra20.dtsi | 32 +--
8 files changed, 57 insertions(+), 31 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
index cb73e62..af5a7ae 100644
--- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
@@ -443,6 +443,10 @@
nvidia,phy-reset-gpio = gpio 169 0; /* gpio PV1 */
};
+ usb-phy@c5004000 {
This node doesn't have a *reg* property. So @c5004000 is not needed.
This comment applies to all the nodes which doesn't have *reg* property.
Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
-Original Message-
From: kishon [mailto:kis...@ti.com]
Sent: Wednesday, March 20, 2013 4:53 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
disc...@lists.ozlabs.org
Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
rework
Hi,
On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
This patch updates all Tegra board files so that they contain all the
properties required by the updated USB DT binding. Note that this patch
only adds the new properties and does not yet remove the old properties,
in order to maintain bisectability. The old properties will be removed
once the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
arch/arm/boot/dts/tegra20.dtsi | 32
+--
8 files changed, 57 insertions(+), 31 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
index cb73e62..af5a7ae 100644
--- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
@@ -443,6 +443,10 @@
nvidia,phy-reset-gpio = gpio 169 0; /* gpio PV1 */
};
+ usb-phy@c5004000 {
This node doesn't have a *reg* property. So @c5004000 is not needed.
This comment applies to all the nodes which doesn't have *reg* property.
Thanks Kishon for the comments.
As I've 3 usb-phy DT nodes, how to differentiate between them if I remove this
@Address ?
Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
-Original Message- From: Stephen Warren [mailto:swar...@wwwdotorg.org] Sent: Wednesday, March 20, 2013 1:24 AM To: Venu Byravarasu Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-te...@vger.kernel.org; devicetree-disc...@lists.ozlabs.org Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework On 03/18/2013 06:29 AM, Venu Byravarasu wrote: This patch updates all Tegra board files so that they contain all the properties required by the updated USB DT binding. Note that this patch only adds the new properties and does not yet remove the old properties, in order to maintain bisectability. The old properties will be removed once the driver has been updated to assume the new bindings. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++ arch/arm/boot/dts/tegra20-harmony.dts |8 +++--- arch/arm/boot/dts/tegra20-iris-512.dts |4 +++ arch/arm/boot/dts/tegra20-paz00.dts|8 +++--- arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++--- arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++--- arch/arm/boot/dts/tegra20-ventana.dts |7 +++-- arch/arm/boot/dts/tegra20.dtsi | 32 +-- 8 files changed, 57 insertions(+), 31 deletions(-) I think you forgot to update arch/arm/boot/dts/tegra20-whistler.dts in this patch. Thanks Stephen, will add that send updated patch for review. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On Wed, Mar 20, 2013 at 05:47:46PM +0530, Venu Byravarasu wrote:
-Original Message-
From: kishon [mailto:kis...@ti.com]
Sent: Wednesday, March 20, 2013 4:53 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
disc...@lists.ozlabs.org
Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
rework
Hi,
On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
This patch updates all Tegra board files so that they contain all the
properties required by the updated USB DT binding. Note that this patch
only adds the new properties and does not yet remove the old properties,
in order to maintain bisectability. The old properties will be removed
once the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
arch/arm/boot/dts/tegra20.dtsi | 32
+--
8 files changed, 57 insertions(+), 31 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
index cb73e62..af5a7ae 100644
--- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
@@ -443,6 +443,10 @@
nvidia,phy-reset-gpio = gpio 169 0; /* gpio PV1 */
};
+ usb-phy@c5004000 {
This node doesn't have a *reg* property. So @c5004000 is not needed.
This comment applies to all the nodes which doesn't have *reg* property.
Thanks Kishon for the comments.
As I've 3 usb-phy DT nodes, how to differentiate between them if I remove
this @Address ?
then add reg property :-)
--
balbi
signature.asc
Description: Digital signature
RE: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Wednesday, March 20, 2013 5:55 PM
To: Venu Byravarasu
Cc: kishon; gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
disc...@lists.ozlabs.org
Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
rework
* PGP Signed by an unknown key
On Wed, Mar 20, 2013 at 05:47:46PM +0530, Venu Byravarasu wrote:
-Original Message-
From: kishon [mailto:kis...@ti.com]
Sent: Wednesday, March 20, 2013 4:53 PM
To: Venu Byravarasu
Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu;
ba...@ti.com; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org;
swar...@wwwdotorg.org; linux-te...@vger.kernel.org; devicetree-
disc...@lists.ozlabs.org
Subject: Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding
rework
Hi,
+ usb-phy@c5004000 {
This node doesn't have a *reg* property. So @c5004000 is not needed.
This comment applies to all the nodes which doesn't have *reg* property.
Thanks Kishon for the comments.
As I've 3 usb-phy DT nodes, how to differentiate between them if I remove
this @Address ?
then add reg property :-)
Thanks Felipe, for confirming.
--
balbi
* Unknown Key
* 0x35CAA444
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On 03/20/2013 05:23 AM, kishon wrote:
Hi,
On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
This patch updates all Tegra board files so that they contain all the
properties required by the updated USB DT binding. Note that this patch
only adds the new properties and does not yet remove the old properties,
in order to maintain bisectability. The old properties will be removed
once the driver has been updated to assume the new bindings.
Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com
---
arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++
arch/arm/boot/dts/tegra20-harmony.dts |8 +++---
arch/arm/boot/dts/tegra20-iris-512.dts |4 +++
arch/arm/boot/dts/tegra20-paz00.dts|8 +++---
arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++---
arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++---
arch/arm/boot/dts/tegra20-ventana.dts |7 +++--
arch/arm/boot/dts/tegra20.dtsi | 32
+--
8 files changed, 57 insertions(+), 31 deletions(-)
diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
index cb73e62..af5a7ae 100644
--- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
@@ -443,6 +443,10 @@
nvidia,phy-reset-gpio = gpio 169 0; /* gpio PV1 */
};
+usb-phy@c5004000 {
This node doesn't have a *reg* property. So @c5004000 is not needed.
This comment applies to all the nodes which doesn't have *reg* property.
Yes it does have a reg property.
The node itself is first defined in tegra20.dtsi, and does contain a reg
property there.
tegra20-colibri-512.dtsi (and many other files in this patch) include
tegra20.dtsi, and simply add additional board-specific properties to the
existing node, and should not re-iterate properties that already exist.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > This patch updates all Tegra board files so that they contain all the > properties required by the updated USB DT binding. Note that this patch > only adds the new properties and does not yet remove the old properties, > in order to maintain bisectability. The old properties will be removed > once the driver has been updated to assume the new bindings. > > Signed-off-by: Venu Byravarasu > --- > arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++ > arch/arm/boot/dts/tegra20-harmony.dts |8 +++--- > arch/arm/boot/dts/tegra20-iris-512.dts |4 +++ > arch/arm/boot/dts/tegra20-paz00.dts|8 +++--- > arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++--- > arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++--- > arch/arm/boot/dts/tegra20-ventana.dts |7 +++-- > arch/arm/boot/dts/tegra20.dtsi | 32 +-- > 8 files changed, 57 insertions(+), 31 deletions(-) I think you forgot to update arch/arm/boot/dts/tegra20-whistler.dts in this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: This patch updates all Tegra board files so that they contain all the properties required by the updated USB DT binding. Note that this patch only adds the new properties and does not yet remove the old properties, in order to maintain bisectability. The old properties will be removed once the driver has been updated to assume the new bindings. Signed-off-by: Venu Byravarasu vbyravar...@nvidia.com --- arch/arm/boot/dts/tegra20-colibri-512.dtsi |4 +++ arch/arm/boot/dts/tegra20-harmony.dts |8 +++--- arch/arm/boot/dts/tegra20-iris-512.dts |4 +++ arch/arm/boot/dts/tegra20-paz00.dts|8 +++--- arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++--- arch/arm/boot/dts/tegra20-trimslice.dts| 12 +++--- arch/arm/boot/dts/tegra20-ventana.dts |7 +++-- arch/arm/boot/dts/tegra20.dtsi | 32 +-- 8 files changed, 57 insertions(+), 31 deletions(-) I think you forgot to update arch/arm/boot/dts/tegra20-whistler.dts in this patch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
