Re: [PATCH 2/7] Function to retrieve main clock state

2020-10-01 Thread Thomas Gleixner 
On Fri, Oct 02 2020 at 00:05, Thomas Gleixner wrote:
> On Thu, Oct 01 2020 at 22:51, Erez Geva wrote:
>
> same comments as for patch 1 apply.
>
>> Add kernel function to retrieve main clock oscillator state.
>
> The function you are adding is named adjtimex(). adjtimex(2) is a well
> known user space interface and naming a read only kernel interface the
> same way is misleading.

Aside of that there is no user for this function in this series. We're
not adding interfaces just because we can.

Thanks,

tglx

Re: [PATCH 2/7] Function to retrieve main clock state

2020-10-01 Thread Thomas Gleixner 
Erez,

On Thu, Oct 01 2020 at 22:51, Erez Geva wrote:

same comments as for patch 1 apply.

> Add kernel function to retrieve main clock oscillator state.

The function you are adding is named adjtimex(). adjtimex(2) is a well
known user space interface and naming a read only kernel interface the
same way is misleading.

Thanks,

tglx