Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS
Den man. 13. jul. 2020 kl. 09.26 skrev Joe Perches :
>
> On Mon, 2020-07-13 at 15:13 +0800, Shawn Guo wrote:
> > On Sun, Jul 12, 2020 at 10:22:50PM -0700, Joe Perches wrote:
> []
> > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> []
> > > @@ -436,7 +436,7 @@ sub maintainers_in_file {
> > >
> > > return if ($file =~ m@\bMAINTAINERS$@);
> > >
> > > -if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> > > +if (-f $file && ($email_file_emails || $file =~
> > > /\.(?:yaml|dtsi?)$/)) {
> >
> > It should cover .dts file too?
>
> It does as dtsi? means the i is optional.
It sounds like a good idea for handling dts reviewers.
Maybe we could also update script/checkpatch.pl to ignore
new dts/dtsi files and not suggest updating MAINTAINERS
file.
/Bruno
Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS
On Mon, 2020-07-13 at 15:13 +0800, Shawn Guo wrote:
> On Sun, Jul 12, 2020 at 10:22:50PM -0700, Joe Perches wrote:
[]
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> > @@ -436,7 +436,7 @@ sub maintainers_in_file {
> >
> > return if ($file =~ m@\bMAINTAINERS$@);
> >
> > -if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> > +if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
>
> It should cover .dts file too?
It does as dtsi? means the i is optional.
Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS
On Sun, Jul 12, 2020 at 10:22:50PM -0700, Joe Perches wrote:
> Right now, a little less than half of the .dts* files
> have an author or other email address in them.
>
> $ git ls-files arch/arm/boot/dts/*.dts* | wc -l
> 2105
>
> $ git grep -P --name-only '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l
> 997
>
> Some have multiple email addresses:
>
> $ git grep -P '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l
> 1240
>
> (and there are a few false positives in that regex)
>
> I suppose that get_maintainer could handle .dts* files
> the same way .yaml files are handled so any email address
> in the file is added to patches that touch the file.
>
> This is the commit that added the .yaml file handling:
>
> commit 0c78c013762142bfe8fce34e7e968f83f0a4b891
> Author: Joe Perches
> Date: Thu Jun 4 16:50:01 2020 -0700
>
> get_maintainer: add email addresses from .yaml files
>
> .yaml files can contain maintainer/author addresses and it seems unlikely
> or unnecessary that individual MAINTAINER file section entries for each
> .yaml file will be created.
>
> So add the email addresses found in .yaml files to the default
> get_maintainer output.
>
> The email addresses are marked with "(in file)" when using the "--roles"
> or "--rolestats" options.
>
> So something like:
Yeah, that's helpful.
> ---
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 484d2fbf5921..4c3c69d7bed0 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -436,7 +436,7 @@ sub maintainers_in_file {
>
> return if ($file =~ m@\bMAINTAINERS$@);
>
> -if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> +if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
It should cover .dts file too?
Shawn
> open(my $f, '<', $file)
> or die "$P: Can't open $file: $!\n";
> my $text = do { local($/) ; <$f> };
>
>
Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS
On Mon, 2020-07-13 at 10:56 +0800, Shawn Guo wrote:
> On Mon, Jun 29, 2020 at 01:49:27PM +0200, Bruno Thomsen wrote:
> > Add myself as reviewer of device trees for Kamstrup
> > Concentrators.
> >
> > Signed-off-by: Bruno Thomsen
> > ---
> > MAINTAINERS | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 496fd4eafb68..97fc112309af 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9282,6 +9282,11 @@ S: Maintained
> > F: Documentation/hwmon/k8temp.rst
> > F: drivers/hwmon/k8temp.c
> >
> > +KAMSTRUP CONCENTRATORS
> > +R: Bruno Thomsen
> > +S: Maintained
> > +F: arch/arm/boot/dts/imx7d-flex-concentrator*.dts
> > +
>
> I guess get_maintainer.pl should list you for patches touching the
> files, so it's not really required? I'm worried about that MAINTAINERS
> file will get bloated quickly if we patch it for every single DTS
> file.
Right now, a little less than half of the .dts* files
have an author or other email address in them.
$ git ls-files arch/arm/boot/dts/*.dts* | wc -l
2105
$ git grep -P --name-only '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l
997
Some have multiple email addresses:
$ git grep -P '<\S+@\S+>' arch/arm/boot/dts/*.dts* | wc -l
1240
(and there are a few false positives in that regex)
I suppose that get_maintainer could handle .dts* files
the same way .yaml files are handled so any email address
in the file is added to patches that touch the file.
This is the commit that added the .yaml file handling:
commit 0c78c013762142bfe8fce34e7e968f83f0a4b891
Author: Joe Perches
Date: Thu Jun 4 16:50:01 2020 -0700
get_maintainer: add email addresses from .yaml files
.yaml files can contain maintainer/author addresses and it seems unlikely
or unnecessary that individual MAINTAINER file section entries for each
.yaml file will be created.
So add the email addresses found in .yaml files to the default
get_maintainer output.
The email addresses are marked with "(in file)" when using the "--roles"
or "--rolestats" options.
So something like:
---
scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 484d2fbf5921..4c3c69d7bed0 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -436,7 +436,7 @@ sub maintainers_in_file {
return if ($file =~ m@\bMAINTAINERS$@);
-if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
+if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
open(my $f, '<', $file)
or die "$P: Can't open $file: $!\n";
my $text = do { local($/) ; <$f> };
Re: [PATCH 3/3] MAINTAINERS: Add Bruno Thomsen as reviewer of Kamstrup DTS
On Mon, Jun 29, 2020 at 01:49:27PM +0200, Bruno Thomsen wrote: > Add myself as reviewer of device trees for Kamstrup > Concentrators. > > Signed-off-by: Bruno Thomsen > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 496fd4eafb68..97fc112309af 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9282,6 +9282,11 @@ S: Maintained > F: Documentation/hwmon/k8temp.rst > F: drivers/hwmon/k8temp.c > > +KAMSTRUP CONCENTRATORS > +R: Bruno Thomsen > +S: Maintained > +F: arch/arm/boot/dts/imx7d-flex-concentrator*.dts > + I guess get_maintainer.pl should list you for patches touching the files, so it's not really required? I'm worried about that MAINTAINERS file will get bloated quickly if we patch it for every single DTS file. Shawn > KASAN > M: Andrey Ryabinin > R: Alexander Potapenko > -- > 2.26.2 >
