Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl
Em Wed, Dec 23, 2020 at 08:54:59PM +0530, Naveen N. Rao escreveu: > Arnaldo Carvalho de Melo wrote: > > Em Fri, Dec 18, 2020 at 08:08:56PM +0530, Naveen N. Rao escreveu: > > > Hi Arnaldo, > > > > > > Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Dec 18, 2020 at 08:26:59AM -0300, Arnaldo Carvalho de Melo > > > > escreveu: > > > > > Em Fri, Dec 18, 2020 at 03:59:23PM +0800, Tiezhu Yang escreveu: > > > > > > This silences the following tools/perf/ build warning: > > > > > > Warning: Kernel ABI header at > > > > > > 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from > > > > > > latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl' > > > > > > > Hi Ravi, Naveen, > > > > > > > Can I get your Reviewed-by or Acked-by for this change and > > > the > > > > > other that adds s390's syscall.tbl to check_headers.sh so that we get > > > > > oops s/s390/powerpc/g :-) > > > > > > notified when the copy drifts, so that we can see if it still > > > continues > > > > > working and we can get new syscalls to be supported in things like > > > > > 'perf > > > > > trace'? > > > > > > Yes, this looks good to me: > > > Reviewed-by: Naveen N. Rao > > > > > > FWIW, I had posted a similar patch back in April, but glad to have this go > > > in ;) > > > http://lkml.kernel.org/r/20200220063740.785913-1-naveen.n@linux.vnet.ibm.com > > > > My bad :-\ > > No worries, thanks for checking on this one. Applied now, with your Reviewed-by, I had to refresh the update as there were more changes after Tiezhu's update. - Arnaldo
Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl
Arnaldo Carvalho de Melo wrote: Em Fri, Dec 18, 2020 at 08:08:56PM +0530, Naveen N. Rao escreveu: Hi Arnaldo, Arnaldo Carvalho de Melo wrote: > Em Fri, Dec 18, 2020 at 08:26:59AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Dec 18, 2020 at 03:59:23PM +0800, Tiezhu Yang escreveu: > > > This silences the following tools/perf/ build warning: > > > Warning: Kernel ABI header at 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl' > > > > Hi Ravi, Naveen, > > > > Can I get your Reviewed-by or Acked-by for this change and the > > other that adds s390's syscall.tbl to check_headers.sh so that we get > > oops s/s390/powerpc/g :-) > > > notified when the copy drifts, so that we can see if it still continues > > working and we can get new syscalls to be supported in things like 'perf > > trace'? Yes, this looks good to me: Reviewed-by: Naveen N. Rao FWIW, I had posted a similar patch back in April, but glad to have this go in ;) http://lkml.kernel.org/r/20200220063740.785913-1-naveen.n@linux.vnet.ibm.com My bad :-\ No worries, thanks for checking on this one. - Naveen
Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl
Em Fri, Dec 18, 2020 at 08:08:56PM +0530, Naveen N. Rao escreveu: > Hi Arnaldo, > > Arnaldo Carvalho de Melo wrote: > > Em Fri, Dec 18, 2020 at 08:26:59AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Dec 18, 2020 at 03:59:23PM +0800, Tiezhu Yang escreveu: > > > > This silences the following tools/perf/ build warning: > > > > Warning: Kernel ABI header at > > > > 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from > > > > latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl' > > > > > > Hi Ravi, Naveen, > > > > > > Can I get your Reviewed-by or Acked-by for this change and the > > > other that adds s390's syscall.tbl to check_headers.sh so that we get > > > > oops s/s390/powerpc/g :-) > > > > > notified when the copy drifts, so that we can see if it still continues > > > working and we can get new syscalls to be supported in things like 'perf > > > trace'? > > Yes, this looks good to me: > Reviewed-by: Naveen N. Rao > > FWIW, I had posted a similar patch back in April, but glad to have this go > in ;) > http://lkml.kernel.org/r/20200220063740.785913-1-naveen.n@linux.vnet.ibm.com My bad :-\ > > Thanks, > Naveen > -- - Arnaldo
Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl
Hi Arnaldo, Arnaldo Carvalho de Melo wrote: Em Fri, Dec 18, 2020 at 08:26:59AM -0300, Arnaldo Carvalho de Melo escreveu: Em Fri, Dec 18, 2020 at 03:59:23PM +0800, Tiezhu Yang escreveu: > This silences the following tools/perf/ build warning: > Warning: Kernel ABI header at 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl' Hi Ravi, Naveen, Can I get your Reviewed-by or Acked-by for this change and the other that adds s390's syscall.tbl to check_headers.sh so that we get oops s/s390/powerpc/g :-) notified when the copy drifts, so that we can see if it still continues working and we can get new syscalls to be supported in things like 'perf trace'? Yes, this looks good to me: Reviewed-by: Naveen N. Rao FWIW, I had posted a similar patch back in April, but glad to have this go in ;) http://lkml.kernel.org/r/20200220063740.785913-1-naveen.n@linux.vnet.ibm.com Thanks, Naveen
Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl
Em Fri, Dec 18, 2020 at 08:26:59AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Dec 18, 2020 at 03:59:23PM +0800, Tiezhu Yang escreveu: > > This silences the following tools/perf/ build warning: > > Warning: Kernel ABI header at > > 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest > > version at 'arch/powerpc/kernel/syscalls/syscall.tbl' > > Hi Ravi, Naveen, > > Can I get your Reviewed-by or Acked-by for this change and the > other that adds s390's syscall.tbl to check_headers.sh so that we get oops s/s390/powerpc/g :-) > notified when the copy drifts, so that we can see if it still continues > working and we can get new syscalls to be supported in things like 'perf > trace'? > > Thanks, > > - Arnaldo > > > Just make them same: > > cp arch/powerpc/kernel/syscalls/syscall.tbl > > tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > > > > Signed-off-by: Tiezhu Yang > > --- > > tools/perf/arch/powerpc/entry/syscalls/syscall.tbl | 25 > > -- > > 1 file changed, 18 insertions(+), 7 deletions(-) > > > > diff --git a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > > b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > > index b168364..1275dae 100644 > > --- a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > > +++ b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > > @@ -9,7 +9,9 @@ > > # > > 0 nospu restart_syscall sys_restart_syscall > > 1 nospu exitsys_exit > > -2 nospu forkppc_fork > > +2 32 forkppc_fork > > sys_fork > > +2 64 forksys_fork > > +2 spu forksys_ni_syscall > > 3 common readsys_read > > 4 common write sys_write > > 5 common opensys_open > > compat_sys_open > > @@ -158,7 +160,9 @@ > > 11932 sigreturn sys_sigreturn > > compat_sys_sigreturn > > 11964 sigreturn sys_ni_syscall > > 119spu sigreturn sys_ni_syscall > > -120nospu clone ppc_clone > > +12032 clone ppc_clone > > sys_clone > > +12064 clone sys_clone > > +120spu clone sys_ni_syscall > > 121common setdomainname sys_setdomainname > > 122common uname sys_newuname > > 123common modify_ldt sys_ni_syscall > > @@ -240,7 +244,9 @@ > > 186spu sendfilesys_sendfile64 > > 187common getpmsg sys_ni_syscall > > 188common putpmsg sys_ni_syscall > > -189nospu vfork ppc_vfork > > +18932 vfork ppc_vfork > > sys_vfork > > +18964 vfork sys_vfork > > +189spu vfork sys_ni_syscall > > 190common ugetrlimit sys_getrlimit > > compat_sys_getrlimit > > 191common readahead sys_readahead > > compat_sys_readahead > > 19232 mmap2 sys_mmap2 > > compat_sys_mmap2 > > @@ -316,8 +322,8 @@ > > 24832 clock_nanosleep > > sys_clock_nanosleep_time32 > > 24864 clock_nanosleep sys_clock_nanosleep > > 248spu clock_nanosleep sys_clock_nanosleep > > -24932 swapcontext ppc_swapcontext > > ppc32_swapcontext > > -24964 swapcontext ppc64_swapcontext > > +24932 swapcontext ppc_swapcontext > > compat_sys_swapcontext > > +24964 swapcontext sys_swapcontext > > 249spu swapcontext sys_ni_syscall > > 250common tgkill sys_tgkill > > 25132 utimes sys_utimes_time32 > > @@ -456,7 +462,7 @@ > > 361common bpf sys_bpf > > 362nospu execveatsys_execveat > > compat_sys_execveat > > 36332 switch_endian sys_ni_syscall > > -36364 switch_endian ppc_switch_endian > > +36364 switch_endian sys_switch_endian > > 363spu switch_endian
Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl
Em Fri, Dec 18, 2020 at 03:59:23PM +0800, Tiezhu Yang escreveu: > This silences the following tools/perf/ build warning: > Warning: Kernel ABI header at > 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest > version at 'arch/powerpc/kernel/syscalls/syscall.tbl' Hi Ravi, Naveen, Can I get your Reviewed-by or Acked-by for this change and the other that adds s390's syscall.tbl to check_headers.sh so that we get notified when the copy drifts, so that we can see if it still continues working and we can get new syscalls to be supported in things like 'perf trace'? Thanks, - Arnaldo > Just make them same: > cp arch/powerpc/kernel/syscalls/syscall.tbl > tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > > Signed-off-by: Tiezhu Yang > --- > tools/perf/arch/powerpc/entry/syscalls/syscall.tbl | 25 > -- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > index b168364..1275dae 100644 > --- a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > +++ b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl > @@ -9,7 +9,9 @@ > # > 0nospu restart_syscall sys_restart_syscall > 1nospu exitsys_exit > -2nospu forkppc_fork > +232 forkppc_fork > sys_fork > +264 forksys_fork > +2spu forksys_ni_syscall > 3common readsys_read > 4common write sys_write > 5common opensys_open > compat_sys_open > @@ -158,7 +160,9 @@ > 119 32 sigreturn sys_sigreturn > compat_sys_sigreturn > 119 64 sigreturn sys_ni_syscall > 119 spu sigreturn sys_ni_syscall > -120 nospu clone ppc_clone > +120 32 clone ppc_clone > sys_clone > +120 64 clone sys_clone > +120 spu clone sys_ni_syscall > 121 common setdomainname sys_setdomainname > 122 common uname sys_newuname > 123 common modify_ldt sys_ni_syscall > @@ -240,7 +244,9 @@ > 186 spu sendfilesys_sendfile64 > 187 common getpmsg sys_ni_syscall > 188 common putpmsg sys_ni_syscall > -189 nospu vfork ppc_vfork > +189 32 vfork ppc_vfork > sys_vfork > +189 64 vfork sys_vfork > +189 spu vfork sys_ni_syscall > 190 common ugetrlimit sys_getrlimit > compat_sys_getrlimit > 191 common readahead sys_readahead > compat_sys_readahead > 192 32 mmap2 sys_mmap2 > compat_sys_mmap2 > @@ -316,8 +322,8 @@ > 248 32 clock_nanosleep sys_clock_nanosleep_time32 > 248 64 clock_nanosleep sys_clock_nanosleep > 248 spu clock_nanosleep sys_clock_nanosleep > -249 32 swapcontext ppc_swapcontext > ppc32_swapcontext > -249 64 swapcontext ppc64_swapcontext > +249 32 swapcontext ppc_swapcontext > compat_sys_swapcontext > +249 64 swapcontext sys_swapcontext > 249 spu swapcontext sys_ni_syscall > 250 common tgkill sys_tgkill > 251 32 utimes sys_utimes_time32 > @@ -456,7 +462,7 @@ > 361 common bpf sys_bpf > 362 nospu execveatsys_execveat > compat_sys_execveat > 363 32 switch_endian sys_ni_syscall > -363 64 switch_endian ppc_switch_endian > +363 64 switch_endian sys_switch_endian > 363 spu switch_endian sys_ni_syscall > 364 common userfaultfd sys_userfaultfd > 365 common membarrier sys_membarrier > @@ -516,6 +522,11 @@ > 432 common fsmount sys_fsmount > 433 common fspick sys_fspick > 434 common pidfd_open sys_pidfd_open > -435 nospu clone3 ppc_clone3 > +435 32 clone3 ppc_clone3
