Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-04-07 Thread Lee Jones 
On Tue, 29 Mar 2016, Paul Kocialkowski wrote:

> Since the twl-core mfd driver is not limited to twl4030 support, but also
> supports other chips of the TWL family, it makes sense to rename its matching
> Kconfig opton to a non-model-specific name.

No, it doesn't.  The naming convention is; unless there was already
forethought to make the name generic, it should be kept as the first
supported device i.e. in this case TWL4030.

It's also helpful if you Cc *all* of the maintainers for subsystems
you are attempting to make changes in.

> Signed-off-by: Paul Kocialkowski 
> ---
>  arch/arm/mach-omap2/Kconfig | 2 +-
>  arch/arm/mach-omap2/Makefile| 2 +-
>  arch/arm/mach-omap2/pm.h| 2 +-
>  arch/arm/plat-omap/Kconfig  | 2 +-
>  drivers/gpio/Kconfig| 2 +-
>  drivers/iio/adc/Kconfig | 4 ++--
>  drivers/input/keyboard/Kconfig  | 2 +-
>  drivers/input/misc/Kconfig  | 4 ++--
>  drivers/mfd/Kconfig | 6 +++---
>  drivers/mfd/Makefile| 2 +-
>  drivers/mfd/twl4030-irq.c   | 6 +++---
>  drivers/phy/Kconfig | 2 +-
>  drivers/power/Kconfig   | 2 +-
>  drivers/pwm/Kconfig | 4 ++--
>  drivers/regulator/Kconfig   | 2 +-
>  drivers/rtc/Kconfig | 2 +-
>  drivers/usb/phy/Kconfig | 2 +-
>  drivers/video/backlight/Kconfig | 2 +-
>  drivers/watchdog/Kconfig| 2 +-
>  include/linux/i2c/twl.h | 4 ++--
>  sound/soc/codecs/Kconfig| 2 +-
>  sound/soc/omap/Kconfig  | 4 ++--
>  22 files changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 0517f0c..ada4c7a1 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -124,7 +124,7 @@ config ARCH_OMAP2PLUS_TYPICAL
>   select PM
>   select REGULATOR
>   select REGULATOR_FIXED_VOLTAGE
> - select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
> + select TWL_CORE if ARCH_OMAP3 || ARCH_OMAP4
>   select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
>   select VFP
>   help
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index 0ba6a0e..6eb680a 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -27,7 +27,7 @@ ifneq ($(CONFIG_SND_OMAP_SOC_MCBSP),)
>  obj-y += mcbsp.o
>  endif
>  
> -obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> +obj-$(CONFIG_TWL_CORE) += omap_twl.o
>  obj-$(CONFIG_SOC_HAS_OMAP2_SDRC) += sdrc.o
>  
>  # SMP support ONLY available for OMAP4
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index b668719..bf4dac2 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -123,7 +123,7 @@ static inline int omap_devinit_smartreflex(void)
>  static inline void omap_enable_smartreflex_on_init(void) {}
>  #endif
>  
> -#ifdef CONFIG_TWL4030_CORE
> +#ifdef CONFIG_TWL_CORE
>  extern int omap3_twl_init(void);
>  extern int omap4_twl_init(void);
>  extern int omap3_twl_set_sr_bit(bool enable);
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index d055db3..8631a45 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -44,7 +44,7 @@ config POWER_AVS_OMAP
>  
>  config POWER_AVS_OMAP_CLASS3
>   bool "Class 3 mode of Smartreflex Implementation"
> - depends on POWER_AVS_OMAP && TWL4030_CORE
> + depends on POWER_AVS_OMAP && TWL_CORE
>   help
> Say Y to enable Class 3 implementation of Smartreflex
>  
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5f3429f..62ca9b4 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -933,7 +933,7 @@ config GPIO_TPS65912
>  
>  config GPIO_TWL4030
>   tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> Say yes here to access the GPIO signals of various multi-function
> power management chips from Texas Instruments.
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7..3360492 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -440,7 +440,7 @@ config TI_AM335X_ADC
>  
>  config TWL4030_MADC
>   tristate "TWL4030 MADC (Monitoring A/D Converter)"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> This driver provides support for Triton TWL4030-MADC. The
> driver supports both RT and SW conversion methods.
> @@ -450,7 +450,7 @@ config TWL4030_MADC
>  
>  config TWL6030_GPADC
>   tristate "TWL6030 GPADC (General Purpose A/D Converter) Support"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   default n
>   help
> Say yes here if you want support for the TWL6030/TWL6032 General
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 509608c..9cfa09b 100644
> --- a/drivers/input/keyboard/Kconfig
> +++

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-04-07 Thread Lee Jones 
On Tue, 29 Mar 2016, Paul Kocialkowski wrote:

> Since the twl-core mfd driver is not limited to twl4030 support, but also
> supports other chips of the TWL family, it makes sense to rename its matching
> Kconfig opton to a non-model-specific name.

No, it doesn't.  The naming convention is; unless there was already
forethought to make the name generic, it should be kept as the first
supported device i.e. in this case TWL4030.

It's also helpful if you Cc *all* of the maintainers for subsystems
you are attempting to make changes in.

> Signed-off-by: Paul Kocialkowski 
> ---
>  arch/arm/mach-omap2/Kconfig | 2 +-
>  arch/arm/mach-omap2/Makefile| 2 +-
>  arch/arm/mach-omap2/pm.h| 2 +-
>  arch/arm/plat-omap/Kconfig  | 2 +-
>  drivers/gpio/Kconfig| 2 +-
>  drivers/iio/adc/Kconfig | 4 ++--
>  drivers/input/keyboard/Kconfig  | 2 +-
>  drivers/input/misc/Kconfig  | 4 ++--
>  drivers/mfd/Kconfig | 6 +++---
>  drivers/mfd/Makefile| 2 +-
>  drivers/mfd/twl4030-irq.c   | 6 +++---
>  drivers/phy/Kconfig | 2 +-
>  drivers/power/Kconfig   | 2 +-
>  drivers/pwm/Kconfig | 4 ++--
>  drivers/regulator/Kconfig   | 2 +-
>  drivers/rtc/Kconfig | 2 +-
>  drivers/usb/phy/Kconfig | 2 +-
>  drivers/video/backlight/Kconfig | 2 +-
>  drivers/watchdog/Kconfig| 2 +-
>  include/linux/i2c/twl.h | 4 ++--
>  sound/soc/codecs/Kconfig| 2 +-
>  sound/soc/omap/Kconfig  | 4 ++--
>  22 files changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 0517f0c..ada4c7a1 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -124,7 +124,7 @@ config ARCH_OMAP2PLUS_TYPICAL
>   select PM
>   select REGULATOR
>   select REGULATOR_FIXED_VOLTAGE
> - select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
> + select TWL_CORE if ARCH_OMAP3 || ARCH_OMAP4
>   select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
>   select VFP
>   help
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index 0ba6a0e..6eb680a 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -27,7 +27,7 @@ ifneq ($(CONFIG_SND_OMAP_SOC_MCBSP),)
>  obj-y += mcbsp.o
>  endif
>  
> -obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> +obj-$(CONFIG_TWL_CORE) += omap_twl.o
>  obj-$(CONFIG_SOC_HAS_OMAP2_SDRC) += sdrc.o
>  
>  # SMP support ONLY available for OMAP4
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index b668719..bf4dac2 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -123,7 +123,7 @@ static inline int omap_devinit_smartreflex(void)
>  static inline void omap_enable_smartreflex_on_init(void) {}
>  #endif
>  
> -#ifdef CONFIG_TWL4030_CORE
> +#ifdef CONFIG_TWL_CORE
>  extern int omap3_twl_init(void);
>  extern int omap4_twl_init(void);
>  extern int omap3_twl_set_sr_bit(bool enable);
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index d055db3..8631a45 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -44,7 +44,7 @@ config POWER_AVS_OMAP
>  
>  config POWER_AVS_OMAP_CLASS3
>   bool "Class 3 mode of Smartreflex Implementation"
> - depends on POWER_AVS_OMAP && TWL4030_CORE
> + depends on POWER_AVS_OMAP && TWL_CORE
>   help
> Say Y to enable Class 3 implementation of Smartreflex
>  
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5f3429f..62ca9b4 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -933,7 +933,7 @@ config GPIO_TPS65912
>  
>  config GPIO_TWL4030
>   tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> Say yes here to access the GPIO signals of various multi-function
> power management chips from Texas Instruments.
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7..3360492 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -440,7 +440,7 @@ config TI_AM335X_ADC
>  
>  config TWL4030_MADC
>   tristate "TWL4030 MADC (Monitoring A/D Converter)"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> This driver provides support for Triton TWL4030-MADC. The
> driver supports both RT and SW conversion methods.
> @@ -450,7 +450,7 @@ config TWL4030_MADC
>  
>  config TWL6030_GPADC
>   tristate "TWL6030 GPADC (General Purpose A/D Converter) Support"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   default n
>   help
> Say yes here if you want support for the TWL6030/TWL6032 General
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 509608c..9cfa09b 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-04-05 Thread Grygorii Strashko 
On 04/02/2016 11:12 PM, Paul Kocialkowski wrote:
> Le mercredi 30 mars 2016 à 18:34 +0300, Grygorii Strashko a écrit :
>> On 03/29/2016 10:22 PM, Paul Kocialkowski wrote:
>>>
>>> Since the twl-core mfd driver is not limited to twl4030 support, but also
>>> supports other chips of the TWL family, it makes sense to rename its
>>> matching
>>> Kconfig opton to a non-model-specific name.
>>
>> Personally I don't see too much reason for this, but it's up to maintainers 
>> to
>> decide.
> 
> I'm a strong advocate of consistency in naming and using twl4030 prefixes for
> drivers that are common to more twl chips looks very inconsistent to me.
> Besides, some common twl drivers are already using the twl prefix, so this can
> also be seen as harmonisation.

Yah. May be.

But I see the problem with your series - small amount of functional changes
is hidden in the fog of huge amount of renaming/beautification ;)

But, again, this is my personal opinion - final decision is up to maintainers

+ cc: Lee Jones

> 
>> Regarding this patch - pls, do not mix Kconfig and code changes.
> 
> Do you mean that for code changes that are directly affected by Kconfig 
> changes
> (e.g. #ifdef CONFIG_)? Is the policy that "each commit must produce a working
> result" or is it okay to break drivers in between commits of the same series?

I mean this:
  */
-#define TWL4030_CORE_NR_IRQS   8
+#define TWL_CORE_NR_IRQS   8
 #define TWL4030_PWR_NR_IRQS8
 
 /* PIH register offsets */
@@ -693,7 +693,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 * the hwirqs numbers are defined contiguously from 1 to 15.
 * Create only one domain for both.
 */
-   nr_irqs = TWL4030_PWR_NR_IRQS + TWL4030_CORE_NR_IRQS;
+   nr_irqs = TWL4030_PWR_NR_IRQS + TWL_CORE_NR_IRQS;
 
irq_base = irq_alloc_descs(-1, 0, nr_irqs, 0);
if (IS_ERR_VALUE(irq_base)) {
@@ -704,7 +704,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
irq_domain_add_legacy(node, nr_irqs, irq_base, 0,
  _domain_simple_ops, NULL);
 
-   irq_end = irq_base + TWL4030_CORE_NR_IRQS;
+   irq_end = irq_base + TWL_CORE_NR_IRQS;

> 
>> And it will be good to have cover letter.
> 
> Noted, I'll come up with something for v2.
> 
>>> Signed-off-by: Paul Kocialkowski 
>>> ---
>>>arch/arm/mach-omap2/Kconfig | 2 +-
>>>arch/arm/mach-omap2/Makefile| 2 +-
>>>arch/arm/mach-omap2/pm.h| 2 +-
>>>arch/arm/plat-omap/Kconfig  | 2 +-

[..]


-- 
regards,
-grygorii

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-04-05 Thread Grygorii Strashko 
On 04/02/2016 11:12 PM, Paul Kocialkowski wrote:
> Le mercredi 30 mars 2016 à 18:34 +0300, Grygorii Strashko a écrit :
>> On 03/29/2016 10:22 PM, Paul Kocialkowski wrote:
>>>
>>> Since the twl-core mfd driver is not limited to twl4030 support, but also
>>> supports other chips of the TWL family, it makes sense to rename its
>>> matching
>>> Kconfig opton to a non-model-specific name.
>>
>> Personally I don't see too much reason for this, but it's up to maintainers 
>> to
>> decide.
> 
> I'm a strong advocate of consistency in naming and using twl4030 prefixes for
> drivers that are common to more twl chips looks very inconsistent to me.
> Besides, some common twl drivers are already using the twl prefix, so this can
> also be seen as harmonisation.

Yah. May be.

But I see the problem with your series - small amount of functional changes
is hidden in the fog of huge amount of renaming/beautification ;)

But, again, this is my personal opinion - final decision is up to maintainers

+ cc: Lee Jones

> 
>> Regarding this patch - pls, do not mix Kconfig and code changes.
> 
> Do you mean that for code changes that are directly affected by Kconfig 
> changes
> (e.g. #ifdef CONFIG_)? Is the policy that "each commit must produce a working
> result" or is it okay to break drivers in between commits of the same series?

I mean this:
  */
-#define TWL4030_CORE_NR_IRQS   8
+#define TWL_CORE_NR_IRQS   8
 #define TWL4030_PWR_NR_IRQS8
 
 /* PIH register offsets */
@@ -693,7 +693,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 * the hwirqs numbers are defined contiguously from 1 to 15.
 * Create only one domain for both.
 */
-   nr_irqs = TWL4030_PWR_NR_IRQS + TWL4030_CORE_NR_IRQS;
+   nr_irqs = TWL4030_PWR_NR_IRQS + TWL_CORE_NR_IRQS;
 
irq_base = irq_alloc_descs(-1, 0, nr_irqs, 0);
if (IS_ERR_VALUE(irq_base)) {
@@ -704,7 +704,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
irq_domain_add_legacy(node, nr_irqs, irq_base, 0,
  _domain_simple_ops, NULL);
 
-   irq_end = irq_base + TWL4030_CORE_NR_IRQS;
+   irq_end = irq_base + TWL_CORE_NR_IRQS;

> 
>> And it will be good to have cover letter.
> 
> Noted, I'll come up with something for v2.
> 
>>> Signed-off-by: Paul Kocialkowski 
>>> ---
>>>arch/arm/mach-omap2/Kconfig | 2 +-
>>>arch/arm/mach-omap2/Makefile| 2 +-
>>>arch/arm/mach-omap2/pm.h| 2 +-
>>>arch/arm/plat-omap/Kconfig  | 2 +-

[..]


-- 
regards,
-grygorii

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-04-02 Thread Paul Kocialkowski 
Le mercredi 30 mars 2016 à 18:34 +0300, Grygorii Strashko a écrit :
> On 03/29/2016 10:22 PM, Paul Kocialkowski wrote:
> > 
> > Since the twl-core mfd driver is not limited to twl4030 support, but also
> > supports other chips of the TWL family, it makes sense to rename its
> > matching
> > Kconfig opton to a non-model-specific name.
>
> Personally I don't see too much reason for this, but it's up to maintainers to
> decide.

I'm a strong advocate of consistency in naming and using twl4030 prefixes for
drivers that are common to more twl chips looks very inconsistent to me.
Besides, some common twl drivers are already using the twl prefix, so this can
also be seen as harmonisation.

> Regarding this patch - pls, do not mix Kconfig and code changes.

Do you mean that for code changes that are directly affected by Kconfig changes
(e.g. #ifdef CONFIG_)? Is the policy that "each commit must produce a working
result" or is it okay to break drivers in between commits of the same series?

> And it will be good to have cover letter.

Noted, I'll come up with something for v2.

> > Signed-off-by: Paul Kocialkowski 
> > ---
> >   arch/arm/mach-omap2/Kconfig | 2 +-
> >   arch/arm/mach-omap2/Makefile| 2 +-
> >   arch/arm/mach-omap2/pm.h| 2 +-
> >   arch/arm/plat-omap/Kconfig  | 2 +-
> >   drivers/gpio/Kconfig| 2 +-
> >   drivers/iio/adc/Kconfig | 4 ++--
> >   drivers/input/keyboard/Kconfig  | 2 +-
> >   drivers/input/misc/Kconfig  | 4 ++--
> >   drivers/mfd/Kconfig | 6 +++---
> >   drivers/mfd/Makefile| 2 +-
> >   drivers/mfd/twl4030-irq.c   | 6 +++---
> >   drivers/phy/Kconfig | 2 +-
> >   drivers/power/Kconfig   | 2 +-
> >   drivers/pwm/Kconfig | 4 ++--
> >   drivers/regulator/Kconfig   | 2 +-
> >   drivers/rtc/Kconfig | 2 +-
> >   drivers/usb/phy/Kconfig | 2 +-
> >   drivers/video/backlight/Kconfig | 2 +-
> >   drivers/watchdog/Kconfig| 2 +-
> >   include/linux/i2c/twl.h | 4 ++--
> >   sound/soc/codecs/Kconfig| 2 +-
> >   sound/soc/omap/Kconfig  | 4 ++--
> >   22 files changed, 31 insertions(+), 31 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> > index 0517f0c..ada4c7a1 100644
> > --- a/arch/arm/mach-omap2/Kconfig
> > +++ b/arch/arm/mach-omap2/Kconfig
> > @@ -124,7 +124,7 @@ config ARCH_OMAP2PLUS_TYPICAL
> >     select PM
> >     select REGULATOR
> >     select REGULATOR_FIXED_VOLTAGE
> > -   select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
> > +   select TWL_CORE if ARCH_OMAP3 || ARCH_OMAP4
> >     select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
> >     select VFP
> >     help
> > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> > index 0ba6a0e..6eb680a 100644
> > --- a/arch/arm/mach-omap2/Makefile
> > +++ b/arch/arm/mach-omap2/Makefile
> > @@ -27,7 +27,7 @@ ifneq ($(CONFIG_SND_OMAP_SOC_MCBSP),)
> >   obj-y += mcbsp.o
> >   endif
> >   
> > -obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> > +obj-$(CONFIG_TWL_CORE) += omap_twl.o
> >   obj-$(CONFIG_SOC_HAS_OMAP2_SDRC)  += sdrc.o
> >   
> >   # SMP support ONLY available for OMAP4
> > diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> > index b668719..bf4dac2 100644
> > --- a/arch/arm/mach-omap2/pm.h
> > +++ b/arch/arm/mach-omap2/pm.h
> > @@ -123,7 +123,7 @@ static inline int omap_devinit_smartreflex(void)
> >   static inline void omap_enable_smartreflex_on_init(void) {}
> >   #endif
> >   
> > -#ifdef CONFIG_TWL4030_CORE
> > +#ifdef CONFIG_TWL_CORE
> >   extern int omap3_twl_init(void);
> >   extern int omap4_twl_init(void);
> >   extern int omap3_twl_set_sr_bit(bool enable);
> > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> > index d055db3..8631a45 100644
> > --- a/arch/arm/plat-omap/Kconfig
> > +++ b/arch/arm/plat-omap/Kconfig
> > @@ -44,7 +44,7 @@ config POWER_AVS_OMAP
> >   
> >   config POWER_AVS_OMAP_CLASS3
> >     bool "Class 3 mode of Smartreflex Implementation"
> > -   depends on POWER_AVS_OMAP && TWL4030_CORE
> > +   depends on POWER_AVS_OMAP && TWL_CORE
> >     help
> >       Say Y to enable Class 3 implementation of Smartreflex
> >   
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index 5f3429f..62ca9b4 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -933,7 +933,7 @@ config GPIO_TPS65912
> >   
> >   config GPIO_TWL4030
> >     tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
> > -   depends on TWL4030_CORE
> > +   depends on TWL_CORE
> >     help
> >       Say yes here to access the GPIO signals of various multi-
> > function
> >       power management chips from Texas Instruments.
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index af4aea7..3360492 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -440,7 +440,7 @@ config TI_AM335X_ADC
> >   
> >   config TWL4030_MADC
>

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-04-02 Thread Paul Kocialkowski 
Le mercredi 30 mars 2016 à 18:34 +0300, Grygorii Strashko a écrit :
> On 03/29/2016 10:22 PM, Paul Kocialkowski wrote:
> > 
> > Since the twl-core mfd driver is not limited to twl4030 support, but also
> > supports other chips of the TWL family, it makes sense to rename its
> > matching
> > Kconfig opton to a non-model-specific name.
>
> Personally I don't see too much reason for this, but it's up to maintainers to
> decide.

I'm a strong advocate of consistency in naming and using twl4030 prefixes for
drivers that are common to more twl chips looks very inconsistent to me.
Besides, some common twl drivers are already using the twl prefix, so this can
also be seen as harmonisation.

> Regarding this patch - pls, do not mix Kconfig and code changes.

Do you mean that for code changes that are directly affected by Kconfig changes
(e.g. #ifdef CONFIG_)? Is the policy that "each commit must produce a working
result" or is it okay to break drivers in between commits of the same series?

> And it will be good to have cover letter.

Noted, I'll come up with something for v2.

> > Signed-off-by: Paul Kocialkowski 
> > ---
> >   arch/arm/mach-omap2/Kconfig | 2 +-
> >   arch/arm/mach-omap2/Makefile| 2 +-
> >   arch/arm/mach-omap2/pm.h| 2 +-
> >   arch/arm/plat-omap/Kconfig  | 2 +-
> >   drivers/gpio/Kconfig| 2 +-
> >   drivers/iio/adc/Kconfig | 4 ++--
> >   drivers/input/keyboard/Kconfig  | 2 +-
> >   drivers/input/misc/Kconfig  | 4 ++--
> >   drivers/mfd/Kconfig | 6 +++---
> >   drivers/mfd/Makefile| 2 +-
> >   drivers/mfd/twl4030-irq.c   | 6 +++---
> >   drivers/phy/Kconfig | 2 +-
> >   drivers/power/Kconfig   | 2 +-
> >   drivers/pwm/Kconfig | 4 ++--
> >   drivers/regulator/Kconfig   | 2 +-
> >   drivers/rtc/Kconfig | 2 +-
> >   drivers/usb/phy/Kconfig | 2 +-
> >   drivers/video/backlight/Kconfig | 2 +-
> >   drivers/watchdog/Kconfig| 2 +-
> >   include/linux/i2c/twl.h | 4 ++--
> >   sound/soc/codecs/Kconfig| 2 +-
> >   sound/soc/omap/Kconfig  | 4 ++--
> >   22 files changed, 31 insertions(+), 31 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> > index 0517f0c..ada4c7a1 100644
> > --- a/arch/arm/mach-omap2/Kconfig
> > +++ b/arch/arm/mach-omap2/Kconfig
> > @@ -124,7 +124,7 @@ config ARCH_OMAP2PLUS_TYPICAL
> >     select PM
> >     select REGULATOR
> >     select REGULATOR_FIXED_VOLTAGE
> > -   select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
> > +   select TWL_CORE if ARCH_OMAP3 || ARCH_OMAP4
> >     select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
> >     select VFP
> >     help
> > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> > index 0ba6a0e..6eb680a 100644
> > --- a/arch/arm/mach-omap2/Makefile
> > +++ b/arch/arm/mach-omap2/Makefile
> > @@ -27,7 +27,7 @@ ifneq ($(CONFIG_SND_OMAP_SOC_MCBSP),)
> >   obj-y += mcbsp.o
> >   endif
> >   
> > -obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> > +obj-$(CONFIG_TWL_CORE) += omap_twl.o
> >   obj-$(CONFIG_SOC_HAS_OMAP2_SDRC)  += sdrc.o
> >   
> >   # SMP support ONLY available for OMAP4
> > diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> > index b668719..bf4dac2 100644
> > --- a/arch/arm/mach-omap2/pm.h
> > +++ b/arch/arm/mach-omap2/pm.h
> > @@ -123,7 +123,7 @@ static inline int omap_devinit_smartreflex(void)
> >   static inline void omap_enable_smartreflex_on_init(void) {}
> >   #endif
> >   
> > -#ifdef CONFIG_TWL4030_CORE
> > +#ifdef CONFIG_TWL_CORE
> >   extern int omap3_twl_init(void);
> >   extern int omap4_twl_init(void);
> >   extern int omap3_twl_set_sr_bit(bool enable);
> > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> > index d055db3..8631a45 100644
> > --- a/arch/arm/plat-omap/Kconfig
> > +++ b/arch/arm/plat-omap/Kconfig
> > @@ -44,7 +44,7 @@ config POWER_AVS_OMAP
> >   
> >   config POWER_AVS_OMAP_CLASS3
> >     bool "Class 3 mode of Smartreflex Implementation"
> > -   depends on POWER_AVS_OMAP && TWL4030_CORE
> > +   depends on POWER_AVS_OMAP && TWL_CORE
> >     help
> >       Say Y to enable Class 3 implementation of Smartreflex
> >   
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index 5f3429f..62ca9b4 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -933,7 +933,7 @@ config GPIO_TPS65912
> >   
> >   config GPIO_TWL4030
> >     tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
> > -   depends on TWL4030_CORE
> > +   depends on TWL_CORE
> >     help
> >       Say yes here to access the GPIO signals of various multi-
> > function
> >       power management chips from Texas Instruments.
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index af4aea7..3360492 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -440,7 +440,7 @@ config TI_AM335X_ADC
> >   
> >   config TWL4030_MADC
> >     tristate

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-03-30 Thread Grygorii Strashko 
On 03/29/2016 10:22 PM, Paul Kocialkowski wrote:
> Since the twl-core mfd driver is not limited to twl4030 support, but also
> supports other chips of the TWL family, it makes sense to rename its matching
> Kconfig opton to a non-model-specific name.

Personally I don't see too much reason for this, but it's up to maintainers to 
decide.
Regarding this patch - pls, do not mix Kconfig and code changes.

And it will be good to have cover letter.

> 
> Signed-off-by: Paul Kocialkowski 
> ---
>   arch/arm/mach-omap2/Kconfig | 2 +-
>   arch/arm/mach-omap2/Makefile| 2 +-
>   arch/arm/mach-omap2/pm.h| 2 +-
>   arch/arm/plat-omap/Kconfig  | 2 +-
>   drivers/gpio/Kconfig| 2 +-
>   drivers/iio/adc/Kconfig | 4 ++--
>   drivers/input/keyboard/Kconfig  | 2 +-
>   drivers/input/misc/Kconfig  | 4 ++--
>   drivers/mfd/Kconfig | 6 +++---
>   drivers/mfd/Makefile| 2 +-
>   drivers/mfd/twl4030-irq.c   | 6 +++---
>   drivers/phy/Kconfig | 2 +-
>   drivers/power/Kconfig   | 2 +-
>   drivers/pwm/Kconfig | 4 ++--
>   drivers/regulator/Kconfig   | 2 +-
>   drivers/rtc/Kconfig | 2 +-
>   drivers/usb/phy/Kconfig | 2 +-
>   drivers/video/backlight/Kconfig | 2 +-
>   drivers/watchdog/Kconfig| 2 +-
>   include/linux/i2c/twl.h | 4 ++--
>   sound/soc/codecs/Kconfig| 2 +-
>   sound/soc/omap/Kconfig  | 4 ++--
>   22 files changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 0517f0c..ada4c7a1 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -124,7 +124,7 @@ config ARCH_OMAP2PLUS_TYPICAL
>   select PM
>   select REGULATOR
>   select REGULATOR_FIXED_VOLTAGE
> - select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
> + select TWL_CORE if ARCH_OMAP3 || ARCH_OMAP4
>   select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
>   select VFP
>   help
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index 0ba6a0e..6eb680a 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -27,7 +27,7 @@ ifneq ($(CONFIG_SND_OMAP_SOC_MCBSP),)
>   obj-y += mcbsp.o
>   endif
>   
> -obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> +obj-$(CONFIG_TWL_CORE) += omap_twl.o
>   obj-$(CONFIG_SOC_HAS_OMAP2_SDRC)+= sdrc.o
>   
>   # SMP support ONLY available for OMAP4
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index b668719..bf4dac2 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -123,7 +123,7 @@ static inline int omap_devinit_smartreflex(void)
>   static inline void omap_enable_smartreflex_on_init(void) {}
>   #endif
>   
> -#ifdef CONFIG_TWL4030_CORE
> +#ifdef CONFIG_TWL_CORE
>   extern int omap3_twl_init(void);
>   extern int omap4_twl_init(void);
>   extern int omap3_twl_set_sr_bit(bool enable);
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index d055db3..8631a45 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -44,7 +44,7 @@ config POWER_AVS_OMAP
>   
>   config POWER_AVS_OMAP_CLASS3
>   bool "Class 3 mode of Smartreflex Implementation"
> - depends on POWER_AVS_OMAP && TWL4030_CORE
> + depends on POWER_AVS_OMAP && TWL_CORE
>   help
> Say Y to enable Class 3 implementation of Smartreflex
>   
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5f3429f..62ca9b4 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -933,7 +933,7 @@ config GPIO_TPS65912
>   
>   config GPIO_TWL4030
>   tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> Say yes here to access the GPIO signals of various multi-function
> power management chips from Texas Instruments.
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7..3360492 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -440,7 +440,7 @@ config TI_AM335X_ADC
>   
>   config TWL4030_MADC
>   tristate "TWL4030 MADC (Monitoring A/D Converter)"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> This driver provides support for Triton TWL4030-MADC. The
> driver supports both RT and SW conversion methods.
> @@ -450,7 +450,7 @@ config TWL4030_MADC
>   
>   config TWL6030_GPADC
>   tristate "TWL6030 GPADC (General Purpose A/D Converter) Support"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   default n
>   help
> Say yes here if you want support for the TWL6030/TWL6032 General
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 509608c..9cfa09b 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -653,7 +653,7 @@ config

Re: [PATCH 3/8] mfd: twl-core: Rename TWL4030_CORE Kconfig option to TWL_CORE

2016-03-30 Thread Grygorii Strashko 
On 03/29/2016 10:22 PM, Paul Kocialkowski wrote:
> Since the twl-core mfd driver is not limited to twl4030 support, but also
> supports other chips of the TWL family, it makes sense to rename its matching
> Kconfig opton to a non-model-specific name.

Personally I don't see too much reason for this, but it's up to maintainers to 
decide.
Regarding this patch - pls, do not mix Kconfig and code changes.

And it will be good to have cover letter.

> 
> Signed-off-by: Paul Kocialkowski 
> ---
>   arch/arm/mach-omap2/Kconfig | 2 +-
>   arch/arm/mach-omap2/Makefile| 2 +-
>   arch/arm/mach-omap2/pm.h| 2 +-
>   arch/arm/plat-omap/Kconfig  | 2 +-
>   drivers/gpio/Kconfig| 2 +-
>   drivers/iio/adc/Kconfig | 4 ++--
>   drivers/input/keyboard/Kconfig  | 2 +-
>   drivers/input/misc/Kconfig  | 4 ++--
>   drivers/mfd/Kconfig | 6 +++---
>   drivers/mfd/Makefile| 2 +-
>   drivers/mfd/twl4030-irq.c   | 6 +++---
>   drivers/phy/Kconfig | 2 +-
>   drivers/power/Kconfig   | 2 +-
>   drivers/pwm/Kconfig | 4 ++--
>   drivers/regulator/Kconfig   | 2 +-
>   drivers/rtc/Kconfig | 2 +-
>   drivers/usb/phy/Kconfig | 2 +-
>   drivers/video/backlight/Kconfig | 2 +-
>   drivers/watchdog/Kconfig| 2 +-
>   include/linux/i2c/twl.h | 4 ++--
>   sound/soc/codecs/Kconfig| 2 +-
>   sound/soc/omap/Kconfig  | 4 ++--
>   22 files changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 0517f0c..ada4c7a1 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -124,7 +124,7 @@ config ARCH_OMAP2PLUS_TYPICAL
>   select PM
>   select REGULATOR
>   select REGULATOR_FIXED_VOLTAGE
> - select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4
> + select TWL_CORE if ARCH_OMAP3 || ARCH_OMAP4
>   select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4
>   select VFP
>   help
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index 0ba6a0e..6eb680a 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -27,7 +27,7 @@ ifneq ($(CONFIG_SND_OMAP_SOC_MCBSP),)
>   obj-y += mcbsp.o
>   endif
>   
> -obj-$(CONFIG_TWL4030_CORE) += omap_twl.o
> +obj-$(CONFIG_TWL_CORE) += omap_twl.o
>   obj-$(CONFIG_SOC_HAS_OMAP2_SDRC)+= sdrc.o
>   
>   # SMP support ONLY available for OMAP4
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index b668719..bf4dac2 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -123,7 +123,7 @@ static inline int omap_devinit_smartreflex(void)
>   static inline void omap_enable_smartreflex_on_init(void) {}
>   #endif
>   
> -#ifdef CONFIG_TWL4030_CORE
> +#ifdef CONFIG_TWL_CORE
>   extern int omap3_twl_init(void);
>   extern int omap4_twl_init(void);
>   extern int omap3_twl_set_sr_bit(bool enable);
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index d055db3..8631a45 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -44,7 +44,7 @@ config POWER_AVS_OMAP
>   
>   config POWER_AVS_OMAP_CLASS3
>   bool "Class 3 mode of Smartreflex Implementation"
> - depends on POWER_AVS_OMAP && TWL4030_CORE
> + depends on POWER_AVS_OMAP && TWL_CORE
>   help
> Say Y to enable Class 3 implementation of Smartreflex
>   
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5f3429f..62ca9b4 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -933,7 +933,7 @@ config GPIO_TPS65912
>   
>   config GPIO_TWL4030
>   tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> Say yes here to access the GPIO signals of various multi-function
> power management chips from Texas Instruments.
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index af4aea7..3360492 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -440,7 +440,7 @@ config TI_AM335X_ADC
>   
>   config TWL4030_MADC
>   tristate "TWL4030 MADC (Monitoring A/D Converter)"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   help
> This driver provides support for Triton TWL4030-MADC. The
> driver supports both RT and SW conversion methods.
> @@ -450,7 +450,7 @@ config TWL4030_MADC
>   
>   config TWL6030_GPADC
>   tristate "TWL6030 GPADC (General Purpose A/D Converter) Support"
> - depends on TWL4030_CORE
> + depends on TWL_CORE
>   default n
>   help
> Say yes here if you want support for the TWL6030/TWL6032 General
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 509608c..9cfa09b 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -653,7 +653,7 @@ config KEYBOARD_TC3589X
>   
>