Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: > > Get the interconnect paths for SPI based Serial Engine device > and vote accordingly based on maximum supported SPI frequency. > > Signed-off-by: Alok Chauhan > --- > drivers/spi/spi-geni-qcom.c | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > index fdb7cb88..7bbbe9d 100644 > --- a/drivers/spi/spi-geni-qcom.c > +++ b/drivers/spi/spi-geni-qcom.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include Sorted includes please, as mentioned by others. > > /* SPI SE specific registers and respective register fields */ > #define SE_SPI_CPHA0x224 > @@ -589,6 +590,15 @@ static int spi_geni_probe(struct platform_device *pdev) > spin_lock_init(>lock); > pm_runtime_enable(>dev); > > + /* Set the bus quota to a reasonable value */ > + mas->se.avg_bw = Bps_to_icc(2500); > + mas->se.peak_bw = Bps_to_icc(2); Like the i2c case, can we compute real value based on clock speed?
Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support
On Tue, Jan 22, 2019 at 12:03:34PM +0530, Alok Chauhan wrote: > Get the interconnect paths for SPI based Serial Engine device > and vote accordingly based on maximum supported SPI frequency. Acked-by: Mark Brown signature.asc Description: PGP signature
Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support
On Wed, Jan 23, 2019 at 12:45:30PM +0530, al...@codeaurora.org wrote: > On 2019-01-23 01:59, Mark Brown wrote: > > Still not seeing anything except this patch here in my inbox - like I > > said what's the story with dependencies? > I've added linux-spi mailing list to all the patches sent as part of this > series. Not sure why you didn't get other patches. Today I've explicitly > added you in all the patches. You really need to ensure that things end up in people's inboxes - sending them to a mailing list usually means they'll go to a completely different folder. > This change series basically enabled interconnect (as per > bindings/interconnect/interconnect.txt) support in GENI QUPs based drivers > so appropriate BW request can be put based on SE usages. > here is my complete change series: > https://lore.kernel.org/lkml/1548069703-26595-1-git-send-email-al...@codeaurora.org/ > I hope I answer to your question properly. So it looks like there is a dependency on earlier patches in the series, that's what I needed to know. signature.asc Description: PGP signature
Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support
On 2019-01-23 01:59, Mark Brown wrote: On Tue, Jan 22, 2019 at 12:03:34PM +0530, Alok Chauhan wrote: Get the interconnect paths for SPI based Serial Engine device and vote accordingly based on maximum supported SPI frequency. Still not seeing anything except this patch here in my inbox - like I said what's the story with dependencies? I've added linux-spi mailing list to all the patches sent as part of this series. Not sure why you didn't get other patches. Today I've explicitly added you in all the patches. This change series basically enabled interconnect (as per bindings/interconnect/interconnect.txt) support in GENI QUPs based drivers so appropriate BW request can be put based on SE usages. here is my complete change series: https://lore.kernel.org/lkml/1548069703-26595-1-git-send-email-al...@codeaurora.org/ I hope I answer to your question properly. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,a Linux Foundation Collaborative Project
Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support
On Tue, Jan 22, 2019 at 12:03:34PM +0530, Alok Chauhan wrote: > Get the interconnect paths for SPI based Serial Engine device > and vote accordingly based on maximum supported SPI frequency. Still not seeing anything except this patch here in my inbox - like I said what's the story with dependencies? signature.asc Description: PGP signature
Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support
On 2019-01-21 18:13, Mark Brown wrote: On Mon, Jan 21, 2019 at 04:51:41PM +0530, Alok Chauhan wrote: Get the interconnect paths for SPI based Serial Engine device and vote accordingly based on maximum supported SPI frequency. I don't have any of the other patches in this series or a cover letter - what's going on with dependencies here? I am extremely sorry to waste your time. Looks like I missed some mailing list while sending patches upstream. I will resend patches today. -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,a Linux Foundation Collaborative Project
Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support
On Mon, Jan 21, 2019 at 04:51:41PM +0530, Alok Chauhan wrote: > Get the interconnect paths for SPI based Serial Engine device > and vote accordingly based on maximum supported SPI frequency. I don't have any of the other patches in this series or a cover letter - what's going on with dependencies here? signature.asc Description: PGP signature
