Re: [PATCH 4/7] kref: Remove WARN_ON for NULL release functions

2017-03-15 Thread Peter Zijlstra 
On Wed, Mar 15, 2017 at 10:46:56AM +0800, Greg KH wrote:
> On Tue, Mar 14, 2017 at 07:14:28PM -0700, Andi Kleen wrote:
> > From: Andi Kleen 
> > 
> > The kref functions check for NULL release functions.
> > This WARN_ON seems rather pointless. We will eventually release and
> > then just crash nicely. It is also somewhat expensive because
> > these functions are inlined in a lot of places.
> > Removing the WARN_ONs saves around 2.3k in this kernel
> > (likely more in others with more drivers)
> > 
> >textdata bss dec hex filename
> > 9083992 5367600 6544255681361862388 
> > vmlinux-before-load-avg
> > 9070166 5367600 654425554310185ed86 vmlinux-load-avg
> 
> WARN_ON() is heavy, didn't realize that.

I actually have patches fixing that.

Re: [PATCH 4/7] kref: Remove WARN_ON for NULL release functions

2017-03-15 Thread Peter Zijlstra 
On Wed, Mar 15, 2017 at 10:46:56AM +0800, Greg KH wrote:
> On Tue, Mar 14, 2017 at 07:14:28PM -0700, Andi Kleen wrote:
> > From: Andi Kleen 
> > 
> > The kref functions check for NULL release functions.
> > This WARN_ON seems rather pointless. We will eventually release and
> > then just crash nicely. It is also somewhat expensive because
> > these functions are inlined in a lot of places.
> > Removing the WARN_ONs saves around 2.3k in this kernel
> > (likely more in others with more drivers)
> > 
> >textdata bss dec hex filename
> > 9083992 5367600 6544255681361862388 
> > vmlinux-before-load-avg
> > 9070166 5367600 654425554310185ed86 vmlinux-load-avg
> 
> WARN_ON() is heavy, didn't realize that.

I actually have patches fixing that.

Re: [PATCH 4/7] kref: Remove WARN_ON for NULL release functions

2017-03-14 Thread Greg KH 
On Tue, Mar 14, 2017 at 07:14:28PM -0700, Andi Kleen wrote:
> From: Andi Kleen 
> 
> The kref functions check for NULL release functions.
> This WARN_ON seems rather pointless. We will eventually release and
> then just crash nicely. It is also somewhat expensive because
> these functions are inlined in a lot of places.
> Removing the WARN_ONs saves around 2.3k in this kernel
> (likely more in others with more drivers)
> 
>textdata bss dec hex filename
> 9083992 5367600 6544255681361862388 
> vmlinux-before-load-avg
> 9070166 5367600 654425554310185ed86 vmlinux-load-avg

WARN_ON() is heavy, didn't realize that.

No objection from me.

Acked-by: Greg Kroah-Hartman

Re: [PATCH 4/7] kref: Remove WARN_ON for NULL release functions

2017-03-14 Thread Greg KH 
On Tue, Mar 14, 2017 at 07:14:28PM -0700, Andi Kleen wrote:
> From: Andi Kleen 
> 
> The kref functions check for NULL release functions.
> This WARN_ON seems rather pointless. We will eventually release and
> then just crash nicely. It is also somewhat expensive because
> these functions are inlined in a lot of places.
> Removing the WARN_ONs saves around 2.3k in this kernel
> (likely more in others with more drivers)
> 
>textdata bss dec hex filename
> 9083992 5367600 6544255681361862388 
> vmlinux-before-load-avg
> 9070166 5367600 654425554310185ed86 vmlinux-load-avg

WARN_ON() is heavy, didn't realize that.

No objection from me.

Acked-by: Greg Kroah-Hartman