Re: [PATCH 4.20 00/50] 4.20.9-stable review
On Fri, Feb 15, 2019 at 09:22:21AM -0800, Guenter Roeck wrote: > On Fri, Feb 15, 2019 at 07:56:22AM +0100, Greg Kroah-Hartman wrote: > > On Thu, Feb 14, 2019 at 01:02:26PM -0800, Guenter Roeck wrote: > > > On Wed, Feb 13, 2019 at 07:38:05PM +0100, Greg Kroah-Hartman wrote: > > > > This is the start of the stable review cycle for the 4.20.9 release. > > > > There are 50 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Fri Feb 15 18:36:30 UTC 2019. > > > > Anything received after that time might be too late. > > > > > > > > > > Build results: > > > total: 159 pass: 159 fail: 0 > > > Qemu test results: > > > total: 343 pass: 330 fail: 13 > > > Failed tests: > > > sh:rts7751r2dplus_defconfig:initrd > > > sh:rts7751r2dplus_defconfig:ata:rootfs > > > sh:rts7751r2dplus_defconfig:mmc:rootfs > > > sh:rts7751r2dplus_defconfig:usb:rootfs > > > sh:rts7751r2dplus_defconfig:usb-hub:rootfs > > > sh:rts7751r2dplus_defconfig:usb-ohci:rootfs > > > sh:rts7751r2dplus_defconfig:usb-ehci:rootfs > > > sh:rts7751r2dplus_defconfig:usb-xhci:rootfs > > > sh:rts7751r2dplus_defconfig:usb-uas-ehci:rootfs > > > sh:rts7751r2dplus_defconfig:usb-uas-xhci:rootfs > > > sh:rts7751r2dplus_defconfig:scsi[53C810]:rootfs > > > sh:rts7751r2dplus_defconfig:scsi[53C895A]:rootfs > > > sh:rts7751r2dplus_defconfig:scsi[FUSION]:rootfs > > > > > > This failure gave me a bit of trouble. It is similar to the failure > > > observed > > > earlier with v4.4.y, but changing the C compiler version did not help (I > > > tried 8.2.0 and 5.5.0), and changing the qemu version did not help either. > > > Bisect points to commit 31e8a058e1f ("Revert "ext4: use ext4_write_inode() > > > when fsyncing w/o a journal") as the culprit. No idea why that would be > > > the case, but I repeated the bisect twice with the same results, and > > > reverting that revert indeed fixes the problem. This is weird since > > > one of the failing tests doesn't even mount a file system but boots > > > from initrd. Go figure. Bisect results are below. > > > > > > Guenter > > > > > > --- > > > # bad: [f4a86d6d2a0bdead7cf98d552481367e6356ef28] Linux 4.20.9-rc1 > > > # good: [0788acb1a3ed1589da1768ba64b1e5c76e8cb661] Linux 4.20.8 > > > git bisect start 'HEAD' 'v4.20.8' > > > # good: [df6033ca3341635d8f529d6cdb6d37257df6f783] MIPS: OCTEON: don't > > > set octeon_dma_bar_type if PCI is disabled > > > git bisect good df6033ca3341635d8f529d6cdb6d37257df6f783 > > > # good: [da33f30a55d08758a63de90038344f956252ea8f] drm/rockchip: rgb: > > > update SPDX license identifier > > > git bisect good da33f30a55d08758a63de90038344f956252ea8f > > > # good: [3ef454cd518997a8447080fb01743aaa4d4de8ae] xfrm: Make set-mark > > > default behavior backward compatible > > > git bisect good 3ef454cd518997a8447080fb01743aaa4d4de8ae > > > # bad: [b442f17368f050887aae5d525b4dd0e146440f94] libceph: avoid > > > KEEPALIVE_PENDING races in ceph_con_keepalive() > > > git bisect bad b442f17368f050887aae5d525b4dd0e146440f94 > > > # bad: [31e8a058e1f9aa32254f64a9643853062141895a] Revert "ext4: use > > > ext4_write_inode() when fsyncing w/o a journal" > > > git bisect bad 31e8a058e1f9aa32254f64a9643853062141895a > > > # good: [0bc4dd12c3196b01d2123f95bb1c949e5eebe483] drm/i915: Try to > > > sanitize bogus DPLL state left over by broken SNB BIOSen > > > git bisect good 0bc4dd12c3196b01d2123f95bb1c949e5eebe483 > > > # first bad commit: [31e8a058e1f9aa32254f64a9643853062141895a] Revert > > > "ext4: use ext4_write_inode() when fsyncing w/o a journal" > > > > That's really odd, given that this is only showing up in sh and not in > > any of the other releases. I'll blame gcc for this one :( > > > I suspect it may be a code alignment issue, but who knows. The problem > is gone in v4.20.10, meaning the revert of "exec: load_script: don't > blindly truncate shebang string" "fixed" the problem as well. That's sad, and scary :( Thanks for letting me know. greg k-h
Re: [PATCH 4.20 00/50] 4.20.9-stable review
On Fri, Feb 15, 2019 at 07:56:22AM +0100, Greg Kroah-Hartman wrote: > On Thu, Feb 14, 2019 at 01:02:26PM -0800, Guenter Roeck wrote: > > On Wed, Feb 13, 2019 at 07:38:05PM +0100, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.20.9 release. > > > There are 50 patches in this series, all will be posted as a response > > > to this one. If anyone has any issues with these being applied, please > > > let me know. > > > > > > Responses should be made by Fri Feb 15 18:36:30 UTC 2019. > > > Anything received after that time might be too late. > > > > > > > Build results: > > total: 159 pass: 159 fail: 0 > > Qemu test results: > > total: 343 pass: 330 fail: 13 > > Failed tests: > > sh:rts7751r2dplus_defconfig:initrd > > sh:rts7751r2dplus_defconfig:ata:rootfs > > sh:rts7751r2dplus_defconfig:mmc:rootfs > > sh:rts7751r2dplus_defconfig:usb:rootfs > > sh:rts7751r2dplus_defconfig:usb-hub:rootfs > > sh:rts7751r2dplus_defconfig:usb-ohci:rootfs > > sh:rts7751r2dplus_defconfig:usb-ehci:rootfs > > sh:rts7751r2dplus_defconfig:usb-xhci:rootfs > > sh:rts7751r2dplus_defconfig:usb-uas-ehci:rootfs > > sh:rts7751r2dplus_defconfig:usb-uas-xhci:rootfs > > sh:rts7751r2dplus_defconfig:scsi[53C810]:rootfs > > sh:rts7751r2dplus_defconfig:scsi[53C895A]:rootfs > > sh:rts7751r2dplus_defconfig:scsi[FUSION]:rootfs > > > > This failure gave me a bit of trouble. It is similar to the failure observed > > earlier with v4.4.y, but changing the C compiler version did not help (I > > tried 8.2.0 and 5.5.0), and changing the qemu version did not help either. > > Bisect points to commit 31e8a058e1f ("Revert "ext4: use ext4_write_inode() > > when fsyncing w/o a journal") as the culprit. No idea why that would be > > the case, but I repeated the bisect twice with the same results, and > > reverting that revert indeed fixes the problem. This is weird since > > one of the failing tests doesn't even mount a file system but boots > > from initrd. Go figure. Bisect results are below. > > > > Guenter > > > > --- > > # bad: [f4a86d6d2a0bdead7cf98d552481367e6356ef28] Linux 4.20.9-rc1 > > # good: [0788acb1a3ed1589da1768ba64b1e5c76e8cb661] Linux 4.20.8 > > git bisect start 'HEAD' 'v4.20.8' > > # good: [df6033ca3341635d8f529d6cdb6d37257df6f783] MIPS: OCTEON: don't set > > octeon_dma_bar_type if PCI is disabled > > git bisect good df6033ca3341635d8f529d6cdb6d37257df6f783 > > # good: [da33f30a55d08758a63de90038344f956252ea8f] drm/rockchip: rgb: > > update SPDX license identifier > > git bisect good da33f30a55d08758a63de90038344f956252ea8f > > # good: [3ef454cd518997a8447080fb01743aaa4d4de8ae] xfrm: Make set-mark > > default behavior backward compatible > > git bisect good 3ef454cd518997a8447080fb01743aaa4d4de8ae > > # bad: [b442f17368f050887aae5d525b4dd0e146440f94] libceph: avoid > > KEEPALIVE_PENDING races in ceph_con_keepalive() > > git bisect bad b442f17368f050887aae5d525b4dd0e146440f94 > > # bad: [31e8a058e1f9aa32254f64a9643853062141895a] Revert "ext4: use > > ext4_write_inode() when fsyncing w/o a journal" > > git bisect bad 31e8a058e1f9aa32254f64a9643853062141895a > > # good: [0bc4dd12c3196b01d2123f95bb1c949e5eebe483] drm/i915: Try to > > sanitize bogus DPLL state left over by broken SNB BIOSen > > git bisect good 0bc4dd12c3196b01d2123f95bb1c949e5eebe483 > > # first bad commit: [31e8a058e1f9aa32254f64a9643853062141895a] Revert > > "ext4: use ext4_write_inode() when fsyncing w/o a journal" > > That's really odd, given that this is only showing up in sh and not in > any of the other releases. I'll blame gcc for this one :( > I suspect it may be a code alignment issue, but who knows. The problem is gone in v4.20.10, meaning the revert of "exec: load_script: don't blindly truncate shebang string" "fixed" the problem as well. Guenter
Re: [PATCH 4.20 00/50] 4.20.9-stable review
On Thu, Feb 14, 2019 at 10:52:42AM -0600, Dan Rue wrote: > On Wed, Feb 13, 2019 at 07:38:05PM +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.20.9 release. > > There are 50 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Fri Feb 15 18:36:30 UTC 2019. > > Anything received after that time might be too late. > > Results from Linaro’s test farm. > No regressions on arm64, arm, x86_64, and i386. Great, thanks for testing all of these and letting me know. greg k-h
Re: [PATCH 4.20 00/50] 4.20.9-stable review
On Thu, Feb 14, 2019 at 01:02:26PM -0800, Guenter Roeck wrote: > On Wed, Feb 13, 2019 at 07:38:05PM +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.20.9 release. > > There are 50 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Fri Feb 15 18:36:30 UTC 2019. > > Anything received after that time might be too late. > > > > Build results: > total: 159 pass: 159 fail: 0 > Qemu test results: > total: 343 pass: 330 fail: 13 > Failed tests: > sh:rts7751r2dplus_defconfig:initrd > sh:rts7751r2dplus_defconfig:ata:rootfs > sh:rts7751r2dplus_defconfig:mmc:rootfs > sh:rts7751r2dplus_defconfig:usb:rootfs > sh:rts7751r2dplus_defconfig:usb-hub:rootfs > sh:rts7751r2dplus_defconfig:usb-ohci:rootfs > sh:rts7751r2dplus_defconfig:usb-ehci:rootfs > sh:rts7751r2dplus_defconfig:usb-xhci:rootfs > sh:rts7751r2dplus_defconfig:usb-uas-ehci:rootfs > sh:rts7751r2dplus_defconfig:usb-uas-xhci:rootfs > sh:rts7751r2dplus_defconfig:scsi[53C810]:rootfs > sh:rts7751r2dplus_defconfig:scsi[53C895A]:rootfs > sh:rts7751r2dplus_defconfig:scsi[FUSION]:rootfs > > This failure gave me a bit of trouble. It is similar to the failure observed > earlier with v4.4.y, but changing the C compiler version did not help (I > tried 8.2.0 and 5.5.0), and changing the qemu version did not help either. > Bisect points to commit 31e8a058e1f ("Revert "ext4: use ext4_write_inode() > when fsyncing w/o a journal") as the culprit. No idea why that would be > the case, but I repeated the bisect twice with the same results, and > reverting that revert indeed fixes the problem. This is weird since > one of the failing tests doesn't even mount a file system but boots > from initrd. Go figure. Bisect results are below. > > Guenter > > --- > # bad: [f4a86d6d2a0bdead7cf98d552481367e6356ef28] Linux 4.20.9-rc1 > # good: [0788acb1a3ed1589da1768ba64b1e5c76e8cb661] Linux 4.20.8 > git bisect start 'HEAD' 'v4.20.8' > # good: [df6033ca3341635d8f529d6cdb6d37257df6f783] MIPS: OCTEON: don't set > octeon_dma_bar_type if PCI is disabled > git bisect good df6033ca3341635d8f529d6cdb6d37257df6f783 > # good: [da33f30a55d08758a63de90038344f956252ea8f] drm/rockchip: rgb: update > SPDX license identifier > git bisect good da33f30a55d08758a63de90038344f956252ea8f > # good: [3ef454cd518997a8447080fb01743aaa4d4de8ae] xfrm: Make set-mark > default behavior backward compatible > git bisect good 3ef454cd518997a8447080fb01743aaa4d4de8ae > # bad: [b442f17368f050887aae5d525b4dd0e146440f94] libceph: avoid > KEEPALIVE_PENDING races in ceph_con_keepalive() > git bisect bad b442f17368f050887aae5d525b4dd0e146440f94 > # bad: [31e8a058e1f9aa32254f64a9643853062141895a] Revert "ext4: use > ext4_write_inode() when fsyncing w/o a journal" > git bisect bad 31e8a058e1f9aa32254f64a9643853062141895a > # good: [0bc4dd12c3196b01d2123f95bb1c949e5eebe483] drm/i915: Try to sanitize > bogus DPLL state left over by broken SNB BIOSen > git bisect good 0bc4dd12c3196b01d2123f95bb1c949e5eebe483 > # first bad commit: [31e8a058e1f9aa32254f64a9643853062141895a] Revert "ext4: > use ext4_write_inode() when fsyncing w/o a journal" That's really odd, given that this is only showing up in sh and not in any of the other releases. I'll blame gcc for this one :( Thanks for testing all of these and letting me know. greg k-h
Re: [PATCH 4.20 00/50] 4.20.9-stable review
On Thu, Feb 14, 2019 at 03:24:07PM -0700, shuah wrote: > On 2/13/19 11:38 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.20.9 release. > > There are 50 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Fri Feb 15 18:36:30 UTC 2019. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.20.9-rc1.gz > > or in the git tree and branch at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > linux-4.20.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > > > Compiled and booted on my test system. No dmesg regressions. Thanks for testing all of these and letting me know. greg k-h
Re: [PATCH 4.20 00/50] 4.20.9-stable review
On 2/13/19 11:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.20.9 release. There are 50 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Fri Feb 15 18:36:30 UTC 2019. Anything received after that time might be too late. The whole patch series can be found in one patch at: https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.20.9-rc1.gz or in the git tree and branch at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.20.y and the diffstat can be found below. thanks, greg k-h Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah
Re: [PATCH 4.20 00/50] 4.20.9-stable review
On Wed, Feb 13, 2019 at 07:38:05PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.20.9 release. > There are 50 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Fri Feb 15 18:36:30 UTC 2019. > Anything received after that time might be too late. > Build results: total: 159 pass: 159 fail: 0 Qemu test results: total: 343 pass: 330 fail: 13 Failed tests: sh:rts7751r2dplus_defconfig:initrd sh:rts7751r2dplus_defconfig:ata:rootfs sh:rts7751r2dplus_defconfig:mmc:rootfs sh:rts7751r2dplus_defconfig:usb:rootfs sh:rts7751r2dplus_defconfig:usb-hub:rootfs sh:rts7751r2dplus_defconfig:usb-ohci:rootfs sh:rts7751r2dplus_defconfig:usb-ehci:rootfs sh:rts7751r2dplus_defconfig:usb-xhci:rootfs sh:rts7751r2dplus_defconfig:usb-uas-ehci:rootfs sh:rts7751r2dplus_defconfig:usb-uas-xhci:rootfs sh:rts7751r2dplus_defconfig:scsi[53C810]:rootfs sh:rts7751r2dplus_defconfig:scsi[53C895A]:rootfs sh:rts7751r2dplus_defconfig:scsi[FUSION]:rootfs This failure gave me a bit of trouble. It is similar to the failure observed earlier with v4.4.y, but changing the C compiler version did not help (I tried 8.2.0 and 5.5.0), and changing the qemu version did not help either. Bisect points to commit 31e8a058e1f ("Revert "ext4: use ext4_write_inode() when fsyncing w/o a journal") as the culprit. No idea why that would be the case, but I repeated the bisect twice with the same results, and reverting that revert indeed fixes the problem. This is weird since one of the failing tests doesn't even mount a file system but boots from initrd. Go figure. Bisect results are below. Guenter --- # bad: [f4a86d6d2a0bdead7cf98d552481367e6356ef28] Linux 4.20.9-rc1 # good: [0788acb1a3ed1589da1768ba64b1e5c76e8cb661] Linux 4.20.8 git bisect start 'HEAD' 'v4.20.8' # good: [df6033ca3341635d8f529d6cdb6d37257df6f783] MIPS: OCTEON: don't set octeon_dma_bar_type if PCI is disabled git bisect good df6033ca3341635d8f529d6cdb6d37257df6f783 # good: [da33f30a55d08758a63de90038344f956252ea8f] drm/rockchip: rgb: update SPDX license identifier git bisect good da33f30a55d08758a63de90038344f956252ea8f # good: [3ef454cd518997a8447080fb01743aaa4d4de8ae] xfrm: Make set-mark default behavior backward compatible git bisect good 3ef454cd518997a8447080fb01743aaa4d4de8ae # bad: [b442f17368f050887aae5d525b4dd0e146440f94] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive() git bisect bad b442f17368f050887aae5d525b4dd0e146440f94 # bad: [31e8a058e1f9aa32254f64a9643853062141895a] Revert "ext4: use ext4_write_inode() when fsyncing w/o a journal" git bisect bad 31e8a058e1f9aa32254f64a9643853062141895a # good: [0bc4dd12c3196b01d2123f95bb1c949e5eebe483] drm/i915: Try to sanitize bogus DPLL state left over by broken SNB BIOSen git bisect good 0bc4dd12c3196b01d2123f95bb1c949e5eebe483 # first bad commit: [31e8a058e1f9aa32254f64a9643853062141895a] Revert "ext4: use ext4_write_inode() when fsyncing w/o a journal"
Re: [PATCH 4.20 00/50] 4.20.9-stable review
On Wed, Feb 13, 2019 at 07:38:05PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.20.9 release. > There are 50 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Fri Feb 15 18:36:30 UTC 2019. > Anything received after that time might be too late. Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Summary kernel: 4.20.9-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.20.y git commit: f4a86d6d2a0bdead7cf98d552481367e6356ef28 git describe: v4.20.8-51-gf4a86d6d2a0b Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.20-oe/build/v4.20.8-51-gf4a86d6d2a0b No regressions (compared to build v4.20.8) No fixes (compared to build v4.20.8) Ran 21515 total tests in the following environments and test suites. Environments -- - dragonboard-410c - arm64 - hi6220-hikey - arm64 - i386 - juno-r2 - arm64 - qemu_arm - qemu_arm64 - qemu_i386 - qemu_x86_64 - x15 - arm - x86_64 Test Suites --- * boot * install-android-platform-tools-r2600 * kselftest * libhugetlbfs * ltp-cap_bounds-tests * ltp-containers-tests * ltp-cpuhotplug-tests * ltp-cve-tests * ltp-fcntl-locktests-tests * ltp-filecaps-tests * ltp-fs_bind-tests * ltp-fs_perms_simple-tests * ltp-fsx-tests * ltp-hugetlb-tests * ltp-io-tests * ltp-ipc-tests * ltp-math-tests * ltp-mm-tests * ltp-nptl-tests * ltp-pty-tests * ltp-sched-tests * ltp-securebits-tests * ltp-syscalls-tests * ltp-timers-tests * spectre-meltdown-checker-test * ltp-fs-tests * ltp-open-posix-tests * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-none -- Linaro LKFT https://lkft.linaro.org