Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, Feb 17, 2018 at 09:35:59AM -0800, Guenter Roeck wrote: > On 02/17/2018 05:45 AM, Greg Kroah-Hartman wrote: > > On Sat, Feb 17, 2018 at 02:31:53PM +0100, Yves-Alexis Perez wrote: > > > On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: > > > > > arch/powerpc/kernel/entry_64.S: Assembler messages: > > > > > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: > > > > > `rfi_to_user' > > > > > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > > > > > `rfi_to_kernel' > > > > > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: > > > > > `rfi_to_user' > > > > > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > > > > > `rfi_to_kernel' > > > > > > > > > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro > > > > > conversions") is missing, > > > > > or at least part of it. Unfortunately it doesn't apply cleanly. > > > > > > > > Ugh. Let's see if the ppc developers care about this or not :) > > > > > > Hi, > > > > > > in Debian we extracted the following hunk from 222f20f140623 to fix build > > > on > > > powerpc/ppc64el. Only compile tested against Debian builds though. > > > > > > diff --git a/arch/powerpc/kernel/entry_64.S > > > b/arch/powerpc/kernel/entry_64.S > > > index 3320bcac7192..e68faa4d1b13 100644 > > > --- a/arch/powerpc/kernel/entry_64.S > > > +++ b/arch/powerpc/kernel/entry_64.S > > > @@ -37,6 +37,11 @@ > > > #include > > > #include > > > #include > > > +#ifdef CONFIG_PPC_BOOK3S > > > +#include > > > +#else > > > +#include > > > +#endif > > > > Ah, thanks! I've now queued up this portion of the patch. > > > > Hmm, that chunk really doesn't do what the original patch is supposed to do, > meaning it won't provide the vulnerability protection it is supposed to > provide > (AFAICS that is Meltdown). Just a note in case anyone is concerned about > actually providing that protection. Good point, I've renamed this patch now to make it more obvious what is going on. thanks, greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, Feb 17, 2018 at 09:35:59AM -0800, Guenter Roeck wrote: > On 02/17/2018 05:45 AM, Greg Kroah-Hartman wrote: > > On Sat, Feb 17, 2018 at 02:31:53PM +0100, Yves-Alexis Perez wrote: > > > On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: > > > > > arch/powerpc/kernel/entry_64.S: Assembler messages: > > > > > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: > > > > > `rfi_to_user' > > > > > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > > > > > `rfi_to_kernel' > > > > > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: > > > > > `rfi_to_user' > > > > > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > > > > > `rfi_to_kernel' > > > > > > > > > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro > > > > > conversions") is missing, > > > > > or at least part of it. Unfortunately it doesn't apply cleanly. > > > > > > > > Ugh. Let's see if the ppc developers care about this or not :) > > > > > > Hi, > > > > > > in Debian we extracted the following hunk from 222f20f140623 to fix build > > > on > > > powerpc/ppc64el. Only compile tested against Debian builds though. > > > > > > diff --git a/arch/powerpc/kernel/entry_64.S > > > b/arch/powerpc/kernel/entry_64.S > > > index 3320bcac7192..e68faa4d1b13 100644 > > > --- a/arch/powerpc/kernel/entry_64.S > > > +++ b/arch/powerpc/kernel/entry_64.S > > > @@ -37,6 +37,11 @@ > > > #include > > > #include > > > #include > > > +#ifdef CONFIG_PPC_BOOK3S > > > +#include > > > +#else > > > +#include > > > +#endif > > > > Ah, thanks! I've now queued up this portion of the patch. > > > > Hmm, that chunk really doesn't do what the original patch is supposed to do, > meaning it won't provide the vulnerability protection it is supposed to > provide > (AFAICS that is Meltdown). Just a note in case anyone is concerned about > actually providing that protection. Good point, I've renamed this patch now to make it more obvious what is going on. thanks, greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, 2018-02-17 at 09:35 -0800, Guenter Roeck wrote: > Hmm, that chunk really doesn't do what the original patch is supposed to do, > meaning it won't provide the vulnerability protection it is supposed to > provide > (AFAICS that is Meltdown). Just a note in case anyone is concerned about > actually providing that protection. Right now my concern was really about fixing 4.9.81/4.9.82 build failure on powerpc. Whether the patches backported in those two releases are enough to fix Meltdown or not is a different thing indeed (and an information I'd be glad to have too). Regards, -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, 2018-02-17 at 09:35 -0800, Guenter Roeck wrote: > Hmm, that chunk really doesn't do what the original patch is supposed to do, > meaning it won't provide the vulnerability protection it is supposed to > provide > (AFAICS that is Meltdown). Just a note in case anyone is concerned about > actually providing that protection. Right now my concern was really about fixing 4.9.81/4.9.82 build failure on powerpc. Whether the patches backported in those two releases are enough to fix Meltdown or not is a different thing indeed (and an information I'd be glad to have too). Regards, -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/17/2018 05:45 AM, Greg Kroah-Hartman wrote: On Sat, Feb 17, 2018 at 02:31:53PM +0100, Yves-Alexis Perez wrote: On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: arch/powerpc/kernel/entry_64.S: Assembler messages: arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: `rfi_to_kernel' arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: `rfi_to_kernel' Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is missing, or at least part of it. Unfortunately it doesn't apply cleanly. Ugh. Let's see if the ppc developers care about this or not :) Hi, in Debian we extracted the following hunk from 222f20f140623 to fix build on powerpc/ppc64el. Only compile tested against Debian builds though. diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index 3320bcac7192..e68faa4d1b13 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/powerpc/kernel/entry_64.S @@ -37,6 +37,11 @@ #include #include #include +#ifdef CONFIG_PPC_BOOK3S +#include +#else +#include +#endif Ah, thanks! I've now queued up this portion of the patch. Hmm, that chunk really doesn't do what the original patch is supposed to do, meaning it won't provide the vulnerability protection it is supposed to provide (AFAICS that is Meltdown). Just a note in case anyone is concerned about actually providing that protection. Guenter
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/17/2018 05:45 AM, Greg Kroah-Hartman wrote: On Sat, Feb 17, 2018 at 02:31:53PM +0100, Yves-Alexis Perez wrote: On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: arch/powerpc/kernel/entry_64.S: Assembler messages: arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: `rfi_to_kernel' arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: `rfi_to_kernel' Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is missing, or at least part of it. Unfortunately it doesn't apply cleanly. Ugh. Let's see if the ppc developers care about this or not :) Hi, in Debian we extracted the following hunk from 222f20f140623 to fix build on powerpc/ppc64el. Only compile tested against Debian builds though. diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index 3320bcac7192..e68faa4d1b13 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/powerpc/kernel/entry_64.S @@ -37,6 +37,11 @@ #include #include #include +#ifdef CONFIG_PPC_BOOK3S +#include +#else +#include +#endif Ah, thanks! I've now queued up this portion of the patch. Hmm, that chunk really doesn't do what the original patch is supposed to do, meaning it won't provide the vulnerability protection it is supposed to provide (AFAICS that is Meltdown). Just a note in case anyone is concerned about actually providing that protection. Guenter
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, Feb 17, 2018 at 02:31:53PM +0100, Yves-Alexis Perez wrote: > On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: > > > arch/powerpc/kernel/entry_64.S: Assembler messages: > > > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: > > > `rfi_to_user' > > > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > > > `rfi_to_kernel' > > > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: > > > `rfi_to_user' > > > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > > > `rfi_to_kernel' > > > > > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is > > > missing, > > > or at least part of it. Unfortunately it doesn't apply cleanly. > > > > Ugh. Let's see if the ppc developers care about this or not :) > > Hi, > > in Debian we extracted the following hunk from 222f20f140623 to fix build on > powerpc/ppc64el. Only compile tested against Debian builds though. > > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S > index 3320bcac7192..e68faa4d1b13 100644 > --- a/arch/powerpc/kernel/entry_64.S > +++ b/arch/powerpc/kernel/entry_64.S > @@ -37,6 +37,11 @@ > #include > #include > #include > +#ifdef CONFIG_PPC_BOOK3S > +#include > +#else > +#include > +#endif > Ah, thanks! I've now queued up this portion of the patch. greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, Feb 17, 2018 at 02:31:53PM +0100, Yves-Alexis Perez wrote: > On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: > > > arch/powerpc/kernel/entry_64.S: Assembler messages: > > > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: > > > `rfi_to_user' > > > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > > > `rfi_to_kernel' > > > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: > > > `rfi_to_user' > > > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > > > `rfi_to_kernel' > > > > > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is > > > missing, > > > or at least part of it. Unfortunately it doesn't apply cleanly. > > > > Ugh. Let's see if the ppc developers care about this or not :) > > Hi, > > in Debian we extracted the following hunk from 222f20f140623 to fix build on > powerpc/ppc64el. Only compile tested against Debian builds though. > > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S > index 3320bcac7192..e68faa4d1b13 100644 > --- a/arch/powerpc/kernel/entry_64.S > +++ b/arch/powerpc/kernel/entry_64.S > @@ -37,6 +37,11 @@ > #include > #include > #include > +#ifdef CONFIG_PPC_BOOK3S > +#include > +#else > +#include > +#endif > Ah, thanks! I've now queued up this portion of the patch. greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: > > arch/powerpc/kernel/entry_64.S: Assembler messages: > > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: > > `rfi_to_user' > > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > > `rfi_to_kernel' > > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: > > `rfi_to_user' > > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > > `rfi_to_kernel' > > > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is > > missing, > > or at least part of it. Unfortunately it doesn't apply cleanly. > > Ugh. Let's see if the ppc developers care about this or not :) Hi, in Debian we extracted the following hunk from 222f20f140623 to fix build on powerpc/ppc64el. Only compile tested against Debian builds though. diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index 3320bcac7192..e68faa4d1b13 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/powerpc/kernel/entry_64.S @@ -37,6 +37,11 @@ #include #include #include +#ifdef CONFIG_PPC_BOOK3S +#include +#else +#include +#endif /* * System calls. -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Tue, 2018-02-13 at 16:29 +0100, Greg Kroah-Hartman wrote: > > arch/powerpc/kernel/entry_64.S: Assembler messages: > > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: > > `rfi_to_user' > > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > > `rfi_to_kernel' > > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: > > `rfi_to_user' > > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > > `rfi_to_kernel' > > > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is > > missing, > > or at least part of it. Unfortunately it doesn't apply cleanly. > > Ugh. Let's see if the ppc developers care about this or not :) Hi, in Debian we extracted the following hunk from 222f20f140623 to fix build on powerpc/ppc64el. Only compile tested against Debian builds though. diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index 3320bcac7192..e68faa4d1b13 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/powerpc/kernel/entry_64.S @@ -37,6 +37,11 @@ #include #include #include +#ifdef CONFIG_PPC_BOOK3S +#include +#else +#include +#endif /* * System calls. -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Tue, Feb 13, 2018 at 06:30:36AM -0800, Guenter Roeck wrote: > On 02/13/2018 01:36 AM, Greg Kroah-Hartman wrote: > > On Sat, Feb 10, 2018 at 07:46:50AM -0800, Guenter Roeck wrote: > > > On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: > > > > This is the start of the stable review cycle for the 4.9.81 release. > > > > There are 92 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > > > > Anything received after that time might be too late. > > > > > > > > > > Build results: > > > total: 145 pass: 140 fail: 5 > > > Failed builds: > > > powerpc:defconfig > > > powerpc:allmodconfig > > > powerpc:ppc64e_defconfig > > > powerpc:cell_defconfig > > > powerpc:maple_defconfig > > > Qemu test results: > > > total: 118 pass: 113 fail: 5 > > > Failed tests: > > > powerpc:mac99:ppc64_book3s_defconfig:nosmp > > > powerpc:mac99:ppc64_book3s_defconfig:smp4 > > > powerpc:pseries:pseries_defconfig > > > powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp > > > powerpc:mpc8544ds:ppc64_e5500_defconfig:smp > > > > > > All builds and tests fail with the following error. > > > > > > arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such > > > file or directory > > > > > > For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow > > > control of RFI > > > flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. > > > > Thanks for letting me know, I've now fixed this up. Will go work on the > > 4.4 patch as well. > > > > Unfortunately it wasn't the only problem. Now we have: > > arch/powerpc/kernel/entry_64.S: Assembler messages: > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: `rfi_to_user' > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > `rfi_to_kernel' > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: `rfi_to_user' > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > `rfi_to_kernel' > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is > missing, > or at least part of it. Unfortunately it doesn't apply cleanly. Ugh. Let's see if the ppc developers care about this or not :) > 4.4 also now has a different failure. > > In file included from drivers/staging/rdma/ehca/hcp_if.c:45:0: > arch/powerpc/include/asm/hvcall.h:439:2: error: unknown type name 'u64' > u64 character; > ^ > arch/powerpc/include/asm/hvcall.h:440:2: error: unknown type name 'u64' > u64 behaviour; > > You'll need 1b689a95ce742 to fix that problem. Now queued up, thanks. greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Tue, Feb 13, 2018 at 06:30:36AM -0800, Guenter Roeck wrote: > On 02/13/2018 01:36 AM, Greg Kroah-Hartman wrote: > > On Sat, Feb 10, 2018 at 07:46:50AM -0800, Guenter Roeck wrote: > > > On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: > > > > This is the start of the stable review cycle for the 4.9.81 release. > > > > There are 92 patches in this series, all will be posted as a response > > > > to this one. If anyone has any issues with these being applied, please > > > > let me know. > > > > > > > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > > > > Anything received after that time might be too late. > > > > > > > > > > Build results: > > > total: 145 pass: 140 fail: 5 > > > Failed builds: > > > powerpc:defconfig > > > powerpc:allmodconfig > > > powerpc:ppc64e_defconfig > > > powerpc:cell_defconfig > > > powerpc:maple_defconfig > > > Qemu test results: > > > total: 118 pass: 113 fail: 5 > > > Failed tests: > > > powerpc:mac99:ppc64_book3s_defconfig:nosmp > > > powerpc:mac99:ppc64_book3s_defconfig:smp4 > > > powerpc:pseries:pseries_defconfig > > > powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp > > > powerpc:mpc8544ds:ppc64_e5500_defconfig:smp > > > > > > All builds and tests fail with the following error. > > > > > > arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such > > > file or directory > > > > > > For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow > > > control of RFI > > > flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. > > > > Thanks for letting me know, I've now fixed this up. Will go work on the > > 4.4 patch as well. > > > > Unfortunately it wasn't the only problem. Now we have: > > arch/powerpc/kernel/entry_64.S: Assembler messages: > arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: `rfi_to_user' > arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: > `rfi_to_kernel' > arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: `rfi_to_user' > arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: > `rfi_to_kernel' > > Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is > missing, > or at least part of it. Unfortunately it doesn't apply cleanly. Ugh. Let's see if the ppc developers care about this or not :) > 4.4 also now has a different failure. > > In file included from drivers/staging/rdma/ehca/hcp_if.c:45:0: > arch/powerpc/include/asm/hvcall.h:439:2: error: unknown type name 'u64' > u64 character; > ^ > arch/powerpc/include/asm/hvcall.h:440:2: error: unknown type name 'u64' > u64 behaviour; > > You'll need 1b689a95ce742 to fix that problem. Now queued up, thanks. greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/13/2018 01:36 AM, Greg Kroah-Hartman wrote: On Sat, Feb 10, 2018 at 07:46:50AM -0800, Guenter Roeck wrote: On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.81 release. There are 92 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Feb 11 13:39:04 UTC 2018. Anything received after that time might be too late. Build results: total: 145 pass: 140 fail: 5 Failed builds: powerpc:defconfig powerpc:allmodconfig powerpc:ppc64e_defconfig powerpc:cell_defconfig powerpc:maple_defconfig Qemu test results: total: 118 pass: 113 fail: 5 Failed tests: powerpc:mac99:ppc64_book3s_defconfig:nosmp powerpc:mac99:ppc64_book3s_defconfig:smp4 powerpc:pseries:pseries_defconfig powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp powerpc:mpc8544ds:ppc64_e5500_defconfig:smp All builds and tests fail with the following error. arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such file or directory For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow control of RFI flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. Thanks for letting me know, I've now fixed this up. Will go work on the 4.4 patch as well. Unfortunately it wasn't the only problem. Now we have: arch/powerpc/kernel/entry_64.S: Assembler messages: arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: `rfi_to_kernel' arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: `rfi_to_kernel' Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is missing, or at least part of it. Unfortunately it doesn't apply cleanly. 4.4 also now has a different failure. In file included from drivers/staging/rdma/ehca/hcp_if.c:45:0: arch/powerpc/include/asm/hvcall.h:439:2: error: unknown type name 'u64' u64 character; ^ arch/powerpc/include/asm/hvcall.h:440:2: error: unknown type name 'u64' u64 behaviour; You'll need 1b689a95ce742 to fix that problem. Guenter
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/13/2018 01:36 AM, Greg Kroah-Hartman wrote: On Sat, Feb 10, 2018 at 07:46:50AM -0800, Guenter Roeck wrote: On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.81 release. There are 92 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Feb 11 13:39:04 UTC 2018. Anything received after that time might be too late. Build results: total: 145 pass: 140 fail: 5 Failed builds: powerpc:defconfig powerpc:allmodconfig powerpc:ppc64e_defconfig powerpc:cell_defconfig powerpc:maple_defconfig Qemu test results: total: 118 pass: 113 fail: 5 Failed tests: powerpc:mac99:ppc64_book3s_defconfig:nosmp powerpc:mac99:ppc64_book3s_defconfig:smp4 powerpc:pseries:pseries_defconfig powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp powerpc:mpc8544ds:ppc64_e5500_defconfig:smp All builds and tests fail with the following error. arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such file or directory For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow control of RFI flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. Thanks for letting me know, I've now fixed this up. Will go work on the 4.4 patch as well. Unfortunately it wasn't the only problem. Now we have: arch/powerpc/kernel/entry_64.S: Assembler messages: arch/powerpc/kernel/entry_64.S:260: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:270: Error: unrecognized opcode: `rfi_to_kernel' arch/powerpc/kernel/entry_64.S:885: Error: unrecognized opcode: `rfi_to_user' arch/powerpc/kernel/entry_64.S:900: Error: unrecognized opcode: `rfi_to_kernel' Looks like 222f20f140623 ("powerpc/64s: Simple RFI macro conversions") is missing, or at least part of it. Unfortunately it doesn't apply cleanly. 4.4 also now has a different failure. In file included from drivers/staging/rdma/ehca/hcp_if.c:45:0: arch/powerpc/include/asm/hvcall.h:439:2: error: unknown type name 'u64' u64 character; ^ arch/powerpc/include/asm/hvcall.h:440:2: error: unknown type name 'u64' u64 behaviour; You'll need 1b689a95ce742 to fix that problem. Guenter
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, Feb 10, 2018 at 07:46:50AM -0800, Guenter Roeck wrote: > On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.81 release. > > There are 92 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > > Anything received after that time might be too late. > > > > Build results: > total: 145 pass: 140 fail: 5 > Failed builds: > powerpc:defconfig > powerpc:allmodconfig > powerpc:ppc64e_defconfig > powerpc:cell_defconfig > powerpc:maple_defconfig > Qemu test results: > total: 118 pass: 113 fail: 5 > Failed tests: > powerpc:mac99:ppc64_book3s_defconfig:nosmp > powerpc:mac99:ppc64_book3s_defconfig:smp4 > powerpc:pseries:pseries_defconfig > powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp > powerpc:mpc8544ds:ppc64_e5500_defconfig:smp > > All builds and tests fail with the following error. > > arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such > file or directory > > For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow > control of RFI > flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. Thanks for letting me know, I've now fixed this up. Will go work on the 4.4 patch as well. greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Sat, Feb 10, 2018 at 07:46:50AM -0800, Guenter Roeck wrote: > On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.81 release. > > There are 92 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > > Anything received after that time might be too late. > > > > Build results: > total: 145 pass: 140 fail: 5 > Failed builds: > powerpc:defconfig > powerpc:allmodconfig > powerpc:ppc64e_defconfig > powerpc:cell_defconfig > powerpc:maple_defconfig > Qemu test results: > total: 118 pass: 113 fail: 5 > Failed tests: > powerpc:mac99:ppc64_book3s_defconfig:nosmp > powerpc:mac99:ppc64_book3s_defconfig:smp4 > powerpc:pseries:pseries_defconfig > powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp > powerpc:mpc8544ds:ppc64_e5500_defconfig:smp > > All builds and tests fail with the following error. > > arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such > file or directory > > For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow > control of RFI > flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. Thanks for letting me know, I've now fixed this up. Will go work on the 4.4 patch as well. greg k-h
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.81 release. There are 92 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Feb 11 13:39:04 UTC 2018. Anything received after that time might be too late. Build results: total: 145 pass: 140 fail: 5 Failed builds: powerpc:defconfig powerpc:allmodconfig powerpc:ppc64e_defconfig powerpc:cell_defconfig powerpc:maple_defconfig Qemu test results: total: 118 pass: 113 fail: 5 Failed tests: powerpc:mac99:ppc64_book3s_defconfig:nosmp powerpc:mac99:ppc64_book3s_defconfig:smp4 powerpc:pseries:pseries_defconfig powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp powerpc:mpc8544ds:ppc64_e5500_defconfig:smp All builds and tests fail with the following error. arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such file or directory For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow control of RFI flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. 4.4.y-queue is affected as well. Guenter
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/09/2018 05:38 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.81 release. There are 92 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sun Feb 11 13:39:04 UTC 2018. Anything received after that time might be too late. Build results: total: 145 pass: 140 fail: 5 Failed builds: powerpc:defconfig powerpc:allmodconfig powerpc:ppc64e_defconfig powerpc:cell_defconfig powerpc:maple_defconfig Qemu test results: total: 118 pass: 113 fail: 5 Failed tests: powerpc:mac99:ppc64_book3s_defconfig:nosmp powerpc:mac99:ppc64_book3s_defconfig:smp4 powerpc:pseries:pseries_defconfig powerpc:mpc8544ds:ppc64_e5500_defconfig:nosmp powerpc:mpc8544ds:ppc64_e5500_defconfig:smp All builds and tests fail with the following error. arch/powerpc/kernel/setup_64.c:41:25: fatal error: asm/debugfs.h: No such file or directory For older kernels, the backport of 236003e6b5443c4 ("powerpc/64s: Allow control of RFI flush via debugfs") should include linux/debugfs.h, not asm/debugfs.h. 4.4.y-queue is affected as well. Guenter
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Fri, Feb 09, 2018 at 02:38:29PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.81 release. > There are 92 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.81-rc1.gz > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. Results from Linaro’s test farm. No regressions on arm64, arm and x86_64. Summary kernel: 4.9.81-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.9.y git commit: d3dab8430a0720fba4183f6107d70edb373be852 git describe: v4.9.80-93-gd3dab8430a07 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.9-oe/build/v4.9.80-93-gd3dab8430a07 No regressions (compared to build v4.9.80-93-ga5ced8b8b31d) Boards, architectures and test suites: - hi6220-hikey - arm64 * boot - pass: 20 * kselftest - skip: 24, pass: 41 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - skip: 1, pass: 21 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 4, pass: 10 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 152, pass: 996 * ltp-timers-tests - skip: 1, pass: 12 juno-r2 - arm64 * boot - pass: 21 * kselftest - skip: 23, pass: 42 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - pass: 22 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 4, pass: 10 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 149, pass: 999 * ltp-timers-tests - skip: 1, pass: 12 x15 - arm * boot - pass: 20 * kselftest - skip: 25, pass: 39 * libhugetlbfs - skip: 1, pass: 87 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - skip: 2, pass: 20 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 1, pass: 13 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 97, pass: 1051 * ltp-timers-tests - skip: 1, pass: 12 x86_64 * boot - pass: 20 * kselftest - skip: 27, pass: 54 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 1, pass: 62 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - pass: 21 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 5, pass: 9 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 118, pass: 1030 * ltp-timers-tests - skip: 1, pass: 12 -- Linaro QA (beta) https://qa-reports.linaro.org
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On Fri, Feb 09, 2018 at 02:38:29PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.81 release. > There are 92 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.81-rc1.gz > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. Results from Linaro’s test farm. No regressions on arm64, arm and x86_64. Summary kernel: 4.9.81-rc1 git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git git branch: linux-4.9.y git commit: d3dab8430a0720fba4183f6107d70edb373be852 git describe: v4.9.80-93-gd3dab8430a07 Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.9-oe/build/v4.9.80-93-gd3dab8430a07 No regressions (compared to build v4.9.80-93-ga5ced8b8b31d) Boards, architectures and test suites: - hi6220-hikey - arm64 * boot - pass: 20 * kselftest - skip: 24, pass: 41 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - skip: 1, pass: 21 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 4, pass: 10 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 152, pass: 996 * ltp-timers-tests - skip: 1, pass: 12 juno-r2 - arm64 * boot - pass: 21 * kselftest - skip: 23, pass: 42 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - pass: 22 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 4, pass: 10 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 149, pass: 999 * ltp-timers-tests - skip: 1, pass: 12 x15 - arm * boot - pass: 20 * kselftest - skip: 25, pass: 39 * libhugetlbfs - skip: 1, pass: 87 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 2, pass: 61 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - skip: 2, pass: 20 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 1, pass: 13 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 97, pass: 1051 * ltp-timers-tests - skip: 1, pass: 12 x86_64 * boot - pass: 20 * kselftest - skip: 27, pass: 54 * libhugetlbfs - skip: 1, pass: 90 * ltp-cap_bounds-tests - pass: 2 * ltp-containers-tests - skip: 17, pass: 64 * ltp-fcntl-locktests-tests - pass: 2 * ltp-filecaps-tests - pass: 2 * ltp-fs-tests - skip: 1, pass: 62 * ltp-fs_bind-tests - pass: 2 * ltp-fs_perms_simple-tests - pass: 19 * ltp-fsx-tests - pass: 2 * ltp-hugetlb-tests - pass: 21 * ltp-io-tests - pass: 3 * ltp-ipc-tests - pass: 9 * ltp-math-tests - pass: 11 * ltp-nptl-tests - pass: 2 * ltp-pty-tests - pass: 4 * ltp-sched-tests - skip: 5, pass: 9 * ltp-securebits-tests - pass: 4 * ltp-syscalls-tests - fail: 2, skip: 118, pass: 1030 * ltp-timers-tests - skip: 1, pass: 12 -- Linaro QA (beta) https://qa-reports.linaro.org
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/09/2018 06:38 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.81 release. > There are 92 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.81-rc1.gz > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. > > thanks, > > greg k-h > Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah
Re: [PATCH 4.9 00/92] 4.9.81-stable review
On 02/09/2018 06:38 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.81 release. > There are 92 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun Feb 11 13:39:04 UTC 2018. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.9.81-rc1.gz > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > linux-4.9.y > and the diffstat can be found below. > > thanks, > > greg k-h > Compiled and booted on my test system. No dmesg regressions. thanks, -- Shuah