Re: [PATCH 5/5] drm/exynos: don't include plat/gpio-cfg.h

2013-01-31 Thread Rahul Sharma
Hi Arnd Bergmann,

It looks good to me. My patch caused this issue.
Thanks for the fix.

regards,
Rahul Sharma.

On Fri, Jan 25, 2013 at 8:58 PM, Arnd Bergmann  wrote:
> Patch  9eb3e9e6f3 "drm/exynos: add support for ARCH_MULTIPLATFORM"
> allowed building the exynos hdmi driver on non-samsung platforms,
> which unfortunately broke compilation in combination with 22c4f42897
> "drm: exynos: hdmi: add support for exynos5 hdmi", which added
> an inclusion of the samsung-specific plat/gpio-cfg.h header file.
>
> Fortunately, that header file is not required any more here, so
> we can simply revert the inclusion in order to build the ARM
> allyesconfig again without getting this error:
>
> drivers/gpu/drm/exynos/exynos_hdmi.c:37:27: fatal error: plat/gpio-cfg.h: No 
> such file or directory
>
> Signed-off-by: Arnd Bergmann 
> Cc: Rob Clark 
> Cc: Inki Dae 
> Cc: Kyungmin Park 
> Cc: Rahul Sharma 
> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c 
> b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 41ff79d..b5f5119 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -34,7 +34,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>
>  #include 
>
> --
> 1.8.0
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 5/5] drm/exynos: don't include plat/gpio-cfg.h

2013-01-31 Thread Rahul Sharma
Hi Arnd Bergmann,

It looks good to me. My patch caused this issue.
Thanks for the fix.

regards,
Rahul Sharma.

On Fri, Jan 25, 2013 at 8:58 PM, Arnd Bergmann a...@arndb.de wrote:
 Patch  9eb3e9e6f3 drm/exynos: add support for ARCH_MULTIPLATFORM
 allowed building the exynos hdmi driver on non-samsung platforms,
 which unfortunately broke compilation in combination with 22c4f42897
 drm: exynos: hdmi: add support for exynos5 hdmi, which added
 an inclusion of the samsung-specific plat/gpio-cfg.h header file.

 Fortunately, that header file is not required any more here, so
 we can simply revert the inclusion in order to build the ARM
 allyesconfig again without getting this error:

 drivers/gpu/drm/exynos/exynos_hdmi.c:37:27: fatal error: plat/gpio-cfg.h: No 
 such file or directory

 Signed-off-by: Arnd Bergmann a...@arndb.de
 Cc: Rob Clark r...@ti.com
 Cc: Inki Dae inki@samsung.com
 Cc: Kyungmin Park kyungmin.p...@samsung.com
 Cc: Rahul Sharma rahul.sha...@samsung.com
 ---
  drivers/gpu/drm/exynos/exynos_hdmi.c | 1 -
  1 file changed, 1 deletion(-)

 diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c 
 b/drivers/gpu/drm/exynos/exynos_hdmi.c
 index 41ff79d..b5f5119 100644
 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
 +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
 @@ -34,7 +34,6 @@
  #include linux/regulator/consumer.h
  #include linux/io.h
  #include linux/of_gpio.h
 -#include plat/gpio-cfg.h

  #include drm/exynos_drm.h

 --
 1.8.0


 ___
 linux-arm-kernel mailing list
 linux-arm-ker...@lists.infradead.org
 http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/