Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu
On 12/3/12 12:43 AM, Lars-Peter Clausen wrote: On 12/03/2012 09:28 AM, czankel wrote: Thanks Lars, I have added it to the Xtensa for_next tree. -Chris Hi, While the patch works standalone. It would be better if it'd go through the same tree as the other patches in this series. Patch 1 removes the unused vmlist field from the mm_context_t struct in asm-generic/mmu.h. So without that patch this patch basically doubles the size of your mm_context_t. OK, reverted it. Regarding the Xtensa patch, Acked-by: Chris Zankel Thanks, -Chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu
On 12/03/2012 09:28 AM, czankel wrote:
> Thanks Lars, I have added it to the Xtensa for_next tree.
>
> -Chris
Hi,
While the patch works standalone. It would be better if it'd go through the
same tree as the other patches in this series. Patch 1 removes the unused
vmlist field from the mm_context_t struct in asm-generic/mmu.h. So without that
patch this patch basically doubles the size of your mm_context_t.
- Lars
>
> On 11/1/12 3:24 AM, Lars-Peter Clausen wrote:
>> The nommu portion of mmu.h of the extensa platform is basically the
>> same as the
>> asm-generic mmu.h. So use it instead.
>>
>> Signed-off-by: Lars-Peter Clausen
>>
>> ---
>> Note, due to lack of toolchain, etc this patch is completely untested.
>> ---
>> arch/xtensa/include/asm/mmu.h |2 +-
>> arch/xtensa/include/asm/nommu.h |3 ---
>> 2 files changed, 1 insertions(+), 4 deletions(-)
>> delete mode 100644 arch/xtensa/include/asm/nommu.h
>>
>> diff --git a/arch/xtensa/include/asm/mmu.h
>> b/arch/xtensa/include/asm/mmu.h
>> index 04890d6..8554b2c 100644
>> --- a/arch/xtensa/include/asm/mmu.h
>> +++ b/arch/xtensa/include/asm/mmu.h
>> @@ -12,7 +12,7 @@
>> #define _XTENSA_MMU_H
>> #ifndef CONFIG_MMU
>> -#include
>> +#include
>> #else
>> /* Default "unsigned long" context */
>> diff --git a/arch/xtensa/include/asm/nommu.h
>> b/arch/xtensa/include/asm/nommu.h
>> deleted file mode 100644
>> index dce2c43..000
>> --- a/arch/xtensa/include/asm/nommu.h
>> +++ /dev/null
>> @@ -1,3 +0,0 @@
>> -typedef struct {
>> -unsigned long end_brk;
>> -} mm_context_t;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu
Thanks Lars, I have added it to the Xtensa for_next tree.
-Chris
On 11/1/12 3:24 AM, Lars-Peter Clausen wrote:
The nommu portion of mmu.h of the extensa platform is basically the same as the
asm-generic mmu.h. So use it instead.
Signed-off-by: Lars-Peter Clausen
---
Note, due to lack of toolchain, etc this patch is completely untested.
---
arch/xtensa/include/asm/mmu.h |2 +-
arch/xtensa/include/asm/nommu.h |3 ---
2 files changed, 1 insertions(+), 4 deletions(-)
delete mode 100644 arch/xtensa/include/asm/nommu.h
diff --git a/arch/xtensa/include/asm/mmu.h b/arch/xtensa/include/asm/mmu.h
index 04890d6..8554b2c 100644
--- a/arch/xtensa/include/asm/mmu.h
+++ b/arch/xtensa/include/asm/mmu.h
@@ -12,7 +12,7 @@
#define _XTENSA_MMU_H
#ifndef CONFIG_MMU
-#include
+#include
#else
/* Default "unsigned long" context */
diff --git a/arch/xtensa/include/asm/nommu.h b/arch/xtensa/include/asm/nommu.h
deleted file mode 100644
index dce2c43..000
--- a/arch/xtensa/include/asm/nommu.h
+++ /dev/null
@@ -1,3 +0,0 @@
-typedef struct {
- unsigned long end_brk;
-} mm_context_t;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu
Thanks Lars, I have added it to the Xtensa for_next tree.
-Chris
On 11/1/12 3:24 AM, Lars-Peter Clausen wrote:
The nommu portion of mmu.h of the extensa platform is basically the same as the
asm-generic mmu.h. So use it instead.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
---
Note, due to lack of toolchain, etc this patch is completely untested.
---
arch/xtensa/include/asm/mmu.h |2 +-
arch/xtensa/include/asm/nommu.h |3 ---
2 files changed, 1 insertions(+), 4 deletions(-)
delete mode 100644 arch/xtensa/include/asm/nommu.h
diff --git a/arch/xtensa/include/asm/mmu.h b/arch/xtensa/include/asm/mmu.h
index 04890d6..8554b2c 100644
--- a/arch/xtensa/include/asm/mmu.h
+++ b/arch/xtensa/include/asm/mmu.h
@@ -12,7 +12,7 @@
#define _XTENSA_MMU_H
#ifndef CONFIG_MMU
-#include asm/nommu.h
+#include asm-generic/mmu.h
#else
/* Default unsigned long context */
diff --git a/arch/xtensa/include/asm/nommu.h b/arch/xtensa/include/asm/nommu.h
deleted file mode 100644
index dce2c43..000
--- a/arch/xtensa/include/asm/nommu.h
+++ /dev/null
@@ -1,3 +0,0 @@
-typedef struct {
- unsigned long end_brk;
-} mm_context_t;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu
On 12/03/2012 09:28 AM, czankel wrote:
Thanks Lars, I have added it to the Xtensa for_next tree.
-Chris
Hi,
While the patch works standalone. It would be better if it'd go through the
same tree as the other patches in this series. Patch 1 removes the unused
vmlist field from the mm_context_t struct in asm-generic/mmu.h. So without that
patch this patch basically doubles the size of your mm_context_t.
- Lars
On 11/1/12 3:24 AM, Lars-Peter Clausen wrote:
The nommu portion of mmu.h of the extensa platform is basically the
same as the
asm-generic mmu.h. So use it instead.
Signed-off-by: Lars-Peter Clausen l...@metafoo.de
---
Note, due to lack of toolchain, etc this patch is completely untested.
---
arch/xtensa/include/asm/mmu.h |2 +-
arch/xtensa/include/asm/nommu.h |3 ---
2 files changed, 1 insertions(+), 4 deletions(-)
delete mode 100644 arch/xtensa/include/asm/nommu.h
diff --git a/arch/xtensa/include/asm/mmu.h
b/arch/xtensa/include/asm/mmu.h
index 04890d6..8554b2c 100644
--- a/arch/xtensa/include/asm/mmu.h
+++ b/arch/xtensa/include/asm/mmu.h
@@ -12,7 +12,7 @@
#define _XTENSA_MMU_H
#ifndef CONFIG_MMU
-#include asm/nommu.h
+#include asm-generic/mmu.h
#else
/* Default unsigned long context */
diff --git a/arch/xtensa/include/asm/nommu.h
b/arch/xtensa/include/asm/nommu.h
deleted file mode 100644
index dce2c43..000
--- a/arch/xtensa/include/asm/nommu.h
+++ /dev/null
@@ -1,3 +0,0 @@
-typedef struct {
-unsigned long end_brk;
-} mm_context_t;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu
On 12/3/12 12:43 AM, Lars-Peter Clausen wrote: On 12/03/2012 09:28 AM, czankel wrote: Thanks Lars, I have added it to the Xtensa for_next tree. -Chris Hi, While the patch works standalone. It would be better if it'd go through the same tree as the other patches in this series. Patch 1 removes the unused vmlist field from the mm_context_t struct in asm-generic/mmu.h. So without that patch this patch basically doubles the size of your mm_context_t. OK, reverted it. Regarding the Xtensa patch, Acked-by: Chris Zankel ch...@zankel.net Thanks, -Chris -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
