Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
On Mon, Oct 19, 2020 at 09:19:33AM -0400, Mathieu Desnoyers wrote: - On Oct 18, 2020, at 9:40 PM, David Ahern dsah...@gmail.com wrote: On 10/18/20 1:40 PM, Jakub Kicinski wrote: This one got applied a few days ago, and the urgency is low so it may be worth letting it see at least one -rc release ;) agreed Likewise, I agree there is no need to hurry. Letting those patches live through a few -rc releases before picking them into stable is a wise course of action. That's fair, and I've moved this patch into a different queue to make it go out later. -- Thanks, Sasha
Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
On Mon, Oct 19, 2020 at 08:33:27AM -0700, Jakub Kicinski wrote: On Mon, 19 Oct 2020 07:52:36 -0400 Sasha Levin wrote: On Sun, Oct 18, 2020 at 07:40:12PM -0600, David Ahern wrote: >On 10/18/20 1:40 PM, Jakub Kicinski wrote: >> This one got applied a few days ago, and the urgency is low so it may be >> worth letting it see at least one -rc release ;) > >agreed Definitely - AUTOSEL patches get extra soaking time before getting queued up. This is more of a request to make sure it's not doing anything silly. Could you put a number on "extra soaking time"? I'm asking mostly out of curiosity :) The AUTOSEL process adds at least another week into the flow, this means that the fastest this patch will go in into a released kernel is about 2 weeks from now. -- Thanks, Sasha
Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
On Mon, 19 Oct 2020 07:52:36 -0400 Sasha Levin wrote: > On Sun, Oct 18, 2020 at 07:40:12PM -0600, David Ahern wrote: > >On 10/18/20 1:40 PM, Jakub Kicinski wrote: > >> This one got applied a few days ago, and the urgency is low so it may be > >> worth letting it see at least one -rc release ;) > > > >agreed > > Definitely - AUTOSEL patches get extra soaking time before getting > queued up. This is more of a request to make sure it's not doing > anything silly. Could you put a number on "extra soaking time"? I'm asking mostly out of curiosity :)
Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
- On Oct 18, 2020, at 9:40 PM, David Ahern dsah...@gmail.com wrote: > On 10/18/20 1:40 PM, Jakub Kicinski wrote: >> This one got applied a few days ago, and the urgency is low so it may be >> worth letting it see at least one -rc release ;) > > agreed Likewise, I agree there is no need to hurry. Letting those patches live through a few -rc releases before picking them into stable is a wise course of action. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
On Sun, Oct 18, 2020 at 07:40:12PM -0600, David Ahern wrote: On 10/18/20 1:40 PM, Jakub Kicinski wrote: This one got applied a few days ago, and the urgency is low so it may be worth letting it see at least one -rc release ;) agreed Definitely - AUTOSEL patches get extra soaking time before getting queued up. This is more of a request to make sure it's not doing anything silly. -- Thanks, Sasha
Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
On 10/18/20 1:40 PM, Jakub Kicinski wrote: > This one got applied a few days ago, and the urgency is low so it may be > worth letting it see at least one -rc release ;) agreed
Re: [PATCH AUTOSEL 5.9 035/111] ipv6/icmp: l3mdev: Perform icmp error route lookup on source device routing table (v2)
On Sun, 18 Oct 2020 15:16:51 -0400 Sasha Levin wrote: > From: Mathieu Desnoyers > > [ Upstream commit 272928d1cdacfc3b55f605cb0e9115832ecfb20c ] > > As per RFC4443, the destination address field for ICMPv6 error messages > is copied from the source address field of the invoking packet. > > In configurations with Virtual Routing and Forwarding tables, looking up > which routing table to use for sending ICMPv6 error messages is > currently done by using the destination net_device. This one got applied a few days ago, and the urgency is low so it may be worth letting it see at least one -rc release ;) Maybe Mathieu & David feel differently.
