Re: [PATCH V2] video : remove redundant error check
Hi,
2014-08-26 19:34 GMT+09:00 Tomi Valkeinen :
> On 16/05/14 12:31, Daeseok Youn wrote:
>> It doesn't need to check "err" for printing info.
>> And also use pr_info instead of printk.
>>
>> Signed-off-by: Daeseok Youn
>> ---
>> V2: removes unneeded lines for sending a patch
>>
>> drivers/video/fbdev/i810/i810_main.c |7 +++
>> 1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/i810/i810_main.c
>> b/drivers/video/fbdev/i810/i810_main.c
>> index bb674e4..15cb397 100644
>> --- a/drivers/video/fbdev/i810/i810_main.c
>> +++ b/drivers/video/fbdev/i810/i810_main.c
>> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info
>> *info)
>>
>> for (i = 0; i < par->ddc_num + 1; i++) {
>> err = i810_probe_i2c_connector(info, >edid, i);
>> - if (!err)
>> + if (!err) {
>> + pr_info("i810fb_init_pci: DDC probe successful\n");
>> break;
>> + }
>> }
>>
>> - if (!err)
>> - printk("i810fb_init_pci: DDC probe successful\n");
>> -
>> fb_edid_to_monspecs(par->edid, specs);
>>
>> if (specs->modedb == NULL)
>>
>
> I don't know... I think I personally like more the original version. In
> fact, the whole print looks quite useless to me, or at least it should
> be a debug print.
Yes. this patch doesn't need.
Thanks for review.
regards,
Daeseok Youn.
>
> Tomi
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V2] video : remove redundant error check
Hi,
2014-08-26 19:34 GMT+09:00 Tomi Valkeinen tomi.valkei...@ti.com:
On 16/05/14 12:31, Daeseok Youn wrote:
It doesn't need to check err for printing info.
And also use pr_info instead of printk.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: removes unneeded lines for sending a patch
drivers/video/fbdev/i810/i810_main.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/i810/i810_main.c
b/drivers/video/fbdev/i810/i810_main.c
index bb674e4..15cb397 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info
*info)
for (i = 0; i par-ddc_num + 1; i++) {
err = i810_probe_i2c_connector(info, par-edid, i);
- if (!err)
+ if (!err) {
+ pr_info(i810fb_init_pci: DDC probe successful\n);
break;
+ }
}
- if (!err)
- printk(i810fb_init_pci: DDC probe successful\n);
-
fb_edid_to_monspecs(par-edid, specs);
if (specs-modedb == NULL)
I don't know... I think I personally like more the original version. In
fact, the whole print looks quite useless to me, or at least it should
be a debug print.
Yes. this patch doesn't need.
Thanks for review.
regards,
Daeseok Youn.
Tomi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH V2] video : remove redundant error check
On 16/05/14 12:31, Daeseok Youn wrote:
> It doesn't need to check "err" for printing info.
> And also use pr_info instead of printk.
>
> Signed-off-by: Daeseok Youn
> ---
> V2: removes unneeded lines for sending a patch
>
> drivers/video/fbdev/i810/i810_main.c |7 +++
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/i810/i810_main.c
> b/drivers/video/fbdev/i810/i810_main.c
> index bb674e4..15cb397 100644
> --- a/drivers/video/fbdev/i810/i810_main.c
> +++ b/drivers/video/fbdev/i810/i810_main.c
> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info
> *info)
>
> for (i = 0; i < par->ddc_num + 1; i++) {
> err = i810_probe_i2c_connector(info, >edid, i);
> - if (!err)
> + if (!err) {
> + pr_info("i810fb_init_pci: DDC probe successful\n");
> break;
> + }
> }
>
> - if (!err)
> - printk("i810fb_init_pci: DDC probe successful\n");
> -
> fb_edid_to_monspecs(par->edid, specs);
>
> if (specs->modedb == NULL)
>
I don't know... I think I personally like more the original version. In
fact, the whole print looks quite useless to me, or at least it should
be a debug print.
Tomi
signature.asc
Description: OpenPGP digital signature
Re: [PATCH V2] video : remove redundant error check
On 16/05/14 12:31, Daeseok Youn wrote:
It doesn't need to check err for printing info.
And also use pr_info instead of printk.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
---
V2: removes unneeded lines for sending a patch
drivers/video/fbdev/i810/i810_main.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/i810/i810_main.c
b/drivers/video/fbdev/i810/i810_main.c
index bb674e4..15cb397 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info
*info)
for (i = 0; i par-ddc_num + 1; i++) {
err = i810_probe_i2c_connector(info, par-edid, i);
- if (!err)
+ if (!err) {
+ pr_info(i810fb_init_pci: DDC probe successful\n);
break;
+ }
}
- if (!err)
- printk(i810fb_init_pci: DDC probe successful\n);
-
fb_edid_to_monspecs(par-edid, specs);
if (specs-modedb == NULL)
I don't know... I think I personally like more the original version. In
fact, the whole print looks quite useless to me, or at least it should
be a debug print.
Tomi
signature.asc
Description: OpenPGP digital signature
