Re: [PATCH V2 1/2] soc: qcom: aoss: Expose send for generic usecase
On Thu 08 Apr 23:39 CDT 2021, Deepak Kumar Singh wrote:
[..]
> +/**
> + * qmp_get() - get a qmp handle from a device
> + * @dev: client device pointer
> + *
> + * Return: handle to qmp device on success, ERR_PTR() on failure
> + */
> +struct qmp *qmp_get(struct device *dev)
> +{
> + struct platform_device *pdev;
> + struct device_node *np;
> + struct qmp *qmp;
> +
> + if (!dev || !dev->of_node)
> + return ERR_PTR(-EINVAL);
> +
> + np = of_parse_phandle(dev->of_node, "qcom,qmp", 0);
> + if (!np)
> + return ERR_PTR(-ENODEV);
> +
> + pdev = of_find_device_by_node(np);
> + if (!pdev)
> + return ERR_PTR(-EINVAL);
> +
> + qmp = platform_get_drvdata(pdev);
> + return qmp ? qmp : ERR_PTR(-EPROBE_DEFER);
> +}
> +EXPORT_SYMBOL(qmp_get);
> +
> +void qmp_put(struct platform_device *pdev)
> +{
> + platform_device_put(pdev);
I was expecting that the devres allocated struct qmp would stick around
until the struct device's release callback came. As described in my
answer to Mani yesterday I was wrong.
As such you need to make sure that struct qmp stays around until
qmp_remove() and all qmp_put() calls has been made.
I presume a reasonable way to achieve this is to not use devm to
allocate our struct qmp, add a kref to the object. So this would have to
be a kref_put() on that instead of the platform_device_put() I asked you
to implement here.
Sorry about that.
The rest of the patch looks good.
Regards,
Bjorn
Re: [PATCH V2 1/2] soc: qcom: aoss: Expose send for generic usecase
Hi Deepak,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.12-rc6 next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Deepak-Kumar-Singh/soc-qcom-aoss-Expose-send-for-generic-usecase/20210409-124213
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
17e7124aad766b3f158943acb51467f86220afe9
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/57a0c1a28e094b79cd975f60f759cf9c00bc7d62
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Deepak-Kumar-Singh/soc-qcom-aoss-Expose-send-for-generic-usecase/20210409-124213
git checkout 57a0c1a28e094b79cd975f60f759cf9c00bc7d62
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> drivers/soc/qcom/qcom_aoss.c:557:6: warning: no previous prototype for
>> 'qmp_put' [-Wmissing-prototypes]
557 | void qmp_put(struct platform_device *pdev)
| ^~~
vim +/qmp_put +557 drivers/soc/qcom/qcom_aoss.c
556
> 557 void qmp_put(struct platform_device *pdev)
558 {
559 platform_device_put(pdev);
560 }
561 EXPORT_SYMBOL(qmp_put);
562
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
