Re: [PATCH V2 3/9] x86/jump_label: Move checking code away from __jump_label_transform()

2018-12-19 Thread Daniel Bristot de Oliveira 
On 12/19/18 9:49 AM, Thomas Gleixner wrote:
> On Wed, 19 Dec 2018, Jiri Kosina wrote:
> 
>> On Tue, 18 Dec 2018, Daniel Bristot de Oliveira wrote:
>>
>>> This patch creates a new functions 
>>
>> I am not a native speaker, but this doesn't sound like proper english to 
>> me.
> 
> Aside of that 'This patch' is wrong to begin with. See Documentation/process/
> 

I will address these errors in the next version.

Thanks.

-- Daniel

Re: [PATCH V2 3/9] x86/jump_label: Move checking code away from __jump_label_transform()

2018-12-19 Thread Thomas Gleixner 
On Wed, 19 Dec 2018, Jiri Kosina wrote:

> On Tue, 18 Dec 2018, Daniel Bristot de Oliveira wrote:
> 
> > This patch creates a new functions 
> 
> I am not a native speaker, but this doesn't sound like proper english to 
> me.

Aside of that 'This patch' is wrong to begin with. See Documentation/process/

Re: [PATCH V2 3/9] x86/jump_label: Move checking code away from __jump_label_transform()

2018-12-19 Thread Jiri Kosina 
On Tue, 18 Dec 2018, Daniel Bristot de Oliveira wrote:

> This patch creates a new functions 

I am not a native speaker, but this doesn't sound like proper english to 
me.

> to check the current code before updating a jump_entry.

It should also be stated that this is equivalent code transformation, I 
think.

Thanks,

-- 
Jiri Kosina
SUSE Labs