subject:"Re\: \[PATCH V7 1\/8\] ACPI\: I\/O Remapping Table \(IORT\) initial support"

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-07-26 Thread Marc Zyngier

On Tue, 26 Jul 2016 09:19:15 -0400
Christopher Covington  wrote:

Hi Christopher,

> Hi Marc,
> 
> On 06/22/2016 09:34 PM, Hanjun Guo wrote:
> > On 2016/6/22 22:51, Marc Zyngier wrote:  
> >> On 22/06/16 14:52, Tomasz Nowicki wrote:  
> >>> On 22.06.2016 15:25, Marc Zyngier wrote:  
>  On 22/06/16 13:35, Tomasz Nowicki wrote:  
> > IORT shows representation of IO topology for ARM based systems.
> > It describes how various components are connected together on
> > parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> > http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
> >
> > Initial support allows to detect IORT table presence and save its
> > root pointer obtained through acpi_get_table(). The pointer validity
> > depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> > is not set while using IORT nodes we would dereference unmapped 
> > pointers.
> >
> > For the aforementioned reason call iort_table_detect() from acpi_init()
> > which guarantees acpi_gbl_permanent_mmap to be set at that point.
> >
> > Add generic helpers which are helpful for scanning and retrieving
> > information from IORT table content. List of the most important helpers:
> > - iort_find_dev_node() finds IORT node for a given device
> > - iort_node_map_rid() maps device RID and returns IORT node which 
> > provides
> >final translation
> >
> > Signed-off-by: Tomasz Nowicki 
> > ---
> >   drivers/acpi/Kconfig  |   3 +
> >   drivers/acpi/Makefile |   1 +
> >   drivers/acpi/bus.c|   2 +
> >   drivers/acpi/iort.c   | 217 
> > ++
> >   include/linux/iort.h  |  30 +++
> >   5 files changed, 253 insertions(+)
> >   create mode 100644 drivers/acpi/iort.c
> >   create mode 100644 include/linux/iort.h  
> 
> > I tracked Marc's tree on git.kernel.org, it's  acpi_os_free(buffer.pointer) 
> > there so
> > my worry is gone :)  
> 
> Do you plan on submitting this during the 4.8 merge window?

Short of having received the necessary Ack from the ACPI maintainer,
the answer is unfortunately negative. I'm hoping that the new split
ACPI maintenance between generic code and arm64 will help getting
things moving for 4.9.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny.

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-07-26 Thread Marc Zyngier

On Tue, 26 Jul 2016 09:19:15 -0400
Christopher Covington  wrote:

Hi Christopher,

> Hi Marc,
> 
> On 06/22/2016 09:34 PM, Hanjun Guo wrote:
> > On 2016/6/22 22:51, Marc Zyngier wrote:  
> >> On 22/06/16 14:52, Tomasz Nowicki wrote:  
> >>> On 22.06.2016 15:25, Marc Zyngier wrote:  
>  On 22/06/16 13:35, Tomasz Nowicki wrote:  
> > IORT shows representation of IO topology for ARM based systems.
> > It describes how various components are connected together on
> > parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> > http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
> >
> > Initial support allows to detect IORT table presence and save its
> > root pointer obtained through acpi_get_table(). The pointer validity
> > depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> > is not set while using IORT nodes we would dereference unmapped 
> > pointers.
> >
> > For the aforementioned reason call iort_table_detect() from acpi_init()
> > which guarantees acpi_gbl_permanent_mmap to be set at that point.
> >
> > Add generic helpers which are helpful for scanning and retrieving
> > information from IORT table content. List of the most important helpers:
> > - iort_find_dev_node() finds IORT node for a given device
> > - iort_node_map_rid() maps device RID and returns IORT node which 
> > provides
> >final translation
> >
> > Signed-off-by: Tomasz Nowicki 
> > ---
> >   drivers/acpi/Kconfig  |   3 +
> >   drivers/acpi/Makefile |   1 +
> >   drivers/acpi/bus.c|   2 +
> >   drivers/acpi/iort.c   | 217 
> > ++
> >   include/linux/iort.h  |  30 +++
> >   5 files changed, 253 insertions(+)
> >   create mode 100644 drivers/acpi/iort.c
> >   create mode 100644 include/linux/iort.h  
> 
> > I tracked Marc's tree on git.kernel.org, it's  acpi_os_free(buffer.pointer) 
> > there so
> > my worry is gone :)  
> 
> Do you plan on submitting this during the 4.8 merge window?

Short of having received the necessary Ack from the ACPI maintainer,
the answer is unfortunately negative. I'm hoping that the new split
ACPI maintenance between generic code and arm64 will help getting
things moving for 4.9.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny.

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-07-26 Thread Christopher Covington

Hi Marc,

On 06/22/2016 09:34 PM, Hanjun Guo wrote:
> On 2016/6/22 22:51, Marc Zyngier wrote:
>> On 22/06/16 14:52, Tomasz Nowicki wrote:
>>> On 22.06.2016 15:25, Marc Zyngier wrote:
 On 22/06/16 13:35, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
>
> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.
>
> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.
>
> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>final translation
>
> Signed-off-by: Tomasz Nowicki 
> ---
>   drivers/acpi/Kconfig  |   3 +
>   drivers/acpi/Makefile |   1 +
>   drivers/acpi/bus.c|   2 +
>   drivers/acpi/iort.c   | 217 
> ++
>   include/linux/iort.h  |  30 +++
>   5 files changed, 253 insertions(+)
>   create mode 100644 drivers/acpi/iort.c
>   create mode 100644 include/linux/iort.h

> I tracked Marc's tree on git.kernel.org, it's  acpi_os_free(buffer.pointer) 
> there so
> my worry is gone :)

Do you plan on submitting this during the 4.8 merge window?

Thanks,
Cov

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code
Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-07-26 Thread Christopher Covington

Hi Marc,

On 06/22/2016 09:34 PM, Hanjun Guo wrote:
> On 2016/6/22 22:51, Marc Zyngier wrote:
>> On 22/06/16 14:52, Tomasz Nowicki wrote:
>>> On 22.06.2016 15:25, Marc Zyngier wrote:
 On 22/06/16 13:35, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
>
> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.
>
> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.
>
> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>final translation
>
> Signed-off-by: Tomasz Nowicki 
> ---
>   drivers/acpi/Kconfig  |   3 +
>   drivers/acpi/Makefile |   1 +
>   drivers/acpi/bus.c|   2 +
>   drivers/acpi/iort.c   | 217 
> ++
>   include/linux/iort.h  |  30 +++
>   5 files changed, 253 insertions(+)
>   create mode 100644 drivers/acpi/iort.c
>   create mode 100644 include/linux/iort.h

> I tracked Marc's tree on git.kernel.org, it's  acpi_os_free(buffer.pointer) 
> there so
> my worry is gone :)

Do you plan on submitting this during the 4.8 merge window?

Thanks,
Cov

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code
Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Hanjun Guo

On 2016/6/22 22:51, Marc Zyngier wrote:
> On 22/06/16 14:52, Tomasz Nowicki wrote:
>> On 22.06.2016 15:25, Marc Zyngier wrote:
>>> On 22/06/16 13:35, Tomasz Nowicki wrote:
 IORT shows representation of IO topology for ARM based systems.
 It describes how various components are connected together on
 parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
 http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf

 Initial support allows to detect IORT table presence and save its
 root pointer obtained through acpi_get_table(). The pointer validity
 depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
 is not set while using IORT nodes we would dereference unmapped pointers.

 For the aforementioned reason call iort_table_detect() from acpi_init()
 which guarantees acpi_gbl_permanent_mmap to be set at that point.

 Add generic helpers which are helpful for scanning and retrieving
 information from IORT table content. List of the most important helpers:
 - iort_find_dev_node() finds IORT node for a given device
 - iort_node_map_rid() maps device RID and returns IORT node which provides
final translation

 Signed-off-by: Tomasz Nowicki 
 ---
   drivers/acpi/Kconfig  |   3 +
   drivers/acpi/Makefile |   1 +
   drivers/acpi/bus.c|   2 +
   drivers/acpi/iort.c   | 217 
 ++
   include/linux/iort.h  |  30 +++
   5 files changed, 253 insertions(+)
   create mode 100644 drivers/acpi/iort.c
   create mode 100644 include/linux/iort.h

 diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
 index b7e2e77..848471f 100644
 --- a/drivers/acpi/Kconfig
 +++ b/drivers/acpi/Kconfig
 @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
   config ACPI_CCA_REQUIRED
bool

 +config IORT_TABLE
 +  bool
 +
   config ACPI_DEBUGGER
bool "AML debugger interface"
select ACPI_DEBUG
 diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
 index 251ce85..c7c9b29 100644
 --- a/drivers/acpi/Makefile
 +++ b/drivers/acpi/Makefile
 @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
   obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
   obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
   obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
 +obj-$(CONFIG_IORT_TABLE)  += iort.o

   # processor has its own "processor." module_param namespace
   processor-y  := processor_driver.o
 diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
 index 31e8da6..176c17d 100644
 --- a/drivers/acpi/bus.c
 +++ b/drivers/acpi/bus.c
 @@ -33,6 +33,7 @@
   #ifdef CONFIG_X86
   #include 
   #endif
 +#include 
   #include 
   #include 
   #include 
 @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
}

pci_mmcfg_late_init();
 +  iort_table_detect();
acpi_scan_init();
acpi_ec_init();
acpi_debugfs_init();
 diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
 new file mode 100644
 index 000..fcfa008f
 --- /dev/null
 +++ b/drivers/acpi/iort.c
 @@ -0,0 +1,217 @@
 +/*
 + * Copyright (C) 2016, Semihalf
 + *Author: Tomasz Nowicki 
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms and conditions of the GNU General Public License,
 + * version 2, as published by the Free Software Foundation.
 + *
 + * This program is distributed in the hope it will be useful, but WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License 
 for
 + * more details.
 + *
 + * This file implements early detection/parsing of I/O mapping
 + * reported to OS through firmware via I/O Remapping Table (IORT)
 + * IORT document number: ARM DEN 0049A
 + */
 +
 +#define pr_fmt(fmt)   "ACPI: IORT: " fmt
 +
 +#include 
 +#include 
 +#include 
 +
 +typedef acpi_status (*iort_find_node_callback)
 +  (struct acpi_iort_node *node, void *context);
 +
 +/* Root pointer to the mapped IORT table */
 +static struct acpi_table_header *iort_table;
 +
 +static struct acpi_iort_node *
 +iort_scan_node(enum acpi_iort_node_type type,
 + iort_find_node_callback callback, void *context)
 +{
 +  struct acpi_iort_node *iort_node, *iort_end;
 +  struct acpi_table_iort *iort;
 +  int i;
 +
 +  /* Get the first IORT node */
 +  iort = (struct acpi_table_iort *)iort_table;
 +  iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
 +

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Hanjun Guo

On 2016/6/22 22:51, Marc Zyngier wrote:
> On 22/06/16 14:52, Tomasz Nowicki wrote:
>> On 22.06.2016 15:25, Marc Zyngier wrote:
>>> On 22/06/16 13:35, Tomasz Nowicki wrote:
 IORT shows representation of IO topology for ARM based systems.
 It describes how various components are connected together on
 parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
 http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf

 Initial support allows to detect IORT table presence and save its
 root pointer obtained through acpi_get_table(). The pointer validity
 depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
 is not set while using IORT nodes we would dereference unmapped pointers.

 For the aforementioned reason call iort_table_detect() from acpi_init()
 which guarantees acpi_gbl_permanent_mmap to be set at that point.

 Add generic helpers which are helpful for scanning and retrieving
 information from IORT table content. List of the most important helpers:
 - iort_find_dev_node() finds IORT node for a given device
 - iort_node_map_rid() maps device RID and returns IORT node which provides
final translation

 Signed-off-by: Tomasz Nowicki 
 ---
   drivers/acpi/Kconfig  |   3 +
   drivers/acpi/Makefile |   1 +
   drivers/acpi/bus.c|   2 +
   drivers/acpi/iort.c   | 217 
 ++
   include/linux/iort.h  |  30 +++
   5 files changed, 253 insertions(+)
   create mode 100644 drivers/acpi/iort.c
   create mode 100644 include/linux/iort.h

 diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
 index b7e2e77..848471f 100644
 --- a/drivers/acpi/Kconfig
 +++ b/drivers/acpi/Kconfig
 @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
   config ACPI_CCA_REQUIRED
bool

 +config IORT_TABLE
 +  bool
 +
   config ACPI_DEBUGGER
bool "AML debugger interface"
select ACPI_DEBUG
 diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
 index 251ce85..c7c9b29 100644
 --- a/drivers/acpi/Makefile
 +++ b/drivers/acpi/Makefile
 @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
   obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
   obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
   obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
 +obj-$(CONFIG_IORT_TABLE)  += iort.o

   # processor has its own "processor." module_param namespace
   processor-y  := processor_driver.o
 diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
 index 31e8da6..176c17d 100644
 --- a/drivers/acpi/bus.c
 +++ b/drivers/acpi/bus.c
 @@ -33,6 +33,7 @@
   #ifdef CONFIG_X86
   #include 
   #endif
 +#include 
   #include 
   #include 
   #include 
 @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
}

pci_mmcfg_late_init();
 +  iort_table_detect();
acpi_scan_init();
acpi_ec_init();
acpi_debugfs_init();
 diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
 new file mode 100644
 index 000..fcfa008f
 --- /dev/null
 +++ b/drivers/acpi/iort.c
 @@ -0,0 +1,217 @@
 +/*
 + * Copyright (C) 2016, Semihalf
 + *Author: Tomasz Nowicki 
 + *
 + * This program is free software; you can redistribute it and/or modify it
 + * under the terms and conditions of the GNU General Public License,
 + * version 2, as published by the Free Software Foundation.
 + *
 + * This program is distributed in the hope it will be useful, but WITHOUT
 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License 
 for
 + * more details.
 + *
 + * This file implements early detection/parsing of I/O mapping
 + * reported to OS through firmware via I/O Remapping Table (IORT)
 + * IORT document number: ARM DEN 0049A
 + */
 +
 +#define pr_fmt(fmt)   "ACPI: IORT: " fmt
 +
 +#include 
 +#include 
 +#include 
 +
 +typedef acpi_status (*iort_find_node_callback)
 +  (struct acpi_iort_node *node, void *context);
 +
 +/* Root pointer to the mapped IORT table */
 +static struct acpi_table_header *iort_table;
 +
 +static struct acpi_iort_node *
 +iort_scan_node(enum acpi_iort_node_type type,
 + iort_find_node_callback callback, void *context)
 +{
 +  struct acpi_iort_node *iort_node, *iort_end;
 +  struct acpi_table_iort *iort;
 +  int i;
 +
 +  /* Get the first IORT node */
 +  iort = (struct acpi_table_iort *)iort_table;
 +  iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
 +

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 22/06/16 14:52, Tomasz Nowicki wrote:
> On 22.06.2016 15:25, Marc Zyngier wrote:
>> On 22/06/16 13:35, Tomasz Nowicki wrote:
>>> IORT shows representation of IO topology for ARM based systems.
>>> It describes how various components are connected together on
>>> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
>>> http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
>>>
>>> Initial support allows to detect IORT table presence and save its
>>> root pointer obtained through acpi_get_table(). The pointer validity
>>> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
>>> is not set while using IORT nodes we would dereference unmapped pointers.
>>>
>>> For the aforementioned reason call iort_table_detect() from acpi_init()
>>> which guarantees acpi_gbl_permanent_mmap to be set at that point.
>>>
>>> Add generic helpers which are helpful for scanning and retrieving
>>> information from IORT table content. List of the most important helpers:
>>> - iort_find_dev_node() finds IORT node for a given device
>>> - iort_node_map_rid() maps device RID and returns IORT node which provides
>>>final translation
>>>
>>> Signed-off-by: Tomasz Nowicki 
>>> ---
>>>   drivers/acpi/Kconfig  |   3 +
>>>   drivers/acpi/Makefile |   1 +
>>>   drivers/acpi/bus.c|   2 +
>>>   drivers/acpi/iort.c   | 217 
>>> ++
>>>   include/linux/iort.h  |  30 +++
>>>   5 files changed, 253 insertions(+)
>>>   create mode 100644 drivers/acpi/iort.c
>>>   create mode 100644 include/linux/iort.h
>>>
>>> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
>>> index b7e2e77..848471f 100644
>>> --- a/drivers/acpi/Kconfig
>>> +++ b/drivers/acpi/Kconfig
>>> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>>>   config ACPI_CCA_REQUIRED
>>> bool
>>>
>>> +config IORT_TABLE
>>> +   bool
>>> +
>>>   config ACPI_DEBUGGER
>>> bool "AML debugger interface"
>>> select ACPI_DEBUG
>>> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
>>> index 251ce85..c7c9b29 100644
>>> --- a/drivers/acpi/Makefile
>>> +++ b/drivers/acpi/Makefile
>>> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>>>   obj-$(CONFIG_ACPI_BGRT)   += bgrt.o
>>>   obj-$(CONFIG_ACPI_CPPC_LIB)   += cppc_acpi.o
>>>   obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
>>> +obj-$(CONFIG_IORT_TABLE)   += iort.o
>>>
>>>   # processor has its own "processor." module_param namespace
>>>   processor-y   := processor_driver.o
>>> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
>>> index 31e8da6..176c17d 100644
>>> --- a/drivers/acpi/bus.c
>>> +++ b/drivers/acpi/bus.c
>>> @@ -33,6 +33,7 @@
>>>   #ifdef CONFIG_X86
>>>   #include 
>>>   #endif
>>> +#include 
>>>   #include 
>>>   #include 
>>>   #include 
>>> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>>> }
>>>
>>> pci_mmcfg_late_init();
>>> +   iort_table_detect();
>>> acpi_scan_init();
>>> acpi_ec_init();
>>> acpi_debugfs_init();
>>> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
>>> new file mode 100644
>>> index 000..fcfa008f
>>> --- /dev/null
>>> +++ b/drivers/acpi/iort.c
>>> @@ -0,0 +1,217 @@
>>> +/*
>>> + * Copyright (C) 2016, Semihalf
>>> + * Author: Tomasz Nowicki 
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify it
>>> + * under the terms and conditions of the GNU General Public License,
>>> + * version 2, as published by the Free Software Foundation.
>>> + *
>>> + * This program is distributed in the hope it will be useful, but WITHOUT
>>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>>> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License 
>>> for
>>> + * more details.
>>> + *
>>> + * This file implements early detection/parsing of I/O mapping
>>> + * reported to OS through firmware via I/O Remapping Table (IORT)
>>> + * IORT document number: ARM DEN 0049A
>>> + */
>>> +
>>> +#define pr_fmt(fmt)"ACPI: IORT: " fmt
>>> +
>>> +#include 
>>> +#include 
>>> +#include 
>>> +
>>> +typedef acpi_status (*iort_find_node_callback)
>>> +   (struct acpi_iort_node *node, void *context);
>>> +
>>> +/* Root pointer to the mapped IORT table */
>>> +static struct acpi_table_header *iort_table;
>>> +
>>> +static struct acpi_iort_node *
>>> +iort_scan_node(enum acpi_iort_node_type type,
>>> +  iort_find_node_callback callback, void *context)
>>> +{
>>> +   struct acpi_iort_node *iort_node, *iort_end;
>>> +   struct acpi_table_iort *iort;
>>> +   int i;
>>> +
>>> +   /* Get the first IORT node */
>>> +   iort = (struct acpi_table_iort *)iort_table;
>>> +   iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
>>> +iort->node_offset);
>>> +   iort_end = ACPI_ADD_PTR(struct acpi_iort_node, iort_table,
>>> +

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 22/06/16 14:52, Tomasz Nowicki wrote:
> On 22.06.2016 15:25, Marc Zyngier wrote:
>> On 22/06/16 13:35, Tomasz Nowicki wrote:
>>> IORT shows representation of IO topology for ARM based systems.
>>> It describes how various components are connected together on
>>> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
>>> http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
>>>
>>> Initial support allows to detect IORT table presence and save its
>>> root pointer obtained through acpi_get_table(). The pointer validity
>>> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
>>> is not set while using IORT nodes we would dereference unmapped pointers.
>>>
>>> For the aforementioned reason call iort_table_detect() from acpi_init()
>>> which guarantees acpi_gbl_permanent_mmap to be set at that point.
>>>
>>> Add generic helpers which are helpful for scanning and retrieving
>>> information from IORT table content. List of the most important helpers:
>>> - iort_find_dev_node() finds IORT node for a given device
>>> - iort_node_map_rid() maps device RID and returns IORT node which provides
>>>final translation
>>>
>>> Signed-off-by: Tomasz Nowicki 
>>> ---
>>>   drivers/acpi/Kconfig  |   3 +
>>>   drivers/acpi/Makefile |   1 +
>>>   drivers/acpi/bus.c|   2 +
>>>   drivers/acpi/iort.c   | 217 
>>> ++
>>>   include/linux/iort.h  |  30 +++
>>>   5 files changed, 253 insertions(+)
>>>   create mode 100644 drivers/acpi/iort.c
>>>   create mode 100644 include/linux/iort.h
>>>
>>> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
>>> index b7e2e77..848471f 100644
>>> --- a/drivers/acpi/Kconfig
>>> +++ b/drivers/acpi/Kconfig
>>> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>>>   config ACPI_CCA_REQUIRED
>>> bool
>>>
>>> +config IORT_TABLE
>>> +   bool
>>> +
>>>   config ACPI_DEBUGGER
>>> bool "AML debugger interface"
>>> select ACPI_DEBUG
>>> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
>>> index 251ce85..c7c9b29 100644
>>> --- a/drivers/acpi/Makefile
>>> +++ b/drivers/acpi/Makefile
>>> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>>>   obj-$(CONFIG_ACPI_BGRT)   += bgrt.o
>>>   obj-$(CONFIG_ACPI_CPPC_LIB)   += cppc_acpi.o
>>>   obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
>>> +obj-$(CONFIG_IORT_TABLE)   += iort.o
>>>
>>>   # processor has its own "processor." module_param namespace
>>>   processor-y   := processor_driver.o
>>> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
>>> index 31e8da6..176c17d 100644
>>> --- a/drivers/acpi/bus.c
>>> +++ b/drivers/acpi/bus.c
>>> @@ -33,6 +33,7 @@
>>>   #ifdef CONFIG_X86
>>>   #include 
>>>   #endif
>>> +#include 
>>>   #include 
>>>   #include 
>>>   #include 
>>> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>>> }
>>>
>>> pci_mmcfg_late_init();
>>> +   iort_table_detect();
>>> acpi_scan_init();
>>> acpi_ec_init();
>>> acpi_debugfs_init();
>>> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
>>> new file mode 100644
>>> index 000..fcfa008f
>>> --- /dev/null
>>> +++ b/drivers/acpi/iort.c
>>> @@ -0,0 +1,217 @@
>>> +/*
>>> + * Copyright (C) 2016, Semihalf
>>> + * Author: Tomasz Nowicki 
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify it
>>> + * under the terms and conditions of the GNU General Public License,
>>> + * version 2, as published by the Free Software Foundation.
>>> + *
>>> + * This program is distributed in the hope it will be useful, but WITHOUT
>>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>>> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License 
>>> for
>>> + * more details.
>>> + *
>>> + * This file implements early detection/parsing of I/O mapping
>>> + * reported to OS through firmware via I/O Remapping Table (IORT)
>>> + * IORT document number: ARM DEN 0049A
>>> + */
>>> +
>>> +#define pr_fmt(fmt)"ACPI: IORT: " fmt
>>> +
>>> +#include 
>>> +#include 
>>> +#include 
>>> +
>>> +typedef acpi_status (*iort_find_node_callback)
>>> +   (struct acpi_iort_node *node, void *context);
>>> +
>>> +/* Root pointer to the mapped IORT table */
>>> +static struct acpi_table_header *iort_table;
>>> +
>>> +static struct acpi_iort_node *
>>> +iort_scan_node(enum acpi_iort_node_type type,
>>> +  iort_find_node_callback callback, void *context)
>>> +{
>>> +   struct acpi_iort_node *iort_node, *iort_end;
>>> +   struct acpi_table_iort *iort;
>>> +   int i;
>>> +
>>> +   /* Get the first IORT node */
>>> +   iort = (struct acpi_table_iort *)iort_table;
>>> +   iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
>>> +iort->node_offset);
>>> +   iort_end = ACPI_ADD_PTR(struct acpi_iort_node, iort_table,
>>> +   iort_table->length);
>>> +
>>> +   for (i = 0; i <

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Tomasz Nowicki


On 22.06.2016 15:25, Marc Zyngier wrote:

On 22/06/16 13:35, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
   final translation

Signed-off-by: Tomasz Nowicki 
---
  drivers/acpi/Kconfig  |   3 +
  drivers/acpi/Makefile |   1 +
  drivers/acpi/bus.c|   2 +
  drivers/acpi/iort.c   | 217 ++
  include/linux/iort.h  |  30 +++
  5 files changed, 253 insertions(+)
  create mode 100644 drivers/acpi/iort.c
  create mode 100644 include/linux/iort.h

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index b7e2e77..848471f 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
  config ACPI_CCA_REQUIRED
bool

+config IORT_TABLE
+   bool
+
  config ACPI_DEBUGGER
bool "AML debugger interface"
select ACPI_DEBUG
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 251ce85..c7c9b29 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
  obj-$(CONFIG_ACPI_BGRT)   += bgrt.o
  obj-$(CONFIG_ACPI_CPPC_LIB)   += cppc_acpi.o
  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
+obj-$(CONFIG_IORT_TABLE)   += iort.o

  # processor has its own "processor." module_param namespace
  processor-y   := processor_driver.o
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 31e8da6..176c17d 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -33,6 +33,7 @@
  #ifdef CONFIG_X86
  #include 
  #endif
+#include 
  #include 
  #include 
  #include 
@@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
}

pci_mmcfg_late_init();
+   iort_table_detect();
acpi_scan_init();
acpi_ec_init();
acpi_debugfs_init();
diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
new file mode 100644
index 000..fcfa008f
--- /dev/null
+++ b/drivers/acpi/iort.c
@@ -0,0 +1,217 @@
+/*
+ * Copyright (C) 2016, Semihalf
+ * Author: Tomasz Nowicki 
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * This file implements early detection/parsing of I/O mapping
+ * reported to OS through firmware via I/O Remapping Table (IORT)
+ * IORT document number: ARM DEN 0049A
+ */
+
+#define pr_fmt(fmt)"ACPI: IORT: " fmt
+
+#include 
+#include 
+#include 
+
+typedef acpi_status (*iort_find_node_callback)
+   (struct acpi_iort_node *node, void *context);
+
+/* Root pointer to the mapped IORT table */
+static struct acpi_table_header *iort_table;
+
+static struct acpi_iort_node *
+iort_scan_node(enum acpi_iort_node_type type,
+  iort_find_node_callback callback, void *context)
+{
+   struct acpi_iort_node *iort_node, *iort_end;
+   struct acpi_table_iort *iort;
+   int i;
+
+   /* Get the first IORT node */
+   iort = (struct acpi_table_iort *)iort_table;
+   iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
+iort->node_offset);
+   iort_end = ACPI_ADD_PTR(struct acpi_iort_node, iort_table,
+   iort_table->length);
+
+   for (i = 0; i < iort->node_count; i++) {
+   if (WARN_TAINT(iort_node >= iort_end, TAINT_FIRMWARE_WORKAROUND,
+  "IORT node pointer overflows, bad table!\n"))
+   return NULL;
+
+   if (iort_node->type == type) {
+   if (ACPI_SUCCESS(callback(iort_node, context)))
+   return iort_node;
+   }
+
+

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Tomasz Nowicki


On 22.06.2016 15:25, Marc Zyngier wrote:

On 22/06/16 13:35, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
   final translation

Signed-off-by: Tomasz Nowicki 
---
  drivers/acpi/Kconfig  |   3 +
  drivers/acpi/Makefile |   1 +
  drivers/acpi/bus.c|   2 +
  drivers/acpi/iort.c   | 217 ++
  include/linux/iort.h  |  30 +++
  5 files changed, 253 insertions(+)
  create mode 100644 drivers/acpi/iort.c
  create mode 100644 include/linux/iort.h

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index b7e2e77..848471f 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
  config ACPI_CCA_REQUIRED
bool

+config IORT_TABLE
+   bool
+
  config ACPI_DEBUGGER
bool "AML debugger interface"
select ACPI_DEBUG
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
index 251ce85..c7c9b29 100644
--- a/drivers/acpi/Makefile
+++ b/drivers/acpi/Makefile
@@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
  obj-$(CONFIG_ACPI_BGRT)   += bgrt.o
  obj-$(CONFIG_ACPI_CPPC_LIB)   += cppc_acpi.o
  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
+obj-$(CONFIG_IORT_TABLE)   += iort.o

  # processor has its own "processor." module_param namespace
  processor-y   := processor_driver.o
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 31e8da6..176c17d 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -33,6 +33,7 @@
  #ifdef CONFIG_X86
  #include 
  #endif
+#include 
  #include 
  #include 
  #include 
@@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
}

pci_mmcfg_late_init();
+   iort_table_detect();
acpi_scan_init();
acpi_ec_init();
acpi_debugfs_init();
diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
new file mode 100644
index 000..fcfa008f
--- /dev/null
+++ b/drivers/acpi/iort.c
@@ -0,0 +1,217 @@
+/*
+ * Copyright (C) 2016, Semihalf
+ * Author: Tomasz Nowicki 
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * This file implements early detection/parsing of I/O mapping
+ * reported to OS through firmware via I/O Remapping Table (IORT)
+ * IORT document number: ARM DEN 0049A
+ */
+
+#define pr_fmt(fmt)"ACPI: IORT: " fmt
+
+#include 
+#include 
+#include 
+
+typedef acpi_status (*iort_find_node_callback)
+   (struct acpi_iort_node *node, void *context);
+
+/* Root pointer to the mapped IORT table */
+static struct acpi_table_header *iort_table;
+
+static struct acpi_iort_node *
+iort_scan_node(enum acpi_iort_node_type type,
+  iort_find_node_callback callback, void *context)
+{
+   struct acpi_iort_node *iort_node, *iort_end;
+   struct acpi_table_iort *iort;
+   int i;
+
+   /* Get the first IORT node */
+   iort = (struct acpi_table_iort *)iort_table;
+   iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
+iort->node_offset);
+   iort_end = ACPI_ADD_PTR(struct acpi_iort_node, iort_table,
+   iort_table->length);
+
+   for (i = 0; i < iort->node_count; i++) {
+   if (WARN_TAINT(iort_node >= iort_end, TAINT_FIRMWARE_WORKAROUND,
+  "IORT node pointer overflows, bad table!\n"))
+   return NULL;
+
+   if (iort_node->type == type) {
+   if (ACPI_SUCCESS(callback(iort_node, context)))
+   return iort_node;
+   }
+
+   iort_node = ACPI_ADD_PTR(struct

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 22/06/16 13:35, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
> 
> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.
> 
> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.
> 
> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>   final translation
> 
> Signed-off-by: Tomasz Nowicki 
> ---
>  drivers/acpi/Kconfig  |   3 +
>  drivers/acpi/Makefile |   1 +
>  drivers/acpi/bus.c|   2 +
>  drivers/acpi/iort.c   | 217 
> ++
>  include/linux/iort.h  |  30 +++
>  5 files changed, 253 insertions(+)
>  create mode 100644 drivers/acpi/iort.c
>  create mode 100644 include/linux/iort.h
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7e2e77..848471f 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>  config ACPI_CCA_REQUIRED
>   bool
>  
> +config IORT_TABLE
> + bool
> +
>  config ACPI_DEBUGGER
>   bool "AML debugger interface"
>   select ACPI_DEBUG
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 251ce85..c7c9b29 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>  obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
>  obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
>  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
> +obj-$(CONFIG_IORT_TABLE) += iort.o
>  
>  # processor has its own "processor." module_param namespace
>  processor-y  := processor_driver.o
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 31e8da6..176c17d 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -33,6 +33,7 @@
>  #ifdef CONFIG_X86
>  #include 
>  #endif
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>   }
>  
>   pci_mmcfg_late_init();
> + iort_table_detect();
>   acpi_scan_init();
>   acpi_ec_init();
>   acpi_debugfs_init();
> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
> new file mode 100644
> index 000..fcfa008f
> --- /dev/null
> +++ b/drivers/acpi/iort.c
> @@ -0,0 +1,217 @@
> +/*
> + * Copyright (C) 2016, Semihalf
> + *   Author: Tomasz Nowicki 
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * This file implements early detection/parsing of I/O mapping
> + * reported to OS through firmware via I/O Remapping Table (IORT)
> + * IORT document number: ARM DEN 0049A
> + */
> +
> +#define pr_fmt(fmt)  "ACPI: IORT: " fmt
> +
> +#include 
> +#include 
> +#include 
> +
> +typedef acpi_status (*iort_find_node_callback)
> + (struct acpi_iort_node *node, void *context);
> +
> +/* Root pointer to the mapped IORT table */
> +static struct acpi_table_header *iort_table;
> +
> +static struct acpi_iort_node *
> +iort_scan_node(enum acpi_iort_node_type type,
> +iort_find_node_callback callback, void *context)
> +{
> + struct acpi_iort_node *iort_node, *iort_end;
> + struct acpi_table_iort *iort;
> + int i;
> +
> + /* Get the first IORT node */
> + iort = (struct acpi_table_iort *)iort_table;
> + iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
> +  iort->node_offset);
> + iort_end = ACPI_ADD_PTR(struct acpi_iort_node, iort_table,
> + iort_table->length);
> +
> + for (i = 0; i < iort->node_count; i++) {
> + if (WARN_TAINT(iort_node >= iort_end, TAINT_FIRMWARE_WORKAROUND,
> +"IORT node pointer overflows, bad table!\n"))
> + return NULL;
> +
> + if (iort_node->type == type) {
> +

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 22/06/16 13:35, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf
> 
> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.
> 
> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.
> 
> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>   final translation
> 
> Signed-off-by: Tomasz Nowicki 
> ---
>  drivers/acpi/Kconfig  |   3 +
>  drivers/acpi/Makefile |   1 +
>  drivers/acpi/bus.c|   2 +
>  drivers/acpi/iort.c   | 217 
> ++
>  include/linux/iort.h  |  30 +++
>  5 files changed, 253 insertions(+)
>  create mode 100644 drivers/acpi/iort.c
>  create mode 100644 include/linux/iort.h
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7e2e77..848471f 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>  config ACPI_CCA_REQUIRED
>   bool
>  
> +config IORT_TABLE
> + bool
> +
>  config ACPI_DEBUGGER
>   bool "AML debugger interface"
>   select ACPI_DEBUG
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 251ce85..c7c9b29 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>  obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
>  obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
>  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
> +obj-$(CONFIG_IORT_TABLE) += iort.o
>  
>  # processor has its own "processor." module_param namespace
>  processor-y  := processor_driver.o
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 31e8da6..176c17d 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -33,6 +33,7 @@
>  #ifdef CONFIG_X86
>  #include 
>  #endif
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>   }
>  
>   pci_mmcfg_late_init();
> + iort_table_detect();
>   acpi_scan_init();
>   acpi_ec_init();
>   acpi_debugfs_init();
> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
> new file mode 100644
> index 000..fcfa008f
> --- /dev/null
> +++ b/drivers/acpi/iort.c
> @@ -0,0 +1,217 @@
> +/*
> + * Copyright (C) 2016, Semihalf
> + *   Author: Tomasz Nowicki 
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * This file implements early detection/parsing of I/O mapping
> + * reported to OS through firmware via I/O Remapping Table (IORT)
> + * IORT document number: ARM DEN 0049A
> + */
> +
> +#define pr_fmt(fmt)  "ACPI: IORT: " fmt
> +
> +#include 
> +#include 
> +#include 
> +
> +typedef acpi_status (*iort_find_node_callback)
> + (struct acpi_iort_node *node, void *context);
> +
> +/* Root pointer to the mapped IORT table */
> +static struct acpi_table_header *iort_table;
> +
> +static struct acpi_iort_node *
> +iort_scan_node(enum acpi_iort_node_type type,
> +iort_find_node_callback callback, void *context)
> +{
> + struct acpi_iort_node *iort_node, *iort_end;
> + struct acpi_table_iort *iort;
> + int i;
> +
> + /* Get the first IORT node */
> + iort = (struct acpi_table_iort *)iort_table;
> + iort_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
> +  iort->node_offset);
> + iort_end = ACPI_ADD_PTR(struct acpi_iort_node, iort_table,
> + iort_table->length);
> +
> + for (i = 0; i < iort->node_count; i++) {
> + if (WARN_TAINT(iort_node >= iort_end, TAINT_FIRMWARE_WORKAROUND,
> +"IORT node pointer overflows, bad table!\n"))
> + return NULL;
> +
> + if (iort_node->type == type) {
> + if

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Tomasz Nowicki


On 22.06.2016 14:35, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
   final translation

Signed-off-by: Tomasz Nowicki 


The updated patch incorporates fixes and addresses Lorenzo's comments.
The whole series is here:
https://github.com/semihalf-nowicki-tomasz/linux.git (its-acpi-v7.1)

Thanks,
Tomasz

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Tomasz Nowicki


On 22.06.2016 14:35, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
http://infocenter.arm.com/help/topic/com.arm.doc.den0049b/DEN0049B_IO_Remapping_Table.pdf

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
   final translation

Signed-off-by: Tomasz Nowicki 


The updated patch incorporates fixes and addresses Lorenzo's comments.
The whole series is here:
https://github.com/semihalf-nowicki-tomasz/linux.git (its-acpi-v7.1)

Thanks,
Tomasz

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 22/06/16 12:06, Tomasz Nowicki wrote:
> On 22.06.2016 12:50, Marc Zyngier wrote:
>> On 21/06/16 08:12, Hanjun Guo wrote:
>>> Hi Tomasz,
>>>
>>> Sorry for jumping out late, just one comment below.
>>>
>>> On 2016/6/20 19:02, Tomasz Nowicki wrote:
 IORT shows representation of IO topology for ARM based systems.
 It describes how various components are connected together on
 parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

 Initial support allows to detect IORT table presence and save its
 root pointer obtained through acpi_get_table(). The pointer validity
 depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
 is not set while using IORT nodes we would dereference unmapped pointers.

 For the aforementioned reason call iort_table_detect() from acpi_init()
 which guarantees acpi_gbl_permanent_mmap to be set at that point.

 Add generic helpers which are helpful for scanning and retrieving
 information from IORT table content. List of the most important helpers:
 - iort_find_dev_node() finds IORT node for a given device
 - iort_node_map_rid() maps device RID and returns IORT node which provides
final translation

 Signed-off-by: Tomasz Nowicki 
 ---
   drivers/acpi/Kconfig  |   3 +
   drivers/acpi/Makefile |   1 +
   drivers/acpi/bus.c|   2 +
   drivers/acpi/iort.c   | 220 
 ++
   include/linux/iort.h  |  30 +++
>>>
>>> [...]
>>>
 +static acpi_status
 +iort_match_node_callback(struct acpi_iort_node *node, void *context)
 +{
 +  struct device *dev = context;
 +
 +  switch (node->type) {
 +  case ACPI_IORT_NODE_NAMED_COMPONENT: {
 +  struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
>>>
>>> ACPI_ALLOCATE_BUFFER is used here, so ...
>>>
 +  struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
 +  struct acpi_iort_named_component *ncomp;
 +
 +  if (!adev)
 +  break;
 +
 +  ncomp = (struct acpi_iort_named_component *)node->node_data;
 +
 +  if (ACPI_FAILURE(acpi_get_name(adev->handle,
 + ACPI_FULL_PATHNAME, ))) {
 +  dev_warn(dev, "Can't get device full path name\n");
 +  break;
 +  }
 +
 +  if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
 +  return AE_OK;
>>>
>>> ... we need to kfree(buffer.pointer) before we return or break.
>>
>> For the record, I've queued this patch on top:
>>
>> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
>> index 496dcf6..3b9e55b 100644
>> --- a/drivers/acpi/iort.c
>> +++ b/drivers/acpi/iort.c
>> @@ -158,11 +158,15 @@ iort_match_node_callback(struct acpi_iort_node *node, 
>> void *context)
>>  if (ACPI_FAILURE(acpi_get_name(adev->handle,
>> ACPI_FULL_PATHNAME, ))) {
>>  dev_warn(dev, "Can't get device full path name\n");
>> -break;
>> -}
>> +} else {
>> +int match;
>>
>> -if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
>> -return AE_OK;
>> +match = !strcmp(ncomp->device_name, buffer.pointer);
>> +acpi_os_free();
>> +
>> +if (match)
>> +return AE_OK;
>> +}
>>
>>  break;
>>  }
>>
>>
>> assuming that Rafael is OK with the general approach, of course.
>>
> 
> Thanks Marc. As Lorenzo pointed out, we need another fix for 
> iort_node_map_rid(). Do you want me to refresh the whole series or this 
> patch only?

If the changes are localized enough, just this patch.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 22/06/16 12:06, Tomasz Nowicki wrote:
> On 22.06.2016 12:50, Marc Zyngier wrote:
>> On 21/06/16 08:12, Hanjun Guo wrote:
>>> Hi Tomasz,
>>>
>>> Sorry for jumping out late, just one comment below.
>>>
>>> On 2016/6/20 19:02, Tomasz Nowicki wrote:
 IORT shows representation of IO topology for ARM based systems.
 It describes how various components are connected together on
 parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

 Initial support allows to detect IORT table presence and save its
 root pointer obtained through acpi_get_table(). The pointer validity
 depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
 is not set while using IORT nodes we would dereference unmapped pointers.

 For the aforementioned reason call iort_table_detect() from acpi_init()
 which guarantees acpi_gbl_permanent_mmap to be set at that point.

 Add generic helpers which are helpful for scanning and retrieving
 information from IORT table content. List of the most important helpers:
 - iort_find_dev_node() finds IORT node for a given device
 - iort_node_map_rid() maps device RID and returns IORT node which provides
final translation

 Signed-off-by: Tomasz Nowicki 
 ---
   drivers/acpi/Kconfig  |   3 +
   drivers/acpi/Makefile |   1 +
   drivers/acpi/bus.c|   2 +
   drivers/acpi/iort.c   | 220 
 ++
   include/linux/iort.h  |  30 +++
>>>
>>> [...]
>>>
 +static acpi_status
 +iort_match_node_callback(struct acpi_iort_node *node, void *context)
 +{
 +  struct device *dev = context;
 +
 +  switch (node->type) {
 +  case ACPI_IORT_NODE_NAMED_COMPONENT: {
 +  struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
>>>
>>> ACPI_ALLOCATE_BUFFER is used here, so ...
>>>
 +  struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
 +  struct acpi_iort_named_component *ncomp;
 +
 +  if (!adev)
 +  break;
 +
 +  ncomp = (struct acpi_iort_named_component *)node->node_data;
 +
 +  if (ACPI_FAILURE(acpi_get_name(adev->handle,
 + ACPI_FULL_PATHNAME, ))) {
 +  dev_warn(dev, "Can't get device full path name\n");
 +  break;
 +  }
 +
 +  if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
 +  return AE_OK;
>>>
>>> ... we need to kfree(buffer.pointer) before we return or break.
>>
>> For the record, I've queued this patch on top:
>>
>> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
>> index 496dcf6..3b9e55b 100644
>> --- a/drivers/acpi/iort.c
>> +++ b/drivers/acpi/iort.c
>> @@ -158,11 +158,15 @@ iort_match_node_callback(struct acpi_iort_node *node, 
>> void *context)
>>  if (ACPI_FAILURE(acpi_get_name(adev->handle,
>> ACPI_FULL_PATHNAME, ))) {
>>  dev_warn(dev, "Can't get device full path name\n");
>> -break;
>> -}
>> +} else {
>> +int match;
>>
>> -if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
>> -return AE_OK;
>> +match = !strcmp(ncomp->device_name, buffer.pointer);
>> +acpi_os_free();
>> +
>> +if (match)
>> +return AE_OK;
>> +}
>>
>>  break;
>>  }
>>
>>
>> assuming that Rafael is OK with the general approach, of course.
>>
> 
> Thanks Marc. As Lorenzo pointed out, we need another fix for 
> iort_node_map_rid(). Do you want me to refresh the whole series or this 
> patch only?

If the changes are localized enough, just this patch.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Tomasz Nowicki


On 22.06.2016 12:50, Marc Zyngier wrote:

On 21/06/16 08:12, Hanjun Guo wrote:

Hi Tomasz,

Sorry for jumping out late, just one comment below.

On 2016/6/20 19:02, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
   final translation

Signed-off-by: Tomasz Nowicki 
---
  drivers/acpi/Kconfig  |   3 +
  drivers/acpi/Makefile |   1 +
  drivers/acpi/bus.c|   2 +
  drivers/acpi/iort.c   | 220 ++
  include/linux/iort.h  |  30 +++


[...]


+static acpi_status
+iort_match_node_callback(struct acpi_iort_node *node, void *context)
+{
+   struct device *dev = context;
+
+   switch (node->type) {
+   case ACPI_IORT_NODE_NAMED_COMPONENT: {
+   struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };


ACPI_ALLOCATE_BUFFER is used here, so ...


+   struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
+   struct acpi_iort_named_component *ncomp;
+
+   if (!adev)
+   break;
+
+   ncomp = (struct acpi_iort_named_component *)node->node_data;
+
+   if (ACPI_FAILURE(acpi_get_name(adev->handle,
+  ACPI_FULL_PATHNAME, ))) {
+   dev_warn(dev, "Can't get device full path name\n");
+   break;
+   }
+
+   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
+   return AE_OK;


... we need to kfree(buffer.pointer) before we return or break.


For the record, I've queued this patch on top:

diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
index 496dcf6..3b9e55b 100644
--- a/drivers/acpi/iort.c
+++ b/drivers/acpi/iort.c
@@ -158,11 +158,15 @@ iort_match_node_callback(struct acpi_iort_node *node, 
void *context)
if (ACPI_FAILURE(acpi_get_name(adev->handle,
   ACPI_FULL_PATHNAME, ))) {
dev_warn(dev, "Can't get device full path name\n");
-   break;
-   }
+   } else {
+   int match;

-   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
-   return AE_OK;
+   match = !strcmp(ncomp->device_name, buffer.pointer);
+   acpi_os_free();
+
+   if (match)
+   return AE_OK;
+   }

break;
}


assuming that Rafael is OK with the general approach, of course.



Thanks Marc. As Lorenzo pointed out, we need another fix for 
iort_node_map_rid(). Do you want me to refresh the whole series or this 
patch only?


Tomasz

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Tomasz Nowicki


On 22.06.2016 12:50, Marc Zyngier wrote:

On 21/06/16 08:12, Hanjun Guo wrote:

Hi Tomasz,

Sorry for jumping out late, just one comment below.

On 2016/6/20 19:02, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
   final translation

Signed-off-by: Tomasz Nowicki 
---
  drivers/acpi/Kconfig  |   3 +
  drivers/acpi/Makefile |   1 +
  drivers/acpi/bus.c|   2 +
  drivers/acpi/iort.c   | 220 ++
  include/linux/iort.h  |  30 +++


[...]


+static acpi_status
+iort_match_node_callback(struct acpi_iort_node *node, void *context)
+{
+   struct device *dev = context;
+
+   switch (node->type) {
+   case ACPI_IORT_NODE_NAMED_COMPONENT: {
+   struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };


ACPI_ALLOCATE_BUFFER is used here, so ...


+   struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
+   struct acpi_iort_named_component *ncomp;
+
+   if (!adev)
+   break;
+
+   ncomp = (struct acpi_iort_named_component *)node->node_data;
+
+   if (ACPI_FAILURE(acpi_get_name(adev->handle,
+  ACPI_FULL_PATHNAME, ))) {
+   dev_warn(dev, "Can't get device full path name\n");
+   break;
+   }
+
+   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
+   return AE_OK;


... we need to kfree(buffer.pointer) before we return or break.


For the record, I've queued this patch on top:

diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
index 496dcf6..3b9e55b 100644
--- a/drivers/acpi/iort.c
+++ b/drivers/acpi/iort.c
@@ -158,11 +158,15 @@ iort_match_node_callback(struct acpi_iort_node *node, 
void *context)
if (ACPI_FAILURE(acpi_get_name(adev->handle,
   ACPI_FULL_PATHNAME, ))) {
dev_warn(dev, "Can't get device full path name\n");
-   break;
-   }
+   } else {
+   int match;

-   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
-   return AE_OK;
+   match = !strcmp(ncomp->device_name, buffer.pointer);
+   acpi_os_free();
+
+   if (match)
+   return AE_OK;
+   }

break;
}


assuming that Rafael is OK with the general approach, of course.



Thanks Marc. As Lorenzo pointed out, we need another fix for 
iort_node_map_rid(). Do you want me to refresh the whole series or this 
patch only?


Tomasz

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 21/06/16 08:12, Hanjun Guo wrote:
> Hi Tomasz,
> 
> Sorry for jumping out late, just one comment below.
> 
> On 2016/6/20 19:02, Tomasz Nowicki wrote:
>> IORT shows representation of IO topology for ARM based systems.
>> It describes how various components are connected together on
>> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
>>
>> Initial support allows to detect IORT table presence and save its
>> root pointer obtained through acpi_get_table(). The pointer validity
>> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
>> is not set while using IORT nodes we would dereference unmapped pointers.
>>
>> For the aforementioned reason call iort_table_detect() from acpi_init()
>> which guarantees acpi_gbl_permanent_mmap to be set at that point.
>>
>> Add generic helpers which are helpful for scanning and retrieving
>> information from IORT table content. List of the most important helpers:
>> - iort_find_dev_node() finds IORT node for a given device
>> - iort_node_map_rid() maps device RID and returns IORT node which provides
>>   final translation
>>
>> Signed-off-by: Tomasz Nowicki 
>> ---
>>  drivers/acpi/Kconfig  |   3 +
>>  drivers/acpi/Makefile |   1 +
>>  drivers/acpi/bus.c|   2 +
>>  drivers/acpi/iort.c   | 220 
>> ++
>>  include/linux/iort.h  |  30 +++
> 
> [...]
> 
>> +static acpi_status
>> +iort_match_node_callback(struct acpi_iort_node *node, void *context)
>> +{
>> +struct device *dev = context;
>> +
>> +switch (node->type) {
>> +case ACPI_IORT_NODE_NAMED_COMPONENT: {
>> +struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> 
> ACPI_ALLOCATE_BUFFER is used here, so ...
> 
>> +struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
>> +struct acpi_iort_named_component *ncomp;
>> +
>> +if (!adev)
>> +break;
>> +
>> +ncomp = (struct acpi_iort_named_component *)node->node_data;
>> +
>> +if (ACPI_FAILURE(acpi_get_name(adev->handle,
>> +   ACPI_FULL_PATHNAME, ))) {
>> +dev_warn(dev, "Can't get device full path name\n");
>> +break;
>> +}
>> +
>> +if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
>> +return AE_OK;
> 
> ... we need to kfree(buffer.pointer) before we return or break.

For the record, I've queued this patch on top:

diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
index 496dcf6..3b9e55b 100644
--- a/drivers/acpi/iort.c
+++ b/drivers/acpi/iort.c
@@ -158,11 +158,15 @@ iort_match_node_callback(struct acpi_iort_node *node, 
void *context)
if (ACPI_FAILURE(acpi_get_name(adev->handle,
   ACPI_FULL_PATHNAME, ))) {
dev_warn(dev, "Can't get device full path name\n");
-   break;
-   }
+   } else {
+   int match;
 
-   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
-   return AE_OK;
+   match = !strcmp(ncomp->device_name, buffer.pointer);
+   acpi_os_free();
+
+   if (match)
+   return AE_OK;
+   }
 
break;
}


assuming that Rafael is OK with the general approach, of course.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-22 Thread Marc Zyngier

On 21/06/16 08:12, Hanjun Guo wrote:
> Hi Tomasz,
> 
> Sorry for jumping out late, just one comment below.
> 
> On 2016/6/20 19:02, Tomasz Nowicki wrote:
>> IORT shows representation of IO topology for ARM based systems.
>> It describes how various components are connected together on
>> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
>>
>> Initial support allows to detect IORT table presence and save its
>> root pointer obtained through acpi_get_table(). The pointer validity
>> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
>> is not set while using IORT nodes we would dereference unmapped pointers.
>>
>> For the aforementioned reason call iort_table_detect() from acpi_init()
>> which guarantees acpi_gbl_permanent_mmap to be set at that point.
>>
>> Add generic helpers which are helpful for scanning and retrieving
>> information from IORT table content. List of the most important helpers:
>> - iort_find_dev_node() finds IORT node for a given device
>> - iort_node_map_rid() maps device RID and returns IORT node which provides
>>   final translation
>>
>> Signed-off-by: Tomasz Nowicki 
>> ---
>>  drivers/acpi/Kconfig  |   3 +
>>  drivers/acpi/Makefile |   1 +
>>  drivers/acpi/bus.c|   2 +
>>  drivers/acpi/iort.c   | 220 
>> ++
>>  include/linux/iort.h  |  30 +++
> 
> [...]
> 
>> +static acpi_status
>> +iort_match_node_callback(struct acpi_iort_node *node, void *context)
>> +{
>> +struct device *dev = context;
>> +
>> +switch (node->type) {
>> +case ACPI_IORT_NODE_NAMED_COMPONENT: {
>> +struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> 
> ACPI_ALLOCATE_BUFFER is used here, so ...
> 
>> +struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
>> +struct acpi_iort_named_component *ncomp;
>> +
>> +if (!adev)
>> +break;
>> +
>> +ncomp = (struct acpi_iort_named_component *)node->node_data;
>> +
>> +if (ACPI_FAILURE(acpi_get_name(adev->handle,
>> +   ACPI_FULL_PATHNAME, ))) {
>> +dev_warn(dev, "Can't get device full path name\n");
>> +break;
>> +}
>> +
>> +if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
>> +return AE_OK;
> 
> ... we need to kfree(buffer.pointer) before we return or break.

For the record, I've queued this patch on top:

diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
index 496dcf6..3b9e55b 100644
--- a/drivers/acpi/iort.c
+++ b/drivers/acpi/iort.c
@@ -158,11 +158,15 @@ iort_match_node_callback(struct acpi_iort_node *node, 
void *context)
if (ACPI_FAILURE(acpi_get_name(adev->handle,
   ACPI_FULL_PATHNAME, ))) {
dev_warn(dev, "Can't get device full path name\n");
-   break;
-   }
+   } else {
+   int match;
 
-   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
-   return AE_OK;
+   match = !strcmp(ncomp->device_name, buffer.pointer);
+   acpi_os_free();
+
+   if (match)
+   return AE_OK;
+   }
 
break;
}


assuming that Rafael is OK with the general approach, of course.

Thanks,

M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-21 Thread Lorenzo Pieralisi

Hi Rafael,

On Mon, Jun 20, 2016 at 01:02:14PM +0200, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> 
> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.
> 
> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.

This moot point has become a blocker for this patchset and we need
your feedback please. I noticed that x86 code (drivers/iommu/dmar.c)
makes the same assumption (ie a table pointer, dmar_tbl, retrieved
through acpi_get_table_with_size() can be stashed in a global variable
and reused in functions like dmar_acpi_dev_scope_init() and
dmar_ir_support() without going through the ACPI API to retrieve
it again.

Is this a valid assumption ? This patch relies on it, since
otherwise it would become quite unwieldy (and unnecessary) to
create a cache of IORT nodes entries, so if we can retrieve the
table pointer through acpi_get_table_size() in iort_table_detect()
and stash it for further use that would make things much simpler
(as they are in the current patch).

I think that's the whole point behind acpi_gbl_permanent_mmap,
if that's set the corresponding tables pointers can be considered
permanently mapped, we really need to know if that's a reliable
assumption to make progress.

Thanks,
Lorenzo

> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>   final translation
> 
> Signed-off-by: Tomasz Nowicki 
> ---
>  drivers/acpi/Kconfig  |   3 +
>  drivers/acpi/Makefile |   1 +
>  drivers/acpi/bus.c|   2 +
>  drivers/acpi/iort.c   | 220 
> ++
>  include/linux/iort.h  |  30 +++
>  5 files changed, 256 insertions(+)
>  create mode 100644 drivers/acpi/iort.c
>  create mode 100644 include/linux/iort.h
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7e2e77..848471f 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>  config ACPI_CCA_REQUIRED
>   bool
>  
> +config IORT_TABLE
> + bool
> +
>  config ACPI_DEBUGGER
>   bool "AML debugger interface"
>   select ACPI_DEBUG
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 251ce85..c7c9b29 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>  obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
>  obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
>  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
> +obj-$(CONFIG_IORT_TABLE) += iort.o
>  
>  # processor has its own "processor." module_param namespace
>  processor-y  := processor_driver.o
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 31e8da6..176c17d 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -33,6 +33,7 @@
>  #ifdef CONFIG_X86
>  #include 
>  #endif
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>   }
>  
>   pci_mmcfg_late_init();
> + iort_table_detect();
>   acpi_scan_init();
>   acpi_ec_init();
>   acpi_debugfs_init();
> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
> new file mode 100644
> index 000..e342bac
> --- /dev/null
> +++ b/drivers/acpi/iort.c
> @@ -0,0 +1,220 @@
> +/*
> + * Copyright (C) 2016, Semihalf
> + *   Author: Tomasz Nowicki 
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * This file implements early detection/parsing of I/O mapping
> + * reported to OS through firmware via I/O Remapping Table (IORT)
> + * IORT document number: ARM DEN 0049A
> + */
> +
> +#define pr_fmt(fmt)  "ACPI: IORT: " fmt
> +
> +#include 
> +#include 
> +#include 
> +
> +typedef acpi_status (*iort_find_node_callback)
> + (struct acpi_iort_node *node, void *context);
> +
> +/* Root pointer to the mapped IORT table */
> +static

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-21 Thread Lorenzo Pieralisi

Hi Rafael,

On Mon, Jun 20, 2016 at 01:02:14PM +0200, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.
> 
> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.
> 
> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.

This moot point has become a blocker for this patchset and we need
your feedback please. I noticed that x86 code (drivers/iommu/dmar.c)
makes the same assumption (ie a table pointer, dmar_tbl, retrieved
through acpi_get_table_with_size() can be stashed in a global variable
and reused in functions like dmar_acpi_dev_scope_init() and
dmar_ir_support() without going through the ACPI API to retrieve
it again.

Is this a valid assumption ? This patch relies on it, since
otherwise it would become quite unwieldy (and unnecessary) to
create a cache of IORT nodes entries, so if we can retrieve the
table pointer through acpi_get_table_size() in iort_table_detect()
and stash it for further use that would make things much simpler
(as they are in the current patch).

I think that's the whole point behind acpi_gbl_permanent_mmap,
if that's set the corresponding tables pointers can be considered
permanently mapped, we really need to know if that's a reliable
assumption to make progress.

Thanks,
Lorenzo

> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>   final translation
> 
> Signed-off-by: Tomasz Nowicki 
> ---
>  drivers/acpi/Kconfig  |   3 +
>  drivers/acpi/Makefile |   1 +
>  drivers/acpi/bus.c|   2 +
>  drivers/acpi/iort.c   | 220 
> ++
>  include/linux/iort.h  |  30 +++
>  5 files changed, 256 insertions(+)
>  create mode 100644 drivers/acpi/iort.c
>  create mode 100644 include/linux/iort.h
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7e2e77..848471f 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>  config ACPI_CCA_REQUIRED
>   bool
>  
> +config IORT_TABLE
> + bool
> +
>  config ACPI_DEBUGGER
>   bool "AML debugger interface"
>   select ACPI_DEBUG
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 251ce85..c7c9b29 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>  obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
>  obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
>  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
> +obj-$(CONFIG_IORT_TABLE) += iort.o
>  
>  # processor has its own "processor." module_param namespace
>  processor-y  := processor_driver.o
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 31e8da6..176c17d 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -33,6 +33,7 @@
>  #ifdef CONFIG_X86
>  #include 
>  #endif
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>   }
>  
>   pci_mmcfg_late_init();
> + iort_table_detect();
>   acpi_scan_init();
>   acpi_ec_init();
>   acpi_debugfs_init();
> diff --git a/drivers/acpi/iort.c b/drivers/acpi/iort.c
> new file mode 100644
> index 000..e342bac
> --- /dev/null
> +++ b/drivers/acpi/iort.c
> @@ -0,0 +1,220 @@
> +/*
> + * Copyright (C) 2016, Semihalf
> + *   Author: Tomasz Nowicki 
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * This file implements early detection/parsing of I/O mapping
> + * reported to OS through firmware via I/O Remapping Table (IORT)
> + * IORT document number: ARM DEN 0049A
> + */
> +
> +#define pr_fmt(fmt)  "ACPI: IORT: " fmt
> +
> +#include 
> +#include 
> +#include 
> +
> +typedef acpi_status (*iort_find_node_callback)
> + (struct acpi_iort_node *node, void *context);
> +
> +/* Root pointer to the mapped IORT table */
> +static struct acpi_table_header *iort_table;

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-21 Thread Lorenzo Pieralisi

On Mon, Jun 20, 2016 at 01:02:14PM +0200, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

Add the spec link if you want a reference to it otherwise "Also see IORT spec"
is pretty much useless.

> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.

We still need Rafael's feeback on this.

> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.

Ditto.

> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>   final translation
> 
> Signed-off-by: Tomasz Nowicki 
> ---
>  drivers/acpi/Kconfig  |   3 +
>  drivers/acpi/Makefile |   1 +
>  drivers/acpi/bus.c|   2 +
>  drivers/acpi/iort.c   | 220 
> ++
>  include/linux/iort.h  |  30 +++
>  5 files changed, 256 insertions(+)
>  create mode 100644 drivers/acpi/iort.c
>  create mode 100644 include/linux/iort.h
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7e2e77..848471f 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>  config ACPI_CCA_REQUIRED
>   bool
>  
> +config IORT_TABLE
> + bool
> +
>  config ACPI_DEBUGGER
>   bool "AML debugger interface"
>   select ACPI_DEBUG
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 251ce85..c7c9b29 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>  obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
>  obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
>  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
> +obj-$(CONFIG_IORT_TABLE) += iort.o
>  
>  # processor has its own "processor." module_param namespace
>  processor-y  := processor_driver.o
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 31e8da6..176c17d 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -33,6 +33,7 @@
>  #ifdef CONFIG_X86
>  #include 
>  #endif
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>   }
>  
>   pci_mmcfg_late_init();
> + iort_table_detect();

IORT is arch specific (and empty on any system other than ARM64), this call
here is fine by me because it provides us the ordering we need (ie
initialize the IORT table pointers before we start running scan handlers),
we need Rafael's feeback on this though.

[...]

> +static int
> +iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in, u32 
> *rid_out)
> +{
> + if (!rid_out)
> + return -EINVAL;

Nit: It is an internal function honestly I do not see the need for
this check here, it is close to paranoia.

> + /* Single mapping does not care for input id */
> + if (map->flags & ACPI_IORT_ID_SINGLE_MAPPING) {
> + if (type == ACPI_IORT_NODE_NAMED_COMPONENT ||
> + type == ACPI_IORT_NODE_PCI_ROOT_COMPLEX) {
> + *rid_out = map->output_base;
> + return 0;
> + }
> +
> + pr_warn(FW_BUG "[map %p] SINGLE MAPPING flag not allowed for 
> node type %d, skipping ID map\n",
> + map, type);
> + return -ENXIO;
> + }
> +
> + if (rid_in < map->input_base ||
> + (rid_in > map->input_base + map->id_count))
> + return -ENXIO;
> +
> + *rid_out = map->output_base + (rid_in - map->input_base);
> + return 0;
> +}
> +
> +static struct acpi_iort_node *
> +iort_node_map_rid(struct acpi_iort_node *node, u32 rid_in,
> +   u32 *rid_out, u8 type)
> +{
> + u32 rid = rid_in;
> + int found = 0;
> +
> + /* Climb up ID mapping tree to find specified node type */

s/Climb/Parse the/

> + while (node && node->type != type) {
> + struct acpi_iort_id_mapping *map;
> + int i;
> +
> + if (!node->mapping_offset || !node->mapping_count) {
> + node = NULL;
> + break;
> + }
> +
> + map = ACPI_ADD_PTR(struct acpi_iort_id_mapping, node,
> +   node->mapping_offset);
> +
> + /* Firmware bug! */
> + if (!map->output_reference) {
> + pr_err(FW_BUG "[node %p type

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-21 Thread Lorenzo Pieralisi

On Mon, Jun 20, 2016 at 01:02:14PM +0200, Tomasz Nowicki wrote:
> IORT shows representation of IO topology for ARM based systems.
> It describes how various components are connected together on
> parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

Add the spec link if you want a reference to it otherwise "Also see IORT spec"
is pretty much useless.

> Initial support allows to detect IORT table presence and save its
> root pointer obtained through acpi_get_table(). The pointer validity
> depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
> is not set while using IORT nodes we would dereference unmapped pointers.

We still need Rafael's feeback on this.

> For the aforementioned reason call iort_table_detect() from acpi_init()
> which guarantees acpi_gbl_permanent_mmap to be set at that point.

Ditto.

> Add generic helpers which are helpful for scanning and retrieving
> information from IORT table content. List of the most important helpers:
> - iort_find_dev_node() finds IORT node for a given device
> - iort_node_map_rid() maps device RID and returns IORT node which provides
>   final translation
> 
> Signed-off-by: Tomasz Nowicki 
> ---
>  drivers/acpi/Kconfig  |   3 +
>  drivers/acpi/Makefile |   1 +
>  drivers/acpi/bus.c|   2 +
>  drivers/acpi/iort.c   | 220 
> ++
>  include/linux/iort.h  |  30 +++
>  5 files changed, 256 insertions(+)
>  create mode 100644 drivers/acpi/iort.c
>  create mode 100644 include/linux/iort.h
> 
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7e2e77..848471f 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -57,6 +57,9 @@ config ACPI_SYSTEM_POWER_STATES_SUPPORT
>  config ACPI_CCA_REQUIRED
>   bool
>  
> +config IORT_TABLE
> + bool
> +
>  config ACPI_DEBUGGER
>   bool "AML debugger interface"
>   select ACPI_DEBUG
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 251ce85..c7c9b29 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -82,6 +82,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o
>  obj-$(CONFIG_ACPI_BGRT)  += bgrt.o
>  obj-$(CONFIG_ACPI_CPPC_LIB)  += cppc_acpi.o
>  obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o
> +obj-$(CONFIG_IORT_TABLE) += iort.o
>  
>  # processor has its own "processor." module_param namespace
>  processor-y  := processor_driver.o
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 31e8da6..176c17d 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -33,6 +33,7 @@
>  #ifdef CONFIG_X86
>  #include 
>  #endif
> +#include 
>  #include 
>  #include 
>  #include 
> @@ -1118,6 +1119,7 @@ static int __init acpi_init(void)
>   }
>  
>   pci_mmcfg_late_init();
> + iort_table_detect();

IORT is arch specific (and empty on any system other than ARM64), this call
here is fine by me because it provides us the ordering we need (ie
initialize the IORT table pointers before we start running scan handlers),
we need Rafael's feeback on this though.

[...]

> +static int
> +iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in, u32 
> *rid_out)
> +{
> + if (!rid_out)
> + return -EINVAL;

Nit: It is an internal function honestly I do not see the need for
this check here, it is close to paranoia.

> + /* Single mapping does not care for input id */
> + if (map->flags & ACPI_IORT_ID_SINGLE_MAPPING) {
> + if (type == ACPI_IORT_NODE_NAMED_COMPONENT ||
> + type == ACPI_IORT_NODE_PCI_ROOT_COMPLEX) {
> + *rid_out = map->output_base;
> + return 0;
> + }
> +
> + pr_warn(FW_BUG "[map %p] SINGLE MAPPING flag not allowed for 
> node type %d, skipping ID map\n",
> + map, type);
> + return -ENXIO;
> + }
> +
> + if (rid_in < map->input_base ||
> + (rid_in > map->input_base + map->id_count))
> + return -ENXIO;
> +
> + *rid_out = map->output_base + (rid_in - map->input_base);
> + return 0;
> +}
> +
> +static struct acpi_iort_node *
> +iort_node_map_rid(struct acpi_iort_node *node, u32 rid_in,
> +   u32 *rid_out, u8 type)
> +{
> + u32 rid = rid_in;
> + int found = 0;
> +
> + /* Climb up ID mapping tree to find specified node type */

s/Climb/Parse the/

> + while (node && node->type != type) {
> + struct acpi_iort_id_mapping *map;
> + int i;
> +
> + if (!node->mapping_offset || !node->mapping_count) {
> + node = NULL;
> + break;
> + }
> +
> + map = ACPI_ADD_PTR(struct acpi_iort_id_mapping, node,
> +   node->mapping_offset);
> +
> + /* Firmware bug! */
> + if (!map->output_reference) {
> + pr_err(FW_BUG "[node %p type %d] ID map has NULL

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-21 Thread Hanjun Guo


Hi Tomasz,

Sorry for jumping out late, just one comment below.

On 2016/6/20 19:02, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
  final translation

Signed-off-by: Tomasz Nowicki 
---
 drivers/acpi/Kconfig  |   3 +
 drivers/acpi/Makefile |   1 +
 drivers/acpi/bus.c|   2 +
 drivers/acpi/iort.c   | 220 ++
 include/linux/iort.h  |  30 +++


[...]


+static acpi_status
+iort_match_node_callback(struct acpi_iort_node *node, void *context)
+{
+   struct device *dev = context;
+
+   switch (node->type) {
+   case ACPI_IORT_NODE_NAMED_COMPONENT: {
+   struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };


ACPI_ALLOCATE_BUFFER is used here, so ...


+   struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
+   struct acpi_iort_named_component *ncomp;
+
+   if (!adev)
+   break;
+
+   ncomp = (struct acpi_iort_named_component *)node->node_data;
+
+   if (ACPI_FAILURE(acpi_get_name(adev->handle,
+  ACPI_FULL_PATHNAME, ))) {
+   dev_warn(dev, "Can't get device full path name\n");
+   break;
+   }
+
+   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
+   return AE_OK;


... we need to kfree(buffer.pointer) before we return or break.

With this fixed,

Reviewed-by: Hanjun Guo 

Thanks
Hanjun


+
+   break;
+   }

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

2016-06-21 Thread Hanjun Guo


Hi Tomasz,

Sorry for jumping out late, just one comment below.

On 2016/6/20 19:02, Tomasz Nowicki wrote:

IORT shows representation of IO topology for ARM based systems.
It describes how various components are connected together on
parent-child basis e.g. PCI RC -> SMMU -> ITS. Also see IORT spec.

Initial support allows to detect IORT table presence and save its
root pointer obtained through acpi_get_table(). The pointer validity
depends on acpi_gbl_permanent_mmap because if acpi_gbl_permanent_mmap
is not set while using IORT nodes we would dereference unmapped pointers.

For the aforementioned reason call iort_table_detect() from acpi_init()
which guarantees acpi_gbl_permanent_mmap to be set at that point.

Add generic helpers which are helpful for scanning and retrieving
information from IORT table content. List of the most important helpers:
- iort_find_dev_node() finds IORT node for a given device
- iort_node_map_rid() maps device RID and returns IORT node which provides
  final translation

Signed-off-by: Tomasz Nowicki 
---
 drivers/acpi/Kconfig  |   3 +
 drivers/acpi/Makefile |   1 +
 drivers/acpi/bus.c|   2 +
 drivers/acpi/iort.c   | 220 ++
 include/linux/iort.h  |  30 +++


[...]


+static acpi_status
+iort_match_node_callback(struct acpi_iort_node *node, void *context)
+{
+   struct device *dev = context;
+
+   switch (node->type) {
+   case ACPI_IORT_NODE_NAMED_COMPONENT: {
+   struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };


ACPI_ALLOCATE_BUFFER is used here, so ...


+   struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
+   struct acpi_iort_named_component *ncomp;
+
+   if (!adev)
+   break;
+
+   ncomp = (struct acpi_iort_named_component *)node->node_data;
+
+   if (ACPI_FAILURE(acpi_get_name(adev->handle,
+  ACPI_FULL_PATHNAME, ))) {
+   dev_warn(dev, "Can't get device full path name\n");
+   break;
+   }
+
+   if (!strcmp(ncomp->device_name, (char *)buffer.pointer))
+   return AE_OK;


... we need to kfree(buffer.pointer) before we return or break.

With this fixed,

Reviewed-by: Hanjun Guo 

Thanks
Hanjun


+
+   break;
+   }

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

Re: [PATCH V7 1/8] ACPI: I/O Remapping Table (IORT) initial support

26 matches

Site Navigation

Mail list logo

Footer information