Re: [PATCH iproute2-next V3] devlink: add support for port params get/set

2021-02-08 Thread David Ahern
On 2/2/21 6:04 AM, Oleksandr Mazur wrote:
> Add implementation for the port parameters
> getting/setting.
> Add bash completion for port param.
> Add man description for port param.
> 
> Example:
> $ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value 
> false cmode runtime
> 
> $ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter
> netdevsim/netdevsim0/0:
>   name test_port_parameter type driver-specific
> values:
>   cmode runtime value false
> 
> $ devlink port  -jp param show netdevsim/netdevsim0/0 name test_port_parameter
> {
> "param": {
> "netdevsim/netdevsim0/0": [ {
> "name": "test_port_parameter",
> "type": "driver-specific",
> "values": [ {
> "cmode": "runtime",
> "value": false
> } ]
> } ]
> }
> }
> 
> Signed-off-by: Oleksandr Mazur 
> ---
> V3:
> 1) Add usage example;
> 2) Remove stray newline in code;
> V2:
> 1) Add bash completion for port param;
> 2) Add man decsription / examples for port param;
> 
>  bash-completion/devlink |  55 
>  devlink/devlink.c   | 274 +++-
>  man/man8/devlink-port.8 |  65 ++
>  3 files changed, 388 insertions(+), 6 deletions(-)
> 

does not apply to iproute2-next. please rebase



Re: [PATCH iproute2-next V3] devlink: add support for port params get/set

2021-02-05 Thread Jiri Pirko
Tue, Feb 02, 2021 at 02:04:45PM CET, oleksandr.ma...@plvision.eu wrote:
>Add implementation for the port parameters
>getting/setting.
>Add bash completion for port param.
>Add man description for port param.
>
>Example:
>$ devlink dev param set netdevsim/netdevsim0/0 name test_port_parameter value 
>false cmode runtime
>
>$ devlink port param show netdevsim/netdevsim0/0 name test_port_parameter
>netdevsim/netdevsim0/0:
>  name test_port_parameter type driver-specific
>values:
>  cmode runtime value false
>
>$ devlink port  -jp param show netdevsim/netdevsim0/0 name test_port_parameter
>{
>"param": {
>"netdevsim/netdevsim0/0": [ {
>"name": "test_port_parameter",
>"type": "driver-specific",
>"values": [ {
>"cmode": "runtime",
>"value": false
>} ]
>} ]
>}
>}
>
>Signed-off-by: Oleksandr Mazur 

Looks fine.

Reviewed-by: Jiri Pirko 


Re: [PATCH iproute2-next V3] devlink: add support for port params get/set

2021-02-04 Thread David Ahern
Jiri/Parav: does this look ok to you?