Re: [PATCH net-next] selftests: mptcp: interpret \n as a new line
On Tue, 06 Oct 2020 18:12:45 +0200 Paolo Abeni wrote:
> On Tue, 2020-10-06 at 18:06 +0200, Matthieu Baerts wrote:
> > In case of errors, this message was printed:
> >
> > (...)
> > balanced bwidth with unbalanced delay 5233 max 5005 [ fail ]
> > client exit code 0, server 0
> > \nnetns ns3-0-EwnkPH socket stat for 10003:
> > (...)
> >
> > Obviously, the idea was to add a new line before the socket stat and not
> > print "\nnetns".
> >
> > The commit 8b974778f998 ("selftests: mptcp: interpret \n as a new line")
> > is very similar to this one. But the modification in simult_flows.sh was
> > missed because this commit above was done in parallel to one here below.
>
> Acked-by: Paolo Abeni
Applied, thanks!
Re: [PATCH net-next] selftests: mptcp: interpret \n as a new line
On Tue, 2020-10-06 at 18:06 +0200, Matthieu Baerts wrote:
> In case of errors, this message was printed:
>
> (...)
> balanced bwidth with unbalanced delay 5233 max 5005 [ fail ]
> client exit code 0, server 0
> \nnetns ns3-0-EwnkPH socket stat for 10003:
> (...)
>
> Obviously, the idea was to add a new line before the socket stat and not
> print "\nnetns".
>
> The commit 8b974778f998 ("selftests: mptcp: interpret \n as a new line")
> is very similar to this one. But the modification in simult_flows.sh was
> missed because this commit above was done in parallel to one here below.
>
> Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests")
> Signed-off-by: Matthieu Baerts
Acked-by: Paolo Abeni
Re: [PATCH net-next] selftests: mptcp: interpret \n as a new line
From: Matthieu Baerts
Date: Wed, 16 Sep 2020 15:13:51 +0200
> In case of errors, this message was printed:
>
> (...)
> # read: Resource temporarily unavailable
> # client exit code 0, server 3
> # \nnetns ns1-0-BJlt5D socket stat for 10003:
> (...)
>
> Obviously, the idea was to add a new line before the socket stat and not
> print "\nnetns".
>
> Fixes: b08fbf241064 ("selftests: add test-cases for MPTCP MP_JOIN")
> Fixes: 048d19d444be ("mptcp: add basic kselftest for mptcp")
> Signed-off-by: Matthieu Baerts
Applied.
Re: [PATCH net-next] selftests: mptcp: interpret \n as a new line
On Wed, 2020-09-16 at 15:13 +0200, Matthieu Baerts wrote:
> In case of errors, this message was printed:
>
> (...)
> # read: Resource temporarily unavailable
> # client exit code 0, server 3
> # \nnetns ns1-0-BJlt5D socket stat for 10003:
> (...)
>
> Obviously, the idea was to add a new line before the socket stat and not
> print "\nnetns".
>
> Fixes: b08fbf241064 ("selftests: add test-cases for MPTCP MP_JOIN")
> Fixes: 048d19d444be ("mptcp: add basic kselftest for mptcp")
> Signed-off-by: Matthieu Baerts
Acked-by: Paolo Abeni
