Re: [PATCH net-next v2 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-ti-Allow-most-drivers-with-COMPILE_TEST/20180519-043005 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc64 All errors (new ones prefixed by >>): `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o drivers/net/ethernet/ti/netcp_core.o: In function `netcp_txpipe_open': >> netcp_core.c:(.text+0xc84): undefined reference to `knav_queue_open' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH net-next v2 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-ti-Allow-most-drivers-with-COMPILE_TEST/20180519-043005 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc64 All errors (new ones prefixed by >>): `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o drivers/net/ethernet/ti/netcp_core.o: In function `netcp_txpipe_open': >> netcp_core.c:(.text+0xc84): undefined reference to `knav_queue_open' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH net-next v2 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST
Hi Florian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-ti-Allow-most-drivers-with-COMPILE_TEST/20180519-043005
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64
All warnings (new ones prefixed by >>):
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_free_rx_desc_chain':
>> drivers/net/ethernet/ti/netcp_core.c:613:13: warning: cast to pointer from
>> integer of different size [-Wint-to-pointer-cast]
buf_ptr = (void *)GET_SW_DATA0(ndesc);
^
drivers/net/ethernet/ti/netcp_core.c:622:12: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
buf_ptr = (void *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c: In function
'netcp_process_one_rx_packet':
drivers/net/ethernet/ti/netcp_core.c:681:16: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
org_buf_ptr = (void *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c:718:10: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
page = (struct page *)GET_SW_DATA0(ndesc);
^
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_free_rx_buf':
drivers/net/ethernet/ti/netcp_core.c:822:13: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
buf_ptr = (void *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_allocate_rx_buf':
>> drivers/net/ethernet/ti/netcp_core.c:906:16: warning: cast from pointer to
>> integer of different size [-Wpointer-to-int-cast]
sw_data[0] = (u32)bufptr;
^
drivers/net/ethernet/ti/netcp_core.c:919:16: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
sw_data[0] = (u32)page;
^
drivers/net/ethernet/ti/netcp_core.c: In function
'netcp_process_tx_compl_packets':
drivers/net/ethernet/ti/netcp_core.c:1041:9: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
skb = (struct sk_buff *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_tx_submit_skb':
drivers/net/ethernet/ti/netcp_core.c:1256:15: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
SET_SW_DATA0((u32)skb, desc);
^
drivers/net/ethernet/ti/netcp_core.c:181:49: note: in definition of macro
'SET_SW_DATA0'
#define SET_SW_DATA0(data, desc) set_sw_data(0, data, desc)
^~~~
vim +613 drivers/net/ethernet/ti/netcp_core.c
84640e27 Karicheri, Muralidharan 2015-01-15 591
84640e27 Karicheri, Muralidharan 2015-01-15 592 static void
netcp_free_rx_desc_chain(struct netcp_intf *netcp,
84640e27 Karicheri, Muralidharan 2015-01-15 593
struct knav_dma_desc *desc)
84640e27 Karicheri, Muralidharan 2015-01-15 594 {
84640e27 Karicheri, Muralidharan 2015-01-15 595struct knav_dma_desc
*ndesc;
84640e27 Karicheri, Muralidharan 2015-01-15 596dma_addr_t dma_desc,
dma_buf;
84640e27 Karicheri, Muralidharan 2015-01-15 597unsigned int buf_len,
dma_sz = sizeof(*ndesc);
84640e27 Karicheri, Muralidharan 2015-01-15 598void *buf_ptr;
958d104e Arnd Bergmann 2015-12-18 599u32 tmp;
84640e27 Karicheri, Muralidharan 2015-01-15 600
84640e27 Karicheri, Muralidharan 2015-01-15 601get_words(_desc, 1,
>next_desc);
84640e27 Karicheri, Muralidharan 2015-01-15 602
84640e27 Karicheri, Muralidharan 2015-01-15 603while (dma_desc) {
84640e27 Karicheri, Muralidharan 2015-01-15 604ndesc =
knav_pool_desc_unmap(netcp->rx_pool, dma_desc, dma_sz);
84640e27 Karicheri, Muralidharan 2015-01-15 605if
(unlikely(!ndesc)) {
84640e27 Karicheri, Muralidharan 2015-01-15 606
dev_err(netcp->ndev_dev, "failed to unmap Rx desc\n");
84640e27 Karicheri, Muralidharan 2015-01-15 607break;
84640e27 Karicheri, Muralidharan 2015-01-15 608}
958d104e Arnd Bergmann 2015-12-18 609
get_pkt_info(_buf, , _desc, ndesc);
06324481 Karicheri, Muralidharan 2016-02-19 610/* warning
We are retrieving the virtual ptr in the sw_data
06324481 Karicheri, Muralidharan 2016-02-19 611 * field as a
32bit value. Will not work on 64bit machines
06324481 Karicheri, Muralidharan 2016-02-19 612 */
06324481
Re: [PATCH net-next v2 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST
Hi Florian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-ti-Allow-most-drivers-with-COMPILE_TEST/20180519-043005
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64
All warnings (new ones prefixed by >>):
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_free_rx_desc_chain':
>> drivers/net/ethernet/ti/netcp_core.c:613:13: warning: cast to pointer from
>> integer of different size [-Wint-to-pointer-cast]
buf_ptr = (void *)GET_SW_DATA0(ndesc);
^
drivers/net/ethernet/ti/netcp_core.c:622:12: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
buf_ptr = (void *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c: In function
'netcp_process_one_rx_packet':
drivers/net/ethernet/ti/netcp_core.c:681:16: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
org_buf_ptr = (void *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c:718:10: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
page = (struct page *)GET_SW_DATA0(ndesc);
^
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_free_rx_buf':
drivers/net/ethernet/ti/netcp_core.c:822:13: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
buf_ptr = (void *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_allocate_rx_buf':
>> drivers/net/ethernet/ti/netcp_core.c:906:16: warning: cast from pointer to
>> integer of different size [-Wpointer-to-int-cast]
sw_data[0] = (u32)bufptr;
^
drivers/net/ethernet/ti/netcp_core.c:919:16: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
sw_data[0] = (u32)page;
^
drivers/net/ethernet/ti/netcp_core.c: In function
'netcp_process_tx_compl_packets':
drivers/net/ethernet/ti/netcp_core.c:1041:9: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
skb = (struct sk_buff *)GET_SW_DATA0(desc);
^
drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_tx_submit_skb':
drivers/net/ethernet/ti/netcp_core.c:1256:15: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
SET_SW_DATA0((u32)skb, desc);
^
drivers/net/ethernet/ti/netcp_core.c:181:49: note: in definition of macro
'SET_SW_DATA0'
#define SET_SW_DATA0(data, desc) set_sw_data(0, data, desc)
^~~~
vim +613 drivers/net/ethernet/ti/netcp_core.c
84640e27 Karicheri, Muralidharan 2015-01-15 591
84640e27 Karicheri, Muralidharan 2015-01-15 592 static void
netcp_free_rx_desc_chain(struct netcp_intf *netcp,
84640e27 Karicheri, Muralidharan 2015-01-15 593
struct knav_dma_desc *desc)
84640e27 Karicheri, Muralidharan 2015-01-15 594 {
84640e27 Karicheri, Muralidharan 2015-01-15 595struct knav_dma_desc
*ndesc;
84640e27 Karicheri, Muralidharan 2015-01-15 596dma_addr_t dma_desc,
dma_buf;
84640e27 Karicheri, Muralidharan 2015-01-15 597unsigned int buf_len,
dma_sz = sizeof(*ndesc);
84640e27 Karicheri, Muralidharan 2015-01-15 598void *buf_ptr;
958d104e Arnd Bergmann 2015-12-18 599u32 tmp;
84640e27 Karicheri, Muralidharan 2015-01-15 600
84640e27 Karicheri, Muralidharan 2015-01-15 601get_words(_desc, 1,
>next_desc);
84640e27 Karicheri, Muralidharan 2015-01-15 602
84640e27 Karicheri, Muralidharan 2015-01-15 603while (dma_desc) {
84640e27 Karicheri, Muralidharan 2015-01-15 604ndesc =
knav_pool_desc_unmap(netcp->rx_pool, dma_desc, dma_sz);
84640e27 Karicheri, Muralidharan 2015-01-15 605if
(unlikely(!ndesc)) {
84640e27 Karicheri, Muralidharan 2015-01-15 606
dev_err(netcp->ndev_dev, "failed to unmap Rx desc\n");
84640e27 Karicheri, Muralidharan 2015-01-15 607break;
84640e27 Karicheri, Muralidharan 2015-01-15 608}
958d104e Arnd Bergmann 2015-12-18 609
get_pkt_info(_buf, , _desc, ndesc);
06324481 Karicheri, Muralidharan 2016-02-19 610/* warning
We are retrieving the virtual ptr in the sw_data
06324481 Karicheri, Muralidharan 2016-02-19 611 * field as a
32bit value. Will not work on 64bit machines
06324481 Karicheri, Muralidharan 2016-02-19 612 */
06324481
