RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Kishon, On Thu, Jan 24, 2013 at 17:21:45, Mohammed, Afzal wrote: > On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote: > > On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: > > > USB first instance of am335x works in mainline as of now. > > > Can you check if this series indeed breaks am335x? > > > > Thanks for your help. > > Do you have a tree having these changes, it would be easier for me. I tried with your "omap5-with-palmas" branch that was mentioned in the cover letter of your latest series (but couldn't find the commit that you mentioned in the cover letter, HEAD of that branch that I tested was "2c29519 ARM: dts: palmas: update dt data for palmas-usb") usb first instance of am335x works as earlier. Regards Afzal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Kishon, On Thu, Jan 24, 2013 at 17:21:45, Mohammed, Afzal wrote: On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote: On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: USB first instance of am335x works in mainline as of now. Can you check if this series indeed breaks am335x? Thanks for your help. Do you have a tree having these changes, it would be easier for me. I tried with your omap5-with-palmas branch that was mentioned in the cover letter of your latest series (but couldn't find the commit that you mentioned in the cover letter, HEAD of that branch that I tested was 2c29519 ARM: dts: palmas: update dt data for palmas-usb) usb first instance of am335x works as earlier. Regards Afzal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Kishon, On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote: > On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: > > USB first instance of am335x works in mainline as of now. > Can you check if this series indeed breaks am335x? > > Thanks for your help. Do you have a tree having these changes, it would be easier for me. Regards Afzal
RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Kishon, On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote: On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: USB first instance of am335x works in mainline as of now. Can you check if this series indeed breaks am335x? Thanks for your help. Do you have a tree having these changes, it would be easier for me. Regards Afzal
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Afzal, On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: Hi Koen, On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote: Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy enough to patch in locally. USB first instance of am335x works in mainline as of now. Can you check if this series indeed breaks am335x? Thanks for your help. Regards Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Koen, On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote: > Actually it uses nop-phy as a phy, which is missing from > arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the > nop-phy to the DT is easy enough to patch in locally. USB first instance of am335x works in mainline as of now. Regards Afzal
RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Koen, On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote: Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy enough to patch in locally. USB first instance of am335x works in mainline as of now. Regards Afzal
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi Afzal, On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote: Hi Koen, On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote: Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy enough to patch in locally. USB first instance of am335x works in mainline as of now. Can you check if this series indeed breaks am335x? Thanks for your help. Regards Kishon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
On Tuesday 22 January 2013 10:32 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 17:16 heeft kishon het volgende geschreven:
Hi,
On Tuesday 22 January 2013 09:15 PM, kishon wrote:
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I
het volgende geschreven:
This patch series adds support for adding multiple PHY's (of same type).
The binding information has to be present in the PHY library (otg.c) in
order for it to return the appropriate PHY whenever the USB controller
request for the PHY. So added a new API usb_bind_phy() to pass the
binding
information. This API should be called by platform specific
initialization
code.
So the binding should be done something like
usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); specifying
the USB
controller device name, index, and the PHY device name.
I have done this binding for OMAP platforms, but it should be done for
all the platforms.
After this design, the phy can be got by passing the USB controller
device
pointer and the index.
Developed this patch series on
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
after applying "usb: musb: add driver for control module" patch series
and "ARM: dts: omap: add dt data for MUSB"
Did basic enumeration testing in omap4 panda and omap3 beagle.
With this patchset USB completely breaks on am33xx beaglebone, is that
intended?
Not really.
Does am33xx makes use of omap2430.c? Which PHY does am33xx uses?
I figured out it uses drivers/usb/musb/musb_dsps.c (So it doesn't use
omap2430.c). I think it uses TWL4030_USB (TPS659x0) as PHY.
Actually it uses nop-phy as a phy, which is missing from
arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the
nop-phy to the DT is easy enough to patch in locally.
Cool. You can add your patch after applying this series then. (I'll post
a new version addressing the comments in this series.)
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Op 22 jan. 2013, om 17:16 heeft kishon het volgende geschreven:
> Hi,
>
> On Tuesday 22 January 2013 09:15 PM, kishon wrote:
>> On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
>>>
>>> Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I
>>> het volgende geschreven:
>>>
This patch series adds support for adding multiple PHY's (of same type).
The binding information has to be present in the PHY library (otg.c) in
order for it to return the appropriate PHY whenever the USB controller
request for the PHY. So added a new API usb_bind_phy() to pass the
binding
information. This API should be called by platform specific
initialization
code.
So the binding should be done something like
usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); specifying
the USB
controller device name, index, and the PHY device name.
I have done this binding for OMAP platforms, but it should be done for
all the platforms.
After this design, the phy can be got by passing the USB controller
device
pointer and the index.
Developed this patch series on
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
after applying "usb: musb: add driver for control module" patch series
and "ARM: dts: omap: add dt data for MUSB"
Did basic enumeration testing in omap4 panda and omap3 beagle.
>>>
>>> With this patchset USB completely breaks on am33xx beaglebone, is that
>>> intended?
>> Not really.
>> Does am33xx makes use of omap2430.c? Which PHY does am33xx uses?
>
> I figured out it uses drivers/usb/musb/musb_dsps.c (So it doesn't use
> omap2430.c). I think it uses TWL4030_USB (TPS659x0) as PHY.
Actually it uses nop-phy as a phy, which is missing from
arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the
nop-phy to the DT is easy enough to patch in locally.
regards,
Koen--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi,
On Tuesday 22 January 2013 09:15 PM, kishon wrote:
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I
het volgende geschreven:
This patch series adds support for adding multiple PHY's (of same type).
The binding information has to be present in the PHY library (otg.c) in
order for it to return the appropriate PHY whenever the USB controller
request for the PHY. So added a new API usb_bind_phy() to pass the
binding
information. This API should be called by platform specific
initialization
code.
So the binding should be done something like
usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); specifying
the USB
controller device name, index, and the PHY device name.
I have done this binding for OMAP platforms, but it should be done for
all the platforms.
After this design, the phy can be got by passing the USB controller
device
pointer and the index.
Developed this patch series on
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
after applying "usb: musb: add driver for control module" patch series
and "ARM: dts: omap: add dt data for MUSB"
Did basic enumeration testing in omap4 panda and omap3 beagle.
With this patchset USB completely breaks on am33xx beaglebone, is that
intended?
Not really.
Does am33xx makes use of omap2430.c? Which PHY does am33xx uses?
I figured out it uses drivers/usb/musb/musb_dsps.c (So it doesn't use
omap2430.c). I think it uses TWL4030_USB (TPS659x0) as PHY.
Then we need to adapt am33xx to use devm_usb_get_phy_by_phandle.
I'll see how to do it.
Thank you for testing and reporting it :-)
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote:
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I het
volgende geschreven:
This patch series adds support for adding multiple PHY's (of same type).
The binding information has to be present in the PHY library (otg.c) in
order for it to return the appropriate PHY whenever the USB controller
request for the PHY. So added a new API usb_bind_phy() to pass the binding
information. This API should be called by platform specific initialization
code.
So the binding should be done something like
usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); specifying the USB
controller device name, index, and the PHY device name.
I have done this binding for OMAP platforms, but it should be done for
all the platforms.
After this design, the phy can be got by passing the USB controller device
pointer and the index.
Developed this patch series on
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
after applying "usb: musb: add driver for control module" patch series
and "ARM: dts: omap: add dt data for MUSB"
Did basic enumeration testing in omap4 panda and omap3 beagle.
With this patchset USB completely breaks on am33xx beaglebone, is that intended?
Not really.
Does am33xx makes use of omap2430.c? Which PHY does am33xx uses?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I het
volgende geschreven:
> This patch series adds support for adding multiple PHY's (of same type).
> The binding information has to be present in the PHY library (otg.c) in
> order for it to return the appropriate PHY whenever the USB controller
> request for the PHY. So added a new API usb_bind_phy() to pass the binding
> information. This API should be called by platform specific initialization
> code.
>
> So the binding should be done something like
> usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto"); specifying the USB
> controller device name, index, and the PHY device name.
> I have done this binding for OMAP platforms, but it should be done for
> all the platforms.
>
> After this design, the phy can be got by passing the USB controller device
> pointer and the index.
>
> Developed this patch series on
> git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv
> after applying "usb: musb: add driver for control module" patch series
> and "ARM: dts: omap: add dt data for MUSB"
>
> Did basic enumeration testing in omap4 panda and omap3 beagle.
With this patchset USB completely breaks on am33xx beaglebone, is that intended?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate PHY whenever the USB controller request for the PHY. So added a new API usb_bind_phy() to pass the binding information. This API should be called by platform specific initialization code. So the binding should be done something like usb_bind_phy(musb-hdrc.0.auto, 0, omap-usb2.1.auto); specifying the USB controller device name, index, and the PHY device name. I have done this binding for OMAP platforms, but it should be done for all the platforms. After this design, the phy can be got by passing the USB controller device pointer and the index. Developed this patch series on git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv after applying usb: musb: add driver for control module patch series and ARM: dts: omap: add dt data for MUSB Did basic enumeration testing in omap4 panda and omap3 beagle. With this patchset USB completely breaks on am33xx beaglebone, is that intended? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate PHY whenever the USB controller request for the PHY. So added a new API usb_bind_phy() to pass the binding information. This API should be called by platform specific initialization code. So the binding should be done something like usb_bind_phy(musb-hdrc.0.auto, 0, omap-usb2.1.auto); specifying the USB controller device name, index, and the PHY device name. I have done this binding for OMAP platforms, but it should be done for all the platforms. After this design, the phy can be got by passing the USB controller device pointer and the index. Developed this patch series on git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv after applying usb: musb: add driver for control module patch series and ARM: dts: omap: add dt data for MUSB Did basic enumeration testing in omap4 panda and omap3 beagle. With this patchset USB completely breaks on am33xx beaglebone, is that intended? Not really. Does am33xx makes use of omap2430.c? Which PHY does am33xx uses? Thanks Kishon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Hi, On Tuesday 22 January 2013 09:15 PM, kishon wrote: On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate PHY whenever the USB controller request for the PHY. So added a new API usb_bind_phy() to pass the binding information. This API should be called by platform specific initialization code. So the binding should be done something like usb_bind_phy(musb-hdrc.0.auto, 0, omap-usb2.1.auto); specifying the USB controller device name, index, and the PHY device name. I have done this binding for OMAP platforms, but it should be done for all the platforms. After this design, the phy can be got by passing the USB controller device pointer and the index. Developed this patch series on git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv after applying usb: musb: add driver for control module patch series and ARM: dts: omap: add dt data for MUSB Did basic enumeration testing in omap4 panda and omap3 beagle. With this patchset USB completely breaks on am33xx beaglebone, is that intended? Not really. Does am33xx makes use of omap2430.c? Which PHY does am33xx uses? I figured out it uses drivers/usb/musb/musb_dsps.c (So it doesn't use omap2430.c). I think it uses TWL4030_USB (TPS659x0) as PHY. Then we need to adapt am33xx to use devm_usb_get_phy_by_phandle. I'll see how to do it. Thank you for testing and reporting it :-) Thanks Kishon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
Op 22 jan. 2013, om 17:16 heeft kishon kis...@ti.com het volgende geschreven: Hi, On Tuesday 22 January 2013 09:15 PM, kishon wrote: On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate PHY whenever the USB controller request for the PHY. So added a new API usb_bind_phy() to pass the binding information. This API should be called by platform specific initialization code. So the binding should be done something like usb_bind_phy(musb-hdrc.0.auto, 0, omap-usb2.1.auto); specifying the USB controller device name, index, and the PHY device name. I have done this binding for OMAP platforms, but it should be done for all the platforms. After this design, the phy can be got by passing the USB controller device pointer and the index. Developed this patch series on git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv after applying usb: musb: add driver for control module patch series and ARM: dts: omap: add dt data for MUSB Did basic enumeration testing in omap4 panda and omap3 beagle. With this patchset USB completely breaks on am33xx beaglebone, is that intended? Not really. Does am33xx makes use of omap2430.c? Which PHY does am33xx uses? I figured out it uses drivers/usb/musb/musb_dsps.c (So it doesn't use omap2430.c). I think it uses TWL4030_USB (TPS659x0) as PHY. Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy enough to patch in locally. regards, Koen-- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type
On Tuesday 22 January 2013 10:32 PM, Koen Kooi wrote: Op 22 jan. 2013, om 17:16 heeft kishon kis...@ti.com het volgende geschreven: Hi, On Tuesday 22 January 2013 09:15 PM, kishon wrote: On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I kis...@ti.com het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order for it to return the appropriate PHY whenever the USB controller request for the PHY. So added a new API usb_bind_phy() to pass the binding information. This API should be called by platform specific initialization code. So the binding should be done something like usb_bind_phy(musb-hdrc.0.auto, 0, omap-usb2.1.auto); specifying the USB controller device name, index, and the PHY device name. I have done this binding for OMAP platforms, but it should be done for all the platforms. After this design, the phy can be got by passing the USB controller device pointer and the index. Developed this patch series on git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git xceiv after applying usb: musb: add driver for control module patch series and ARM: dts: omap: add dt data for MUSB Did basic enumeration testing in omap4 panda and omap3 beagle. With this patchset USB completely breaks on am33xx beaglebone, is that intended? Not really. Does am33xx makes use of omap2430.c? Which PHY does am33xx uses? I figured out it uses drivers/usb/musb/musb_dsps.c (So it doesn't use omap2430.c). I think it uses TWL4030_USB (TPS659x0) as PHY. Actually it uses nop-phy as a phy, which is missing from arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the nop-phy to the DT is easy enough to patch in locally. Cool. You can add your patch after applying this series then. (I'll post a new version addressing the comments in this series.) Thanks Kishon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
