Re: [PATCH v1 5/5] platform/x86: intel_telemetry: Improve S0ix logs

[Andy Shevchenko]

On Thu, Nov 16, 2017 at 12:18 PM, Souvik Kumar Chakravarty
 wrote:
> Suspend with shallow wakes is not a useful parameter since the phenomena
> does not exist on deployed devices and is only a parameter of use during
> device power-on phase. The field always reads zero. Additionally there
> are other easier methods to detect it, e.g., if the S0ix counter
> increments by more than one during suspend. Hence the field is superfluous
> and can be removed.
>
> This patch also slightly renames the S0ix total field for better
> viewability.

> -   (u64)(s0ix_total_res*10/192));
> +  (u64)(s0ix_total_res*10/192));

Why indentation is changed? Candidate for the patch wrt indentation thingy.

> -   if (suspend_shlw_ctr_exit == 1) {
> +   if (suspend_shlw_ctr_exit > 0) {

How could it be less than 0?

!= 0 ?

> -   if (suspend_deep_ctr_exit == 1) {
> +   if (suspend_deep_ctr_exit > 0) {

Ditto.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 5/5] platform/x86: intel_telemetry: Improve S0ix logs

[Andy Shevchenko]

On Thu, Nov 16, 2017 at 12:18 PM, Souvik Kumar Chakravarty
 wrote:
> Suspend with shallow wakes is not a useful parameter since the phenomena
> does not exist on deployed devices and is only a parameter of use during
> device power-on phase. The field always reads zero. Additionally there
> are other easier methods to detect it, e.g., if the S0ix counter
> increments by more than one during suspend. Hence the field is superfluous
> and can be removed.
>
> This patch also slightly renames the S0ix total field for better
> viewability.

> -   (u64)(s0ix_total_res*10/192));
> +  (u64)(s0ix_total_res*10/192));

Why indentation is changed? Candidate for the patch wrt indentation thingy.

> -   if (suspend_shlw_ctr_exit == 1) {
> +   if (suspend_shlw_ctr_exit > 0) {

How could it be less than 0?

!= 0 ?

> -   if (suspend_deep_ctr_exit == 1) {
> +   if (suspend_deep_ctr_exit > 0) {

Ditto.

-- 
With Best Regards,
Andy Shevchenko