Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
Hi, On Tuesday 22 January 2013 09:08 PM, Peter Ujfalusi wrote: On 01/22/2013 04:21 PM, kishon wrote: But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a driver the deferred modules will try to probe again. This is to check back if the dependency of the deferred modules has been fulfilled by the new driver or not. Thanks Peter. -Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On 01/22/2013 04:21 PM, kishon wrote: > But it's better to check if deferred probing > takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a driver the deferred modules will try to probe again. This is to check back if the dependency of the deferred modules has been fulfilled by the new driver or not. -- Péter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote:
On 01/22/2013 04:37 PM, kishon wrote:
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 1a8cf6d..e43faeb 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
* up through ULPI. TWL4030-family PMICs include one,
* which needs a driver, drivers aren't always needed.
*/
-musb->xceiv = devm_usb_get_phy_dev(dev, 0);
+if (dev->parent->of_node)
+musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent,
+"usb_phy", 0);
+else
+musb->xceiv = devm_usb_get_phy_dev(dev, 0);
+
if (IS_ERR_OR_NULL(musb->xceiv)) {
pr_err("HS USB OTG: no transceiver configured\n");
return -ENODEV;
This will not work with PHY driver as a module. You need to use deferred
probing mechanism here
after you have addressed my comment in patch 2 and also
devm_usb_get_phy_by_phandle()
IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver
as module, since the kernel will try to probe only till the prompt comes.
Oh really? I thought deferred probing takes place whenever a new driver is
bound to a device.
You might also be right. I'm not so sure.
What does "prompt comes" have to do with it?
I just meant end of boot process. But it's better to check if deferred
probing takes place whenever a new driver is bound to a device as you
just mentioned.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On 01/22/2013 04:37 PM, kishon wrote:
> On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
>> On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
>>> The OMAP glue has been modified to get PHY by phandle for dt boot.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I
>>> ---
>>> drivers/usb/musb/omap2430.c |7 ++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
>>> index 1a8cf6d..e43faeb 100644
>>> --- a/drivers/usb/musb/omap2430.c
>>> +++ b/drivers/usb/musb/omap2430.c
>>> @@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
>>>* up through ULPI. TWL4030-family PMICs include one,
>>>* which needs a driver, drivers aren't always needed.
>>>*/
>>> -musb->xceiv = devm_usb_get_phy_dev(dev, 0);
>>> +if (dev->parent->of_node)
>>> +musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent,
>>> +"usb_phy", 0);
>>> +else
>>> +musb->xceiv = devm_usb_get_phy_dev(dev, 0);
>>> +
>>> if (IS_ERR_OR_NULL(musb->xceiv)) {
>>> pr_err("HS USB OTG: no transceiver configured\n");
>>> return -ENODEV;
>>
>> This will not work with PHY driver as a module. You need to use deferred
>> probing mechanism here
>> after you have addressed my comment in patch 2 and also
>> devm_usb_get_phy_by_phandle()
>
> IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver
> as module, since the kernel will try to probe only till the prompt comes.
>
Oh really? I thought deferred probing takes place whenever a new driver is
bound to a device. What does "prompt comes" have to do with it?
> And having -EPROBE_DEFER instead of -ENODEV might also not help since, the
> gadget driver wont be able to bind to UDC (usb_gadget_probe_driver will fail).
>
> A lot of things need to be changed before we change to -EPROBE_DEFER IMO.
OK.
--
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 1a8cf6d..e43faeb 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
* up through ULPI. TWL4030-family PMICs include one,
* which needs a driver, drivers aren't always needed.
*/
- musb->xceiv = devm_usb_get_phy_dev(dev, 0);
+ if (dev->parent->of_node)
+ musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent,
+ "usb_phy", 0);
+ else
+ musb->xceiv = devm_usb_get_phy_dev(dev, 0);
+
if (IS_ERR_OR_NULL(musb->xceiv)) {
pr_err("HS USB OTG: no transceiver configured\n");
return -ENODEV;
This will not work with PHY driver as a module. You need to use deferred
probing mechanism here
after you have addressed my comment in patch 2 and also
devm_usb_get_phy_by_phandle()
IIUC, even using -EPROBE_DEFER might not help if we are making the PHY
driver as module, since the kernel will try to probe only till the
prompt comes.
And having -EPROBE_DEFER instead of -ENODEV might also not help since,
the gadget driver wont be able to bind to UDC (usb_gadget_probe_driver
will fail).
A lot of things need to be changed before we change to -EPROBE_DEFER IMO.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
> The OMAP glue has been modified to get PHY by phandle for dt boot.
>
> Signed-off-by: Kishon Vijay Abraham I
> ---
> drivers/usb/musb/omap2430.c |7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 1a8cf6d..e43faeb 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
>* up through ULPI. TWL4030-family PMICs include one,
>* which needs a driver, drivers aren't always needed.
>*/
> - musb->xceiv = devm_usb_get_phy_dev(dev, 0);
> + if (dev->parent->of_node)
> + musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent,
> + "usb_phy", 0);
> + else
> + musb->xceiv = devm_usb_get_phy_dev(dev, 0);
> +
> if (IS_ERR_OR_NULL(musb->xceiv)) {
> pr_err("HS USB OTG: no transceiver configured\n");
> return -ENODEV;
This will not work with PHY driver as a module. You need to use deferred
probing mechanism here
after you have addressed my comment in patch 2 and also
devm_usb_get_phy_by_phandle()
e.g.
if (IS_ERR(musb->xceiv)) {
int ret = PTR_ERR(musb->xveiv);
if (ret == -ENODEV)
pr_err("HS USB OTG: no transceiver configured\n");
return ret;
}
--
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 1a8cf6d..e43faeb 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
* up through ULPI. TWL4030-family PMICs include one,
* which needs a driver, drivers aren't always needed.
*/
- musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+ if (dev-parent-of_node)
+ musb-xceiv = devm_usb_get_phy_by_phandle(dev-parent,
+ usb_phy, 0);
+ else
+ musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+
if (IS_ERR_OR_NULL(musb-xceiv)) {
pr_err(HS USB OTG: no transceiver configured\n);
return -ENODEV;
This will not work with PHY driver as a module. You need to use deferred
probing mechanism here
after you have addressed my comment in patch 2 and also
devm_usb_get_phy_by_phandle()
e.g.
if (IS_ERR(musb-xceiv)) {
int ret = PTR_ERR(musb-xveiv);
if (ret == -ENODEV)
pr_err(HS USB OTG: no transceiver configured\n);
return ret;
}
--
cheers,
-roger
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 1a8cf6d..e43faeb 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
* up through ULPI. TWL4030-family PMICs include one,
* which needs a driver, drivers aren't always needed.
*/
- musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+ if (dev-parent-of_node)
+ musb-xceiv = devm_usb_get_phy_by_phandle(dev-parent,
+ usb_phy, 0);
+ else
+ musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+
if (IS_ERR_OR_NULL(musb-xceiv)) {
pr_err(HS USB OTG: no transceiver configured\n);
return -ENODEV;
This will not work with PHY driver as a module. You need to use deferred
probing mechanism here
after you have addressed my comment in patch 2 and also
devm_usb_get_phy_by_phandle()
IIUC, even using -EPROBE_DEFER might not help if we are making the PHY
driver as module, since the kernel will try to probe only till the
prompt comes.
And having -EPROBE_DEFER instead of -ENODEV might also not help since,
the gadget driver wont be able to bind to UDC (usb_gadget_probe_driver
will fail).
A lot of things need to be changed before we change to -EPROBE_DEFER IMO.
Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On 01/22/2013 04:37 PM, kishon wrote:
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 1a8cf6d..e43faeb 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
* up through ULPI. TWL4030-family PMICs include one,
* which needs a driver, drivers aren't always needed.
*/
-musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+if (dev-parent-of_node)
+musb-xceiv = devm_usb_get_phy_by_phandle(dev-parent,
+usb_phy, 0);
+else
+musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+
if (IS_ERR_OR_NULL(musb-xceiv)) {
pr_err(HS USB OTG: no transceiver configured\n);
return -ENODEV;
This will not work with PHY driver as a module. You need to use deferred
probing mechanism here
after you have addressed my comment in patch 2 and also
devm_usb_get_phy_by_phandle()
IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver
as module, since the kernel will try to probe only till the prompt comes.
Oh really? I thought deferred probing takes place whenever a new driver is
bound to a device. What does prompt comes have to do with it?
And having -EPROBE_DEFER instead of -ENODEV might also not help since, the
gadget driver wont be able to bind to UDC (usb_gadget_probe_driver will fail).
A lot of things need to be changed before we change to -EPROBE_DEFER IMO.
OK.
--
cheers,
-roger
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote:
On 01/22/2013 04:37 PM, kishon wrote:
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 1a8cf6d..e43faeb 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -345,7 +345,12 @@ static int omap2430_musb_init(struct musb *musb)
* up through ULPI. TWL4030-family PMICs include one,
* which needs a driver, drivers aren't always needed.
*/
-musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+if (dev-parent-of_node)
+musb-xceiv = devm_usb_get_phy_by_phandle(dev-parent,
+usb_phy, 0);
+else
+musb-xceiv = devm_usb_get_phy_dev(dev, 0);
+
if (IS_ERR_OR_NULL(musb-xceiv)) {
pr_err(HS USB OTG: no transceiver configured\n);
return -ENODEV;
This will not work with PHY driver as a module. You need to use deferred
probing mechanism here
after you have addressed my comment in patch 2 and also
devm_usb_get_phy_by_phandle()
IIUC, even using -EPROBE_DEFER might not help if we are making the PHY driver
as module, since the kernel will try to probe only till the prompt comes.
Oh really? I thought deferred probing takes place whenever a new driver is
bound to a device.
You might also be right. I'm not so sure.
What does prompt comes have to do with it?
I just meant end of boot process. But it's better to check if deferred
probing takes place whenever a new driver is bound to a device as you
just mentioned.
Thanks
Kishon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
On 01/22/2013 04:21 PM, kishon wrote: But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a driver the deferred modules will try to probe again. This is to check back if the dependency of the deferred modules has been fulfilled by the new driver or not. -- Péter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot
Hi, On Tuesday 22 January 2013 09:08 PM, Peter Ujfalusi wrote: On 01/22/2013 04:21 PM, kishon wrote: But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a driver the deferred modules will try to probe again. This is to check back if the dependency of the deferred modules has been fulfilled by the new driver or not. Thanks Peter. -Kishon -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
