Re: [PATCH v18 24/32] mm/pgdat: remove pgdat lru_lock

2020-09-22 Thread Alex Shi



在 2020/9/22 下午1:53, Hugh Dickins 写道:
>> Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore.
>>
>> Signed-off-by: Alex Shi 
>> Reviewed-by: Alexander Duyck 
> I don't take pleasure in spoiling your celebrations and ceremonies,
> but I strongly agree with AlexD that this should simply be merged
> into the big one, 20/32.  That can be ceremony enough.
> 

folded into that patch.
Thanks!


Re: [PATCH v18 24/32] mm/pgdat: remove pgdat lru_lock

2020-09-21 Thread Hugh Dickins
On Mon, 24 Aug 2020, Alex Shi wrote:

> Now pgdat.lru_lock was replaced by lruvec lock. It's not used anymore.
> 
> Signed-off-by: Alex Shi 
> Reviewed-by: Alexander Duyck 

I don't take pleasure in spoiling your celebrations and ceremonies,
but I strongly agree with AlexD that this should simply be merged
into the big one, 20/32.  That can be ceremony enough.

> Cc: Andrew Morton 
> Cc: Konstantin Khlebnikov 
> Cc: Hugh Dickins 
> Cc: Johannes Weiner 
> Cc: linux...@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Cc: cgro...@vger.kernel.org
> ---
>  include/linux/mmzone.h | 1 -
>  mm/page_alloc.c| 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index f0596e634863..0ed520954843 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -758,7 +758,6 @@ struct deferred_split {
>  
>   /* Write-intensive fields used by page reclaim */
>   ZONE_PADDING(_pad1_)
> - spinlock_t  lru_lock;
>  
>  #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
>   /*
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index fab5e97dc9ca..775120fcc869 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6733,7 +6733,6 @@ static void __meminit pgdat_init_internals(struct 
> pglist_data *pgdat)
>   init_waitqueue_head(>pfmemalloc_wait);
>  
>   pgdat_page_ext_init(pgdat);
> - spin_lock_init(>lru_lock);
>   lruvec_init(>__lruvec);
>  }
>  
> -- 
> 1.8.3.1