Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups
On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote: In most cases, usleep_range is better than udelay, as the precise wakeup from udelay is unnecessary. But, udelay does something different than usleep, are you sure you should be giving up the cpu at this point in time? Are you sure you are even in a function that is allowed to sleep? I don't think that is the case for all of these at all, sorry, unless you have the hardware to test this change, I can't take it. greg k-h I wasn't aware of this, thank you for pointing out. Since I don't have this hardware, I'm unable to test the changes. Shiva Kerdel
Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups
On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote: In most cases, usleep_range is better than udelay, as the precise wakeup from udelay is unnecessary. But, udelay does something different than usleep, are you sure you should be giving up the cpu at this point in time? Are you sure you are even in a function that is allowed to sleep? I don't think that is the case for all of these at all, sorry, unless you have the hardware to test this change, I can't take it. greg k-h I wasn't aware of this, thank you for pointing out. Since I don't have this hardware, I'm unable to test the changes. Shiva Kerdel
Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups
On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote: > In most cases, usleep_range is better than udelay, as the precise wakeup > from udelay is unnecessary. But, udelay does something different than usleep, are you sure you should be giving up the cpu at this point in time? Are you sure you are even in a function that is allowed to sleep? I don't think that is the case for all of these at all, sorry, unless you have the hardware to test this change, I can't take it. greg k-h
Re: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups
On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote: > In most cases, usleep_range is better than udelay, as the precise wakeup > from udelay is unnecessary. But, udelay does something different than usleep, are you sure you should be giving up the cpu at this point in time? Are you sure you are even in a function that is allowed to sleep? I don't think that is the case for all of these at all, sorry, unless you have the hardware to test this change, I can't take it. greg k-h