Re: [PATCH v2] i2c: mv64xxx: continue probe when clock-frequency is missing
On Mon, Sep 01, 2014 at 10:28:13PM +0800, Chen-Yu Tsai wrote:
> The "clock-frequency" DT property is listed as optional, However,
> the current code stores the return value of of_property_read_u32 in
> the return code of mv64xxx_of_config, but then forgets to clear it
> after setting the default value of "clock-frequency". It is then
> passed out to the main probe function, resulting in a probe failure
> when "clock-frequency" is missing.
>
> This patch checks and then throws away the return value of
> of_property_read_u32, instead of storing it and having to clear it
> afterwards.
>
> This issue was discovered after the property was removed from all
> sunxi DTs.
Hmm, I don't like that removal. Probably I should take care that this
property is not "optional" but "recommended". The default value is
depending on the driver, mostly because of historic reasons. It is
definately better to explicitly state it. Despite all that...
>
> Fixes: 4c730a06c19bb ("i2c: mv64xxx: Set bus frequency to 100kHz if
> clock-frequency is not provided")
> Signed-off-by: Chen-Yu Tsai
> Cc: sta...@vger.kernel.org
> Acked-by: Andrew Lunn
> Acked-by: Maxime Ripard
Applied to for-current, thanks!
signature.asc
Description: Digital signature
Re: [PATCH v2] i2c: mv64xxx: continue probe when clock-frequency is missing
On Mon, Sep 01, 2014 at 10:28:13PM +0800, Chen-Yu Tsai wrote: The clock-frequency DT property is listed as optional, However, the current code stores the return value of of_property_read_u32 in the return code of mv64xxx_of_config, but then forgets to clear it after setting the default value of clock-frequency. It is then passed out to the main probe function, resulting in a probe failure when clock-frequency is missing. This patch checks and then throws away the return value of of_property_read_u32, instead of storing it and having to clear it afterwards. This issue was discovered after the property was removed from all sunxi DTs. Hmm, I don't like that removal. Probably I should take care that this property is not optional but recommended. The default value is depending on the driver, mostly because of historic reasons. It is definately better to explicitly state it. Despite all that... Fixes: 4c730a06c19bb (i2c: mv64xxx: Set bus frequency to 100kHz if clock-frequency is not provided) Signed-off-by: Chen-Yu Tsai w...@csie.org Cc: sta...@vger.kernel.org Acked-by: Andrew Lunn and...@lunn.ch Acked-by: Maxime Ripard maxime.rip...@free-electrons.com Applied to for-current, thanks! signature.asc Description: Digital signature
