Re: [PATCH v2] rcar-dmac: initialize all data before registering IRQ handler

[Vinod Koul]

On Mon, Aug 21, 2017 at 06:31:57AM +, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto 
> 
> Anton Volkov noticed that engine->dev is NULL before
> of_dma_controller_register() in probe.
> Thus there might be a NULL pointer dereference in
> rcar_dmac_chan_start_xfer while accessing chan->chan.device->dev which
> is equal to (>engine)->dev.
> On same reason, same and similar things will happen if we didn't
> initialize all necessary data before calling register irq function.
> To be more safety code, this patch initialize all necessary data
> before calling register irq function.

Applied after adding subsytem name, thanks

-- 
~Vinod

Re: [PATCH v2] rcar-dmac: initialize all data before registering IRQ handler

[Vinod Koul]

On Mon, Aug 21, 2017 at 06:31:57AM +, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto 
> 
> Anton Volkov noticed that engine->dev is NULL before
> of_dma_controller_register() in probe.
> Thus there might be a NULL pointer dereference in
> rcar_dmac_chan_start_xfer while accessing chan->chan.device->dev which
> is equal to (>engine)->dev.
> On same reason, same and similar things will happen if we didn't
> initialize all necessary data before calling register irq function.
> To be more safety code, this patch initialize all necessary data
> before calling register irq function.

Applied after adding subsytem name, thanks

-- 
~Vinod