Re: [PATCH v2] virtio_blk: Add support for lifetime feature
On Tue, 20 Apr 2021 06:08:29 -0400 "Michael S. Tsirkin" wrote: > On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote: > > Just to despit my 2 cents again: I think the way this is specified > > in the virtio spec is actively harmful and we should not suport it in > > Linux. > > > > If others override me we at least need to require a detailed > > documentation of these fields as the virto spec does not provide it. > > > > Please also do not add pointless over 80 character lines, and follow > > the one value per sysfs file rule. > > Enrico would you like to raise the issues with the virtio TC > for resolution? > FWIW, I've opened https://github.com/oasis-tcs/virtio-spec/issues/106 to track this.
Re: [PATCH v2] virtio_blk: Add support for lifetime feature
I prepared a proposed patch to address these concerns: https://lists.oasis-open.org/archives/virtio-dev/202104/msg7.html Feedback will be much appreciated Thanks, - Enrico On Tue, Apr 20, 2021 at 4:08 AM Michael S. Tsirkin wrote: > > On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote: > > Just to despit my 2 cents again: I think the way this is specified > > in the virtio spec is actively harmful and we should not suport it in > > Linux. > > > > If others override me we at least need to require a detailed > > documentation of these fields as the virto spec does not provide it. > > > > Please also do not add pointless over 80 character lines, and follow > > the one value per sysfs file rule. > > Enrico would you like to raise the issues with the virtio TC > for resolution? > > -- > MST >
Re: [PATCH v2] virtio_blk: Add support for lifetime feature
On Tue, Apr 20, 2021 at 08:01:29AM +0100, Christoph Hellwig wrote: > Just to despit my 2 cents again: I think the way this is specified > in the virtio spec is actively harmful and we should not suport it in > Linux. > > If others override me we at least need to require a detailed > documentation of these fields as the virto spec does not provide it. > > Please also do not add pointless over 80 character lines, and follow > the one value per sysfs file rule. Enrico would you like to raise the issues with the virtio TC for resolution? -- MST
Re: [PATCH v2] virtio_blk: Add support for lifetime feature
Just to despit my 2 cents again: I think the way this is specified in the virtio spec is actively harmful and we should not suport it in Linux. If others override me we at least need to require a detailed documentation of these fields as the virto spec does not provide it. Please also do not add pointless over 80 character lines, and follow the one value per sysfs file rule.
