Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

[Alex Deucher]

On Sat, May 20, 2017 at 7:39 AM, Christian König
 wrote:
> Am 20.05.2017 um 01:48 schrieb Lyude:
>>
>> This is the first part of me going through and cleaning up the IRQ
>> handling
>> code for radeon, since after taking a look at it the other day while
>> trying to
>> debug something I realized basically all of the code was copy pasted
>> everywhere, and quite difficult to actually read through.
>>
>> Will come up with something for r600 and cik once I've got the chipsets on
>> hand
>> to test with.
>>
>> Lyude (3):
>>drm/radeon: Cleanup display interrupt handling for evergreen, si
>>drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
>>drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si
>
>
> I don't have time to do a line by line review, but what I saw looked very
> good to me.
>
> So the whole seres is Acked-by: Christian König .

Applied.  thanks!

Alex


>
> BTW: You don't want to take a look at the other hw generations as well?
>
> Regards,
> Christian.
>
>>
>>   drivers/gpu/drm/radeon/evergreen.c  | 943
>> ++--
>>   drivers/gpu/drm/radeon/radeon.h |  27 +-
>>   drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
>>   drivers/gpu/drm/radeon/si.c | 655 +-
>>   4 files changed, 344 insertions(+), 1316 deletions(-)
>>
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

[Alex Deucher]

On Sat, May 20, 2017 at 7:39 AM, Christian König
 wrote:
> Am 20.05.2017 um 01:48 schrieb Lyude:
>>
>> This is the first part of me going through and cleaning up the IRQ
>> handling
>> code for radeon, since after taking a look at it the other day while
>> trying to
>> debug something I realized basically all of the code was copy pasted
>> everywhere, and quite difficult to actually read through.
>>
>> Will come up with something for r600 and cik once I've got the chipsets on
>> hand
>> to test with.
>>
>> Lyude (3):
>>drm/radeon: Cleanup display interrupt handling for evergreen, si
>>drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
>>drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si
>
>
> I don't have time to do a line by line review, but what I saw looked very
> good to me.
>
> So the whole seres is Acked-by: Christian König .

Applied.  thanks!

Alex


>
> BTW: You don't want to take a look at the other hw generations as well?
>
> Regards,
> Christian.
>
>>
>>   drivers/gpu/drm/radeon/evergreen.c  | 943
>> ++--
>>   drivers/gpu/drm/radeon/radeon.h |  27 +-
>>   drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
>>   drivers/gpu/drm/radeon/si.c | 655 +-
>>   4 files changed, 344 insertions(+), 1316 deletions(-)
>>
>
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

[Lyude Paul]

On Sat, 2017-05-20 at 13:39 +0200, Christian König wrote:
> Am 20.05.2017 um 01:48 schrieb Lyude:
> > This is the first part of me going through and cleaning up the IRQ
> > handling
> > code for radeon, since after taking a look at it the other day
> > while trying to
> > debug something I realized basically all of the code was copy
> > pasted
> > everywhere, and quite difficult to actually read through.
> > 
> > Will come up with something for r600 and cik once I've got the
> > chipsets on hand
> > to test with.
> > 
> > Lyude (3):
> >    drm/radeon: Cleanup display interrupt handling for evergreen, si
> >    drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
> >    drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si
> 
> I don't have time to do a line by line review, but what I saw looked 
> very good to me.
> 
> So the whole seres is Acked-by: Christian König  .com>.
> 
> BTW: You don't want to take a look at the other hw generations as
> well?
Oh don't worry, I'm already planning on that! The next chance I have
available I'll be going my coworker's GPUs so I can get the hardware I
need to test refactors I write of the rest of the hw gen's IRQ handling
code. :)
> 
> Regards,
> Christian.
> 
> > 
> >   drivers/gpu/drm/radeon/evergreen.c  | 943 ++-
> > -
> >   drivers/gpu/drm/radeon/radeon.h |  27 +-
> >   drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
> >   drivers/gpu/drm/radeon/si.c | 655 +
> > -
> >   4 files changed, 344 insertions(+), 1316 deletions(-)
> > 
> 
> 

Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

[Lyude Paul]

On Sat, 2017-05-20 at 13:39 +0200, Christian König wrote:
> Am 20.05.2017 um 01:48 schrieb Lyude:
> > This is the first part of me going through and cleaning up the IRQ
> > handling
> > code for radeon, since after taking a look at it the other day
> > while trying to
> > debug something I realized basically all of the code was copy
> > pasted
> > everywhere, and quite difficult to actually read through.
> > 
> > Will come up with something for r600 and cik once I've got the
> > chipsets on hand
> > to test with.
> > 
> > Lyude (3):
> >    drm/radeon: Cleanup display interrupt handling for evergreen, si
> >    drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
> >    drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si
> 
> I don't have time to do a line by line review, but what I saw looked 
> very good to me.
> 
> So the whole seres is Acked-by: Christian König  .com>.
> 
> BTW: You don't want to take a look at the other hw generations as
> well?
Oh don't worry, I'm already planning on that! The next chance I have
available I'll be going my coworker's GPUs so I can get the hardware I
need to test refactors I write of the rest of the hw gen's IRQ handling
code. :)
> 
> Regards,
> Christian.
> 
> > 
> >   drivers/gpu/drm/radeon/evergreen.c  | 943 ++-
> > -
> >   drivers/gpu/drm/radeon/radeon.h |  27 +-
> >   drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
> >   drivers/gpu/drm/radeon/si.c | 655 +
> > -
> >   4 files changed, 344 insertions(+), 1316 deletions(-)
> > 
> 
> 

Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

[Christian König]

Am 20.05.2017 um 01:48 schrieb Lyude:

This is the first part of me going through and cleaning up the IRQ handling
code for radeon, since after taking a look at it the other day while trying to
debug something I realized basically all of the code was copy pasted
everywhere, and quite difficult to actually read through.

Will come up with something for r600 and cik once I've got the chipsets on hand
to test with.

Lyude (3):
   drm/radeon: Cleanup display interrupt handling for evergreen, si
   drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
   drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si


I don't have time to do a line by line review, but what I saw looked 
very good to me.


So the whole seres is Acked-by: Christian König .

BTW: You don't want to take a look at the other hw generations as well?

Regards,
Christian.



  drivers/gpu/drm/radeon/evergreen.c  | 943 ++--
  drivers/gpu/drm/radeon/radeon.h |  27 +-
  drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
  drivers/gpu/drm/radeon/si.c | 655 +-
  4 files changed, 344 insertions(+), 1316 deletions(-)

Re: [PATCH v2 0/3] Cleanup evergreen/si IRQ handling code

[Christian König]

Am 20.05.2017 um 01:48 schrieb Lyude:

This is the first part of me going through and cleaning up the IRQ handling
code for radeon, since after taking a look at it the other day while trying to
debug something I realized basically all of the code was copy pasted
everywhere, and quite difficult to actually read through.

Will come up with something for r600 and cik once I've got the chipsets on hand
to test with.

Lyude (3):
   drm/radeon: Cleanup display interrupt handling for evergreen, si
   drm/radeon: Cleanup HDMI audio interrupt handling for evergreen
   drm/radeon: Cleanup pageflipping IRQ handling for evergreen, si


I don't have time to do a line by line review, but what I saw looked 
very good to me.


So the whole seres is Acked-by: Christian König .

BTW: You don't want to take a look at the other hw generations as well?

Regards,
Christian.



  drivers/gpu/drm/radeon/evergreen.c  | 943 ++--
  drivers/gpu/drm/radeon/radeon.h |  27 +-
  drivers/gpu/drm/radeon/radeon_irq_kms.c |  35 ++
  drivers/gpu/drm/radeon/si.c | 655 +-
  4 files changed, 344 insertions(+), 1316 deletions(-)