Re: [PATCH v2 06/19] ARM: dts: aspeed: Add watchdog clocks

2017-12-18 Thread Cédric Le Goater 
On 12/15/2017 07:24 AM, Joel Stanley wrote:
> Signed-off-by: Joel Stanley 


Reviewed-by: Cédric Le Goater 


> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 2 ++
>  arch/arm/boot/dts/aspeed-g5.dtsi | 3 +++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi 
> b/arch/arm/boot/dts/aspeed-g4.dtsi
> index cf407b4db630..2e3666d4fbeb 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -177,11 +177,13 @@
>   wdt1: watchdog@1e785000 {
>   compatible = "aspeed,ast2400-wdt";
>   reg = <0x1e785000 0x1c>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   wdt2: watchdog@1e785020 {
>   compatible = "aspeed,ast2400-wdt";
>   reg = <0x1e785020 0x1c>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   vuart: serial@1e787000 {
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi 
> b/arch/arm/boot/dts/aspeed-g5.dtsi
> index ab26156d6822..24bb2d16b900 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -219,16 +219,19 @@
>   wdt1: watchdog@1e785000 {
>   compatible = "aspeed,ast2500-wdt";
>   reg = <0x1e785000 0x20>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   wdt2: watchdog@1e785020 {
>   compatible = "aspeed,ast2500-wdt";
>   reg = <0x1e785020 0x20>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   wdt3: watchdog@1e785040 {
>   compatible = "aspeed,ast2500-wdt";
>   reg = <0x1e785040 0x20>;
> + clocks = < ASPEED_CLK_APB>;
>   status = "disabled";
>   };
>  
>

Re: [PATCH v2 06/19] ARM: dts: aspeed: Add watchdog clocks

2017-12-18 Thread Cédric Le Goater 
On 12/15/2017 07:24 AM, Joel Stanley wrote:
> Signed-off-by: Joel Stanley 


Reviewed-by: Cédric Le Goater 


> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 2 ++
>  arch/arm/boot/dts/aspeed-g5.dtsi | 3 +++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi 
> b/arch/arm/boot/dts/aspeed-g4.dtsi
> index cf407b4db630..2e3666d4fbeb 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -177,11 +177,13 @@
>   wdt1: watchdog@1e785000 {
>   compatible = "aspeed,ast2400-wdt";
>   reg = <0x1e785000 0x1c>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   wdt2: watchdog@1e785020 {
>   compatible = "aspeed,ast2400-wdt";
>   reg = <0x1e785020 0x1c>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   vuart: serial@1e787000 {
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi 
> b/arch/arm/boot/dts/aspeed-g5.dtsi
> index ab26156d6822..24bb2d16b900 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -219,16 +219,19 @@
>   wdt1: watchdog@1e785000 {
>   compatible = "aspeed,ast2500-wdt";
>   reg = <0x1e785000 0x20>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   wdt2: watchdog@1e785020 {
>   compatible = "aspeed,ast2500-wdt";
>   reg = <0x1e785020 0x20>;
> + clocks = < ASPEED_CLK_APB>;
>   };
>  
>   wdt3: watchdog@1e785040 {
>   compatible = "aspeed,ast2500-wdt";
>   reg = <0x1e785040 0x20>;
> + clocks = < ASPEED_CLK_APB>;
>   status = "disabled";
>   };
>  
>