Re: [PATCH v2 2/2] cpufreq: powernv: Redesign the presentation of throttle notification
Hi Shilpasri,
[auto build test WARNING on tip/perf/core]
[also build test WARNING on v4.4-rc7 next-20151231]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Shilpasri-G-Bhat/cpufreq-powernv-tracing-Add-powernv_throttle-tracepoint/20160102-062606
config: powerpc-allmodconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All warnings (new ones prefixed by >>):
drivers/cpufreq/powernv-cpufreq.c: In function 'occ_reset_show':
drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
>> drivers/cpufreq/powernv-cpufreq.c:625:1: note: in expansion of macro
>> 'define_throttle_reason_attr'
define_throttle_reason_attr(occ_reset, OCC_RESET_THROTTLE);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'over_current_show':
drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:624:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(over_current, OVERCURRENT);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'power_supply_failure_show':
drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:623:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(power_supply_failure, POWER_SUPPLY_FAILURE);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'cpu_over_temperature_show':
drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:622:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(cpu_over_temperature, CPU_OVERTEMP);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'power_cap_show':
drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:621:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(power_cap, POWERCAP);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'throttle_reset_show':
drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:620:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(throttle_reset, NO_THROTTLE);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'throttle_stat_show':
drivers/cpufreq/powernv-cpufreq.c:589:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'throttle_freq_show':
drivers/cpufreq/powernv-cpufreq.c:568:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id);
^
vim +/define_throttle_reason_attr +625 drivers/cpufreq/powernv-cpufreq.c
603 #define define_throttle_reason_attr(attr_name, val)
\
604 static ssize_t attr_name##_show(struct kobject *kobj,
\
605 struct kobj_attribute *attr, char
*buf) \
606 {
\
607 int i, id;
\
608
\
> 609 kstrtoint(kobj->name + 4, 0, &id);
>\
610 for (i = 0; i < nr_chips; i++)
\
611 if (chips[i].id == id)
\
612 break;
\
613
\
Re: [PATCH v2 2/2] cpufreq: powernv: Redesign the presentation of throttle notification
Hi Shilpasri,
[auto build test WARNING on tip/perf/core]
[also build test WARNING on v4.4-rc7 next-20151231]
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
url:
https://github.com/0day-ci/linux/commits/Shilpasri-G-Bhat/cpufreq-powernv-tracing-Add-powernv_throttle-tracepoint/20160102-062606
config: powerpc-defconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All warnings (new ones prefixed by >>):
drivers/cpufreq/powernv-cpufreq.c: In function 'occ_reset_show':
>> drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
>> 'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:625:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(occ_reset, OCC_RESET_THROTTLE);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'over_current_show':
>> drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
>> 'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:624:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(over_current, OVERCURRENT);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'power_supply_failure_show':
>> drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
>> 'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:623:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(power_supply_failure, POWER_SUPPLY_FAILURE);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'cpu_over_temperature_show':
>> drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
>> 'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:622:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(cpu_over_temperature, CPU_OVERTEMP);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'power_cap_show':
>> drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
>> 'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:621:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(power_cap, POWERCAP);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'throttle_reset_show':
>> drivers/cpufreq/powernv-cpufreq.c:609:2: warning: ignoring return value of
>> 'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id); \
^
drivers/cpufreq/powernv-cpufreq.c:620:1: note: in expansion of macro
'define_throttle_reason_attr'
define_throttle_reason_attr(throttle_reset, NO_THROTTLE);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'throttle_stat_show':
drivers/cpufreq/powernv-cpufreq.c:589:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id);
^
drivers/cpufreq/powernv-cpufreq.c: In function 'throttle_freq_show':
drivers/cpufreq/powernv-cpufreq.c:568:2: warning: ignoring return value of
'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(kobj->name + 4, 0, &id);
^
vim +/kstrtoint +609 drivers/cpufreq/powernv-cpufreq.c
593
594 count += sprintf(&buf[count], "turbo %d\n",
chips[i].throt_turbo);
595 count += sprintf(&buf[count], "sub-turbo %d\n",
chips[i].throt_nominal);
596
597 return count;
598 }
599
600 static struct kobj_attribute attr_throttle_stat =
601 __ATTR(throttle_stat, 0444, throttle_stat_show, NULL);
602
603 #define define_throttle_reason_attr(attr_name, val)
\
604 static ssize_t attr_name##_show(struct kobject *kobj,
\
605 struct kobj_attribute *attr, char
*buf) \
606 {
\
607 int i, id;
\
608
\
> 609 kstrtoint(kobj->name + 4, 0, &id);
