Re: [PATCH v2 2/3] arm64: dts: renesas: draak: Describe CVBS input
Hi Jacopo, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [cannot apply to renesas/next v4.17-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/arm64-dts-Draak-Enable-video-inputs-and-VIN4/20180517-102013 base: git://linuxtv.org/media_tree.git master config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm64 All errors (new ones prefixed by >>): >> Error: arch/arm64/boot/dts/renesas/r8a77995-draak.dts:266.1-6 Label or path >> vin4 not found >> FATAL ERROR: Syntax error parsing input tree --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 2/3] arm64: dts: renesas: draak: Describe CVBS input
Hi Jacopo, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [cannot apply to renesas/next v4.17-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jacopo-Mondi/arm64-dts-Draak-Enable-video-inputs-and-VIN4/20180517-102013 base: git://linuxtv.org/media_tree.git master config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm64 All errors (new ones prefixed by >>): >> Error: arch/arm64/boot/dts/renesas/r8a77995-draak.dts:266.1-6 Label or path >> vin4 not found >> FATAL ERROR: Syntax error parsing input tree --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2 2/3] arm64: dts: renesas: draak: Describe CVBS input
Hi Jacopo, Thanks for your patch. On 2018-05-16 15:42:08 +0200, Jacopo Mondi wrote: > Describe CVBS video input through analog video decoder ADV7180 > connected to video input interface VIN4. > > The video input signal path is shared with HDMI video input, and > selected by on-board switches SW-53 and SW-54 with CVBS input selected > by the default switches configuration. You are missing your SoB line :-) Reviewed-by: Niklas Söderlund> --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 36 > ++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > index d03f194..9aba28f 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -142,6 +142,11 @@ > groups = "usb0"; > function = "usb0"; > }; > + > + vin4_pins_cvbs: vin4 { > + groups = "vin4_data8", "vin4_sync", "vin4_clk"; > + function = "vin4"; > + }; > }; > > { > @@ -154,6 +159,17 @@ > reg = <0x50>; > pagesize = <8>; > }; > + > + analog-video@20 { > + compatible = "adi,adv7180"; > + reg = <0x20>; > + > + port { > + adv7180_out: endpoint { > + remote-endpoint = <_in>; > + }; > + }; > + }; > }; > > { > @@ -246,3 +262,23 @@ > timeout-sec = <60>; > status = "okay"; > }; > + > + { > + pinctrl-0 = <_pins_cvbs>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + vin4_in: endpoint { > + remote-endpoint = <_out>; > + }; > + }; > + }; > +}; > -- > 2.7.4 > -- Regards, Niklas Söderlund
Re: [PATCH v2 2/3] arm64: dts: renesas: draak: Describe CVBS input
Hi Jacopo, Thanks for your patch. On 2018-05-16 15:42:08 +0200, Jacopo Mondi wrote: > Describe CVBS video input through analog video decoder ADV7180 > connected to video input interface VIN4. > > The video input signal path is shared with HDMI video input, and > selected by on-board switches SW-53 and SW-54 with CVBS input selected > by the default switches configuration. You are missing your SoB line :-) Reviewed-by: Niklas Söderlund > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 36 > ++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > index d03f194..9aba28f 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -142,6 +142,11 @@ > groups = "usb0"; > function = "usb0"; > }; > + > + vin4_pins_cvbs: vin4 { > + groups = "vin4_data8", "vin4_sync", "vin4_clk"; > + function = "vin4"; > + }; > }; > > { > @@ -154,6 +159,17 @@ > reg = <0x50>; > pagesize = <8>; > }; > + > + analog-video@20 { > + compatible = "adi,adv7180"; > + reg = <0x20>; > + > + port { > + adv7180_out: endpoint { > + remote-endpoint = <_in>; > + }; > + }; > + }; > }; > > { > @@ -246,3 +262,23 @@ > timeout-sec = <60>; > status = "okay"; > }; > + > + { > + pinctrl-0 = <_pins_cvbs>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + vin4_in: endpoint { > + remote-endpoint = <_out>; > + }; > + }; > + }; > +}; > -- > 2.7.4 > -- Regards, Niklas Söderlund