Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

[Masahiro Yamada]

Hi Arnd,


2017-06-14 16:26 GMT+09:00 Arnd Bergmann :
> On Wed, Jun 14, 2017 at 1:08 AM, Matthias Kaehlcke  wrote:
>> hostcc-option is equivalent to cc-option, but uses the host compiler
>> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
>> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>>
>> Suggested-by: Arnd Bergmann 
>> Suggested-by: Masahiro Yamada 
>> Signed-off-by: Matthias Kaehlcke 
>
> Actually, we already have a hostcc-option macro. What I meant with my 
> suggestion
> was that we could redefine the existing one using cc-option-raw.
>
> I checked again now and found that while this was added in 2016 by
> Emese Revfy, we apparently don't have any users of the helper in the
> kernel.


Oops, I missed it because
it is defined in scripts/Makefile.host instead of scripts/Kbuild.include


$(call cc-option, ...) is generally used in the top Makefile (or
arch/*/Makefile).


However, scripts/Makefile.host is not included from the top Makefile,
so $(call hostcc-option, ...) is available only under sub-directories.
I guess that is why we had no user of it.

I think the right thing to do
is to remove the former implementation from Makefile.host

Thanks!



-- 
Best Regards
Masahiro Yamada

Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

[Masahiro Yamada]

Hi Arnd,


2017-06-14 16:26 GMT+09:00 Arnd Bergmann :
> On Wed, Jun 14, 2017 at 1:08 AM, Matthias Kaehlcke  wrote:
>> hostcc-option is equivalent to cc-option, but uses the host compiler
>> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
>> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>>
>> Suggested-by: Arnd Bergmann 
>> Suggested-by: Masahiro Yamada 
>> Signed-off-by: Matthias Kaehlcke 
>
> Actually, we already have a hostcc-option macro. What I meant with my 
> suggestion
> was that we could redefine the existing one using cc-option-raw.
>
> I checked again now and found that while this was added in 2016 by
> Emese Revfy, we apparently don't have any users of the helper in the
> kernel.


Oops, I missed it because
it is defined in scripts/Makefile.host instead of scripts/Kbuild.include


$(call cc-option, ...) is generally used in the top Makefile (or
arch/*/Makefile).


However, scripts/Makefile.host is not included from the top Makefile,
so $(call hostcc-option, ...) is available only under sub-directories.
I guess that is why we had no user of it.

I think the right thing to do
is to remove the former implementation from Makefile.host

Thanks!



-- 
Best Regards
Masahiro Yamada

Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

[Arnd Bergmann]

On Wed, Jun 14, 2017 at 1:08 AM, Matthias Kaehlcke  wrote:
> hostcc-option is equivalent to cc-option, but uses the host compiler
> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>
> Suggested-by: Arnd Bergmann 
> Suggested-by: Masahiro Yamada 
> Signed-off-by: Matthias Kaehlcke 

Actually, we already have a hostcc-option macro. What I meant with my suggestion
was that we could redefine the existing one using cc-option-raw.

I checked again now and found that while this was added in 2016 by
Emese Revfy, we apparently don't have any users of the helper in the
kernel.

  Arnd

Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

[Arnd Bergmann]

On Wed, Jun 14, 2017 at 1:08 AM, Matthias Kaehlcke  wrote:
> hostcc-option is equivalent to cc-option, but uses the host compiler
> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>
> Suggested-by: Arnd Bergmann 
> Suggested-by: Masahiro Yamada 
> Signed-off-by: Matthias Kaehlcke 

Actually, we already have a hostcc-option macro. What I meant with my suggestion
was that we could redefine the existing one using cc-option-raw.

I checked again now and found that while this was added in 2016 by
Emese Revfy, we apparently don't have any users of the helper in the
kernel.

  Arnd

Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

[Masahiro Yamada]

2017-06-14 8:08 GMT+09:00 Matthias Kaehlcke :
> hostcc-option is equivalent to cc-option, but uses the host compiler
> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>
> Suggested-by: Arnd Bergmann 
> Suggested-by: Masahiro Yamada 
> Signed-off-by: Matthias Kaehlcke 
> ---

Acked-by: Masahiro Yamada 

-- 
Best Regards
Masahiro Yamada

Re: [PATCH v2 2/4] kbuild: Add hostcc-option macro

[Masahiro Yamada]

2017-06-14 8:08 GMT+09:00 Matthias Kaehlcke :
> hostcc-option is equivalent to cc-option, but uses the host compiler
> and HOSTCFLAGS. Change HOSTCFLAGS to a simple expanded variable to
> allow for HOSTCFLAGS += $(call hostcc-option, ...).
>
> Suggested-by: Arnd Bergmann 
> Suggested-by: Masahiro Yamada 
> Signed-off-by: Matthias Kaehlcke 
> ---

Acked-by: Masahiro Yamada 

-- 
Best Regards
Masahiro Yamada