Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

2017-05-23 Thread Lee Jones 
On Tue, 23 May 2017, Zhang Rui wrote:

> On Fri, 2017-04-14 at 16:25 -0700,
> sathyanarayanan.kuppusw...@linux.intel.com wrote:
> > From: Kuppuswamy Sathyanarayanan  > tel.com>
> > 
> > PMIC mfd driver only exports first level irq for thermal device.
> > But currently we are reading the irqs from the second level irq
> > chip, So this patch fixes this issue by adding support to use
> > first level PMIC thermal irq.
> > 
> > Signed-off-by: Kuppuswamy Sathyanarayanan
> > 
> 
> Acked-by: Zhang Rui 

I think this is the last Ack.

Please collect them all and re-submit the set so I can pick it up.

> > ---
> >  drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Changes since v1:
> >  * None
> > 
> > diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c
> > b/drivers/thermal/intel_bxt_pmic_thermal.c
> > index 0f19a39..ef6b322 100644
> > --- a/drivers/thermal/intel_bxt_pmic_thermal.c
> > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
> > @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct
> > platform_device *pdev)
> >     }
> >  
> >     regmap = pmic->regmap;
> > -   regmap_irq_chip = pmic->irq_chip_data_level2;
> > +   regmap_irq_chip = pmic->irq_chip_data;
> >  
> >     pmic_irq_count = 0;
> >     while ((irq = platform_get_irq(pdev, pmic_irq_count)) !=
> > -ENXIO) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

2017-05-22 Thread Zhang Rui 
On Fri, 2017-04-14 at 16:25 -0700,
sathyanarayanan.kuppusw...@linux.intel.com wrote:
> From: Kuppuswamy Sathyanarayanan  tel.com>
> 
> PMIC mfd driver only exports first level irq for thermal device.
> But currently we are reading the irqs from the second level irq
> chip, So this patch fixes this issue by adding support to use
> first level PMIC thermal irq.
> 
> Signed-off-by: Kuppuswamy Sathyanarayanan
> 

Acked-by: Zhang Rui 

-rui
> ---
>  drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Changes since v1:
>  * None
> 
> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c
> b/drivers/thermal/intel_bxt_pmic_thermal.c
> index 0f19a39..ef6b322 100644
> --- a/drivers/thermal/intel_bxt_pmic_thermal.c
> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct
> platform_device *pdev)
>   }
>  
>   regmap = pmic->regmap;
> - regmap_irq_chip = pmic->irq_chip_data_level2;
> + regmap_irq_chip = pmic->irq_chip_data;
>  
>   pmic_irq_count = 0;
>   while ((irq = platform_get_irq(pdev, pmic_irq_count)) !=
> -ENXIO) {

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

2017-05-22 Thread sathyanarayanan kuppuswamy 

Hi Rui/Valentin,

Do you have any comments on this patch ? If you agree with this patch, 
Can you please Ack it ?



On 05/22/2017 03:17 AM, Lee Jones wrote:

On Fri, 14 Apr 2017, sathyanarayanan.kuppusw...@linux.intel.com wrote:


From: Kuppuswamy Sathyanarayanan 

PMIC mfd driver only exports first level irq for thermal device.
But currently we are reading the irqs from the second level irq
chip, So this patch fixes this issue by adding support to use
first level PMIC thermal irq.

Signed-off-by: Kuppuswamy Sathyanarayanan 


This still needs a Maintainer Ack.


---
  drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Changes since v1:
  * None

diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c 
b/drivers/thermal/intel_bxt_pmic_thermal.c
index 0f19a39..ef6b322 100644
--- a/drivers/thermal/intel_bxt_pmic_thermal.c
+++ b/drivers/thermal/intel_bxt_pmic_thermal.c
@@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device *pdev)
}
  
  	regmap = pmic->regmap;

-   regmap_irq_chip = pmic->irq_chip_data_level2;
+   regmap_irq_chip = pmic->irq_chip_data;
  
  	pmic_irq_count = 0;

while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {


--
Sathyanarayanan Kuppuswamy
Linux kernel developer

Re: [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq

2017-05-22 Thread Lee Jones 
On Fri, 14 Apr 2017, sathyanarayanan.kuppusw...@linux.intel.com wrote:

> From: Kuppuswamy Sathyanarayanan 
> 
> PMIC mfd driver only exports first level irq for thermal device.
> But currently we are reading the irqs from the second level irq
> chip, So this patch fixes this issue by adding support to use
> first level PMIC thermal irq.
> 
> Signed-off-by: Kuppuswamy Sathyanarayanan 
> 

This still needs a Maintainer Ack.

> ---
>  drivers/thermal/intel_bxt_pmic_thermal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Changes since v1:
>  * None
> 
> diff --git a/drivers/thermal/intel_bxt_pmic_thermal.c 
> b/drivers/thermal/intel_bxt_pmic_thermal.c
> index 0f19a39..ef6b322 100644
> --- a/drivers/thermal/intel_bxt_pmic_thermal.c
> +++ b/drivers/thermal/intel_bxt_pmic_thermal.c
> @@ -241,7 +241,7 @@ static int pmic_thermal_probe(struct platform_device 
> *pdev)
>   }
>  
>   regmap = pmic->regmap;
> - regmap_irq_chip = pmic->irq_chip_data_level2;
> + regmap_irq_chip = pmic->irq_chip_data;
>  
>   pmic_irq_count = 0;
>   while ((irq = platform_get_irq(pdev, pmic_irq_count)) != -ENXIO) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog