Re: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe
On Tue, 2015-03-24 at 16:42 +0100, Michael S. Tsirkin wrote: > pci core now disables msi on probe automatically, > drop this from device-specific code. > > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org > Signed-off-by: Michael S. Tsirkin Acked-by: Dave Jiang > --- > drivers/ntb/ntb_hw.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c > index cd29b10..8225cbc 100644 > --- a/drivers/ntb/ntb_hw.c > +++ b/drivers/ntb/ntb_hw.c > @@ -1313,8 +1313,6 @@ static int ntb_setup_intx(struct ntb_device *ndev) > struct pci_dev *pdev = ndev->pdev; > int rc; > > - pci_msi_off(pdev); > - > /* Verify intx is enabled */ > pci_intx(pdev, 1); > N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a��� 0��h���i
Re: [PATCH v3 07/10] ntb: drop pci_msi_off call on probe
On Tue, 2015-03-24 at 16:42 +0100, Michael S. Tsirkin wrote: pci core now disables msi on probe automatically, drop this from device-specific code. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Dave Jiang dave.ji...@intel.com --- drivers/ntb/ntb_hw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c index cd29b10..8225cbc 100644 --- a/drivers/ntb/ntb_hw.c +++ b/drivers/ntb/ntb_hw.c @@ -1313,8 +1313,6 @@ static int ntb_setup_intx(struct ntb_device *ndev) struct pci_dev *pdev = ndev-pdev; int rc; - pci_msi_off(pdev); - /* Verify intx is enabled */ pci_intx(pdev, 1); N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z��w���?��)ߢf��^jǫy�m��@A�a��� 0��h���i