Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

[Jes Sorensen]

Julian Calaby  writes:
> Hi Geliang,
>
> On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang  wrote:
>> This patch cleans whitespaces and blank lines surrounding
>> list_for_each_entry*().
>
> It does a lot more than this, including:
>  - Removing some unnecessary brackets
>  - Whitespace changes well away from the list_for_each_entry*() calls
>
> You need to either specify all of these in the changelog or split it
> up into multiple patches.
>
> Thanks,
>
> Julian Calaby

I agree, I think a more descriptive patch message will suffice here.

Jes

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

[Jes Sorensen]

Julian Calaby  writes:
> Hi Geliang,
>
> On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang  wrote:
>> This patch cleans whitespaces and blank lines surrounding
>> list_for_each_entry*().
>
> It does a lot more than this, including:
>  - Removing some unnecessary brackets
>  - Whitespace changes well away from the list_for_each_entry*() calls
>
> You need to either specify all of these in the changelog or split it
> up into multiple patches.
>
> Thanks,
>
> Julian Calaby

I agree, I think a more descriptive patch message will suffice here.

Jes

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

[Julian Calaby]

Hi Geliang,

On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang  wrote:
> This patch cleans whitespaces and blank lines surrounding
> list_for_each_entry*().

It does a lot more than this, including:
 - Removing some unnecessary brackets
 - Whitespace changes well away from the list_for_each_entry*() calls

You need to either specify all of these in the changelog or split it
up into multiple patches.

Thanks,

Julian Calaby


>
> Signed-off-by: Geliang Tang 
> ---
> Changes in v3:
>  - split it into three patches.
> Changes in v2:
>  - drop the coding style fixing in v1.
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c   | 41 
> ++-
>  drivers/staging/rtl8723au/core/rtw_mlme.c | 14 +---
>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c |  3 +-
>  drivers/staging/rtl8723au/core/rtw_recv.c | 18 +++---
>  drivers/staging/rtl8723au/core/rtw_sta_mgt.c  | 11 +-
>  drivers/staging/rtl8723au/core/rtw_xmit.c | 30 -
>  drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c |  8 -
>  7 files changed, 17 insertions(+), 108 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
> b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 4bcd617..ce4b589 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -171,7 +171,7 @@ static u8 chk_sta_is_alive(struct sta_info *psta)
> return ret;
>  }
>
> -void   expire_timeout_chk23a(struct rtw_adapter *padapter)
> +void expire_timeout_chk23a(struct rtw_adapter *padapter)
>  {
> struct list_head *phead;
> u8 updated = 0;
> @@ -182,12 +182,9 @@ void   expire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> int i;
>
> spin_lock_bh(>auth_list_lock);
> -
> phead = >auth_list;
> -
> /* check auth_queue */
> list_for_each_entry_safe(psta, ptmp, phead, auth_list) {
> -
> if (psta->expire_to > 0) {
> psta->expire_to--;
> if (psta->expire_to == 0) {
> @@ -205,18 +202,13 @@ void  expire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> spin_lock_bh(>auth_list_lock);
> }
> }
> -
> }
> -
> spin_unlock_bh(>auth_list_lock);
>
> spin_lock_bh(>asoc_list_lock);
> -
> phead = >asoc_list;
> -
> /* check asoc_queue */
> list_for_each_entry_safe(psta, ptmp, phead, asoc_list) {
> -
> if (chk_sta_is_alive(psta) || !psta->expire_to) {
> psta->expire_to = pstapriv->expire_to;
> psta->keep_alive_trycnt = 0;
> @@ -281,7 +273,6 @@ voidexpire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> }
> }
> }
> -
> spin_unlock_bh(>asoc_list_lock);
>
> if (chk_alive_num) {
> @@ -1071,11 +1062,8 @@ int rtw_acl_add_sta23a(struct rtw_adapter *padapter, 
> u8 *addr)
> return -1;
>
> spin_lock_bh(_node_q->lock);
> -
> phead = get_list_head(pacl_node_q);
> -
> list_for_each_entry(paclnode, phead, list) {
> -
> if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
> if (paclnode->valid == true) {
> added = true;
> @@ -1084,7 +1072,6 @@ int rtw_acl_add_sta23a(struct rtw_adapter *padapter, u8 
> *addr)
> }
> }
> }
> -
> spin_unlock_bh(_node_q->lock);
>
> if (added)
> @@ -1127,11 +1114,8 @@ int rtw_acl_remove_sta23a(struct rtw_adapter 
> *padapter, u8 *addr)
> DBG_8723A("%s(acl_num =%d) = %pM\n", __func__, pacl_list->num, addr);
>
> spin_lock_bh(_node_q->lock);
> -
> phead = get_list_head(pacl_node_q);
> -
> list_for_each_entry_safe(paclnode, ptmp, phead, list) {
> -
> if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
> if (paclnode->valid) {
> paclnode->valid = false;
> @@ -1142,7 +1126,6 @@ int rtw_acl_remove_sta23a(struct rtw_adapter *padapter, 
> u8 *addr)
> }
> }
> }
> -
> spin_unlock_bh(_node_q->lock);
>
> DBG_8723A("%s, acl_num =%d\n", __func__, pacl_list->num);
> @@ -1355,14 +1338,9 @@ void associated_clients_update23a(struct rtw_adapter 
> *padapter, u8 updated)
> struct sta_priv *pstapriv = >stapriv;
>
> spin_lock_bh(>asoc_list_lock);
> -
> phead = >asoc_list;
> -
> -   list_for_each_entry_safe(psta, ptmp, phead, asoc_list) {
> -
> +   list_for_each_entry_safe(psta, ptmp, phead, asoc_list)
> VCS_update23a(padapter, psta);
> -   }
> -
> spin_unlock_bh(>asoc_list_lock);
> }
>  }
> @@ -1637,9 +1615,7 @@ int 

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

[Julian Calaby]

Hi Geliang,

On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang  wrote:
> This patch cleans whitespaces and blank lines surrounding
> list_for_each_entry*().

It does a lot more than this, including:
 - Removing some unnecessary brackets
 - Whitespace changes well away from the list_for_each_entry*() calls

You need to either specify all of these in the changelog or split it
up into multiple patches.

Thanks,

Julian Calaby


>
> Signed-off-by: Geliang Tang 
> ---
> Changes in v3:
>  - split it into three patches.
> Changes in v2:
>  - drop the coding style fixing in v1.
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c   | 41 
> ++-
>  drivers/staging/rtl8723au/core/rtw_mlme.c | 14 +---
>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c |  3 +-
>  drivers/staging/rtl8723au/core/rtw_recv.c | 18 +++---
>  drivers/staging/rtl8723au/core/rtw_sta_mgt.c  | 11 +-
>  drivers/staging/rtl8723au/core/rtw_xmit.c | 30 -
>  drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c |  8 -
>  7 files changed, 17 insertions(+), 108 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
> b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 4bcd617..ce4b589 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -171,7 +171,7 @@ static u8 chk_sta_is_alive(struct sta_info *psta)
> return ret;
>  }
>
> -void   expire_timeout_chk23a(struct rtw_adapter *padapter)
> +void expire_timeout_chk23a(struct rtw_adapter *padapter)
>  {
> struct list_head *phead;
> u8 updated = 0;
> @@ -182,12 +182,9 @@ void   expire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> int i;
>
> spin_lock_bh(>auth_list_lock);
> -
> phead = >auth_list;
> -
> /* check auth_queue */
> list_for_each_entry_safe(psta, ptmp, phead, auth_list) {
> -
> if (psta->expire_to > 0) {
> psta->expire_to--;
> if (psta->expire_to == 0) {
> @@ -205,18 +202,13 @@ void  expire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> spin_lock_bh(>auth_list_lock);
> }
> }
> -
> }
> -
> spin_unlock_bh(>auth_list_lock);
>
> spin_lock_bh(>asoc_list_lock);
> -
> phead = >asoc_list;
> -
> /* check asoc_queue */
> list_for_each_entry_safe(psta, ptmp, phead, asoc_list) {
> -
> if (chk_sta_is_alive(psta) || !psta->expire_to) {
> psta->expire_to = pstapriv->expire_to;
> psta->keep_alive_trycnt = 0;
> @@ -281,7 +273,6 @@ voidexpire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> }
> }
> }
> -
> spin_unlock_bh(>asoc_list_lock);
>
> if (chk_alive_num) {
> @@ -1071,11 +1062,8 @@ int rtw_acl_add_sta23a(struct rtw_adapter *padapter, 
> u8 *addr)
> return -1;
>
> spin_lock_bh(_node_q->lock);
> -
> phead = get_list_head(pacl_node_q);
> -
> list_for_each_entry(paclnode, phead, list) {
> -
> if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
> if (paclnode->valid == true) {
> added = true;
> @@ -1084,7 +1072,6 @@ int rtw_acl_add_sta23a(struct rtw_adapter *padapter, u8 
> *addr)
> }
> }
> }
> -
> spin_unlock_bh(_node_q->lock);
>
> if (added)
> @@ -1127,11 +1114,8 @@ int rtw_acl_remove_sta23a(struct rtw_adapter 
> *padapter, u8 *addr)
> DBG_8723A("%s(acl_num =%d) = %pM\n", __func__, pacl_list->num, addr);
>
> spin_lock_bh(_node_q->lock);
> -
> phead = get_list_head(pacl_node_q);
> -
> list_for_each_entry_safe(paclnode, ptmp, phead, list) {
> -
> if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
> if (paclnode->valid) {
> paclnode->valid = false;
> @@ -1142,7 +1126,6 @@ int rtw_acl_remove_sta23a(struct rtw_adapter *padapter, 
> u8 *addr)
> }
> }
> }
> -
> spin_unlock_bh(_node_q->lock);
>
> DBG_8723A("%s, acl_num =%d\n", __func__, pacl_list->num);
> @@ -1355,14 +1338,9 @@ void associated_clients_update23a(struct rtw_adapter 
> *padapter, u8 updated)
> struct sta_priv *pstapriv = >stapriv;
>
> spin_lock_bh(>asoc_list_lock);
> -
> phead = >asoc_list;
> -
> -   list_for_each_entry_safe(psta, ptmp, phead, asoc_list) {
> -
> +   list_for_each_entry_safe(psta, ptmp, phead, asoc_list)
> VCS_update23a(padapter, psta);
> -   }
> -
> spin_unlock_bh(>asoc_list_lock);
> }
>  }
> @@ -1637,9