Re: [PATCH v3 3/4] clk: rockchip: add support for half divider

[Stephen Boyd]

Quoting Heiko Stuebner (2018-07-06 10:19:11)
> Am Freitag, 6. Juli 2018, 18:50:51 CEST schrieb Stephen Boyd:
> > Quoting Elaine Zhang (2018-06-14 19:16:50)
> > > 
> > > diff --git a/drivers/clk/rockchip/clk-half-divider.c 
> > > b/drivers/clk/rockchip/clk-half-divider.c
> > > new file mode 100644
> > > index ..fb7a6501e0c1
> > > --- /dev/null
> > > +++ b/drivers/clk/rockchip/clk-half-divider.c
> > > @@ -0,0 +1,230 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd
> > > + */
> > > +
> > > +#include 
> > > +#include 
> > > +#include 
> > > +#include 
> > 
> > Is this include used?
> 
> nope, and so are bitops and regmap as well.
> I've amended the commit patch accordingly.
> 
> 

Cool. Thanks!

Re: [PATCH v3 3/4] clk: rockchip: add support for half divider

[Heiko Stuebner]

Am Freitag, 6. Juli 2018, 18:50:51 CEST schrieb Stephen Boyd:
> Quoting Elaine Zhang (2018-06-14 19:16:50)
> > 
> > diff --git a/drivers/clk/rockchip/clk-half-divider.c 
> > b/drivers/clk/rockchip/clk-half-divider.c
> > new file mode 100644
> > index ..fb7a6501e0c1
> > --- /dev/null
> > +++ b/drivers/clk/rockchip/clk-half-divider.c
> > @@ -0,0 +1,230 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd
> > + */
> > +
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> 
> Is this include used?

nope, and so are bitops and regmap as well.
I've amended the commit patch accordingly.


Heiko

Re: [PATCH v3 3/4] clk: rockchip: add support for half divider

[Stephen Boyd]

Quoting Elaine Zhang (2018-06-14 19:16:50)
> 
> diff --git a/drivers/clk/rockchip/clk-half-divider.c 
> b/drivers/clk/rockchip/clk-half-divider.c
> new file mode 100644
> index ..fb7a6501e0c1
> --- /dev/null
> +++ b/drivers/clk/rockchip/clk-half-divider.c
> @@ -0,0 +1,230 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd
> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 

Is this include used?

> +#include 
> +#include "clk.h"