Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()
On Fri, May 29, 2020 at 11:28:56AM -0700, Dave Hansen wrote: > On 5/14/20 5:43 PM, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Add vm_ops()->may_mprotect() to check additional constrains set by a > > subsystem for a mprotect() call. > > This changelog needs some more detail about why this is needed. It > would also be nice to include thought about what else it could get used > for and what subsystems can expect by doing this and what the mm core is > expected to do. Point taken. I added a description on how it is used. /Jarkko
Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()
On 5/14/20 5:43 PM, Jarkko Sakkinen wrote: > From: Sean Christopherson > > Add vm_ops()->may_mprotect() to check additional constrains set by a > subsystem for a mprotect() call. This changelog needs some more detail about why this is needed. It would also be nice to include thought about what else it could get used for and what subsystems can expect by doing this and what the mm core is expected to do.
Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()
On Fri, May 29, 2020 at 02:10:38PM +0200, Borislav Petkov wrote: > On Fri, May 15, 2020 at 03:43:59AM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Add vm_ops()->may_mprotect() to check additional constrains set by a > > "constraints" > > > subsystem for a mprotect() call. > > > > Signed-off-by: Sean Christopherson > > Acked-by: Jethro Beekman > > Signed-off-by: Jarkko Sakkinen > > --- > > include/linux/mm.h | 2 ++ > > mm/mprotect.c | 14 +++--- > > 2 files changed, 13 insertions(+), 3 deletions(-) > > This needs an ACK from an mm person. Good point. I'll add the needed cc's. /Jarkko
Re: [PATCH v30 09/20] mm: Introduce vm_ops->may_mprotect()
On Fri, May 15, 2020 at 03:43:59AM +0300, Jarkko Sakkinen wrote: > From: Sean Christopherson > > Add vm_ops()->may_mprotect() to check additional constrains set by a "constraints" > subsystem for a mprotect() call. > > Signed-off-by: Sean Christopherson > Acked-by: Jethro Beekman > Signed-off-by: Jarkko Sakkinen > --- > include/linux/mm.h | 2 ++ > mm/mprotect.c | 14 +++--- > 2 files changed, 13 insertions(+), 3 deletions(-) This needs an ACK from an mm person. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
