Re: [PATCH v4 0/3] about data busy
Hi, On Fri, Feb 13, 2015 at 10:17 PM, Addy Ke wrote: > patch 1: This patch can fix bug that controller is still data busy after > reset all blocks. After this patch, I still get data busy in > set_ios(). > > patch 2: This patch fix bug 'Timeout sending command'. After patch1 and > patch2, there is no mmc errors after: > cd /sys/bus/platform/drivers/dwmmc_rockchip > for i in $(seq 1 1); do > echo "" $i > echo ff0c.dwmmc > unbind > sleep .5 > echo ff0c.dwmmc > bind > sleep 2 > done > > patch3: This patch fix bug that there is data busy before sdio send CMD53. > But This patch is necessary for sd and mmc too. > > Addy Ke (3): > mmc: dw_mmc: update clock after host reach a stable voltage > mmc: dw_mmc: fix bug that cause 'Timeout sending command' > mmc: dw_mmc: Don't start command while data busy > > drivers/mmc/host/dw_mmc.c | 41 - > 1 file changed, 40 insertions(+), 1 deletion(-) A little hard to follow all the patches flying around (so I'll probably reply a few different places with the same info), but I believe that all of Addy's patches (with the exception of the one intended to fix mmc_test which needs to be spun by him for a bugfix) can be replaced with: * mmc: dw_mmc: Don't start commands while busy https://patchwork.kernel.org/patch/5858221/ * mmc: dw_mmc: Make sure we only adjust the clock when power is on https://patchwork.kernel.org/patch/5858261/ * mmc: dw_mmc: Give a good reset after we give power https://patchwork.kernel.org/patch/5858281/ In order to avoid further spreading info out among several patches, I'd request that you don't respond here but instead respond to my posted patches. Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] about data busy
Hi, On Fri, Feb 13, 2015 at 10:17 PM, Addy Ke addy...@rock-chips.com wrote: patch 1: This patch can fix bug that controller is still data busy after reset all blocks. After this patch, I still get data busy in set_ios(). patch 2: This patch fix bug 'Timeout sending command'. After patch1 and patch2, there is no mmc errors after: cd /sys/bus/platform/drivers/dwmmc_rockchip for i in $(seq 1 1); do echo $i echo ff0c.dwmmc unbind sleep .5 echo ff0c.dwmmc bind sleep 2 done patch3: This patch fix bug that there is data busy before sdio send CMD53. But This patch is necessary for sd and mmc too. Addy Ke (3): mmc: dw_mmc: update clock after host reach a stable voltage mmc: dw_mmc: fix bug that cause 'Timeout sending command' mmc: dw_mmc: Don't start command while data busy drivers/mmc/host/dw_mmc.c | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) A little hard to follow all the patches flying around (so I'll probably reply a few different places with the same info), but I believe that all of Addy's patches (with the exception of the one intended to fix mmc_test which needs to be spun by him for a bugfix) can be replaced with: * mmc: dw_mmc: Don't start commands while busy https://patchwork.kernel.org/patch/5858221/ * mmc: dw_mmc: Make sure we only adjust the clock when power is on https://patchwork.kernel.org/patch/5858261/ * mmc: dw_mmc: Give a good reset after we give power https://patchwork.kernel.org/patch/5858281/ In order to avoid further spreading info out among several patches, I'd request that you don't respond here but instead respond to my posted patches. Thanks! -Doug -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] about data busy
Hi, Javier and Alim These days are Spring Festival holiday. Sorry for late reply. On 2015/2/15 19:41, Javier Martinez Canillas wrote: > Hello Addy, > > On Sat, Feb 14, 2015 at 7:17 AM, Addy Ke wrote: >> patch 1: This patch can fix bug that controller is still data busy after >> reset all blocks. After this patch, I still get data busy in >> set_ios(). >> >> patch 2: This patch fix bug 'Timeout sending command'. After patch1 and >> patch2, there is no mmc errors after: >> cd /sys/bus/platform/drivers/dwmmc_rockchip >> for i in $(seq 1 1); do >> echo "" $i >> echo ff0c.dwmmc > unbind >> sleep .5 >> echo ff0c.dwmmc > bind >> sleep 2 >> done >> >> patch3: This patch fix bug that there is data busy before sdio send CMD53. >> But This patch is necessary for sd and mmc too. >> > > I faced the same 'Timeout sending command' error when trying to enable > support for the SDIO wifi chip attached to mmc@1221 (mmc1) on an > Exynos5420 Peach Pit Chromebook. On booting the kernel log shows: > > mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status > 0x80202000) > > 0x202000 == SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT so your patch > #2 dw_mci_setup_bus() avoids the mmc comand to time out. However, it > has a side effect since with your series the uSD that in mmc@1222 > (mmc2) fails to be detected and the kernel log shows: > > [5.466432] Waiting for root device /dev/mmcblk1p4... > [ 240.169436] INFO: task kworker/u16:1:50 blocked for more than 120 seconds. > [ 240.174844] Not tainted > 3.19.0-next-20150211-6-g045d4aba96ce-dirty #476 > [ 240.182302] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables this message. > [ 240.190109] kworker/u16:1 D c04c2710 050 2 0x > [ 240.196446] Workqueue: kmmcd mmc_rescan > [ 240.200249] [] (__schedule) from [] > (schedule+0x34/0x98) > [ 240.207290] [] (schedule) from [] > (schedule_timeout+0x120/0x16c) > [ 240.215009] [] (schedule_timeout) from [] > (wait_for_common+0xb0/0x154) > [ 240.223251] [] (wait_for_common) from [] > (mmc_wait_for_req+0xa0/0x140) > [ 240.231492] [] (mmc_wait_for_req) from [] > (mmc_wait_for_cmd+0x88/0xa8) > [ 240.239735] [] (mmc_wait_for_cmd) from [] > (mmc_go_idle+0x78/0xf8) > [ 240.247540] [] (mmc_go_idle) from [] > (mmc_rescan+0x254/0x300) > [ 240.255003] [] (mmc_rescan) from [] > (process_one_work+0x120/0x324) > [ 240.262897] [] (process_one_work) from [] > (worker_thread+0x138/0x464) > [ 240.271048] [] (worker_thread) from [] > (kthread+0xd8/0xf4) > [ 240.278254] [] (kthread) from [] > (ret_from_fork+0x14/0x34) > > > By enabling debug I see that the card is detected in dw_mci_get_cd() though. > > Alim suggested [0] that dw_mci_wait_busy() should be called in > mci_send_cmd() instead dw_mci_setup_bus() because the controller hangs > when when sending update clock cmd in different cases. > > I modified [1] your patch #2 to do what Alim suggested and only with > that patch on top of linux-next I have neither the the "Timeout > sending command" error nor the uSD not getting detected errors. Linux > mounts the rootfs from the uSD and the wifi SDIO device is enumerated > and listed in /sys/bus/sdio/devices/ > > Does that also solve your issue? After merge Alim patch,and set re_try 8, it can pass test by: cd /sys/bus/platform/drivers/dwmmc_rockchip for i in $(seq 1 1); do echo "" $i echo ff0c.dwmmc > unbind sleep .5 echo ff0c.dwmmc > bind sleep 2 done My card is ADATA UHS-1 card(SDR50). The maximum retry count is 6. [ 1146.907596] mmc1: card 59b4 removed [ 1147.421036] dwmmc_rockchip ff0c.dwmmc: Using internal DMA controller. [ 1147.427827] dwmmc_rockchip ff0c.dwmmc: Version ID is 270a [ 1147.433958] dwmmc_rockchip ff0c.dwmmc: DW MMC controller at irq 64, 32 bit host data width, 256 deep fifo [ 1147.444269] dwmmc_rockchip ff0c.dwmmc: Got CD GPIO #221. [ 1147.450381] dwmmc_rockchip ff0c.dwmmc: Got WP GPIO #226. [ 1147.456046] ff0c.dwmmc supply card-external-vcc not found, using dummy regulator [ 1148.519400] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1149.019451] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1149.519382] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1150.019492] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1150.519442] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) > if re_try is 5, I still get "Timeout sending command". [ 1150.525711] mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000) [ 1150.534723] rockchip-iodomain io-domains.25: Setting to 330 done So re_try must bigger than 6, but I don't known which value is reansonable. Do you have any idear about it? This is the patch Alim
Re: [PATCH v4 0/3] about data busy
Hi, Javier and Alim These days are Spring Festival holiday. Sorry for late reply. On 2015/2/15 19:41, Javier Martinez Canillas wrote: Hello Addy, On Sat, Feb 14, 2015 at 7:17 AM, Addy Ke addy...@rock-chips.com wrote: patch 1: This patch can fix bug that controller is still data busy after reset all blocks. After this patch, I still get data busy in set_ios(). patch 2: This patch fix bug 'Timeout sending command'. After patch1 and patch2, there is no mmc errors after: cd /sys/bus/platform/drivers/dwmmc_rockchip for i in $(seq 1 1); do echo $i echo ff0c.dwmmc unbind sleep .5 echo ff0c.dwmmc bind sleep 2 done patch3: This patch fix bug that there is data busy before sdio send CMD53. But This patch is necessary for sd and mmc too. I faced the same 'Timeout sending command' error when trying to enable support for the SDIO wifi chip attached to mmc@1221 (mmc1) on an Exynos5420 Peach Pit Chromebook. On booting the kernel log shows: mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000) 0x202000 == SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT so your patch #2 dw_mci_setup_bus() avoids the mmc comand to time out. However, it has a side effect since with your series the uSD that in mmc@1222 (mmc2) fails to be detected and the kernel log shows: [5.466432] Waiting for root device /dev/mmcblk1p4... [ 240.169436] INFO: task kworker/u16:1:50 blocked for more than 120 seconds. [ 240.174844] Not tainted 3.19.0-next-20150211-6-g045d4aba96ce-dirty #476 [ 240.182302] echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message. [ 240.190109] kworker/u16:1 D c04c2710 050 2 0x [ 240.196446] Workqueue: kmmcd mmc_rescan [ 240.200249] [c04c2710] (__schedule) from [c04c2ac0] (schedule+0x34/0x98) [ 240.207290] [c04c2ac0] (schedule) from [c04c6568] (schedule_timeout+0x120/0x16c) [ 240.215009] [c04c6568] (schedule_timeout) from [c04c3584] (wait_for_common+0xb0/0x154) [ 240.223251] [c04c3584] (wait_for_common) from [c038a5ac] (mmc_wait_for_req+0xa0/0x140) [ 240.231492] [c038a5ac] (mmc_wait_for_req) from [c038a6d4] (mmc_wait_for_cmd+0x88/0xa8) [ 240.239735] [c038a6d4] (mmc_wait_for_cmd) from [c03905b0] (mmc_go_idle+0x78/0xf8) [ 240.247540] [c03905b0] (mmc_go_idle) from [c038c578] (mmc_rescan+0x254/0x300) [ 240.255003] [c038c578] (mmc_rescan) from [c00346e8] (process_one_work+0x120/0x324) [ 240.262897] [c00346e8] (process_one_work) from [c0034a58] (worker_thread+0x138/0x464) [ 240.271048] [c0034a58] (worker_thread) from [c0039070] (kthread+0xd8/0xf4) [ 240.278254] [c0039070] (kthread) from [c000e680] (ret_from_fork+0x14/0x34) By enabling debug I see that the card is detected in dw_mci_get_cd() though. Alim suggested [0] that dw_mci_wait_busy() should be called in mci_send_cmd() instead dw_mci_setup_bus() because the controller hangs when when sending update clock cmd in different cases. I modified [1] your patch #2 to do what Alim suggested and only with that patch on top of linux-next I have neither the the Timeout sending command error nor the uSD not getting detected errors. Linux mounts the rootfs from the uSD and the wifi SDIO device is enumerated and listed in /sys/bus/sdio/devices/ Does that also solve your issue? After merge Alim patch,and set re_try 8, it can pass test by: cd /sys/bus/platform/drivers/dwmmc_rockchip for i in $(seq 1 1); do echo $i echo ff0c.dwmmc unbind sleep .5 echo ff0c.dwmmc bind sleep 2 done My card is ADATA UHS-1 card(SDR50). The maximum retry count is 6. [ 1146.907596] mmc1: card 59b4 removed [ 1147.421036] dwmmc_rockchip ff0c.dwmmc: Using internal DMA controller. [ 1147.427827] dwmmc_rockchip ff0c.dwmmc: Version ID is 270a [ 1147.433958] dwmmc_rockchip ff0c.dwmmc: DW MMC controller at irq 64, 32 bit host data width, 256 deep fifo [ 1147.444269] dwmmc_rockchip ff0c.dwmmc: Got CD GPIO #221. [ 1147.450381] dwmmc_rockchip ff0c.dwmmc: Got WP GPIO #226. [ 1147.456046] ff0c.dwmmc supply card-external-vcc not found, using dummy regulator [ 1148.519400] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1149.019451] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1149.519382] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1150.019492] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) [ 1150.519442] dwmmc_rockchip ff0c.dwmmc: Data busy (status 0x206) if re_try is 5, I still get Timeout sending command. [ 1150.525711] mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000) [ 1150.534723] rockchip-iodomain io-domains.25: Setting to 330 done So re_try must bigger than 6, but I don't known which value is
Re: [PATCH v4 0/3] about data busy
Hello Jaehoon, On Mon, Feb 16, 2015 at 6:48 AM, Jaehoon Chung wrote: > On 02/15/2015 08:41 PM, Javier Martinez Canillas wrote: >> I modified [1] your patch #2 to do what Alim suggested and only with >> that patch on top of linux-next I have neither the the "Timeout >> sending command" error nor the uSD not getting detected errors. Linux >> mounts the rootfs from the uSD and the wifi SDIO device is enumerated >> and listed in /sys/bus/sdio/devices/ > > it needs to check when clock value only update. > As Javier and Alim are mentioned, if check whether card is busy or not in > setup_bus(), > should be processed unnecessary checking. > (According to TRM, before disabling clock, check whether card is busy or not.) > if my thinking is right, chekcing is located more exactly before > mci_writel(host, CLKENA, 0). > > And i recommend if CLK_GATE is enabled, clkgate_delay sets to the bigger > value than 3. > I'm not sure Javier's issue is same thing..I will check more this. > Thanks for checking, do you have access to a Peach Pit or Pi Chromebook to reproduce the issue I reported? Please let me know if you need any help from me. > Best Regards, > Jaehoon Chung > Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] about data busy
Hello Jaehoon, On Mon, Feb 16, 2015 at 6:48 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 02/15/2015 08:41 PM, Javier Martinez Canillas wrote: I modified [1] your patch #2 to do what Alim suggested and only with that patch on top of linux-next I have neither the the Timeout sending command error nor the uSD not getting detected errors. Linux mounts the rootfs from the uSD and the wifi SDIO device is enumerated and listed in /sys/bus/sdio/devices/ it needs to check when clock value only update. As Javier and Alim are mentioned, if check whether card is busy or not in setup_bus(), should be processed unnecessary checking. (According to TRM, before disabling clock, check whether card is busy or not.) if my thinking is right, chekcing is located more exactly before mci_writel(host, CLKENA, 0). And i recommend if CLK_GATE is enabled, clkgate_delay sets to the bigger value than 3. I'm not sure Javier's issue is same thing..I will check more this. Thanks for checking, do you have access to a Peach Pit or Pi Chromebook to reproduce the issue I reported? Please let me know if you need any help from me. Best Regards, Jaehoon Chung Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] about data busy
On 02/15/2015 08:41 PM, Javier Martinez Canillas wrote: > Hello Addy, > > On Sat, Feb 14, 2015 at 7:17 AM, Addy Ke wrote: >> patch 1: This patch can fix bug that controller is still data busy after >> reset all blocks. After this patch, I still get data busy in >> set_ios(). >> >> patch 2: This patch fix bug 'Timeout sending command'. After patch1 and >> patch2, there is no mmc errors after: >> cd /sys/bus/platform/drivers/dwmmc_rockchip >> for i in $(seq 1 1); do >> echo "" $i >> echo ff0c.dwmmc > unbind >> sleep .5 >> echo ff0c.dwmmc > bind >> sleep 2 >> done >> >> patch3: This patch fix bug that there is data busy before sdio send CMD53. >> But This patch is necessary for sd and mmc too. >> > > I faced the same 'Timeout sending command' error when trying to enable > support for the SDIO wifi chip attached to mmc@1221 (mmc1) on an > Exynos5420 Peach Pit Chromebook. On booting the kernel log shows: > > mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status > 0x80202000) > > 0x202000 == SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT so your patch > #2 dw_mci_setup_bus() avoids the mmc comand to time out. However, it > has a side effect since with your series the uSD that in mmc@1222 > (mmc2) fails to be detected and the kernel log shows: > > [5.466432] Waiting for root device /dev/mmcblk1p4... > [ 240.169436] INFO: task kworker/u16:1:50 blocked for more than 120 seconds. > [ 240.174844] Not tainted > 3.19.0-next-20150211-6-g045d4aba96ce-dirty #476 > [ 240.182302] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables this message. > [ 240.190109] kworker/u16:1 D c04c2710 050 2 0x > [ 240.196446] Workqueue: kmmcd mmc_rescan > [ 240.200249] [] (__schedule) from [] > (schedule+0x34/0x98) > [ 240.207290] [] (schedule) from [] > (schedule_timeout+0x120/0x16c) > [ 240.215009] [] (schedule_timeout) from [] > (wait_for_common+0xb0/0x154) > [ 240.223251] [] (wait_for_common) from [] > (mmc_wait_for_req+0xa0/0x140) > [ 240.231492] [] (mmc_wait_for_req) from [] > (mmc_wait_for_cmd+0x88/0xa8) > [ 240.239735] [] (mmc_wait_for_cmd) from [] > (mmc_go_idle+0x78/0xf8) > [ 240.247540] [] (mmc_go_idle) from [] > (mmc_rescan+0x254/0x300) > [ 240.255003] [] (mmc_rescan) from [] > (process_one_work+0x120/0x324) > [ 240.262897] [] (process_one_work) from [] > (worker_thread+0x138/0x464) > [ 240.271048] [] (worker_thread) from [] > (kthread+0xd8/0xf4) > [ 240.278254] [] (kthread) from [] > (ret_from_fork+0x14/0x34) > > > By enabling debug I see that the card is detected in dw_mci_get_cd() though. > > Alim suggested [0] that dw_mci_wait_busy() should be called in > mci_send_cmd() instead dw_mci_setup_bus() because the controller hangs > when when sending update clock cmd in different cases. > > I modified [1] your patch #2 to do what Alim suggested and only with > that patch on top of linux-next I have neither the the "Timeout > sending command" error nor the uSD not getting detected errors. Linux > mounts the rootfs from the uSD and the wifi SDIO device is enumerated > and listed in /sys/bus/sdio/devices/ it needs to check when clock value only update. As Javier and Alim are mentioned, if check whether card is busy or not in setup_bus(), should be processed unnecessary checking. (According to TRM, before disabling clock, check whether card is busy or not.) if my thinking is right, chekcing is located more exactly before mci_writel(host, CLKENA, 0). And i recommend if CLK_GATE is enabled, clkgate_delay sets to the bigger value than 3. I'm not sure Javier's issue is same thing..I will check more this. Best Regards, Jaehoon Chung > > Does that also solve your issue? > > Best regards, > Javier > > [0]: https://lkml.org/lkml/2015/2/10/353 > [1]: http://paste.debian.net/plain/148794 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] about data busy
Hello Addy, On Sat, Feb 14, 2015 at 7:17 AM, Addy Ke wrote: > patch 1: This patch can fix bug that controller is still data busy after > reset all blocks. After this patch, I still get data busy in > set_ios(). > > patch 2: This patch fix bug 'Timeout sending command'. After patch1 and > patch2, there is no mmc errors after: > cd /sys/bus/platform/drivers/dwmmc_rockchip > for i in $(seq 1 1); do > echo "" $i > echo ff0c.dwmmc > unbind > sleep .5 > echo ff0c.dwmmc > bind > sleep 2 > done > > patch3: This patch fix bug that there is data busy before sdio send CMD53. > But This patch is necessary for sd and mmc too. > I faced the same 'Timeout sending command' error when trying to enable support for the SDIO wifi chip attached to mmc@1221 (mmc1) on an Exynos5420 Peach Pit Chromebook. On booting the kernel log shows: mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000) 0x202000 == SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT so your patch #2 dw_mci_setup_bus() avoids the mmc comand to time out. However, it has a side effect since with your series the uSD that in mmc@1222 (mmc2) fails to be detected and the kernel log shows: [5.466432] Waiting for root device /dev/mmcblk1p4... [ 240.169436] INFO: task kworker/u16:1:50 blocked for more than 120 seconds. [ 240.174844] Not tainted 3.19.0-next-20150211-6-g045d4aba96ce-dirty #476 [ 240.182302] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 240.190109] kworker/u16:1 D c04c2710 050 2 0x [ 240.196446] Workqueue: kmmcd mmc_rescan [ 240.200249] [] (__schedule) from [] (schedule+0x34/0x98) [ 240.207290] [] (schedule) from [] (schedule_timeout+0x120/0x16c) [ 240.215009] [] (schedule_timeout) from [] (wait_for_common+0xb0/0x154) [ 240.223251] [] (wait_for_common) from [] (mmc_wait_for_req+0xa0/0x140) [ 240.231492] [] (mmc_wait_for_req) from [] (mmc_wait_for_cmd+0x88/0xa8) [ 240.239735] [] (mmc_wait_for_cmd) from [] (mmc_go_idle+0x78/0xf8) [ 240.247540] [] (mmc_go_idle) from [] (mmc_rescan+0x254/0x300) [ 240.255003] [] (mmc_rescan) from [] (process_one_work+0x120/0x324) [ 240.262897] [] (process_one_work) from [] (worker_thread+0x138/0x464) [ 240.271048] [] (worker_thread) from [] (kthread+0xd8/0xf4) [ 240.278254] [] (kthread) from [] (ret_from_fork+0x14/0x34) By enabling debug I see that the card is detected in dw_mci_get_cd() though. Alim suggested [0] that dw_mci_wait_busy() should be called in mci_send_cmd() instead dw_mci_setup_bus() because the controller hangs when when sending update clock cmd in different cases. I modified [1] your patch #2 to do what Alim suggested and only with that patch on top of linux-next I have neither the the "Timeout sending command" error nor the uSD not getting detected errors. Linux mounts the rootfs from the uSD and the wifi SDIO device is enumerated and listed in /sys/bus/sdio/devices/ Does that also solve your issue? Best regards, Javier [0]: https://lkml.org/lkml/2015/2/10/353 [1]: http://paste.debian.net/plain/148794 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] about data busy
Hello Addy, On Sat, Feb 14, 2015 at 7:17 AM, Addy Ke addy...@rock-chips.com wrote: patch 1: This patch can fix bug that controller is still data busy after reset all blocks. After this patch, I still get data busy in set_ios(). patch 2: This patch fix bug 'Timeout sending command'. After patch1 and patch2, there is no mmc errors after: cd /sys/bus/platform/drivers/dwmmc_rockchip for i in $(seq 1 1); do echo $i echo ff0c.dwmmc unbind sleep .5 echo ff0c.dwmmc bind sleep 2 done patch3: This patch fix bug that there is data busy before sdio send CMD53. But This patch is necessary for sd and mmc too. I faced the same 'Timeout sending command' error when trying to enable support for the SDIO wifi chip attached to mmc@1221 (mmc1) on an Exynos5420 Peach Pit Chromebook. On booting the kernel log shows: mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000) 0x202000 == SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT so your patch #2 dw_mci_setup_bus() avoids the mmc comand to time out. However, it has a side effect since with your series the uSD that in mmc@1222 (mmc2) fails to be detected and the kernel log shows: [5.466432] Waiting for root device /dev/mmcblk1p4... [ 240.169436] INFO: task kworker/u16:1:50 blocked for more than 120 seconds. [ 240.174844] Not tainted 3.19.0-next-20150211-6-g045d4aba96ce-dirty #476 [ 240.182302] echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message. [ 240.190109] kworker/u16:1 D c04c2710 050 2 0x [ 240.196446] Workqueue: kmmcd mmc_rescan [ 240.200249] [c04c2710] (__schedule) from [c04c2ac0] (schedule+0x34/0x98) [ 240.207290] [c04c2ac0] (schedule) from [c04c6568] (schedule_timeout+0x120/0x16c) [ 240.215009] [c04c6568] (schedule_timeout) from [c04c3584] (wait_for_common+0xb0/0x154) [ 240.223251] [c04c3584] (wait_for_common) from [c038a5ac] (mmc_wait_for_req+0xa0/0x140) [ 240.231492] [c038a5ac] (mmc_wait_for_req) from [c038a6d4] (mmc_wait_for_cmd+0x88/0xa8) [ 240.239735] [c038a6d4] (mmc_wait_for_cmd) from [c03905b0] (mmc_go_idle+0x78/0xf8) [ 240.247540] [c03905b0] (mmc_go_idle) from [c038c578] (mmc_rescan+0x254/0x300) [ 240.255003] [c038c578] (mmc_rescan) from [c00346e8] (process_one_work+0x120/0x324) [ 240.262897] [c00346e8] (process_one_work) from [c0034a58] (worker_thread+0x138/0x464) [ 240.271048] [c0034a58] (worker_thread) from [c0039070] (kthread+0xd8/0xf4) [ 240.278254] [c0039070] (kthread) from [c000e680] (ret_from_fork+0x14/0x34) By enabling debug I see that the card is detected in dw_mci_get_cd() though. Alim suggested [0] that dw_mci_wait_busy() should be called in mci_send_cmd() instead dw_mci_setup_bus() because the controller hangs when when sending update clock cmd in different cases. I modified [1] your patch #2 to do what Alim suggested and only with that patch on top of linux-next I have neither the the Timeout sending command error nor the uSD not getting detected errors. Linux mounts the rootfs from the uSD and the wifi SDIO device is enumerated and listed in /sys/bus/sdio/devices/ Does that also solve your issue? Best regards, Javier [0]: https://lkml.org/lkml/2015/2/10/353 [1]: http://paste.debian.net/plain/148794 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/3] about data busy
On 02/15/2015 08:41 PM, Javier Martinez Canillas wrote: Hello Addy, On Sat, Feb 14, 2015 at 7:17 AM, Addy Ke addy...@rock-chips.com wrote: patch 1: This patch can fix bug that controller is still data busy after reset all blocks. After this patch, I still get data busy in set_ios(). patch 2: This patch fix bug 'Timeout sending command'. After patch1 and patch2, there is no mmc errors after: cd /sys/bus/platform/drivers/dwmmc_rockchip for i in $(seq 1 1); do echo $i echo ff0c.dwmmc unbind sleep .5 echo ff0c.dwmmc bind sleep 2 done patch3: This patch fix bug that there is data busy before sdio send CMD53. But This patch is necessary for sd and mmc too. I faced the same 'Timeout sending command' error when trying to enable support for the SDIO wifi chip attached to mmc@1221 (mmc1) on an Exynos5420 Peach Pit Chromebook. On booting the kernel log shows: mmc_host mmc1: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000) 0x202000 == SDMMC_CMD_UPD_CLK | SDMMC_CMD_PRV_DAT_WAIT so your patch #2 dw_mci_setup_bus() avoids the mmc comand to time out. However, it has a side effect since with your series the uSD that in mmc@1222 (mmc2) fails to be detected and the kernel log shows: [5.466432] Waiting for root device /dev/mmcblk1p4... [ 240.169436] INFO: task kworker/u16:1:50 blocked for more than 120 seconds. [ 240.174844] Not tainted 3.19.0-next-20150211-6-g045d4aba96ce-dirty #476 [ 240.182302] echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message. [ 240.190109] kworker/u16:1 D c04c2710 050 2 0x [ 240.196446] Workqueue: kmmcd mmc_rescan [ 240.200249] [c04c2710] (__schedule) from [c04c2ac0] (schedule+0x34/0x98) [ 240.207290] [c04c2ac0] (schedule) from [c04c6568] (schedule_timeout+0x120/0x16c) [ 240.215009] [c04c6568] (schedule_timeout) from [c04c3584] (wait_for_common+0xb0/0x154) [ 240.223251] [c04c3584] (wait_for_common) from [c038a5ac] (mmc_wait_for_req+0xa0/0x140) [ 240.231492] [c038a5ac] (mmc_wait_for_req) from [c038a6d4] (mmc_wait_for_cmd+0x88/0xa8) [ 240.239735] [c038a6d4] (mmc_wait_for_cmd) from [c03905b0] (mmc_go_idle+0x78/0xf8) [ 240.247540] [c03905b0] (mmc_go_idle) from [c038c578] (mmc_rescan+0x254/0x300) [ 240.255003] [c038c578] (mmc_rescan) from [c00346e8] (process_one_work+0x120/0x324) [ 240.262897] [c00346e8] (process_one_work) from [c0034a58] (worker_thread+0x138/0x464) [ 240.271048] [c0034a58] (worker_thread) from [c0039070] (kthread+0xd8/0xf4) [ 240.278254] [c0039070] (kthread) from [c000e680] (ret_from_fork+0x14/0x34) By enabling debug I see that the card is detected in dw_mci_get_cd() though. Alim suggested [0] that dw_mci_wait_busy() should be called in mci_send_cmd() instead dw_mci_setup_bus() because the controller hangs when when sending update clock cmd in different cases. I modified [1] your patch #2 to do what Alim suggested and only with that patch on top of linux-next I have neither the the Timeout sending command error nor the uSD not getting detected errors. Linux mounts the rootfs from the uSD and the wifi SDIO device is enumerated and listed in /sys/bus/sdio/devices/ it needs to check when clock value only update. As Javier and Alim are mentioned, if check whether card is busy or not in setup_bus(), should be processed unnecessary checking. (According to TRM, before disabling clock, check whether card is busy or not.) if my thinking is right, chekcing is located more exactly before mci_writel(host, CLKENA, 0). And i recommend if CLK_GATE is enabled, clkgate_delay sets to the bigger value than 3. I'm not sure Javier's issue is same thing..I will check more this. Best Regards, Jaehoon Chung Does that also solve your issue? Best regards, Javier [0]: https://lkml.org/lkml/2015/2/10/353 [1]: http://paste.debian.net/plain/148794 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
