Re: [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default
On 4/12/2019 12:05 AM, Josh Triplett wrote: Can you point to the typo? I did, in my response to the patch itself: s/Miscellaneous/miscellaneous/ in the new option's description, since it isn't at the start of a sentence. Thanks, your emails arrived out of order. I got them now.
Re: [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default
On Thu, Apr 11, 2019 at 11:13:42PM -0400, Sinan Kaya wrote: > On 4/11/2019 11:02 PM, Josh Triplett wrote: > > I noticed one minor typo in patch 1/5, with that fixed, for the whole > > series: > > Can you point to the typo? I did, in my response to the patch itself: s/Miscellaneous/miscellaneous/ in the new option's description, since it isn't at the start of a sentence.
Re: [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default
On 4/11/2019 11:02 PM, Josh Triplett wrote: I noticed one minor typo in patch 1/5, with that fixed, for the whole series: Can you point to the typo?
Re: [PATCH v4 0/5] init: Do not select DEBUG_KERNEL by default
On Fri, Apr 12, 2019 at 01:43:50AM +, Sinan Kaya wrote:
> CONFIG_DEBUG_KERNEL has been designed to just enable Kconfig options.
> Kernel code generatoin should not depend on CONFIG_DEBUG_KERNEL.
>
> Proposed alternative plan: let's add a new symbol, something like
> DEBUG_MISC ("Miscellaneous debug code that should be under a more
> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
> "default DEBUG_KERNEL" but allow itself to be turned off, and then
> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
> "#ifdef CONFIG_DEBUG_MISC".
>
> Sinan Kaya (5):
> init: Introduce DEBUG_MISC option
> powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
> mips: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
> xtensa: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
> net: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
I noticed one minor typo in patch 1/5, with that fixed, for the whole
series:
Reviewed-by: Josh Triplett
