Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Paul Kocialkowski]

Le mercredi 30 mars 2016 à 12:13 -0700, Tony Lindgren a écrit :
> * Paul Kocialkowski  [160320 08:59]:
> > 
> > Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> > > 
> > > Anyways, applying the dts changes into omap-for-v4.6/dt thanks.
> > It seems that v3 of this patch was merged into your tree instead of v4,
> > which
> > contains some improvements over v3.
> > 
> > Should I submit a cleanup patch with the diff or can you use v4 instead (if
> > not
> > too late)?
> Oops sorry. Yes please send an incremental patch against v4.6-rc1.

Ah my bad, nevermind this, I double-checked and everything looks good!

-- 
Paul Kocialkowski, low-level free software developer on embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/


signature.asc
Description: This is a digitally signed message part

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Paul Kocialkowski]

Le mercredi 30 mars 2016 à 12:13 -0700, Tony Lindgren a écrit :
> * Paul Kocialkowski  [160320 08:59]:
> > 
> > Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> > > 
> > > Anyways, applying the dts changes into omap-for-v4.6/dt thanks.
> > It seems that v3 of this patch was merged into your tree instead of v4,
> > which
> > contains some improvements over v3.
> > 
> > Should I submit a cleanup patch with the diff or can you use v4 instead (if
> > not
> > too late)?
> Oops sorry. Yes please send an incremental patch against v4.6-rc1.

Ah my bad, nevermind this, I double-checked and everything looks good!

-- 
Paul Kocialkowski, low-level free software developer on embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/


signature.asc
Description: This is a digitally signed message part

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Tony Lindgren]

* Paul Kocialkowski  [160320 08:59]:
> Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> > Anyways, applying the dts changes into omap-for-v4.6/dt thanks.
> 
> It seems that v3 of this patch was merged into your tree instead of v4, which
> contains some improvements over v3.
> 
> Should I submit a cleanup patch with the diff or can you use v4 instead (if 
> not
> too late)?

Oops sorry. Yes please send an incremental patch against v4.6-rc1.

Thanks,

Tony

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Tony Lindgren]

* Paul Kocialkowski  [160320 08:59]:
> Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> > Anyways, applying the dts changes into omap-for-v4.6/dt thanks.
> 
> It seems that v3 of this patch was merged into your tree instead of v4, which
> contains some improvements over v3.
> 
> Should I submit a cleanup patch with the diff or can you use v4 instead (if 
> not
> too late)?

Oops sorry. Yes please send an incremental patch against v4.6-rc1.

Thanks,

Tony

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Paul Kocialkowski]

Hi,

Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> Hi,
> 
> * Paul Kocialkowski  [160228 04:40]:
> > 
> > The LG Optimus Black codename sniper is a smartphone that was designed and
> > manufactured by LG Electronics (LGE) and released back in 2011.
> > It is using an OMAP3630 SoC, GP version.
> > 
> > This adds devicetree support for the device, with only a few basic features
> > supported, such as debug uart, i2c, internal emmc and external mmc.
> ...
> > 
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins>;
> > +
> > +   clock-frequency = <260>;
> > +
> > +   twl: twl@48 {
> > +   reg = <0x48>;
> > +   interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> > +   interrupt-parent = <>;
> > +
> > +   power {
> > +   compatible = "ti,twl4030-power";
> > +   ti,use_poweroff;
> > +   };
> > +   };
> > +};
> Chances are this devices supports cutting off the voltages and
> the high frequency oscillator during idle. So you may want to
> at some point set compatible = "ti,twl4030-power-idle-osc-off"
> here.
> 
> Anyways, applying the dts changes into omap-for-v4.6/dt thanks.

It seems that v3 of this patch was merged into your tree instead of v4, which
contains some improvements over v3.

Should I submit a cleanup patch with the diff or can you use v4 instead (if not
too late)?

Cheers,

-- 
Paul Kocialkowski, low-level free software developer on embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/


signature.asc
Description: This is a digitally signed message part

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Paul Kocialkowski]

Hi,

Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> Hi,
> 
> * Paul Kocialkowski  [160228 04:40]:
> > 
> > The LG Optimus Black codename sniper is a smartphone that was designed and
> > manufactured by LG Electronics (LGE) and released back in 2011.
> > It is using an OMAP3630 SoC, GP version.
> > 
> > This adds devicetree support for the device, with only a few basic features
> > supported, such as debug uart, i2c, internal emmc and external mmc.
> ...
> > 
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins>;
> > +
> > +   clock-frequency = <260>;
> > +
> > +   twl: twl@48 {
> > +   reg = <0x48>;
> > +   interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> > +   interrupt-parent = <>;
> > +
> > +   power {
> > +   compatible = "ti,twl4030-power";
> > +   ti,use_poweroff;
> > +   };
> > +   };
> > +};
> Chances are this devices supports cutting off the voltages and
> the high frequency oscillator during idle. So you may want to
> at some point set compatible = "ti,twl4030-power-idle-osc-off"
> here.
> 
> Anyways, applying the dts changes into omap-for-v4.6/dt thanks.

It seems that v3 of this patch was merged into your tree instead of v4, which
contains some improvements over v3.

Should I submit a cleanup patch with the diff or can you use v4 instead (if not
too late)?

Cheers,

-- 
Paul Kocialkowski, low-level free software developer on embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/


signature.asc
Description: This is a digitally signed message part

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Paul Kocialkowski]

Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> Hi,
> 
> * Paul Kocialkowski  [160228 04:40]:
> > The LG Optimus Black codename sniper is a smartphone that was designed and
> > manufactured by LG Electronics (LGE) and released back in 2011.
> > It is using an OMAP3630 SoC, GP version.
> > 
> > This adds devicetree support for the device, with only a few basic features
> > supported, such as debug uart, i2c, internal emmc and external mmc.
> ...
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins>;
> > +
> > +   clock-frequency = <260>;
> > +
> > +   twl: twl@48 {
> > +   reg = <0x48>;
> > +   interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> > +   interrupt-parent = <>;
> > +
> > +   power {
> > +   compatible = "ti,twl4030-power";
> > +   ti,use_poweroff;
> > +   };
> > +   };
> > +};
> 
> Chances are this devices supports cutting off the voltages and
> the high frequency oscillator during idle. So you may want to
> at some point set compatible = "ti,twl4030-power-idle-osc-off"
> here.

Thanks for the pointer, I'll consider adding this in the future!

> Anyways, applying the dts changes into omap-for-v4.6/dt thanks.

Nice, thanks!

Cheers,

-- 
Paul Kocialkowski, low-level free software developer on embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/


signature.asc
Description: This is a digitally signed message part

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Paul Kocialkowski]

Le lundi 29 février 2016 à 13:51 -0800, Tony Lindgren a écrit :
> Hi,
> 
> * Paul Kocialkowski  [160228 04:40]:
> > The LG Optimus Black codename sniper is a smartphone that was designed and
> > manufactured by LG Electronics (LGE) and released back in 2011.
> > It is using an OMAP3630 SoC, GP version.
> > 
> > This adds devicetree support for the device, with only a few basic features
> > supported, such as debug uart, i2c, internal emmc and external mmc.
> ...
> > + {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <_pins>;
> > +
> > +   clock-frequency = <260>;
> > +
> > +   twl: twl@48 {
> > +   reg = <0x48>;
> > +   interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> > +   interrupt-parent = <>;
> > +
> > +   power {
> > +   compatible = "ti,twl4030-power";
> > +   ti,use_poweroff;
> > +   };
> > +   };
> > +};
> 
> Chances are this devices supports cutting off the voltages and
> the high frequency oscillator during idle. So you may want to
> at some point set compatible = "ti,twl4030-power-idle-osc-off"
> here.

Thanks for the pointer, I'll consider adding this in the future!

> Anyways, applying the dts changes into omap-for-v4.6/dt thanks.

Nice, thanks!

Cheers,

-- 
Paul Kocialkowski, low-level free software developer on embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/


signature.asc
Description: This is a digitally signed message part

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Tony Lindgren]

Hi,

* Paul Kocialkowski  [160228 04:40]:
> The LG Optimus Black codename sniper is a smartphone that was designed and
> manufactured by LG Electronics (LGE) and released back in 2011.
> It is using an OMAP3630 SoC, GP version.
> 
> This adds devicetree support for the device, with only a few basic features
> supported, such as debug uart, i2c, internal emmc and external mmc.
...
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins>;
> +
> + clock-frequency = <260>;
> +
> + twl: twl@48 {
> + reg = <0x48>;
> + interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> + interrupt-parent = <>;
> +
> + power {
> + compatible = "ti,twl4030-power";
> + ti,use_poweroff;
> + };
> + };
> +};

Chances are this devices supports cutting off the voltages and
the high frequency oscillator during idle. So you may want to
at some point set compatible = "ti,twl4030-power-idle-osc-off"
here.

Anyways, applying the dts changes into omap-for-v4.6/dt thanks.

Regards,

Tony

Re: [PATCH v4 1/5] ARM: dts: LG Optimus Black codename sniper basic support

[Tony Lindgren]

Hi,

* Paul Kocialkowski  [160228 04:40]:
> The LG Optimus Black codename sniper is a smartphone that was designed and
> manufactured by LG Electronics (LGE) and released back in 2011.
> It is using an OMAP3630 SoC, GP version.
> 
> This adds devicetree support for the device, with only a few basic features
> supported, such as debug uart, i2c, internal emmc and external mmc.
...
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins>;
> +
> + clock-frequency = <260>;
> +
> + twl: twl@48 {
> + reg = <0x48>;
> + interrupts = <7>; /* SYS_NIRQ cascaded to intc */
> + interrupt-parent = <>;
> +
> + power {
> + compatible = "ti,twl4030-power";
> + ti,use_poweroff;
> + };
> + };
> +};

Chances are this devices supports cutting off the voltages and
the high frequency oscillator during idle. So you may want to
at some point set compatible = "ti,twl4030-power-idle-osc-off"
here.

Anyways, applying the dts changes into omap-for-v4.6/dt thanks.

Regards,

Tony