Re: [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak

2020-07-01 Thread Tiezhu Yang

On 07/01/2020 05:14 PM, Markus Elfring wrote:

In the function omap_init_irq_of(), system resource "omap_irq_base"
was not released in the error case, fix it.

Another small wording adjustment:
   … in an error case. Thus add a call of the function “iounmap”
   in the if branch.


OK, thank you, I will do it in v5 of this patch #11 and next patch #12.



Regards,
Markus




Re: [PATCH v4 11/14] irqchip/omap-intc: Fix potential resource leak

2020-07-01 Thread Markus Elfring
> In the function omap_init_irq_of(), system resource "omap_irq_base"
> was not released in the error case, fix it.

Another small wording adjustment:
  … in an error case. Thus add a call of the function “iounmap”
  in the if branch.

Regards,
Markus