Re: [PATCH v4 3/4] pinctrl: rockchip: split out verification of mux settings
On Thu, Mar 23, 2017 at 11:59 AM, John Keepingwrote: > We need to avoid calling regmap functions from irq handlers, so the next > commit is going to move the call to rockchip_set_mux() into an > irq_bus_sync_unlock handler. But we can't return an error from there so > we still need to check the settings from rockchip_irq_set_type() and we > will use this new rockchip_verify_mux() function from there. > > Signed-off-by: John Keeping > Reviewed-by: Heiko Stuebner > Tested-by: Heiko Stuebner > --- > v3: unchanged > v2: unchanged Patch applied. Yours, Linus Walleij
Re: [PATCH v4 3/4] pinctrl: rockchip: split out verification of mux settings
On Thu, Mar 23, 2017 at 11:59 AM, John Keeping wrote: > We need to avoid calling regmap functions from irq handlers, so the next > commit is going to move the call to rockchip_set_mux() into an > irq_bus_sync_unlock handler. But we can't return an error from there so > we still need to check the settings from rockchip_irq_set_type() and we > will use this new rockchip_verify_mux() function from there. > > Signed-off-by: John Keeping > Reviewed-by: Heiko Stuebner > Tested-by: Heiko Stuebner > --- > v3: unchanged > v2: unchanged Patch applied. Yours, Linus Walleij